Re: [PATCH] analyzer: fix build with gcc 4.4 (PR 93276)

2020-01-24 Thread Jeff Law
On Fri, 2020-01-24 at 19:53 -0500, David Malcolm wrote: > This patch fixes various build failures seen with gcc 4.4 > > gcc prior to 4.6 complains about: > > error: #pragma GCC diagnostic not allowed inside functions > > for various uses of PUSH_IGNORE_WFORMAT and POP_IGNORE_WFORMAT. > This pa

Re: [PATCH] dbr: Filter-out TARGET_FLAGS_REGNUM from end_of_function_needs.

2020-01-25 Thread Jeff Law
On Sat, 2020-01-25 at 15:14 +0100, Hans-Peter Nilsson wrote: > Compared to the cc0 version, I noticed a regression in > delay-slot-filling for CRIS for several functions in libgcc with > a similar layout, one being lshrdi3, where with cc0 all > delay-slots were filled, as exposed by the test-case.

Re: [PATCH] Fix gcc.dg/torture/pr91323.c for aarch64 targets

2020-01-26 Thread Jeff Law
On Fri, 2020-01-17 at 12:07 +, Richard Sandiford wrote: > PR91323 was fixed for x86 and sparc in target code, but aarch64 > instead relies on the target-independent comparison splitters. > Since LTGT is an unordered-signalling operation, we should split > it into unordered-signalling operations

Re: [PATCH] cselib: Fix handling of multireg values for call insns [PR93170]

2020-01-26 Thread Jeff Law
On Mon, 2020-01-20 at 12:54 +, Richard Sandiford wrote: > g:3bd2918594dae34ae84f mishandled the case in which only the > tail end of a multireg hard register is invalidated by the call. > Walking all the entries should be both safer and more precise. > > Avoiding cselib_invalidate_regno also m

Re: [PATCH] lra: Stop registers being incorrectly marked live [PR92989]

2020-01-26 Thread Jeff Law
On Mon, 2020-01-20 at 13:03 +, Richard Sandiford wrote: > lra_assign has an assert to make sure that no pseudo is allocated > to a conflicting hard register. It used to be restricted to > !flag_ipa_ra, but in g:a1e6ee38e708ef2bdef4 I'd enabled it for > flag_ipa_ra too. It then tripped while b

Re: [PATCH] checking: avoid verify_type_variant crash on incomplete type.

2020-01-26 Thread Jeff Law
On Sat, 2020-01-25 at 23:21 -0500, Jason Merrill wrote: > Here, we end up calling gen_type_die_with_usage for a type that's in the > middle of finish_struct_1, after we set TYPE_NEEDS_CONSTRUCTING on it but > before we copy all the flags to the variants--and, significantly, before we > set its TYPE

Re: [PATCH] RX update functions with string constraint

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 14:18 +0200, Darius Galis wrote: > Hello, > > The following patch updates the setmemsi and rx_setmem functions. > The patch adds the rx_allow_string_insns constraint to these functions > in order to be used only when the string support is enabled. > > Regression test is OK,

Re: [PING^7][PATCH 0/4] Fix library testsuite compilation for build sysroot

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 02:19 +, Maciej W. Rozycki wrote: > On Fri, 20 Dec 2019, Mike Stump wrote: > > > > > This patch series addresses a problem with the testsuite compiler being > > > > set up across libatomic, libffi, libgo, libgomp with no correlation > > > > whatsoever to the target comp

Re: [PATCH] Make target_clones resolver fn static.

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 13:48 +0100, Martin Liška wrote: > From a3faaced989869867671ceadd89b56fabde225ff Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Thu, 16 Jan 2020 10:38:41 +0100 > Subject: [PATCH] Make target_clones resolver fn static. > > gcc/ChangeLog: > > 2020-01-17 Martin Liska

Re: [PATCH] Fix missed IPA-CP on by-ref argument directly passed through (PR ipa/93429)

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 04:53 +, Feng Xue OS wrote: > Current IPA does not propagate aggregate constant for by-ref argument > if it is simple pass-through of caller parameter. Here is an example, > >f1 (int *p) >{ > ... = *p; > ... >} > >f2 (int *p) >{ > *p =

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 16:41 +, Richard Sandiford wrote: > In the gcc.target/aarch64/lsl_asr_sbfiz.c part of this PR, we have: > > Failed to match this instruction: > (set (reg:SI 95) > (ashift:SI (subreg:SI (sign_extract:DI (subreg:DI (reg:SI 97) 0) > (const_int 3 [0x3]) >

Re: [PATCH] vect: Pattern-matched calls in reduction chains

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 17:02 +, Richard Sandiford wrote: > gcc.dg/pr56350.c started ICEing for SVE in GCC 10 because we > pattern-matched a division reduction: > > a /= 8; > > into a signed shift with division semantics: > > ... = IFN_SDIV_POW2 (..., 3); > > whereas the reduction

Re: Deprecating cc0 (and consequently cc0 targets)

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 15:01 +0100, Hans-Peter Nilsson wrote: > > From: Jeff Law > > Date: Fri, 20 Sep 2019 17:38:38 +0200 > > Hi. I'm not going to question > > > The first step in that process is to drop support for cc0. > > but could you please elaborate

Re: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2020-01-27 Thread Jeff Law
On Mon, 2019-12-16 at 11:18 +, Bader, Lucas wrote: > Hello, > > within a compile cluster, only the preprocessed output of GCC is transferred > to remote nodes for compilation. > When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. > prints out the affected source > l

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

2020-01-27 Thread Jeff Law
On Thu, 2019-12-12 at 15:44 -0500, Jason Merrill wrote: > Here are the dumps from ssa-dom-thread-7.c made to compile as C++; cx-current > is the dumps with current trunk; cx-old is changed to use the old goto-based > lowering like C. Sorry this has taken so long to get back to. For ssa-dom-threa

Re: Support gnu_unique_object symbols on MIPS

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 18:23 +, Joseph Myers wrote: > mips_declare_object_name is missing the support for declaring symbols > as gnu_unique_object that is present in the generic > ASM_DECLARE_OBJECT_NAME in elfos.h. I'm not aware of any > MIPS-specific reason for that support to be absent; > mi

Re: [PATCH] gimple-fold: Fix buffer overflow in fold_array_ctor_reference [PR93454]

2020-01-27 Thread Jeff Law
On Tue, 2020-01-28 at 00:33 +0100, Jakub Jelinek wrote: > Hi! > > libgcrypt FAILs to build on aarch64-linux with > *** stack smashing detected ***: terminated > when gcc is compiled with -D_FORTIFY_SOURCE=2. The problem is if > fold_array_ctor_reference is called with size equal to or very close

Re: [PATCH] libiberty/hashtab: More const parameters

2020-01-27 Thread Jeff Law
On Mon, 2020-01-27 at 22:32 +, Andrew Burgess wrote: > I know that the tree's currently closed to non-bugfix changes, but I > was hoping this might be accpeted anyway so it can be backported to > binutils-gdb. > > --- > > Makes some parameters const in libiberty's hashtab library. > > includ

Re: [PATCH] i386: Fix ix86_fold_builtin shift folding [PR93418]

2020-01-27 Thread Jeff Law
On Tue, 2020-01-28 at 00:41 +0100, Jakub Jelinek wrote: > Hi! > > The following testcase is miscompiled, because the variable shift left > operand, { -1, -1, -1, -1 } is represented as a VECTOR_CST with > VECTOR_CST_NPATTERNS 1 and VECTOR_CST_NELTS_PER_PATTERN 1, so when > we call builder.new_unar

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Tue, 2019-10-08 at 18:04 +0300, Alexander Monakov wrote: > On Thu, 3 Oct 2019, Jeff Law wrote: > > > You may want to review the 2018 discussion: > > > > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg185287.html > > > > THe 2018 discussion was pri

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Thu, 2019-10-17 at 16:14 +0300, Alexander Monakov wrote: > On Tue, 8 Oct 2019, Alexander Monakov wrote: > > [massive snip] > > > So in my opinion our CFG is good enough, the real issues with -Wclobbered > > false > > positives are not due to phi nodes but other effects. > > > > If you agree:

[RFA/RFC] Improve DSE/aliasing around __builtin_object_size (PR89689, P2 regression)

2020-01-28 Thread Jeff Law
BUILT_IN_OBJECT_SIZE)) + && ref_maybe_used_by_stmt_p (use_stmt, ref)) { /* Handle common cases where we can easily build an ao_ref structure for USE_STMT and in doing so we find that the commit f4e5d3f4755b6a5846ac20b53008b90131a8bb7c Author: Jeff

Re: [RFA/RFC] Improve DSE/aliasing around __builtin_object_size (PR89689, P2 regression)

2020-01-29 Thread Jeff Law
jects. > > So OK for P2. Here's the patch I committed for the historical record. It just adds the test and ChangeLog entries relative to the RFA/RFC originally posted. Jeff commit 786083766459723b790405c9ba22f974f84f637e Author: Jeff Law Date: Wed Jan 29 12:23:53 2020 -0700

[RFA] [c/88660] Fix bogus set-but-unused warning

2020-01-29 Thread Jeff Law
Joseph, you were the last one in this part of c_parser_switch_statement, but the change you made was for supporting atomics. I'm not sure if you'll have context here or not. PR88660 is a false positive warning for a set-but-unused object. We can see trivially from the testcase that "i" is used

[committed] Tweak ssa-dse-26.c test for c6x after recent SRA changes

2020-01-30 Thread Jeff Law
'm also watching for other targets that may need similar handling as a result of the SRA work. Jeff diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0247d2cd083..269adb29e94 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-01-30 Jeff L

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-01-30 Thread Jeff Law
On Wed, 2020-01-29 at 19:18 +, Richard Sandiford wrote: > Andreas Schwab writes: > > On Jan 27 2020, Richard Sandiford wrote: > > > > > * simplify-rtx.c (simplify_truncation): Extend sign/zero_extract > > > simplification to handle subregs as well as bare regs. > > > > That breaks gcc.ta

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-01-30 Thread Jeff Law
On Thu, 2020-01-30 at 18:27 +0100, Jakub Jelinek wrote: > On Thu, Jan 30, 2020 at 10:23:35AM -0700, Jeff Law wrote: > > diff --git a/gcc/config/m68k/m68k.md b/gcc/config/m68k/m68k.md > > index 8e35357ea23..78c4cbe4753 100644 > > --- a/gcc/config/m68k/m68k.md > > ++

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-01-31 Thread Jeff Law
On Thu, 2020-01-30 at 17:54 +, Richard Sandiford wrote: > Jeff Law writes: > > On Wed, 2020-01-29 at 19:18 +, Richard Sandiford wrote: > > > Andreas Schwab writes: > > > > On Jan 27 2020, Richard Sandiford wrote: > > > > > > > >

Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote: > On 2/3/20 2:17 AM, Jiufu Guo wrote: > > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 > > "loop2_unroll"} } */ > > Sorry I didn't catch this addition to the original testcase earlier, but I > wonder how stable this test is g

Re: [PATCH 2/4] [ARC] Use TARGET_INSN_COST.

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 12:38 +0100, Claudiu Zissulescu wrote: > TARGET_INSN_COST gives us a better control over the instruction costs > than classical RTX_COSTS. A simple cost scheme is in place for the > time being, when optimizing for size, the cost is given by the > instruction length. When opti

Re: [PATCH 3/4] [ARC] Deprecate q-class option.

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 12:38 +0100, Claudiu Zissulescu wrote: > This option was used to control the short instruction selection. However, > there is no difference in cycles if we use or not a short instruction, > and always someone wants a smaller program. > > gcc/ > -xx-xx Claudiu Zissulescu

Re: [PATCH 4/4] arc: Don't use if-conversion when optimizing for size.

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 12:38 +0100, Claudiu Zissulescu wrote: > For ARC, predicated instructions are not very friendly with size > optimizations, leading to increased object size. Disable if-conversion > step when optimized for size. > > gcc/ > -xx-xx Claudiu Zissulescu > > * common/c

Re: [Patch] Inline optimization for tanh(x)/sinh(x) -> 1.0/cosh(x)

2020-02-03 Thread Jeff Law
On Fri, 2020-01-31 at 15:50 -0300, Vitor Guidi wrote: > I took the required steps. The patch is attached to this email, I hope > I got it right this time. I did not forward the patch to gcc-patches > the first time, sorry for the inconvenience. > > Thank you for your attention, > > Vitor. > > in

Re: [PATCH 1/4] [ARC] Update mlo/mhi handling when big-endian CPU.

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 12:38 +0100, Claudiu Zissulescu wrote: > The ARC 600 MUL64 instructions are using mlo/mhi registers to pass the > 64-bit result. However, the mlo/mhi registers are not swapping > depending on endianess. Update multiplication patterns to reflect > this fact. > > gcc/ > -x

Re: [PATCH] adjust object size computation for union accesses and PHIs (PR 92765)

2020-02-03 Thread Jeff Law
On Fri, 2020-01-31 at 12:04 -0700, Martin Sebor wrote: > Attached is a reworked patch since the first one didn't go far > enough to solve the major problems. The new solution relies on > get_range_strlen_dynamic the same way as the sprintf optimization, > and does away with the determine_min_objsi

Re: [PATCH] avoid issuing -Wrestrict from folder (PR 93519)

2020-02-04 Thread Jeff Law
On Tue, 2020-02-04 at 10:34 +0100, Richard Biener wrote: > On Tue, Feb 4, 2020 at 1:44 AM Martin Sebor wrote: > > PR 93519 reports a false positive -Wrestrict issued for an inlined call > > to strcpy that carefully guards against self-copying. This is caused > > by the caller's arguments substitu

Re: [PATCH] avoid issuing -Wrestrict from folder (PR 93519)

2020-02-04 Thread Jeff Law
On Tue, 2020-02-04 at 13:08 -0700, Martin Sebor wrote: > On 2/4/20 12:15 PM, Richard Biener wrote: > > On February 4, 2020 5:30:42 PM GMT+01:00, Jeff Law wrote: > > > On Tue, 2020-02-04 at 10:34 +0100, Richard Biener wrote: > > > > On Tue, Feb 4, 2020 at 1:44 AM Mar

[RFA] [PR rtl-optimization/90275] Handle nop reg->reg copies in cse

2020-02-04 Thread Jeff Law
case in 90275, but I'm confident this is ultimately all the same problem. OK for the trunk? Thanks, Jeff diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d6b5ded32a4..90d9f9d92d3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2020-02-04 Jeff Law + + PR rtl-optimizati

Re: [PATCH] avoid issuing -Wrestrict from folder (PR 93519)

2020-02-06 Thread Jeff Law
On Wed, 2020-02-05 at 09:19 +0100, Richard Biener wrote: > On Tue, Feb 4, 2020 at 11:02 PM Martin Sebor wrote: > > On 2/4/20 2:31 PM, Jeff Law wrote: > > > On Tue, 2020-02-04 at 13:08 -0700, Martin Sebor wrote: > > > > On 2/4/20 12:15 PM, Richard Biener wrote: >

Re: [PATCH] adjust object size computation for union accesses and PHIs (PR 92765)

2020-02-06 Thread Jeff Law
On Wed, 2020-02-05 at 16:57 -0700, Martin Sebor wrote: > > It passes thanks to the TREE_CODE (arg) == PARM_DECL test added > in the patch to get_range_strlen (the test was missing before > and so while it handled ordinary objects (local or global) it > unnecessarily excluded function arguments. Oh

Re: [RFA] [PR rtl-optimization/90275] Handle nop reg->reg copies in cse

2020-02-06 Thread Jeff Law
On Wed, 2020-02-05 at 13:30 +, Richard Sandiford wrote: > Jeff Law writes: > > Richard & Segher, if y'all could check my analysis here, it'd be > > appreciated. > > > > pr90275 is a P2 regression that is only triggering on ARM. David's > >

[committed] Fix minor hppa testsuite failure due to recent IRA changes

2020-02-06 Thread Jeff Law
of shadd insns. Committed to the trunk. Jeff commit f976fe0937c2b46880628c2e2749ca3a788c5db0 Author: Jeff Law Date: Wed Feb 5 10:00:48 2020 -0700 Fix testsuite "regression" on hppa after recent IRA changes. * gcc.target/hppa/shadd-3.c: Disable delay slot filling and

Re: [RFA] [PR rtl-optimization/90275] Handle nop reg->reg copies in cse

2020-02-07 Thread Jeff Law
On Thu, 2020-02-06 at 07:56 -0600, Segher Boessenkool wrote: > On Wed, Feb 05, 2020 at 11:48:23AM -0700, Jeff Law wrote: > > Yea, it's closely related. In your case you need to effectively ignore > > the nop insn to get the optimization you want. In mine that nop in

Re: [PATCH] avoid issuing -Wrestrict from folder (PR 93519)

2020-02-07 Thread Jeff Law
On Thu, 2020-02-06 at 14:16 +0100, Richard Biener wrote: > On Thu, Feb 6, 2020 at 2:00 PM Jeff Law wrote: > > On Wed, 2020-02-05 at 09:19 +0100, Richard Biener wrote: > > > On Tue, Feb 4, 2020 at 11:02 PM Martin Sebor wrote: > > > > On 2/4/20 2:31 PM, Jeff Law wrote

Fix libgcc build failure on FRV

2020-02-10 Thread Jeff Law
libgcc to avoid the error. I've verified this fixes the libgcc build failure for FRV and verified that the GCC testresults have returned to normal. Installed on the trunk, Jeff commit 7214fce3024d726ad548d7003fa162eb5021c491 Author: Jeff Law Date: Mon Feb 10 14:12:32 2020 -0700 Fix l

Re: [PATCH] avoid assuming calloc return value is used (PR 93683)

2020-02-11 Thread Jeff Law
On Tue, 2020-02-11 at 16:01 -0700, Martin Sebor wrote: > Along with some special handling of calloc calls, r272717 introduced > the assumption into stmt_kills_ref_p that the value returned from > the call is used. The code triggers an ICE when invoked during DCE > in an attempt to determine whethe

[committed] Clean up various dead patterns, expanders, splitters and peepholes on the H8.

2020-02-12 Thread Jeff Law
in particular is useful to simplify the cc0 conversion. Installing on the trunk momentarily. Jeff commit e5cc04a73a3e212114ca9725911eaaa66d32303c Author: Jeff Law Date: Wed Feb 12 10:35:12 2020 -0700 Clean up dead patterns, splitters, expanders and peepholes on the H8 port.

Re: [PATCH] regalloc/debug: fix buggy print_hard_reg_set

2020-02-12 Thread Jeff Law
On Tue, 2020-02-11 at 15:54 +0100, Hans-Peter Nilsson wrote: > I was using ira-conflicts.c:print_hard_reg_set with a local > patch to gdbinit.in in a debug-session, and noticed the > erroneous output. I see there's an almost identical function in > ira-color.c and on top of that, there's another f

Re: [PATCH] issue -Wstringop-overflow for potential overflow, not -truncation (PR 93646)

2020-02-12 Thread Jeff Law
On Mon, 2020-02-10 at 15:47 -0700, Martin Sebor wrote: > The reporter of RHBZ #1798636 was mislead and confused by GCC > issuing -Wstringop-truncation for a possible overflow in strncat. > It took a few iterations to appreciate this subtlety and realize > the warning was of the wrong kind. > > The

[committed] More H8 cleanups

2020-02-12 Thread Jeff Law
when fed by a simple (and) operation were consolidated into a single peephole2. These are still triggering which may point to a failing of the match.pd patterns, but addressing in match.pd seems terribly out of scope at this point. Installing on the trunk. Jeff commit 37462a131c528d0980915d98567361a

Re: Patch ping

2020-02-12 Thread Jeff Law
On Mon, 2020-02-10 at 10:24 +0100, Jakub Jelinek wrote: > Hi! > > I'd like to ping a couple of patches: > > PR target/91913 - arm movsi + cmpsi -> movsi_compare0 peephole2 ICE fix >https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00010.html Letting the ARM guys deal with this. > > PR preproce

Re: [PATCH] [MIPS] Remove unnecessary moves around DSP multiply-accumulate instructions

2020-02-12 Thread Jeff Law
On Thu, 2020-02-06 at 14:05 +0100, Mihailo Stojanovic wrote: > Unnecessary moves around dpadd and dpsub are caused by different pseudos > being assigned to the input-output operands which correspond to the same > register. > > Just like for the MSA multiply-accumulate instructions, this forces the

[committed] Consolidate two H8 peepholes into one peephole using a mode iterator

2020-02-12 Thread Jeff Law
hortening peepholes): Use a mode iterator to merge the HImode and SImode peepholes. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b566ca4b591..fe42cee9e22 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2020-02-12 Jeff Law + + * config/h8300/h8300.md (c

Re: [PATCH] config: import pkg.m4 from pkg-config

2020-02-13 Thread Jeff Law
On Thu, 2020-02-13 at 00:30 -0500, Mike Frysinger wrote: > We use this in the sim tree currently. Rather than require people to > have pkg-config installed, include it in the config/ dir. > > 2012-12-23 Mike Frysinger > > * pkg.m4: New file from pkg-config-0.29.2. Presumably you're send

Re: [PATCH] libiberty.h: punt duplicate strverscmp prototype

2020-02-13 Thread Jeff Law
On Thu, 2020-02-13 at 00:27 -0500, Mike Frysinger wrote: > SVN r216772 accidentally copied & pasted this prototype when adding > other ones nearby. > > 2020-02-13 Mike Frysinger > > * libiberty.h (strverscmp): Delete duplicate prototype. OK. Please push if you've got privs. If not, let

Re: [fixincludes] skip fixinc on vxworks7*, amend mkheaders

2020-02-13 Thread Jeff Law
On Thu, 2020-02-13 at 01:30 -0300, Alexandre Oliva wrote: > vxworks7 headers haven't required fixes, and we've long avoided > running fixinc on them. > > The problem with that is that, with a dummy fixinc, mkheaders wipes > out include-fixed but then multi_dir subdirs are not created again, so > w

Re: [PATCH v2] [MIPS] Prevent allocation of a GPR for a floating mode pseudo

2020-02-13 Thread Jeff Law
On Mon, 2020-02-10 at 14:33 +0100, Mihailo Stojanovic wrote: > Similar to the mirror case of allocating an FPR for an integer mode > pseudo, prevent GPRs from being allocated for a floating mode pseudo. > > gcc/ChangeLog: > > * gcc/config/mips/mips.c (mips_ira_change_pseudo_allocno_class)

Re: [PATCH] c: Fix ICE with cast to VLA [93576]

2020-02-13 Thread Jeff Law
On Thu, 2020-02-13 at 18:57 +0100, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because the PR84305 changes try to evaluate > the size earlier. If size has side-effects, that is desirable, and the > side-effects will actually be wrapped in a SAVE_EXPR. The problem on this > testca

Re: Patch ping

2020-02-13 Thread Jeff Law
On Thu, 2020-02-13 at 10:42 -0700, Martin Sebor wrote: > On 2/13/20 2:54 AM, Jakub Jelinek wrote: > > On Wed, Feb 12, 2020 at 02:39:05PM -0700, Jeff Law wrote: > > > On Mon, 2020-02-10 at 10:24 +0100, Jakub Jelinek wrote: > > > > Hi! > > > > &g

Re: Do not call null register_common in emutls

2020-02-13 Thread Jeff Law
On Thu, 2020-02-06 at 04:07 -0300, Alexandre Oliva wrote: > Thread-local variables with DECL_COMMON trigger an internal compiler > error on targets that use emulated TLS without register_common, when > we attempt to expand a call to the NULL register_common, with > testcases as simple as gcc.dg/tls

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Jeff Law
On 12/4/19 8:24 AM, Wilco Dijkstra wrote: > Hi Jeff, > >>> I've noticed quite significant package failures caused by the revision. >>> Would you please consider documenting this change in porting_to.html >>> (and in changes.html) for GCC 10 release? >> >> I'm not in the office right now, but figur

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Jeff Law
On 12/4/19 2:03 PM, Joseph Myers wrote: > On Wed, 4 Dec 2019, Jeff Law wrote: > >>> So what normally happens with the numerous new warnings/errors in GCC >>> releases? I suppose that could cause package failures too. Would it be >>> feasible >>> to ove

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-05 Thread Jeff Law
On 12/5/19 2:16 AM, Martin Liška wrote: > >> >> Of the ~450 packages affected I'd estimate that even with the opt-out >> mechanism we're still going to have to fix ~100 packages immediately >> because they don't honor the flags injection mechanisms which the >> opt-out approach relies upon. > > F

Re: [COMMITTED][MSP430] Fix postinc addressing mode being used for dst operand of CMP insns

2019-12-05 Thread Jeff Law
On 12/5/19 4:32 AM, Jozef Lawrynowicz wrote: > MSP430 RTL patterns for conditional branch instructions allow the post > increment addressing mode to be used for the "dest" operand of CMP > instructions > used in these patterns. > > This is currently causing trunk to FTB for msp430-elf since these

Re: [RFC] Characters per line: from punch card (80) to line printer (132) (was: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments)

2019-12-05 Thread Jeff Law
On 12/5/19 9:24 AM, Paul Koning wrote: > > >> On Dec 5, 2019, at 11:17 AM, Joseph Myers >> wrote: >> >> On Thu, 5 Dec 2019, Thomas Schwinge wrote: >> >>> In the relevant session at the GNU Tools Cauldron 2019, Michael >>> Meissner stated that even he is not using a 80 x 24 terminal >>> anymore

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-05 Thread Jeff Law
On 12/5/19 6:18 AM, Wilco Dijkstra wrote: > Hi, > > I have updated the documentation patch here and added relevant maintainers > so hopefully this can go in soon: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00311.html > > I moved the paragraph in changes.html to the C section like you sugges

Re: [PATCH] avoid using uninitialized offset (PR 92622)

2019-12-05 Thread Jeff Law
On Thu, 2019-12-05 at 15:22 -0700, Martin Sebor wrote: > PR middle-end/92622 - FAIL: gcc.dg/Warray-bounds-22.c on ILP32: > missing warnings for VLA on lines 67 and 69 > > gcc/ChangeLog: > > PR testsuite/92622 > * tree-vrp.c (vrp_prop::check_array_ref): Avoid using a > variable >

Re: Fix @multitable handling in texi2pod.pl

2019-12-06 Thread Jeff Law
On Fri, 2019-12-06 at 10:17 +, Richard Sandiford wrote: > While trying out Dennis's Armv8.6-A patch, I noticed that texi2pod.pl > didn't handle the new @multitable correctly. There were two > problems: > > (1) @multitables nested in other @tables inherited the @item type > from > the encl

Re: Fix profile updatin in tree-ssa-threadupdate

2019-12-06 Thread Jeff Law
On Thu, 2019-12-05 at 11:12 +0100, Jan Hubicka wrote: > Hi, > this patch makes tree-ssa-threadupdate to not leave basic blocks with > undefined counts in the program. > > create_block_for_threading sets counts as follows: > > /* Zero out the profile, since the block is unreachable for > now.

Re: [PATCH] [libiberty] Fix read buffer overflow in split_directories

2019-12-06 Thread Jeff Law
On Thu, 2019-11-28 at 22:10 +0100, Tim Rühsen wrote: > An empty name param leads to read buffer overflow in > function split_directories. > > * libiberty/make-relative-prefix.c (split_directories): > Return early on empty name. > --- > libiberty/ChangeLog | 7 +++ > libiberty/m

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-06 Thread Jeff Law
On Tue, 2019-12-03 at 11:52 -0500, David Malcolm wrote: > On Wed, 2019-11-20 at 11:18 +0100, Richard Biener wrote: > > On Tue, Nov 19, 2019 at 11:02 PM David Malcolm > > > > wrote: > > > > > The checker is implemented as a GCC plugin. > > > > > > > > > > The patch kit adds support for "in-tree" p

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-06 Thread Jeff Law
On Wed, 2019-12-04 at 12:55 -0700, Martin Sebor wrote: > On 11/15/19 6:22 PM, David Malcolm wrote: > > This patch kit introduces a static analysis pass for GCC that can > > diagnose > > various kinds of problems in C code at compile-time (e.g. double- > > free, > > use-after-free, etc). > > I have

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

2019-12-06 Thread Jeff Law
On Wed, 2019-11-13 at 09:27 -0700, Sandra Loosemore wrote: > > I bootstrapped and regression-tested this on x86_64-linux-gnu. There > are a few regressions involving these tests: > > gcc.dg/tree-ssa/pr77445-2.c I believe tihs is another instance of the FSA optimization. I'd need to see the befo

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-06 Thread Jeff Law
On Tue, 2019-11-12 at 09:11 +, Matthew Malcomson wrote: > In scheduling passes, notes are removed with `remove_notes` before > the > > scheduling is done, and added back in with `reemit_notes` once the > > scheduling has been decided. > > > > This process leaves the notes in the RTL chain

Re: [PATCH 09/49] gimple const-correctness fixes

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > This patch converts various "gimple *" to "const gimple *" and > similar > fixes for gimple subclasses, adding is_a_helper for gimple subclasses > to support the const form of as_a, and adding a few "const" overloads > of accessors. > > Thi

Re: [PATCH 06/49] timevar.h: add auto_client_timevar class

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > This patch adds a class "auto_client_timevar", similar to > auto_timevar, > but for plugins to use on their own timing items that aren't in > timevar.def > > gcc/ChangeLog: > * timevar.h (class auto_client_timevar): New class. So if w

Re: [PATCH 03/49] diagnostic_show_locus: move initial newline to callers

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > diagnostic_show_locus adds a newline before doing anything (including > the do-nothing-else case). > > This patch removes this initial newline, adding it to all callers > of diagnostic_show_locus instead. > > Doing so makes diagnostic_show

Re: [PATCH 07/49] Replace label_text ctor with "borrow" and "take"

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > libcpp's label_text class wraps a text buffer, along with a flag to > determine if it "owns" the buffer. > > The existing ctor exposed this directly, but I found it difficult > to remember the sense of flag, so this patch hides the ctor, in

Re: [PATCH 08/49] Introduce pretty_printer::clone vfunc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > This patch provides a way to clone a pretty_printer. > > This is needed so that we can capture text in a label_text and make > layout decisions based on it, using the policy of global_dc's > printer, > whilst within a call to diagnostic_sho

Re: [PATCH 13/49] function-tests.c: expose selftest::make_fndecl for use elsewhere

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This is used by new selftests later on in the patch kit. > > gcc/ChangeLog: > * function-tests.c (selftest::make_fndecl): Make non-static. > * selftest.h (selftest::make_fndecl): New decl. OK jeff

Re: [PATCH 14/49] hash-map-tests.c: add a selftest involving int_hash

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > gcc/ChangeLog: > * hash-map-tests.c (selftest::test_map_of_int_to_strings): New > selftest. > (selftest::hash_map_tests_c_tests): Call it. OK jeff >

Re: [PATCH 16/49] Add support for in-tree plugins

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds support for "in-tree" plugins i.e. GCC plugins that > live > in the GCC source tree and are shipped as part of the GCC tarball. > > The patch adds Makefile/configure machinery for handling in-tree GCC > plugins, adapted from

Re: [PATCH 17/49] Support for adding selftests via a plugin

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch provides a plugin callback for invoking selftests, so that > a > plugin can add tests to those run by -fself-test=DIR. The callback > invocation uses invoke_plugin_callbacks, which is a no-op if plugin > support is disabled. > >

Re: [PATCH 12/49] Add diagnostic paths

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > This patch adds support for associating a "diagnostic_path" with a > diagnostic: a sequence of events predicted by the compiler that leads > to > the problem occurring, with their locations in the user's source, > text descriptions, and stac

Re: [PATCH 19/49] analyzer: new files: analyzer-selftests.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > gcc/ChangeLog: > * analyzer/analyzer-selftests.cc: New file. > * analyzer/analyzer-selftests.h: New file. This obviously can't stand on its own, but it's fine once prereqs are approved. jeff

Re: [PATCH 22/49] analyzer: params.def: new parameters

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > gcc/ChangeLog: > * params.def (PARAM_ANALYZER_BB_EXPLOSION_FACTOR): New param. > (PARAM_ANALYZER_MAX_ENODES_PER_PROGRAM_POINT): New param. > (PARAM_ANALYZER_MAX_RECURSION_DEPTH): New param. > (PARAM_ANALYZER_MIN_SNODE

Re: [PATCH 24/49] analyzer: new file: analyzer-pass.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds the IPA pass boilerplate for the analyzer. > > gcc/ChangeLog: > * analyzer/analyzer-pass.cc: New file. Nothing I see controversial here. But obviously will need some adjustment if we're moving away from using the plug

Re: [PATCH 25/49] analyzer: new files: graphviz.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a simple wrapper class to make it easier to > write human-readable .dot files. > > gcc/ChangeLog: > * analyzer/graphviz.cc: New file. > * analyzer/graphviz.h: New file. This doesn't seem specific to the analyzer

Re: [PATCH 26/49] analyzer: new files: digraph.{cc|h} and shortest-paths.h

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds template classes for directed graphs, their nodes > and edges, and for finding the shortest path through such a graph. > > gcc/ChangeLog: > * analyzer/digraph.cc: New file. > * analyzer/digraph.h: New file. >

Re: [PATCH 28/49] analyzer: new files: analyzer.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > gcc/ChangeLog: > * analyzer/analyzer.cc: New file. > * analyzer/analyzer.h: New file. > --- > gcc/analyzer/analyzer.cc | 125 > ++ > gcc/analyzer/analyzer.h | 126 > ++

Re: [PATCH 29/49] analyzer: new files: tristate.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > gcc/ChangeLog: > * analyzer/tristate.cc: New file. > * analyzer/tristate.h: New file. Nothing really concerning here. Seems like a generic facility we'd like to be able to use elsewhere. Move outside the analyzer? jeff

Re: [PATCH 32/49] analyzer: new files: pending-diagnostic.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds classes used by the analyzer for handling its > diagnostics > (queueing them, deduplicating them, precision-of-wording hooks). > > gcc/ChangeLog: > * analyzer/pending-diagnostic.cc: New file. > * analyzer/pending

Re: [PATCH 34/49] analyzer: new file: sm-malloc.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a state machine checker for malloc/free. > > gcc/ChangeLog: > * analyzer/sm-malloc.cc: New file. FWIW, I could easily see someone using this as a template for other checkers. It shows several key concepts that I suspe

Re: [PATCH 35/49] analyzer: new file: sm-file.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a state machine checker for stdio's FILE stream API. > > gcc/ChangeLog: > * analyzer/sm-file.cc: New file. I note this seems somewhat incomplete -- which is fine given my recommendation was to focus on the double-free

Re: [PATCH 36/49] analyzer: new file: sm-pattern-test.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a custom state machine checker intended purely for > DejaGnu > testing of the sm "machinery". > > gcc/ChangeLog: > * analyzer/sm-pattern-test.cc: New file. OK when prereqs are all approved. jeff

Re: [PATCH 37/49] analyzer: new file: sm-sensitive.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a state machine checker for tracking exposure of > sensitive data (e.g. writing passwords to log files). > > This checker isn't ready for production, and is presented as a > proof-of-concept of the sm-based approach. > > gc

Re: [PATCH 38/49] analyzer: new file: sm-taint.cc

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds a state machine checker for tracking "taint", > where data potentially under an attacker's control is used for > things like array indices without sanitization (CWE-129). > > This checker isn't ready for production, and is p

Re: [PATCH 39/49] analyzer: new files: analysis-plan.{cc|h}

2019-12-07 Thread Jeff Law
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote: > This patch adds an analysis_plan class, which encapsulate decisions > about > how the analysis should happen (e.g. the order in which functions > should > be traversed). > > gcc/ChangeLog: > * analyzer/analysis-plan.cc: New file. >

Re: [PATCH] avoid invoking assignment on uninitialized objects (PR 92761, 92762)

2019-12-07 Thread Jeff Law
On Tue, 2019-12-03 at 15:41 -0700, Martin Sebor wrote: > PR middle-end/92761 - hash_table::expand invokes assignment on invalid objects > PR middle-end/92762 - hash_table::empty_slow invokes assignment on invalid > objects > gcc/ChangeLog: > > PR middle-end/92761 > PR middle-end/92762

Re: Move -Wmaybe-uninitialized to -Wextra

2019-12-07 Thread Jeff Law
On Tue, 2019-11-26 at 19:33 +, Michael Witten wrote: > The problem with false positives is correlated with the degree of > optimization; a lot of people have reported problems at only the > `-Og' optimization level (even when the code in question is > embarrassingly correct). > > Theref

<    1   2   3   4   5   6   7   8   9   10   >