Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

Hi Richard, > On 7 Mar 2024, at 13:40, FX Coudert wrote: > >> I think it's an obvious change ... > > Thanks, pushed. > > Dimitry, I suggest you post the second patch for review. Given that the two patches here (for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632) were considered obvious

Re: [PATCH] libstdc++: Fix infinite loop in std::istream::ignore(n, delim) [PR93672]

> On 4 Apr 2024, at 16:29, Jonathan Wakely wrote: > > I would appreciate more eyes on this to confirm my conclusions about > negative int_type values, and the proposed fix, make sense. > > Tested x86_64-linux. > > -- >8 -- > > A negative value for the delim value passed to std::istream::ign

[pushed] testsuite, Darwin: Account for block labels in function body scans.

ite/ChangeLog: * lib/scanasm.exp: Add 'LB*' to the local labels that are ignored for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/scanasm.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/scanasm.exp b/gcc/testsuite/lib/scanas

[pushed] Darwin: Sync coverage specs with gcc/gcc.cc.

ate coverage specs. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/darwin.h b/gcc/config/darwin.h index 31019a0c49d..c09b9e9dc94 100644 --- a/gcc/config/darwin.h +++ b/gcc/config/darwin.h @@ -406,7 +40

[PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627

Hi PR 109627 is about functions that have had their bodies completely elided, but still have the wrappers for EH frames (either .cfi_xxx or LFSxx/LFExx). These are causing issues for some linkers because such functions result in FDEs with a 0 code extent. The simplest representation of this is

Re: [PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627

> On 9 Apr 2024, at 08:48, Jakub Jelinek wrote: > > On Tue, Apr 09, 2024 at 09:44:01AM +0200, Richard Biener wrote: >> (why not do it at each such switch?) > > Because the traps would then be added even to the bbs which later > end up in the middle of the function. If we defer the unreachabl

Re: [PATCH] build: Check for cargo when building rust language

Hi Arthur, > On 9 Apr 2024, at 11:40, Arthur Cohen wrote: > On 4/9/24 09:47, John Paul Adrian Glaubitz wrote: >> Hello, >> On Mon, 2024-04-08 at 18:33 +0200, pierre-emmanuel.pa...@embecosm.com wrote: >>> The rust frontend requires cargo to build some of it's components, >>> it's presence was not

Re: [PATCH] build: Check for cargo when building rust language

Hi Arthur, > On 9 Apr 2024, at 13:01, Arthur Cohen wrote: > > On 4/9/24 10:55, Iain Sandoe wrote: >> Hi Arthur, >>> On 9 Apr 2024, at 11:40, Arthur Cohen wrote: >>> On 4/9/24 09:47, John Paul Adrian Glaubitz wrote: >>>> Hello, >>>&

[PATCH/RFC] target, hooks: Allow a target to trap on unreachable [PR109267].

ps): New. * doc/invoke.texi: Document -munreachable-traps. * doc/tm.texi: Regenerate. * doc/tm.texi.in: Document TARGET_UNREACHABLE_SHOULD_TRAP. * target.def (TARGET_UNREACHABLE_SHOULD_TRAP): New hook. Signed-off-by: Iain Sandoe --- gcc/builtins.cc| 7 +++ gc

Re: [PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627

> On 9 Apr 2024, at 08:53, Iain Sandoe wrote: > > > >> On 9 Apr 2024, at 08:48, Jakub Jelinek wrote: >> >> On Tue, Apr 09, 2024 at 09:44:01AM +0200, Richard Biener wrote: >>> (why not do it at each such switch?) >> >> Because the tr

Re: [PATCH] libstdc++: Compile std::allocator instantiations as C++20

> On 11 Apr 2024, at 18:33, Ville Voutilainen > wrote: > > On Thu, 11 Apr 2024 at 20:22, Jonathan Wakely wrote: >> >> I'm considering this late patch for gcc-14 to workaround an issue >> discovered by a recent Clang change. >> >> I'm not yet sure if Clang is right to require these symbols.

Re: [PATCH] libgcc: Fix up i386/t-heap-trampoline [PR113403]

> On 1 Feb 2024, at 08:22, Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 12:59:27PM +0100, Jakub Jelinek wrote: >> On Sun, Jan 28, 2024 at 02:07:32PM +0000, Iain Sandoe wrote: >>> --- a/libgcc/config/aarch64/t-heap-trampoline >>> +++ b/libgcc/config/aarch

Re: [PATCH] libgcc: Avoid warnings on __gcc_nested_func_ptr_created [PR113402]

> On 1 Feb 2024, at 08:51, Richard Biener wrote: > > On Thu, Feb 1, 2024 at 9:23 AM Jakub Jelinek wrote: >> >> On Wed, Jan 31, 2024 at 01:04:20PM +0100, Jakub Jelinek wrote: >>> On Sun, Jan 28, 2024 at 11:02:33AM +, Iain Sandoe wrote: >>>>

[pushed] testsuite, Darwin: Allow for undefined symbols in shared test.

tested on i686, x86_64 Darwin, x86_64, aarch64 linux, pushed to trunk, thanks, Iain --- 8< --- Darwin's linker defaults to error on undefined (which makes it look as if we do not support shared, leading to tests being marked incorrectly as unsupported). This fixes the issue by allowing the symbo

[PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, OK for trunk, or some alternative is needed? thanks Iain --- 8< --- Currently, most of the acle tests fail on the Darwin port because DI mode is "long" and uint64 is "long long". The fix for this used in other headers is to

Re: [PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

> On 5 Feb 2024, at 14:56, Iain Sandoe wrote: > > Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, > OK for trunk, or some alternative is needed? Hmm.. apparently, this fails the linaro pre-commit CI for g++ with: error: invalid conversion from 'lo

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

Hi Jason, I have tested this on modern Darwin (with libc++ as the system library) and on older Darwin, where we do see the issue - because the system linker is written in C++ and links with libstdc++ (so sometimes we get a crash, or worse unpredictable beahviour). - For modern Darwin [ > m

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 8 Feb 2024, at 17:16, Jason Merrill wrote: > > On 2/8/24 12:12, Jason Merrill wrote: >> On 2/8/24 10:04, Iain Sandoe wrote: >>> Hi Jason, >>> >>> I have tested this on modern Darwin (with libc++ as the system library) and >>> on >&g

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 8 Feb 2024, at 19:25, Jason Merrill wrote: > > On 2/8/24 12:51, Iain Sandoe wrote: >>> On 8 Feb 2024, at 17:16, Jason Merrill wrote: >>> >>> On 2/8/24 12:12, Jason Merrill wrote: >>>> On 2/8/24 10:04, Iain Sandoe wrote: >>>>

[pushed] libgcc, Darwin: Update symbol exports to include bitint and bf.

Tested on i686-darwin8, x86_64-darwin{14,17,19,21,23} pushed to trunk. thanks, Iain --- 8< --- Some exports were missed from the GCC-13 cycle, these are added here along with the bitint-related ones added in GCC-14. libgcc/ChangeLog: * config/i386/libgcc-darwin.ver: Export bf and bitint

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 8 Feb 2024, at 21:44, Jason Merrill wrote: > > On 2/8/24 12:55, Paolo Bonzini wrote: >> On 2/8/24 18:16, Jason Merrill wrote: > Hmm. In stage 1, when we build with the system gcc, I'd think we want the just-built gnat1 to find the system libgcc. In stage

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >> On 8 Feb 2024, at 21:44, Jason Merrill wrote: >> >> On 2/8/24 12:55, Paolo Bonzini wrote: >>> On 2/8/24 18:16, Jason Merrill wrote: >>>>>> >>>>> >>>>> Hmm. In

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 9 Feb 2024, at 23:21, Iain Sandoe wrote: > > > >> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >>> On 8 Feb 2024, at 21:44, Jason Merrill wrote: >>> >>> On 2/8/24 12:55, Paolo Bonzini wrote: >>>> On 2/8/24 18:16, Jason Merrill

Re: [PATCH] Darwin, testsuite: -bind_at_load is deprecated

Hi FX, > On 10 Feb 2024, at 11:58, FX Coudert wrote: > > With Xcode 15, gcc.dg/darwin-ld-2.c fails due to a warning: > ld: warning: -bind_at_load is deprecated on macOS > > The patches ignores the warning when present. > OK to push? Yes, thanks. Iain I guess for GCC-15 we might need to see w

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 10 Feb 2024, at 12:07, Jason Merrill wrote: > > On 2/10/24 05:46, Iain Sandoe wrote: >>> On 9 Feb 2024, at 23:21, Iain Sandoe wrote: >>> >>> >>> >>>> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >>>>> On 8 Feb 2

Re: [PATCH] Darwin, testsuite: -multiply_defined is obsolete

> On 10 Feb 2024, at 14:54, FX Coudert wrote: > > With Xcode 15, gcc.dg/ssp-2.c fails due to a warning: -multiply_defined is > obsolete > > The patches ignores the warning when present. > OK to push? yes, thanks. Iain … although part of me is curious about whether we still have any support

[PATCH] x86, libgcc: Implement ia32 basic heap trampoline [PR113855].

I have so far tested this on i686-darwin17 and on x86_64-linux (with 32b multilib )with the following permutations: C (dg.exp=*nest*), Ada : \{-m64,-m32\}\{,-ftrampoline-impl=heap\}\{,-shared-libgcc\} Fortran \{-m64,-m32\}\{,-ftrampoline-impl=heap\} The only fails [gnat] are expected (scanning fo

Re: [PATCH] x86, libgcc: Implement ia32 basic heap trampoline [PR113855].

> On 10 Feb 2024, at 17:46, Jakub Jelinek wrote: > > On Sat, Feb 10, 2024 at 05:14:44PM +0000, Iain Sandoe wrote: >> PR target/113855 >> >> gcc/ChangeLog: >> >> * config/i386/darwin.h (DARWIN_HEAP_T_LIB): Moved to be >> availa

Re: [PATCH v2] x86: Support x32 and IBT in heap trampoline

> On 14 Feb 2024, at 18:12, H.J. Lu wrote: > > On Tue, Feb 13, 2024 at 8:46 AM Jakub Jelinek wrote: >> >> On Tue, Feb 13, 2024 at 08:40:52AM -0800, H.J. Lu wrote: >>> Add x32 and IBT support to x86 heap trampoline implementation with a >>> testcase. >>> >>> 2024-02-13 Jakub Jelinek >>>

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 12 Feb 2024, at 19:59, Jason Merrill wrote: > > On 2/10/24 07:30, Iain Sandoe wrote: >>> On 10 Feb 2024, at 12:07, Jason Merrill wrote: >>> >>> On 2/10/24 05:46, Iain Sandoe wrote: >>>>> On 9 Feb 2024, at 23:21, Iain Sandoe wrote:

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 14 Feb 2024, at 22:59, Iain Sandoe wrote: >> On 12 Feb 2024, at 19:59, Jason Merrill wrote: >> >> On 2/10/24 07:30, Iain Sandoe wrote: >>>> On 10 Feb 2024, at 12:07, Jason Merrill wrote: >>>> >>>> On 2/10/24 05:46, Iain Sandoe

Re: [PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

> On 15 Feb 2024, at 18:05, Richard Sandiford wrote: > > Iain Sandoe writes: >>> On 5 Feb 2024, at 14:56, Iain Sandoe wrote: >>> >>> Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, >>> OK for trunk, or some alternative i

[PATCH] libiberty: Fix error return value in pex_unix_exec_child [PR113957].

me for the routine. Signed-off-by: Iain Sandoe --- libiberty/pex-unix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libiberty/pex-unix.c b/libiberty/pex-unix.c index af98062a94c..f3a1cc95ada 100644 --- a/libiberty/pex-unix.c +++ b/libiberty/pex-unix.c @@ -695,6 +695,7 @@ pex_unix_exec

[PATCH] libstdc++, Darwin: Handle a linker warning [PR112397].

e.am: If we are building for Darwin, then suppress hot/cold partitioning for the array allocators. * libsupc++/Makefile.in: Regenerated. Signed-off-by: Iain Sandoe Co-authored-by: Jonathan Wakely --- libstdc++-v3/configure | 35 +++--- libs

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 16 Feb 2024, at 21:05, Jason Merrill wrote: > > On 2/14/24 18:33, Iain Sandoe wrote: >>> On 14 Feb 2024, at 22:59, Iain Sandoe wrote: >>>> On 12 Feb 2024, at 19:59, Jason Merrill wrote: >>>> >>>> On 2/10/24 07:30, Iain Sandoe

[PATCH] aarch64: Allow aarch64-linux-muscl for heap trampolines [PR113971].

gcc/ChangeLog: * config/aarch64/heap-trampoline.c: Allow all linux variants. Signed-off-by: Iain Sandoe --- libgcc/config/aarch64/heap-trampoline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libgcc/config/aarch64/heap-trampoline.c b/libgcc/config/aarch64/h

[PATCH] libgcc, aarch64: Allow for BE platforms in heap trampolines.

s a byte array so that the order is independent of memory byte order. (struct aarch64_trampoline): Likewise. Signed-off-by: Iain Sandoe --- libgcc/config/aarch64/heap-trampoline.c | 30 - 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lib

Re: [PATCH] libgccjit: Add option to allow special characters in function names

> On 20 Feb 2024, at 20:50, David Malcolm wrote: > > On Thu, 2024-02-15 at 17:08 -0500, Antoni Boucher wrote: >> Hi. >> This patch adds a new option to allow special characters like . and $ >> in function names. >> This is useful to allow for mangling using those characters. >> Thanks for the

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 21 Feb 2024, at 23:06, Jason Merrill wrote: > > On 2/20/24 00:45, Alexandre Oliva wrote: >> On Feb 16, 2024, Jason Merrill wrote: >>> So, for stage2+, let's add just prev- libgcc. >> I'm pretty sure this will break bootstrap-lean where libgcc_s isn't a >> system library, and we're buildi

Re: [PATCH v1 03/13] aarch64: Mark x18 register as a fixed register for MS ABI

> On 22 Feb 2024, at 17:45, Andrew Pinski wrote: > > On Thu, Feb 22, 2024 at 3:56 AM Richard Earnshaw (lists) > wrote: >> >> On 21/02/2024 18:30, Evgeny Karpov wrote: >>> >> +/* X18 reserved for the TEB on Windows. */ >> +#ifdef TARGET_ARM64_MS_ABI >> +# define FIXED_X18 1 >> +# define CAL

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

Hi Gaius, > On 22 Feb 2024, at 18:06, Gaius Mulley wrote: > > Iain Sandoe writes: > >> Right now, AFAIK the only target runtimes used by host tools are >> libstdc++, libgcc and libgnat. I agree that might change with rust - >> since the rust folks are talking a

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

> On 21 Feb 2024, at 23:36, Iain Sandoe wrote: > >> On 21 Feb 2024, at 23:06, Jason Merrill wrote: >> >> On 2/20/24 00:45, Alexandre Oliva wrote: >>> On Feb 16, 2024, Jason Merrill wrote: >>>> So, for stage2+, let's add just prev- libgcc.

Re: [PATCH] lto, Darwin: Fix offload section names.

Hi Thomas, > On 29 Feb 2024, at 14:37, Thomas Schwinge wrote: > On 2024-01-16T15:00:16+, Iain Sandoe wrote: >> Currently, these section names have wrong syntax for Mach-O. >> Although they were added some time ago; recently added tests are >> now emitting them

Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target?

> On 10 Jan 2024, at 08:49, Jonathan Yong <10wa...@gmail.com> wrote: > > On 1/9/24 19:37, Radek Barton wrote: >> Hello. >> I forgot to add the target maintainers to the CC. My apologies for that. >> Furthermore, I am adding also relevant changes in >> `libgcc/config/aarch64/lse.S` file to the

Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target?

> On 10 Jan 2024, at 09:02, Iain Sandoe wrote: >> On 10 Jan 2024, at 08:49, Jonathan Yong <10wa...@gmail.com> wrote: >> >> On 1/9/24 19:37, Radek Barton wrote: >>> Hello. >>> I forgot to add the target maintainers to the CC. My apologies for tha

[pushed] Darwin, powerpc: Fix bootstrap.

sed diagnostics class member name for abort of error. Signed-off-by: Iain Sandoe --- gcc/config/rs6000/host-darwin.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc index 691dcb39b6d..e0001776339 100644 --- a/gcc/con

[pushed] Objective-C, Darwin: Fix a regression in handling bad receivers.

ady error_mark_node. gcc/objc/ChangeLog: * objc-next-runtime-abi-02.cc (build_v2_objc_method_fixup_call): Early exit for cases where the sender or receiver are known to be in error. Signed-off-by: Iain Sandoe --- gcc/objc/objc-next-runtime-abi-02.cc | 2 ++ 1 file changed

Jit testsuite updates for Darwin

This is a short series of patches to support non-ELF targets in the jit tests where these use target-specific capabilities (e.g. alias support, or scanning for assembler directives.) An alternative would be to skip these tests for Darwin. Tested on x86_64 Darwin, and about to test Linux, OK for t

[PATCH 1/4] testsuite, jit: test-alias-attribute.c requires alias support.

Add a dg-require-alias to cover this. gcc/testsuite/ChangeLog: * jit.dg/test-alias-attribute.c: Require target alias support. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-alias-attribute.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/jit.dg

[PATCH 2/4] testsuite, jit: Handle whitespace in test-link-section-assembler.c.

arguments. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-link-section-assembler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/jit.dg/test-link-section-assembler.c b/gcc/testsuite/jit.dg/test-link-section-assembler.c index a90b00e9a82..a78e9fd26ef

[PATCH 4/4] testsuite,jit: Handle Darwin/Mach-O in assembler tests.

: Iain Sandoe --- gcc/testsuite/jit.dg/test-always_inline-attribute.c | 10 +++--- gcc/testsuite/jit.dg/test-noinline-attribute.c | 10 +++--- gcc/testsuite/jit.dg/test-setting-alignment.c | 3 ++- gcc/testsuite/jit.dg/test-used-attribute.c | 10 +++--- gcc/testsuite

[PATCH 3/4] testsuite, jit: Allow for target-specific assembler scans.

} } } } or ... { jit-verify-assembler-output ".." { target *-*-darwin* } } } gcc/testsuite/ChangeLog: * jit.dg/jit.exp: Accept target clauses in jit-verify-assembler handling. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/jit.exp | 28

[PATCH] jit, Darwin: Implement library exports list.

(we are not bumping the SO name at this stage). This fixes a number of new failures in jit testing. gcc/jit/ChangeLog: * Make-lang.in: Implement exports list, and use a shared libgcc. * libgccjit.exp: New file. Signed-off-by: Iain Sandoe --- gcc/jit/Make-lang.i

[PATCH] testsuite, jit: Stabilize error output.

ter error output to remove per-run variable content. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/jit.exp | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/jit.dg/jit.exp b/gcc/testsuite/jit.dg/jit.exp index 286cfa8192a..893ff5f6

[PATCH] testsuite, jit, Darwin: Add libSystem to a test.

Log: * jit.dg/test-ggc-bugfix.c: Add libSystem for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-ggc-bugfix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/testsuite/jit.dg/test-ggc-bugfix.c b/gcc/testsuite/jit.dg/test-ggc-bugfix.c index 59eb374af8b..fb857fbf

[PATCH] lto, Darwin: Fix offload section names.

ach. gcc/ChangeLog: * lto-section-names.h (OFFLOAD_SECTION_NAME_PREFIX, OFFLOAD_VAR_TABLE_SECTION_NAME, OFFLOAD_FUNC_TABLE_SECTION_NAME, OFFLOAD_IND_FUNC_TABLE_SECTION_NAME): Provide Mach-O syntax versions when the object format is Mach-O. Signed-off-by: Iain San

[PATCH v2] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

and then move __gcc_nested_func_ptr_created and __gcc_nested_func_ptr_deleted from this symbol version to ... (GCC_14.0.0): ... this one. Signed-off-by: Iain Sandoe Co-authored-by: Jakub Jelinek --- gcc/builtins.def| 4 ++-- gcc/doc/invoke.t

Re: [PATCH v2] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

> On 17 Jan 2024, at 08:55, Iain Sandoe wrote: > > Tested on x86_64, aarch64 Darwin21 (which default to heap-based trampolines) > and on x86_64 Darwin19 and Linux (which default to executable stack > trampolines). > OK for trunk? Hmm.. maybe this is not right and the builti

Re: [COMMITTED] rust_debug: Cast size_t values to unsigned long before printing.

Hi Arthur, > On 18 Jan 2024, at 10:30, Arthur Cohen wrote: > On 1/18/24 10:13, Rainer Orth wrote: >> Arthur Cohen writes: >>> Using %lu to format size_t values breaks 32 bit targets, and %zu is not >>> supported by one of the hosts GCC aims to support - HPUX >> But we do have uses of %zu in gcc

[pushed] Darwin: Fix constant CFString code-gen [PR105522].

ing code. (darwin_libc_has_function): Likewise. (darwin_build_constant_cfstring): Create an anonymous var to hold each CFString. * config/darwin.h (ASM_OUTPUT_LABELREF): Handle constant CFstrings. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc

[pushed] Darwin: Fix a typo in Objective-C meta-data.

the properties of the DECLs. gcc/ChangeLog: * config/darwin.cc (darwin_objc1_section): Use the correct meta-data version for constant strings. (machopic_select_section): Assert if we fail to handle CFString sections as Obejctive-C meta-data or drectly. Signed-off-by: I

[pushed] Darwin: Suppress adding embedded rpaths for earlier OS versions.

sent). gcc/ChangeLog: * config/darwin.h (DARWIN_RPATH_SPEC): Arrange for the %P spec to be conditional on macosx-version-min. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/config/darwin.h b/gcc/conf

[pushed] Objective-C/C++: Ensure sufficient setup for the preprocessor.

are initialized before pre-process-only jobs are run. gcc/objc/ChangeLog: * objc-act.cc (objc_init): Initialize interface and class name hash maps before the preprocessor uses them. Signed-off-by: Iain Sandoe --- gcc/objc/objc-act.cc | 7 +-- 1 file changed, 5 insertions(+)

[PATCH v3] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

cc-std.ver.in (GCC_7.0.0): Likewise and then move __gcc_nested_func_ptr_created and __gcc_nested_func_ptr_deleted from this symbol version to ... (GCC_14.0.0): ... this one. Signed-off-by: Iain Sandoe Co-authored-by: Jakub Jelinek --- gcc/builtins.cc |

[pushed] Darwin, configure: Handle a missing substitution.

exp when ENABLE_DARWIN_AT_RPATH_TRUE is not '#'. Signed-off-by: Iain Sandoe --- gcc/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/Makefile.in b/gcc/Makefile.in index deb12e17d25..95caa54a52b 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -4

Re: [PATCH] jit, Darwin: Implement library exports list.

gentle ping, this fixes quite a few of the new jit fails on darwin. thanks Iain > On 16 Jan 2024, at 11:10, Iain Sandoe wrote: > > Tested on x86_64, i686 Darwin and x86_64 Linux, > OK for trunk? when ? > thanks, > Iain > > --- 8< --- > > Currently, we have no

Re: [PATCH] testsuite, jit: Stabilize error output.

gentle ping, with the increasing use of CI, it seems an idea to tackle this sooner rather than later. thanks Iain > On 16 Jan 2024, at 11:12, Iain Sandoe wrote: > > Tested on x86_64, i686 Darwin, x86_64 Linux, > OK for trunk? When? > thanks > Iain > > --- 8< ---

Re: [PATCH] jit, Darwin: Implement library exports list.

Hi David, > On 24 Jan 2024, at 18:31, David Malcolm wrote: > > On Tue, 2024-01-16 at 11:10 +0000, Iain Sandoe wrote: >> Tested on x86_64, i686 Darwin and x86_64 Linux, >> OK for trunk? when ? >> thanks, >> Iain > > Hi Iain, thanks for the patch. > >

Re: [PATCH v3] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

> On 18 Jan 2024, at 15:05, Jakub Jelinek wrote: > > On Thu, Jan 18, 2024 at 02:59:23PM +0000, Iain Sandoe wrote: >> --- a/gcc/builtins.cc >> +++ b/gcc/builtins.cc >> @@ -8416,6 +8416,11 @@ expand_builtin (tree exp, rtx target, rtx subtarget, >&g

[pushed] testsuite, Objective-C: Fix duplicate libobjc cases.

appear on the link line leading to spurious warnings from Darwin's new linker. gcc/testsuite/ChangeLog: * obj-c++.dg/encode-10.mm: Remove unneeded '-lobjc' option addition. * obj-c++.dg/encode-9.mm: Likewise. Signed-off-by: Iain Sandoe --- gcc/testsuite/obj-c+

[PATCH] jit: Ensure ssize_t is defined.

ble since that is where Posix specifies that ssize_t is defined. gcc/jit/ChangeLog: * libgccjit.h: Conditionally include where it is available to ensure declaration of ssize_t. Signed-off-by: Iain Sandoe --- gcc/jit/libgccjit.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[pushed] Objective-C, Darwin: Do not overalign CFStrings and Objective-C metadata.

ise. (build_ehtype): Likewise. * objc-runtime-shared-support.cc (generate_strings): Likewise. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc| 1 + gcc/objc/objc-next-runtime-abi-02.cc| 18 +++--- gcc/objc/objc-runtime-shared-support.cc | 4 3 files chan

[PATCH 0/2] libgcc: Make heap trampoline support dynamic [PR113403].

This series follows Jakub's suggestion in the PR (for Linux in the first patch) and handles Darwin-specific cases (in the second). Sorry this has taken a while, the Darwin permutations had some glitches which necessitated re-tests on several OS versions. Tested on x86_64 (and aarch64) Darwin, x86

[PATCH 1/2] libgcc: Make heap trampoline support dynamic [PR113403].

This removes the heap trampoline support functions from libgcc.a and adds them to libgcc_eh.a. They are also present in libgcc_s. PR libgcc/113403 libgcc/ChangeLog: * config/aarch64/t-heap-trampoline: Move the heap trampoline support functions from libgcc.a to libgcc_eh.

[PATCH 2/2] libgcc: Make heap trampoline support dynamic [PR113403].

In order to handle system security constraints during GCC build and test and that most platform versions cannot link to libgcc_eh since the unwinder there is incompatible with the system one. 1. We make the support functions weak definitions. 2. We include them as a CRT for platform conditions tha

[PATCH] testsuite, GDC: Update link flags [PR112861].

Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are because we do not generate a runpath for the uninstalled libstdc++. This patch updates the link flags handling to simplify it. We need to add options to locate both lib

[PATCH] testsuite, gfortan: Update link flags [PR112862].

Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are caused by two issues: 1. In some cases there is no generated runpath for libatomic 2. In other cases there are duplicate paths. This patch simplifies the addition of the

[PATCH] testsuite, libphobos: Update link flags [PR112864].

Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are primarily from duplicated '-B' additions. We remove the duplicate on the link line. We also make sure that platforms with extensions other than .so for shared libs will

[PATCH] testsuite, Objective-C++: Update link flags [PR112863].

Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- These regressions are caused by missing or duplicate runpaths which now fire linker warnings. We need to add options to locate libobjc (and on Darwin libobjc-gnu) along with libstdc++. Usually '

Re: [PATCH] jit: Ensure ssize_t is defined.

> On 28 Jan 2024, at 21:25, Eric Gallager wrote: > > On Sun, Jan 28, 2024 at 6:45 AM Iain Sandoe wrote: >> >> Tested on i686, x86_64 Darwin, x86_64 Linux, >> OK for trunk? >> >> --- 8< --- >> >> On some targets it seems that ssize_

Re: [PATCH] jit: Ensure ssize_t is defined.

Hi David, I guess the solution here depends on the scope over which we expect the header to be used. > On 28 Jan 2024, at 23:13, Iain Sandoe wrote: >> On 28 Jan 2024, at 21:25, Eric Gallager wrote: >> On Sun, Jan 28, 2024 at 6:45 AM Iain Sandoe wrote: >>> >>&

[PATCH] testsuite, asan, hwsan: Add libstdc++ deps where required.

tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, OK for trunk? thanks Iain --- 8< --- We use the shared asan/hwasan from both C,C++,D and Fortran. The sanitizer libraries link to libstdc++. When we are using the C/gdc/gfortran driver, and the target might require a path to the

[PATCH] testsuite, ubsan: Add libstdc++ deps where required.

tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, OK for trunk? thanks Iain --- 8< --- We use the ubsan tests from both C, C++, D and Fortran. the sanitizer libraries link to libstdc++. When we are using the C/gdc/gfortran driver, and the target might require a path to the libs

Re: [PATCH] libstdc++: Enable std::text_encoding for darwin and FreeBSD

Hi Jonathan, > On 30 Jan 2024, at 15:02, Jonathan Wakely wrote: > > This should fix the std/text_encoding/* FAILs that Iain sees on darwin. > I assume it will make it work for FreeBSD too. > > I won't push this until I hear it works for at least one of those. It works on x86_64-darwin{19,21,23

Re: c++/modules: Emit definitions of ODR-used static members imported from modules [PR112899]

> On 6 Jan 2024, at 22:30, Nathan Sidwell wrote: > > Richard Smith & I discussed whether we should use the module interface's > capability of giving vague linkage entities a strong location. I didn't want > to go messing with that, 'cos it was changing yet more stuff. > > But, perhaps we sh

Re: Darwin: Replace environment runpath with embedded [PR88590]

Hi Ian > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote: > > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote: >> >> Thanks a lot Alexandre for the review! > > This patch changed the files lingo/configure.ac and libgo/configure. > Those files live in an upstream repository and should be cha

Re: [r14-5930 Regression] FAIL: gcc.c-torture/compile/libcall-2.c -Os (test for excess errors) on Linux/x86_64

Hi FX, > On 1 Dec 2023, at 13:55, FX Coudert wrote: > > That commit makes gcc.target/i386/libcall-1.c on darwin: > > FAIL: gcc.target/i386/libcall-1.c scan-assembler globl\t__divti3 > > because the pattern is not found, the only mention of divti3 in the generated > assembly is: > > LCFI0: >

Re: [PATCH] ada: Fix Ada bootstrap on macOS

> On 1 Dec 2023, at 15:14, Rainer Orth wrote: > > The recent warning changes broke Ada bootstrap on macOS: > > adaint.c: In function '__gnat_copy_attribs': > adaint.c:3336:10: error: implicit declaration of function 'utimes'; did you > mean 'utime'? [-Wimplicit-function-declaration] > 3336 |

Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

HI Sam, I think this qualifies as obvious (it’s on my list, but I did not get to it yet, so go ahead). Iain > On 2 Dec 2023, at 05:30, Sam James wrote: > > From: Iain Sandoe > > r12-3005-g220c410162ebece4f missed a cast for the set_32 call. > Fixed thus. > > Si

Re: [PATCH] gcc: Disallow trampolines when -fhardened

> On 2 Dec 2023, at 09:42, Martin Uecker wrote: > > >> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >> >> -- >8 -- >> It came up that a good hardening strategy is to disable trampolines >> which may require executable stack. Therefore the following patch >> adds -Werror=tram

Re: [PATCH] Testsuite, asan, darwin: Adjust output pattern

Hi FX, > On 11 Dec 2023, at 08:43, FX Coudert wrote: > > Since the last import from upstream libsanitizer, the output has changed > and now looks more like this: > > READ of size 6 at 0x7ff7beb2a144 thread T0 >#0 0x101cf7796 in MemcmpInterceptorCommon(void*, int (*)(void const*, void > con

Re: Backport of "fixincludes: Update darwin_flt_eval_method for macOS 14"

Hi FX, > On 11 Dec 2023, at 11:37, FX Coudert wrote: > I’d like to backport the fixincludes for macOS 14 SDK at > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=93f803d53b5ccaabded9d7b4512b54da81c1c616 > to the active branches, i.e. 13, 12 and 11 (unless I am mistaken). > > The fix has been th

Re: [PATCH] contracts: Stop relying on mangling for naming .pre/.post clones

Hi Arsen, > On 15 Dec 2022, at 18:00, Arsen Arsenović via Gcc-patches > wrote: > Jason Merrill writes: > >> On 12/10/22 08:13, Arsen Arsenović wrote: >>> If the mangler is relied on, functions with extern "C" on them emit multiple >>> definitions of the same name. >> >> But doing it here int

Re: [PATCH v2] coroutines: Accept 'extern "C"' coroutines.

no mangling is required. To do this, we append the actor and destroy suffixes in all cases. Signed-off-by: Iain Sandoe gcc/cp/ChangeLog: * mangle.cc (write_mangled_name): Append the helper function suffixes here... (write_encoding): ... rather than here. gcc/testsuite/

[Ping^1] [PATCH] c++, driver: Fix -static-libstdc++ for targets without Bstatic/dynamic.

Hi this has become more important since it seems I can no longer link a working gnat1 without it, thanks Iain > On 4 Dec 2022, at 16:30, Iain Sandoe via Gcc-patches > wrote: > > This fixes a long-standing problem on Darwin where we cannot independently set > -static-libstdc++ b

Re: [PATCH] c++, driver: Fix -static-libstdc++ for targets without Bstatic/dynamic.

> On 22 Dec 2022, at 21:15, Jason Merrill wrote: > > On 12/4/22 11:30, Iain Sandoe wrote: >> This fixes a long-standing problem on Darwin where we cannot independently >> set >> -static-libstdc++ because the flag gets stripped by the g++ driver. >> This pat

Re: [PATCH] libstdc++, configure: Fix GLIBCXX_ZONEINFO_DIR configuration macro.

Hi, > On 23 Dec 2022, at 23:17, Jonathan Wakely wrote: > > On Fri, 23 Dec 2022, 17:06 Iain Sandoe via Libstdc++, > wrote: > This is a patch for comment on the approach - tested on x86_64-darwi21 > thoughts? > Iain > > --- 8< --- > >

Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol.

> On 24 Dec 2022, at 12:12, Jonathan Wakely wrote: > > > > On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, > wrote: > If this is not the right place to export the symbol (or you do not want > to export it in the general case), I can always add a platform

Re: [PATCH] libstdc++: Test for tzdata.zi before fallback version files.

> On 24 Dec 2022, at 12:25, Andreas Schwab wrote: > > On Dez 24 2022, Iain Sandoe via Gcc-patches wrote: > >> @@ -1083,6 +1078,14 @@ namespace std::chrono >> if (*zif >> hash >> label >> version) >> if (hash == '#' &&

Re: [PATCH modula2] PR-108142 Remove empty directories created in the build directory

Hi Gaius, I’m finding it hard to figure out how the configuration is supposed to work for cross compilers (and more so for Canadian/native crosses). Apologies if this is already answered in other review (but maybe some notes would help in that case). questions in-line, thanks Iain > On 26 De

<    1   2   3   4   5   6   7   8   9   10   >