llo wrote:
>
> On 11-10-13 17:55 , Gabriel Charette wrote:
>
>> I'm not sure exactly how you skip headers already parsed now (we
>> didn't used to when I wrote this code and that was the only problem
>> remaining in the line_table (i.e. duplicate entries for
I just thought about something..
Earlier I said that ALL line_table issues were resolved after this
patch (as it ignores the re-included headers that were guarded, as the
non-pph compiler does naturally).
One problem remains however, I'm pretty sure that re-included
non-pph'ed header's line_table
owl wrote:
> I removed the build directories and rebuilt. Everything worked.
> There are gremlins in the machine.
>
> On 7/29/11, Gabriel Charette wrote:
>> I just stashed all my changes and pulled in the latest svn HEAD this
>> morning to check if I was seeing these failure
ly in lto.
Do we want to apply the changes to libcpp to trunk now or wait??
Tested with bootstrap and pph regression testing.
Gab
2011-08-04 Gabriel Charette
* decl.c (finish_function): Remove line 0 hack.
* pph-streamer-in.c (pph_loc_offset): New global variable.
[+ccoutant]
>> Added lto streamer hooks to do this, but Cary (ccoutant) was saying he'd
>> want it directly in lto.
>>
>> Do we want to apply the changes to libcpp to trunk now or wait??
>
> How urgent is the merge? It wouldn't hurt to run a few more test
> cases. I have some hidden in my client
On Fri, Aug 5, 2011 at 9:42 AM, Diego Novillo wrote:
> On Thu, Aug 4, 2011 at 17:47, wrote:
>> So if I understand correctly, the reference system doesn't work yet, you
>> just put out the design in this patch and you'll fill up functionality
>> in an upcoming patch so that's it's clearer what yo
On Fri, Aug 5, 2011 at 10:37 AM, Tom Tromey wrote:
>>>>>> "Gabriel" == Gabriel Charette writes:
>
> Gabriel> This hack, has described in more details in the email labeled
> Gabriel> "Line 0 Hack??", was now causing problem when serializing
I now get the following test failure output after pulling this patch
(potentially from the almost concurrent checkin of my linetable
patch?)
I can send you my diff's if you need to compare.
FAIL: g++.dg/pph/c4inline.cc (assembly comparison, sums 46031=>36250)
FAIL: g++.dg/pph/x1keyed.cc (assemb
This is the test I was talking would potentially fail with our current
implementation.
And it does.
It has an assembly difference in the order of the global variables, like we
used to have in simpler tests.
Gab
2011-08-05 Gabriel Charette
* (x0hardorder1.h): New
>>> Gah. I was going to commit this separately but forgot. Sorry about that.
>>>
>> K, why does this fix the test? seems weird that we had an infinite
>> loop before and changing the flags gets rid of it?
>
> It wasn't an infinite loop but an ICE in the tree caches. The
> different options were
check-c++ RUNTESTFLAGS=pph.exp` ran from
bld/ now also runs c++0x tests it seems.
Diego said we don't care about those yet, so I changed my test run to be `make
check-g++ RUNTESTFLAGS=pph.exp` ran from bld/gcc/
Gab
2011-08-10 Gabriel Charette
* g++.dg/pph/x5dynarray7.h: Remove 2 bog
:
> Let me know if my recent push has not solved this problem.
>
> On 8/5/11, Gabriel Charette wrote:
>> I now get the following test failure output after pulling this patch
>> (potentially from the almost concurrent checkin of my linetable
>> patch?)
>>
>>
like
overkill to me. The only thing I can think of is that it's more optimal as it's
inlined (but if that's really needed we can always make
linemap_position_for_column an inline function).
Gabriel
2011-08-10 Gabriel Charette
* c-opts.c (c_finish_options): Don't c
Tested with bootstrap and full regression testing on x64.
On Wed, Aug 10, 2011 at 11:22 AM, Gabriel Charette wrote:
> There was a bug where c_finish_options would create some builtins and assign
> them source_locations in the linemap other than BUILTINS_LOCATION == 1.
>
> Thus,
On Thu, Aug 11, 2011 at 7:22 AM, Dodji Seketeli wrote:
> Hello,
>
> gch...@google.com (Gabriel Charette) a écrit:
>
>> diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c
>> index 3227f7b..1af8e7b 100644
>> --- a/gcc/c-family/c-opts.c
>> +++ b/gcc/c-fam
On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther
wrote:
> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote:
>> There was a bug where c_finish_options would create some builtins and assign
>> them source_locations in the linemap other than BUILTINS_LOCATION == 1.
&
On Thu, Aug 11, 2011 at 10:14 AM, Richard Guenther
wrote:
> On Thu, Aug 11, 2011 at 6:54 PM, Gabriel Charette wrote:
>> On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther
>> wrote:
>>> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote:
>>>> There wa
On Thu, Aug 11, 2011 at 10:45 AM, Dodji Seketeli wrote:
>> As I mentioned, we have the same problem in pph where we need to force
>> a location (i.e. the lexer is assigning new locations, but we don't
>> want it to when we are replaying pre-processor tokens), so just a
>> "builtin_location" field
can always make
linemap_position_for_column an inline function directly).
Tested with full boostrap and regression testing with all+go language
configuration.
Ok for trunk?
Gabriel
2011-08-11 Gabriel Charette
* include/line-map.h (LINEMAP_POSITION_FOR_COLUMN): Remove.
Update a
> I also removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same thing as
> linemap_position_for_column, so maintaining both in parallel seems like
> overkill to me. The only thing I can think of is that it's more optimal as
> it's inlined (but if that's really needed we can always make
> li
:27 AM, Tom Tromey wrote:
>>>>>> "Gabriel" == Gabriel Charette writes:
>
> Gabriel> Removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same
> Gabriel> thing as linemap_position_for_column, so maintaining both in
> Gabriel> parallel seems like overkill to
On Mon, Aug 15, 2011 at 1:39 PM, Ian Lance Taylor wrote:
> Gabriel Charette writes:
>
>> Ian: can you approve the go changes in this patch?
>
> The changes to the Go frontend are fine, but they need to be applied to
> the master repository for the Go frontend. I can take ca
Forwarding this patch to pph (which was just committed to trunk in
issue4874043).
Committed to pph branch.
2011-08-11 Gabriel Charette
libcpp/ChangeLog
* include/line-map.h (LINEMAP_POSITION_FOR_COLUMN): Remove.
Update all users to use linemap_position_for_column
already; thus it doesn't show up in this updated patch
obviously.
)
Ok for trunk?
Gabriel
2011-08-15 Gabriel Charette
gcc/c-family/ChangeLog
* c-opts.c (c_finish_options): Force BUILTINS_LOCATION for tokens
defined in cpp_init_builtins and c_cpp_builtins.
I really like the way this is implemented! In particular having our
own cache is so great!
A few comments inline below.
Cheers,
Gab
On Mon, Aug 15, 2011 at 8:05 PM, Diego Novillo wrote:
> This patch finishes the support for external references to symbols in
> other PPH files.
>
> This is used w
trunk
patch pending review).
Gab
2011-08-16 Gabriel Charette
gcc/c-family/ChangeLog.pph
* c-opts.c (c_finish_options): Force BUILTINS_LOCATION for tokens
defined in cpp_init_builtins and c_cpp_builtins.
libcpp/ChangeLog.pph
* init.c (cpp_create_r
the quality of the pph line_table (closer and closer to the
non-pph line_table, but not perfect yet).
Tested with bootstrap and pph regression testing.
Gab
2011-08-16 Gabriel Charette
gcc/cp/ChangeLog.pph
* pph-streamer-in.c (pph_read_file_1): Set location of replayed
reads its children...).
I'm working on a better linemap streaming, but I must rely on the list of
includes consisting only of the top-level includes (direct children) for the
current pph.
Committed to pph.
Gab
2011-08-16 Gabriel Charette
* g++.dg/pph/c0deepincl1.h: New.
ed
on read and is already saved in the included pphs themselves.
This fixes c2deepincl.cc which was introduced yesterday to expose this same
issue.
Tested with bootstrap and pph regression testing on x64.
Gab
2011-08-17 Gabriel Charette
gcc/cp/ChangeLog.pph
* pph-st
or a stream (we could definitely map an index to the
post-order traversal of the include tree, but it won't be as fast as a simple
index in a flat vector), I didn't do it for now..
Cheers,
Gab
2011-08-17 Gabriel Charette
gcc/cp/ChangeLog.pph
* pph-streamer-i
Thinking more about this on my way back...
I will only need includes directly included by the current pph, not
the full include tree as I added in version 2 of this patch thinking I
would need it for the line_table...
Can you approve version 1 instead?!
> http://codereview.appspot.com/4904050/di
Tom: ok for trunk?
fortran@: The fortran change just reflects the fix from libcpp,
fortran bootstrap and tests passed.
Thanks,
Gabriel
On Wed, Aug 17, 2011 at 1:04 PM, Dodji Seketeli wrote:
> Hello Gabriel,
>
> gch...@google.com (Gabriel Charette) a écrit:
>
>> Here is
Committing version 1.
Added comment for pph_read_images and moved as requested.
See final patch attached.
Gab
2011-08-18 Gabriel Charette
gcc/cp/ChangeLog.pph
* pph-streamer-in.c (pph_reading_includes): New.
(pph_in_includes): Add logic to control
his fixes the asm diff in p4eabi.cc
It also affects the line number of some expected failures (I think those are
now the "correct" line numbers for the builtins that we are failing on).
Tested on x64 with bootstrap and pph regression testing.
Cheers,
Gab
2011-08-18 Gabriel Chare
x27;t sure is how to handle headers with no .h extensions, will we
ever pph any of those? I currently support them in this patch.
Cheers,
Gab
2011-08-19 Gabriel Charette
gcc/cp/ChangeLog.pph
* pph-streamer-in.c (pph_in_includes): Remove.
(pph_in_linetable_ma
On Mon, Aug 22, 2011 at 8:22 AM, Diego Novillo wrote:
>
> This patch fixes some template test cases. We were trying to
> expand functions that did not really need expanding (templates). This
> got me thinking that we are not approaching the expansion properly.
>
> We are trying to re-create all
otstrap and pph regression testing on x64.
Cheers,
Gab
2011-08-22 Gabriel Charette
* pph-streamer-in.c (pph_loc_offset): Add FIXME to move this variable
to pph_stream.encoder.r
(pph_in_include): New.
(pph_in_line_table_and_includes): Remove LINETAB parameter. Upd
This memory problem was probably due to the big line_table being created with
the incorrect code before.
This test now passes and this FIXME was irrelevant, removed it.
Trivial patch, already discussed with Diego, committed to pph.
2011-08-23 Gabriel Charette
* g++.dg/pph/p4eabi1.h
right now.
Gab
2011-08-24 Gabriel Charette
* pph-streamer-in.c (ALLOC_AND_REGISTER): Take a pph_pickle_cache*
as a first parameter instead of a pph_stream*.
Update all users.
(ALLOC_AND_REGISTER_ALTERNATE): Likewise.
* pph-streamer.c (pph_cache_inser
otentially allowing
us to play tricks later if we need to, i.e. by adding a modified preloaded
structure's reference in the main cache to get the hit we want earlier and
control the result...?)
Tested with bootstrap and pph regression testing.
Cheers,
Gab
2011-08-24 Gabriel Charette
is no implementation change in this patch, every macro used resolves to
what we it replaces, if anything this will make the pph code slightly more
robust to trunk merges.
Tested with boostrap and pph regression testing on x64.
Cheers,
Gab
2011-08-25 Gabriel Charette
* pph-streamer
I'm getting the following pph test failure output after this patch
(I'll commit my patch on top of it anyways as I get the same errors
with a clean build and with my patch, which itself had a clean test
output before this recent pull before my commit).
XPASS: g++.dg/pph/x7rtti.cc -fno-dwarf2-cfi-a
On Fri, Sep 9, 2011 at 4:37 PM, Diego Novillo wrote:
>
> The main problem fixed here is that name lookups for class methods
> uses a binary search that assumes that the methods in
> CLASSTYPE_METHOD_VEC are sorted by pointer value.
>
> Since the reader typically allocates trees in a different patt
Oops forgot to reply all the first time...
On Fri, Sep 9, 2011 at 4:54 PM, Diego Novillo wrote:
> This was not causing any failures, but it is pretty wasteful to read
> the same PPH more than once.
>
> We cannot just skip them, however. We need to read the line table to
> properly modify the lin
Oops forgot to reply all...
On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo wrote:
> This patch removes all the XPASS noise from pph.exp runs by pruning
> the output from the base compiles (thanks Ian for the pointer). It
> add some comments as well.
>
> Lawrence, I noticed that we do not seem to
More comments to come on [3/3], for now just a single comment below on
this specific patch:
> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
> index 0bd4d64..b267833 100644
> --- a/gcc/cp/pph-streamer-in.c
> +++ b/gcc/cp/pph-streamer-in.c
> @@ -439,7 +439,10 @@ pph_in_cxx_binding
Very nice!
I really like where this is heading :)!
I think it would be great to instrument this to know how many times we
need to use a PPH_RECORD_MREF, to avoid trashing the cache (i.e.
potentially there are specific cases where only a small field's value
changes and pickling the entire tree aga
On Wed, Sep 28, 2011 at 5:31 PM, Diego Novillo wrote:
> On Wed, Sep 28, 2011 at 17:23, Gabriel Charette wrote:
>> More comments to come on [3/3], for now just a single comment below on
>> this specific patch:
>>
>>> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/
Just looked at the line_table related sections, but see comments below:
On Tue, Oct 11, 2011 at 4:26 PM, Diego Novillo wrote:
>
> Currently, the consistency check done on pre-processor symbols is
> triggering on symbols that are not really problematic (e.g., symbols
> used for double-include guar
(sorry about the triple-posting, just learnt this mailing list
required plain text emails... hopefully, this works now..)
Additional note: The patch was tested with a full bootstrap build and
regression testing (no new bugs introduced).
There might be header files that are now unused due to the c
Removed the 3 PPH timevars used in pph instrumentation. Those are not used
anymore following the instrumentation removal patch.
Bootstrap build and regression testing were successful.
2011-06-03 Gabriel Charette
* timevar.def (TV_PPH_CACHE_IN): Remove.
(TV_PPH_CACHE_OUT
might be header files that are now unused due to the code removed.
2011-06-06 Gabriel Charette
* gcc/c-family/c.opt (fpth): Remove. Update all users.
(fpth-debug): Likewise.
(fpth-stats). Likewise.
(fpth-md5). Likewise.
* gcc/cp/pph.c (pth_stats): Remove
7
> # of unexpected failures 1
> # of unexpected successes 16
> # of expected failures46
> /usr/local/google/gchare/gcc-clean/bld/gcc/testsuite/g++/../../g++ version
> 4.7.0-pph 20110606 (experimental) (GCC)
2011-06-07 Gabriel Charette
* gcc/cp/pph-st
eLog.pph
===
--- ChangeLog.pph (revision 174853)
+++ ChangeLog.pph (working copy)
@@ -1,3 +1,8 @@
+2011-06-09 Gabriel Charette
+
+ * pph-streamer-out.c (pph_out_tree_header): Rename from
+ pph_output_tree_header. Update all users.
+
2011-06-08 Diego
h
the patch I'm currently writting.
This was tested with a bootstrap build and pph regression testing.
2011-06-14 Gabriel Charette
* pph-streamer-in.c (pph_in_binding_level): Fix read
of shadowed_labels.
(pph_in_binding_level): Removed
2011-06-16 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_in_cxx_binding): Fix streaming logic.
* gcc/cp/pph-streamer-out.c (pph_out_cxx_binding): Fix streaming logic.
Index: gcc/cp/pph-streamer-in.c
===
--- gcc/cp/pp
appears that the compiler
changes it's inlining decisions based on very picky details. In this particular
case, inlining the function resulted in an error.
Tested with bootstrap build and pph regression testing.
2011-06-17 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_start_r
There were two pph_start_record functions, one for the in part, one for the out
part. I renamed them to have different names to avoid confusion for the reader
(and it also makes it easier for tags).
2011-06-17 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_in_start_record
tags).
2011-06-17 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_in_start_record):
Rename from pph_start_record. Update all users.
* gcc/cp/pph-streamer-out.c (pph_out_start_record):
Rename from pph_start_record. Update all users.
Index: gcc/cp/pph-streamer
Clarified comment from v1 of this patch.
2011-06-17 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_start_record):
Initialize cache_ix in all paths.
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
index b3c2ac9..186100f 100644
--- a/gcc/cp/pph-streamer-in.c
`grep "names_size" -R gcc/`.
Should we just remove it?
This doesn't fix any currently failing pph tests.
Tested with bootstrap build and pph regression testing.
2011-06-20 Gabriel Charette
* gcc/cp/pph-streamer-out.c (pph_count_filter_match): Added.
(pph_out_
testing.
2011-06-21 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_in_tree_vec): Make static.
(pph_add_names_to_namespace): Moved from pph.c.
(wrap_macro_def): Moved from pph.c.
(report_validation_error): Moved from pph.c.
(pth_load_identifiers): Moved from
ehaviour which was
to dump the namespace READ in.
This is actually a good thing, because I just realized some of the bindings
are read, but not merged correctly (working on that next), and this exposes
it.
2011-06-22 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_add_names_to_namespace):
global_namespace, but it
compiles without it (which I guess is fine if we don't try to stick to "include
what you use").
2011-06-22 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_add_names_to_namespace): Replaced by
pph_add_bindings_to_namespace.
I've had these two small changes around for a while after making a search and
replace
for extra spaces in my own added code last week.
Tested with bootstrap and pph regression testing, you never know ;)
2011-06-22 Gabriel Charette
* gcc/cp/pph-streamer-out.c (pph_out_lang_spe
t the ICE... I'll have to re-upload the patch as the script already
submitted the files...)
2011-06-22 Gabriel Charette
* gcc/cp/name-lookup.h (cp_binding_level): Removed unused
member names_size. Update all users.
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name-look
See previous message. This patch only adds the fix to the dg-bogus comment for
the failing pph test.
2011-06-22 Gabriel Charette
* gcc/cp/name-lookup.h (cp_binding_level): Removed unused
member names_size. Update all users.
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name
And it looks like this wasn't sent to anyone directly...
Adding back dnovillo and crowl (Diego I don't think Jason was ever
added to the original message...?)
Gab
On Wed, Jun 22, 2011 at 5:02 PM, Gabriel Charette wrote:
>
> See previous message. This patch only adds the fix
Yes I did fill the form, included you as an approver, haven't heard
back from it yet.
Gab
On Thu, Jun 23, 2011 at 10:23 AM, Diego Novillo wrote:
>
> On Thu, Jun 23, 2011 at 13:21, Diego Novillo wrote:
> > I've made a couple of minor edits to comments and formatting and
> > committed to the bran
The names_size member of cp_binding_level was write only. Removed it.
Seems like it was introduced for java in 2002, but it's not used anywhere
anymore in the code.
Tested with bootstrap and full regression testing.
2011-06-23 Gabriel Charette
* name-lookup.h (cp_binding_
Also:
Tested on x86-64. Ok to commit to trunk?
On Thu, Jun 23, 2011 at 2:32 PM, Gabriel Charette wrote:
> The names_size member of cp_binding_level was write only. Removed it.
> Seems like it was introduced for java in 2002, but it's not used anywhere
> anymore in the code.
&
This was commited to trunk. Diego can you commit this patch to pph as well?
Thanks,
Gab
On Thu, Jun 23, 2011 at 4:07 AM, Diego Novillo wrote:
> On Wed, Jun 22, 2011 at 20:17, Gabriel Dos Reis
> wrote:
>> On Wed, Jun 22, 2011 at 7:05 PM, Gabriel Charette wrote:
>>> A
ake a separate case entry with it's own break?
2011-06-24 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_read_tree):
Stream in DECL_CHAIN of VAR_DECL.
Stream in DECL_CHAIN of FUNCTION_DECL.
* gcc/cp/pph-streamer-out.c (pph_write_tree):
Str
Couldn't we have headers look for their corresponding .pph file by
default when -fpph-map is on? (especially since pph.map is only
temporary for the implementation phase)
I would see it like this:
if -fpph-map is not NULL:
look for mapping in file
if not found:
look for default mapping (i.
Just wondering why you're naming x finishing by an underscore "x_",
this is a valid name, but just thinking it's tricky syntax, does this
test anything more? or is it just a preference for private members?
LGTM
On Mon, Jun 27, 2011 at 9:39 AM, Diego Novillo wrote:
> We are very close to having t
On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote:
> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote:
>> Couldn't we have headers look for their corresponding .pph file by
>> default when -fpph-map is on? (especially since pph.map is only
>> temporary fo
On Mon, Jun 27, 2011 at 10:18 AM, Diego Novillo wrote:
> On Mon, Jun 27, 2011 at 13:13, Gabriel Charette wrote:
>> On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote:
>>> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote:
>>>> Couldn't we have header
with bootstrap and pph regression testing.
2011-06-27 Gabriel Charette
* pph-streamer-in.c (pth_get_type_from_index): Moved from pph.c.
(pth_load_number): Moved from pph.c.
(pth_load_token_value): Moved from pph.c.
(pth_load_token): Moved from
Renamed all functions to reflect pph naming schemes (pph_in/out_*).
Also reordered parameters so that the first parameter is always pph_stream*
Tested with bootstrap and pph regression testing.
2011-06-27 Gabriel Charette
* pph-streamer-in.c (pph_get_type_from_index):
Rename
Added myself to write after approval maintainers list.
2011-06-27 Gabriel Charette
* MAINTAINERS (Write After Approval): Add myself.
diff --git a/MAINTAINERS b/MAINTAINERS
index 9dead4f..f6a768e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -324,6 +324,7 @@ Christian Bruel
On Mon, Jun 27, 2011 at 1:40 PM, wrote:
>
> On 2011/06/27 20:33:26, Gabriel Charette wrote:
>>
>> 2011-06-27 Gabriel Charette <mailto:gch...@google.com>
>
> Remove the 'mailto:' prefix.
Weird, that's not in the actual patch, probably gmail pu
need
this new test?
This fixes all of the assembly mismatches in c1limits-externalid.cc however!
Tested with bootstrap build and pph regression testing.
2011-06-27 Gabriel Charette
* pph-streamer-in.c (pph_add_bindings_to_namespace): Reverse names and
namespaces chains
keyed_classes tree eventually when working with
multiple pph's.
2011-06-28 Gabriel Charette
* pph-streamer.c (pph_preload_common_nodes):
Add cp_global_trees[] to cache.
* g++.dg/pph/x1typerefs.cc: Remove xfail.
diff --git a/gcc/cp/pph-streamer.c b/gcc/cp/pph-strea
d pph regression testing.
2011-06-28 Gabriel Charette
* pph-streamer.c (pph_preload_common_nodes):
Append DECL_CONTEXT of global_namespace to cache.
diff --git a/gcc/cp/pph-streamer.c b/gcc/cp/pph-streamer.c
index c62864a..b7ad486 100644
--- a/gcc/cp/pph-streamer.c
+++ b/gcc/c
redundant logic.
Tested with bootstrap build and pph regression testing.
2011-06-29 Gabriel Charette
* pph-streamer.h (struct pph_stream): Fix comment of data_in field.
(pph_out_string_with_length): lto_output_string_with_length now handles
NULL strings, call it
ix any pph test (nor does it even change any pph asm (I
diff'ed the old bad assemblies (*.s+pph) with the new ones)).
Tested with bootstrap build and pph regression testing.
2011-06-30 Gabriel Charette
* Make-lang.in (pph-streamer-out.o): Add dependence on output.h
(pph-stre
to rely on those
fields).
Gab
On Thu, Jun 30, 2011 at 4:33 PM, Diego Novillo wrote:
> On Thu, Jun 30, 2011 at 16:24, Gabriel Charette wrote:
>> first/weak_global_object_name are part of the global state.
>>
>> This seems to be used to produce the assembler names. They are s
Hey,
so I really like the new clean testing system, so that we always
quickly see what we fixed/broked with a local change.
One problem now though: `// pph asm xdiff`, only flags for asm diffs,
but those could be different diffs after a change (for the better or
worse) and this won't be caught. I
ed to revert to this quick hack fix for now (better then not running
the asm diffs...)
(I also added an unrelated re-ordering to the order of the pph asm xdiff
comment in c1varoder.cc)
2011-07-01 Gabriel Charette
* g++.dg/pph/c1varorder.cc: Moved pph asm xdiff comment to top.
regression testing.
PS: Just realized I didn't put a comment in the code for that fix, should I add
one?
2011-07-01 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_add_bindings_to_namespace):
Rebuild the varpool for global variables coming in from the pph.
* gcc/t
On Tue, Jul 5, 2011 at 9:08 PM, Diego Novillo wrote:
> * pph-streamer-in.c (pph_add_bindings_to_namespace):
> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
> index 72536a5..0bab93b 100644
> --- a/gcc/cp/pph-streamer-in.c
> +++ b/gcc/cp/pph-streamer-in.c
> @@ -1167,11 +11
this is not in the front-end
it is not as easy as checking pph_out_file != NULL here.
Gab
diff --git a/gcc/ChangeLog.pph b/gcc/ChangeLog.pph
index b9aeb4d..2776bf0 100644
--- a/gcc/ChangeLog.pph
+++ b/gcc/ChangeLog.pph
@@ -1,3 +1,7 @@
+2011-07-06 Gabriel Charette
+
+ * passes.c
After having a look at how pph.exp works last Friday I think I could
do this myself easily enough.
Or are you still modifying the tests and want me to avoid touching this for now?
Gab
On Fri, Jul 1, 2011 at 5:51 PM, Lawrence Crowl wrote:
> On 7/1/11, Gabriel Charette wrote:
>> One pr
egression testing.
Gab
2011-07-08 Gabriel Charette
* pph-streamer-in.c (pph_in_function_decl): Stream in
DECL_CHAIN of FUNCTION_DECL only if it's part of a RECORD_OR_UNION_TYPE
(pph_read_tree): Stream in DECL_CHAIN of VAR_DECL only if it's part
of a RECOR
th an empty namespace...), if anything maybe we want to assert, but
not skip if it's NULL in my opinion.
Tested with bootstrap and pph regression testing.
Gab
2011-07-08 Gabriel Charette
* gcc/cp/pph-streamer-in.c (pph_add_bindings_to_namespace):
NAMESPACE_LEVEL should nev
kled_tree calls lto_streamer_cache_get
and I'm pretty sure this is the same bug, not a new one introduced by this
patch.
Tested with bootstrap build and pph regression testing.
2011-07-11 Gabriel Charette
* pph-streamer-in.c (pph_add_bindings_to_namespace): Don't reverse
My patch at http://codereview.appspot.com/4657092/ was fixing this.
Did you apply that already? I didn't see it as part of your commits to date?
Gab
On Tue, Jul 12, 2011 at 5:55 AM, Diego Novillo wrote:
>
> Not quite sure what patch fixed this one and I'm too lazy to figure it out
> now.
>
> Co
Re-adding gcc-patches (forgot to send plain text last time...sigh!)
On Tue, Jul 12, 2011 at 10:56 AM, Gabriel Charette wrote:
> I like this implementation!
> Only one thing, if we ACTUALLY want "to_register" NULL instead of the read
> value we can't as in your current i
t 11:14 AM, Diego Novillo wrote:
> On Tue, Jul 12, 2011 at 13:56, Gabriel Charette wrote:
>> I like this implementation!
>> Only one thing, if we ACTUALLY want "to_register" NULL instead of the read
>> value we can't as in your current implementation NULL means
_register_decl_in_symtab): New.
> (pph_register_binding_in_symtab): Rename from
> pph_register_decls_in_symtab. Update all users.
> Do not call nreverse on bl->names and bl->namespaces.
> Call pph_register_decl_in_symtab.
> (pph_read_file_contents
1 - 100 of 117 matches
Mail list logo
