Re: [PATCH] c: add Wzero-as-null-pointer-constant [PR117059]

2024-11-09 Thread Alejandro Colomar
ing that it may be good to add some tests to check that structs with implicit initialization to 0s don't trigger this diagnostic. struct ( int a; void *b; } a = { 0 }; struct ( int a; int b; void *b; } b = { 0 , 0 }; There might be other corner cases worth testing. Thanks for adding this diagnostic! Feel free to add: Suggested-by: Alejandro Colomar Acked-by: Alejandro Colomar Cheers, Alex -- <https://www.alejandro-colomar.es/> signature.asc Description: PGP signature

Re: [PATCH] c: do not warn about truncating NUL char when initializing nonstring arrays [PR117178]

2024-12-16 Thread Alejandro Colomar
check for nonstring cases. > * gcc.dg/Wunterminated-string-initialization-c++.c: Duplicate > C test for -Wc++-compat. The log and the code look good to me, but I'm not a maintainer, so can't review that part. For the behavior and tests: Acked-by: Alejand

Re: [PATCH v20 3/4] c: Add

2025-05-12 Thread Alejandro Colomar
On Mon, May 12, 2025 at 10:54:52AM +, Joseph Myers wrote: > On Sun, 11 May 2025, Alejandro Colomar wrote: > > > gcc/ChangeLog: > > > > * Makefile.in (USER_H): Add . > > * ginclude/stdcountof.h: Add countof macro. > > This is missing tests for th

Re: [PATCH v20 2/4] c: Add _Countof operator

2025-05-12 Thread Alejandro Colomar
On Mon, May 12, 2025 at 10:54:34AM +, Joseph Myers wrote: > On Sun, 11 May 2025, Alejandro Colomar wrote: > > > +/* { dg-options "-Wno-declaration-after-statement -Wno-pedantic -Wno-vla" > > } */ > > > +/* { dg-options "-Wno-pedantic -Wvla-par

Re: [PATCH v1] contrib/: Add support for Link: tags

2025-05-12 Thread Alejandro Colomar
Hi Jonathan, On Mon, May 12, 2025 at 05:42:55PM +0100, Jonathan Wakely wrote: > On Mon, 12 May 2025 at 17:34, Jonathan Wakely wrote: > > > > On Mon, 12 May 2025 at 16:46, Alejandro Colomar wrote: > > > > > > contrib/ChangeLog: > > > > > &g

Re: [PATCH v21 2/3] c: Add

2025-05-12 Thread Alejandro Colomar
Hi Joseph, On Mon, May 12, 2025 at 04:43:45PM +, Joseph Myers wrote: > On Mon, 12 May 2025, Alejandro Colomar wrote: > > > + if (strcmp (xstr(countof), "_Alignas") != 0) > > countof should definitely not expand to _Alignas! D'oh! :-) > I don't

Re: [PATCH v21 1/3] c: Add _Countof operator

2025-05-12 Thread Alejandro Colomar
Hi Jonathan, On Mon, May 12, 2025 at 06:11:18PM +0100, Jonathan Wakely wrote: > On 12/05/25 17:53 +0200, Alejandro Colomar wrote: > > Suggested-by: Xavier Del Campo Romero > > Co-authored-by: Martin Uecker > > Acked-by: "James K. Lowden" > > What

[PATCH v19 0/3] c: Add _Countof and

2025-05-09 Thread Alejandro Colomar
o that in the following days, since I'll be traveling. I haven't yet implemented the pedantic diagnostic for old C versions. This is in my TODO list. I think that's the only thing I'm missing. Have a lovely night! Alex Alejandro Colomar (3): contrib/: Add support for Cc: an

[PATCH v19 2/3] c: Add _Countof operator

2025-05-09 Thread Alejandro Colomar
iewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Cc: Richard Biener Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-fam

[PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

2025-05-09 Thread Alejandro Colomar
contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v19 3/3] c: Add

2025-05-09 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in * ginclude/stdcountof.h: Add countof macro. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h | 31 +++ 2 files changed, 32 insertions(+) create mode 100644 gcc/ginclude

Re: [PATCH v19 3/3] c: Add

2025-05-09 Thread Alejandro Colomar
Hi Jakub, On Fri, May 09, 2025 at 10:02:17PM +0200, Jakub Jelinek wrote: > On Fri, May 09, 2025 at 09:32:50PM +0200, Alejandro Colomar wrote: > > gcc/ChangeLog: > > > > * Makefile.in > > Missing (USER_H): Add stdcountof.h. Thanks! > > --- /dev/null &g

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

2025-05-09 Thread Alejandro Colomar
Hi Joseph, On Fri, May 09, 2025 at 09:00:58PM +, Joseph Myers wrote: > On Fri, 9 May 2025, Alejandro Colomar wrote: > > > contrib/ChangeLog: > > > > * gcc-changelog/git_commit.py (GitCommit): > > Add support for 'Cc: ' and 'Link: ' t

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

2025-05-09 Thread Alejandro Colomar
Hi Joseph, On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote: > > > > contrib/ChangeLog: > > > > > > > > * gcc-changelog/git_commit.py (GitCommit): > > > > Add support for 'Cc: ' and 'Link: ' tags. > > > > > > Please remove this patch from this patch series; it has not

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

2025-05-09 Thread Alejandro Colomar
On Fri, May 09, 2025 at 11:43:18PM +0200, Alejandro Colomar wrote: > Hi Joseph, > > On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote: > > > > > contrib/ChangeLog: > > > > > > > > > > * gcc-changelog/git_commit.py (GitCom

[PATCH v20 0/4] c: Add _Countof and

2025-05-11 Thread Alejandro Colomar
Have a lovely day! Alex Alejandro Colomar (4): contrib/: Add support for Link: tags c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof contrib/gcc-changelog/git_commit.py| 3 + gcc/Makefile.in| 1 + gcc/c-family/c-common.cc

Re: [PATCH v1] contrib/: Add support for Link: tags

2025-05-13 Thread Alejandro Colomar
Hi Jonathan, On Tue, May 13, 2025 at 10:50:23AM +0100, Jonathan Wakely wrote: > Fair enough, I have no objection to adding Link: support to the > git_commit.py script. (We don't really have anybody who is the owner > of those scripts now, so I think you need a global reviewer to approve > it.) Th

Re: [PATCH v21 1/3] c: Add _Countof operator

2025-05-13 Thread Alejandro Colomar
Hi Jonathan, On Tue, May 13, 2025 at 10:39:21AM +0100, Jonathan Wakely wrote: > On Mon, 12 May 2025 at 23:15, Alejandro Colomar wrote: > > <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by> > > > >

Re: [PATCH v1] contrib/: Add support for Link: tags

2025-05-13 Thread Alejandro Colomar
Hi Jason, On Tue, May 13, 2025 at 10:35:00AM -0400, Jason Merrill wrote: > > > It seems to be one of the more common trailers used in the linux > > > kernel [1], > > Hmm, I don't see it in that list. But it is described in > https://docs.kernel.org/process/submitting-patches.html It was mentio

[PATCH v20 2/4] c: Add _Countof operator

2025-05-11 Thread Alejandro Colomar
/questions/37538/#57537491> Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v20 1/4] contrib/: Add support for Link: tags

2025-05-11 Thread Alejandro Colomar
contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Link:' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/gcc-changelog/git_co

[PATCH v20 3/4] c: Add

2025-05-11 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h | 31 +++ 2 files changed, 32 insertions(+) create mode 100644

[PATCH v20 4/4] c: Add -Wpedantic diagnostic for _Countof

2025-05-11 Thread Alejandro Colomar
It is not supported in <= C23 mode. gcc/c/ChangeLog: * c-parser.cc (c_parser_sizeof_or_countof_expression): Add -Wpedantic diagnostic for _Countof in <= C23 mode. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v1] contrib/: Add support for Link: tags

2025-05-12 Thread Alejandro Colomar
contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Link:' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- Hi, This patch is needed by my patches that add _Countof. Have a lovely day! Alex contrib/gcc-changelog/git_com

[PATCH v21 1/3] c: Add _Countof operator

2025-05-12 Thread Alejandro Colomar
/questions/37538/#57537491> Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v21 0/3] c: Add _Countof and

2025-05-12 Thread Alejandro Colomar
hey look good. Have a lovely day! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common.cc | 26 +++ gcc/c-family/c-common.def

[PATCH v21 2/3] c: Add

2025-05-12 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v21 3/3] c: Add -Wpedantic diagnostic for _Countof

2025-05-12 Thread Alejandro Colomar
.dg/countof-pedantic.c * gcc.dg/countof-pedantic-errors.c: Test pedantic diagnostics for _Countof. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-16 Thread Alejandro Colomar
Hi Joseph, On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote: > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > Hmmm, I've been trying to find a compromise between readability and > > simplicity, and I think I have something. I've seen some

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-16 Thread Alejandro Colomar
Hi Joseph, On Fri, May 16, 2025 at 12:25:39PM +, Joseph Myers wrote: > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > - Add (and NDEBUG) to some test files that were missing it, > >and also the forward declaration of strcmp(3). > > Depending on libc heade

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-20 Thread Alejandro Colomar
Hi Joseph, On Tue, May 20, 2025 at 02:43:55PM +, Joseph Myers wrote: > > Could you please clarify if I need to do anything or if this is already > > scheduled for review when you have some time? Also please clarify if > > you're okay with amending that or if you prefer that I send v23. > > I

[PATCH v23 1/3] c: Add _Countof operator

2025-05-20 Thread Alejandro Colomar
f. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26 gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-20 Thread Alejandro Colomar
Hi Jakub, On Tue, May 20, 2025 at 11:20:27PM +0200, Jakub Jelinek wrote: > On Tue, May 20, 2025 at 11:12:38PM +0200, Alejandro Colomar wrote: > > Okay; how about this? > > > > gcc/c-family/ChangeLog: > > > > * c-common.h: Add _Countof operato

[PATCH v23 0/3] c: Add _Countof and

2025-05-20 Thread Alejandro Colomar
I've only ran `make check -j24` once at the tip, and all the countof tests pass. Have a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common

[PATCH v23 3/3] c: Add -Wpedantic diagnostic for _Countof

2025-05-20 Thread Alejandro Colomar
tic-errors on C23. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compat.c | 5 + gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8

[PATCH v23 2/3] c: Add

2025-05-20 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-20 Thread Alejandro Colomar
Hi Joseph, On Fri, May 16, 2025 at 07:13:15PM +0200, Alejandro Colomar wrote: > On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote: > > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > > > Hmmm, I've been trying to find a compromise between readabilit

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-20 Thread Alejandro Colomar
Hi Jakub, On Tue, May 20, 2025 at 05:25:29PM +0200, Jakub Jelinek wrote: > On Tue, May 20, 2025 at 05:15:33PM +0200, Alejandro Colomar wrote: > > I've based on gnulib commits, which I believe follow the same > > guidelines. For example:

Re: [PATCH v23 0/3] c: Add _Countof and

2025-05-21 Thread Alejandro Colomar
On Wed, May 21, 2025 at 02:17:58AM +0200, Alejandro Colomar wrote: > Hi! > > Here's another revision of this patch set. > > v23 changes: > > - More specific change logs. > - #define assert() instead of #include'ing . > > `make check` says all'

[PATCH v1] testsuite: Remove spurious comments [PR117025]

2025-05-28 Thread Alejandro Colomar
PR c/117025 gcc/testsuite/ChangeLog: * gcc.dg/countof-vla.c: Remove spurious comments. * gcc.dg/countof-zero-compile.c: Remove spurious comments. Fixes: 517c9487f8fd (2025-05-27; "c: Add _Countof operator [PR117025]") Reported-by: Sam James Signed-off-by:

Re: [PATCH v25 0/3] c: Add _Countof and

2025-05-27 Thread Alejandro Colomar
Hi Jakub, Joseph, On Tue, May 27, 2025 at 10:28:23PM +0200, Jakub Jelinek wrote: > On Tue, May 27, 2025 at 08:22:28PM +, Joseph Myers wrote: > > Thanks, I've committed these patches, with additional commit message > > changes to reference PR117025 in the standard way for GCC so that Bugzilla

[PATCH v22 0/3] c: Add _Countof and

2025-05-15 Thread Alejandro Colomar
it, and also the forward declaration of strcmp(3). - Fix typos in dejagnu diagnostic comments. Is this ready to merge now, hopefully? :-) Have a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Count

[PATCH v22 2/3] c: Add

2025-05-15 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v22 3/3] c: Add -Wpedantic diagnostic for _Countof

2025-05-15 Thread Alejandro Colomar
.dg/countof-pedantic.c * gcc.dg/countof-pedantic-errors.c: Test pedantic diagnostics for _Countof. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof

[PATCH v22 1/3] c: Add _Countof operator

2025-05-15 Thread Alejandro Colomar
* gcc.dg/countof-zero-compile.c * gcc.dg/countof-zero.c * gcc.dg/countof.c: Add tests for _Countof operator. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.c

Re: [PATCH v22 0/3] c: Add _Countof and

2025-05-15 Thread Alejandro Colomar
Here's the test run. No regressions. BTW, there are some differences between runs. I _think_ this is due to running them in separate days, and having run 'make install' in between, which seems to have made some tests that would normally fail now succeed but that's unrelated to the feature, and i

Re: [PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
Hi Jakub, On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > * c-common.h: Add RID_COUNTOF. > > (enum rid): Add RID_COUNTOF. Okay. > > > (c_countof_type): New function prototype. > > * c-common.def (COUNTOF_EXPR): New tree. > > * c-common.cc > > (c_common_re

[PATCH v25 0/3] c: Add _Countof and

2025-05-21 Thread Alejandro Colomar
ave a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common.cc | 26 gcc/c-family/c-common.def | 3 +

[PATCH v25 2/3] c: Add

2025-05-21 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: New file. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: New test. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h

[PATCH v25 3/3] c: Add -Wpedantic diagnostic for _Countof

2025-05-21 Thread Alejandro Colomar
est. * gcc.dg/countof-pedantic.c: New test. * gcc.dg/countof-pedantic-errors.c: New test. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compa

[PATCH v25 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
* gcc.dg/countof-zero.c: New test. * gcc.dg/countof.c: New test. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26

Re: [PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
Hi Jakub, On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > warning_at (loc, OPT_Wc___compat, > > "defining type in %qs expression is invalid in C++", > > (in_sizeof > > ? "sizeof" > > -: (in_typeof ? "typeof" : "alignof"))); >

Re: [PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
On Wed, May 21, 2025 at 11:36:56PM +0200, Alejandro Colomar wrote: > Hi Jakub, > > On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > > warning_at (loc, OPT_Wc___compat, > > > "defining type in %qs expression is invalid in

Re: [PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
Hi Jakub, On Wed, May 21, 2025 at 11:31:05PM +0200, Alejandro Colomar wrote: > > > +#define c_parser_sizeof_expressi

Re: [PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
Hi Jakub, On Wed, May 21, 2025 at 11:47:30PM +0200, Jakub Jelinek wrote: > > @@ -1747,6 +1737,8 @@ static struct c_expr c_parser_binary_expression > > (c_parser *, struct c_expr *, > > tree); > > static struct c_expr c_parser_cast_expr

[PATCH v24 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
f. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26 gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v24 3/3] c: Add -Wpedantic diagnostic for _Countof

2025-05-21 Thread Alejandro Colomar
tic-errors on C23. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compat.c | 5 + gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8

[PATCH v24 0/3] c: Add _Countof and

2025-05-21 Thread Alejandro Colomar
(test for excess errors) PASS: gcc.dg/countof-zero.c (test for excess errors) PASS: gcc.dg/countof-zero.c execution test PASS: gcc.dg/countof.c (test for excess errors) PASS: gcc.dg/countof.c execution test Have a lovely day! Alex Alejandro Colomar (3): c: Add _Co

[PATCH v24 2/3] c: Add

2025-05-21 Thread Alejandro Colomar
gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

Re: [PATCH v23 1/3] c: Add _Countof operator

2025-05-21 Thread Alejandro Colomar
Hi Joseph, On Wed, May 21, 2025 at 04:26:46PM +, Joseph Myers wrote: > On Wed, 21 May 2025, Alejandro Colomar wrote: > > > @@ -10572,6 +10583,8 @@ c_parser_unary_expression (c_parser *parser) > > case CPP_KEYWORD: > >switch (c_parser_peek

[PATCH resend] Make -Wuse-after-free=3 the default one in -Wall

2023-02-17 Thread Alejandro Colomar via Gcc-patches
ly Cc: Mark Wielaard Cc: Martin Uecker Cc: Michael Kerrisk Cc: Paul Eggert Cc: Sam James Cc: Siddhesh Poyarekar Cc: Yann Droneaud Signed-off-by: Alejandro Colomar --- This is a resend of the same patch previously sent to gcc@. gcc/c-family/c.opt | 4 ++-- gcc/doc/invoke.texi | 2 +- 2 f

Ping: [PATCH resend] Make -Wuse-after-free=3 the default one in -Wall

2023-03-15 Thread Alejandro Colomar via Gcc-patches
Ping On 2/18/23 00:05, Alejandro Colomar wrote: > Link: > <https://inbox.sourceware.org/gcc/3098fd18-9dbf-b4e9-bae5-62ec6fea7...@opteya.com/T/> > Link: <https://github.com/shadow-maint/shadow/pull/649#discussion_r1108350066> > Cc: Andreas Schwab > Cc: David Malcolm

Re: Ping: [PATCH resend] Make -Wuse-after-free=3 the default one in -Wall

2023-03-15 Thread Alejandro Colomar via Gcc-patches
Hi Richard, On 3/15/23 15:52, Richard Biener wrote: > On Wed, Mar 15, 2023 at 3:30 PM Alejandro Colomar via Gcc-patches > wrote: >> >> Ping > > -Wuse-after-free=3 was explicitly added to cover cases with a high > false-positive rate. If you want to > make that

[PATCH 4/4] unsigned-__int128.3: New link to system_data_types(7)

2020-10-01 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/unsigned-__int128.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/unsigned-__int128.3 diff --git a/man3/unsigned-__int128.3 b/man3/unsigned-__int128.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/unsigned

[PATCH 2/4] __int128.3: New link to system_data_types(7)

2020-10-01 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/__int128.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/__int128.3 diff --git a/man3/__int128.3 b/man3/__int128.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/__int128.3 @@ -0,0 +1 @@ +.so man7

[PATCH 3/4] system_data_types.7: Add 'unsigned __int128'

2020-10-01 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man7/system_data_types.7 | 35 +++ 1 file changed, 35 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index 5f9aa648f..3cf3f0ec9 100644 --- a/man7/system_data_types.7 +++ b/man7/system_data_types

[PATCH 0/4] Document 128-bit types

2020-10-01 Thread Alejandro Colomar via Gcc-patches
Hi Michael, I think this might be ready for a patch. I'm done for today :-) Cheers, Alex Alejandro Colomar (4): system_data_types.7: Add '__int128' __int128.3: New link to system_data_types(7) system_data_types.7: Add 'unsigned __int128' unsigne

[PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-01 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man7/system_data_types.7 | 40 1 file changed, 40 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index e545aa1a0..5f9aa648f 100644 --- a/man7/system_data_types.7 +++ b/man7

[PATCH] system_data_types.7: void *: Add info about generic function parameters and return value

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar --- Paul and David, Thanks for your input! Alex man7/system_data_types.7 | 16 1 file changed, 16 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index

Re: [PATCH 2/2] system_data_types.7: void *: Add info about pointer artihmetic

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Michael, The 2/2 is a typo. This is a standalone patch. Cheers, Alex On 2020-10-02 11:44, Alejandro Colomar wrote: Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar --- Paul and David, Thanks for your input! Alex man7/system_data_types.7 | 11

[PATCH 2/2] system_data_types.7: void *: Add info about pointer artihmetic

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar --- Paul and David, Thanks for your input! Alex man7/system_data_types.7 | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index 6451782db

[PATCH 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about generic function parameters and return value Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about pointer artihmetic Reported-by: Paul

[PATCH 0/2] Document 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Michael, As you asked, I squashed. And added the POSIX.1-2008 note too. Thanks for that! Cheers, Alex Alejandro Colomar (2): system_data_types.7: Add 'void *' void.3: New link to system_data_types(7) man3/void.3 | 1 + man7/system_data_ty

[PATCH 2/2] void.3: New link to system_data_types(7)

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/void.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/void.3 diff --git a/man3/void.3 b/man3/void.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/void.3 @@ -0,0 +1 @@ +.so man7/system_data_types.7 -- 2.28.0

[PATCH v2 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man7/system_data_types.7 | 40 1 file changed, 40 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index e545aa1a0..5f9aa648f 100644 --- a/man7/system_data_types.7 +++ b/man7

[PATCH v2 0/4] Document 128-bit types

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Michael, I fixed the stray '"' noticed by Florian. Cheers, Alex Alejandro Colomar (4): system_data_types.7: Add '__int128' __int128.3: New link to system_data_types(7) system_data_types.7: Add 'unsigned __int128' unsigned-__int128.3: New

[PATCH v2 4/4] unsigned-__int128.3: New link to system_data_types(7)

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/unsigned-__int128.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/unsigned-__int128.3 diff --git a/man3/unsigned-__int128.3 b/man3/unsigned-__int128.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/unsigned

[PATCH v2 2/4] __int128.3: New link to system_data_types(7)

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/__int128.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/__int128.3 diff --git a/man3/__int128.3 b/man3/__int128.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/__int128.3 @@ -0,0 +1 @@ +.so man7

[PATCH v2 3/4] system_data_types.7: Add 'unsigned __int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man7/system_data_types.7 | 35 +++ 1 file changed, 35 insertions(+) diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 index 5f9aa648f..3cf3f0ec9 100644 --- a/man7/system_data_types.7 +++ b/man7/system_data_types

[PATCH v4 0/2] Document 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
so, so let's call it v4). Regards, Alex Alejandro Colomar (2): system_data_types.7: Add 'void *' void.3: New link to system_data_types(7) man3/void.3 | 1 + man7/system_data_types.7 | 80 +++- 2 files changed, 79 insertions(+),

[PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about generic function parameters and return value Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about pointer artihmetic Reported-by: Paul

[PATCH v4 2/2] void.3: New link to system_data_types(7)

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/void.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/void.3 diff --git a/man3/void.3 b/man3/void.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/void.3 @@ -0,0 +1 @@ +.so man7/system_data_types.7 -- 2.28.0

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 18:53, Paul Eggert wrote: > On 10/2/20 8:14 AM, Alejandro Colomar wrote: > >> +.I void * > > GNU style is a space between "void" and "*", so this should be '.I > "void\ *"', both here and elsewhere. The backsla

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 19:52, Paul Eggert wrote: Why describe __int128_t in these man pages at all? __int128_t is not a property of either the kernel or of glibc, so it's out of scope. Well, as I see it, [unsigned] __int128 is as good as [u]int64_t. They are part of the C interface in Linux. A

[PATCH v5 0/2] Document 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
: malloc(3), memcmp(3), memcpy(3), memset(3) See also the intptr_t and uintptr_t types in this page. ]] Alejandro Colomar (2): system_data_types.7: Add 'void *' void.3: New link to system_data_types(7) man3/void.3 | 1 + man7/syst

[PATCH v5 2/2] void.3: New link to system_data_types(7)

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar --- man3/void.3 | 1 + 1 file changed, 1 insertion(+) create mode 100644 man3/void.3 diff --git a/man3/void.3 b/man3/void.3 new file mode 100644 index 0..db50c0f09 --- /dev/null +++ b/man3/void.3 @@ -0,0 +1 @@ +.so man7/system_data_types.7 -- 2.28.0

[PATCH v5 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about generic function parameters and return value Reported-by: Paul Eggert Reported-by: David Laight Signed-off-by: Alejandro Colomar system_data_types.7: void *: Add info about pointer artihmetic Reported-by: Paul

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 21:54, Paul Eggert wrote: > On 10/2/20 12:01 PM, Alejandro Colomar wrote: >> If you propose not to document the stdint types either, > > This is not a stdint.h issue. __int128 is not in stdint.h and is not a > system data type in any real sense; it&#

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 22:14, Paul Eggert wrote: > On 10/2/20 11:38 AM, Alejandro Colomar wrote: > >> .I void * >> >> renders with a space in between. > > That's odd, as "man(7)" says "All of the arguments will be printed next > to each ot

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 22:19, Paul Eggert wrote: > On 10/2/20 1:03 PM, Alejandro Colomar wrote: >> I know it's not in stdint, >> but I mean that it behaves as any other stdint type. With caveats, of course. > > It doesn't. There's no portable way to use sc

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-03 Thread Alejandro Colomar via Gcc-patches
Hi Michael and Branden, On 2020-10-03 09:48, G. Branden Robinson wrote: At 2020-10-03T09:10:14+0200, Michael Kerrisk (man-pages) wrote: On 10/2/20 10:27 PM, Alejandro Colomar wrote: On 2020-10-02 22:14, Paul Eggert wrote: > On 10/2/20 11:38 AM, Alejandro Colomar wrote: > >

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-03 Thread Alejandro Colomar via Gcc-patches
On 10/3/20 9:48 AM, G. Branden Robinson wrote: [...] >> The "short" answer[1] is that I think Alex is correct; Paul's caution is >> unwarranted and arises from confusion with the font alternation macros >> of the man(7) macro package.  Examples of the latter are .BI and .BR. >> Those set their ev

[PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-24 Thread Alejandro Colomar via Gcc-patches
wc -l; Link: <https://lore.kernel.org/linux-man/20210423230609.13519-1-alx.manpa...@gmail.com/T/> Link: <https://lore.kernel.org/lkml/YZvIlz7J6vOEY+Xu@yuki/T/> Signed-off-by: Alejandro Colomar Nacked-by: Alexei Starovoitov Nacked-by: Greg Kroah-Hartman Nacked-by: Daniel Borkmann Acked-by:

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-24 Thread Alejandro Colomar via Gcc-patches
Alexei, On 8/24/22 20:55, Alejandro Colomar wrote: > Link: <https://lore.kernel.org/linux-man/20210423230609.13519-1-alx.manpa...@gmail.com/T/> > Link: <https://lore.kernel.org/lkml/YZvIlz7J6vOEY+Xu@yuki/T/> > Signed-off-by: Alejandro Colomar > Nacked-by: Alexei

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Linux, On 8/25/22 02:52, Linus Torvalds wrote: On Wed, Aug 24, 2022 at 4:36 PM Alejandro Colomar wrote: I'm trying to be nice, and ask for review to make sure I'm not making some big mistake by accident, and I get disrespect? No thanks. You've been told multiple times

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Greg, On 8/25/22 07:57, Greg Kroah-Hartman wrote: On Thu, Aug 25, 2022 at 01:36:10AM +0200, Alejandro Colomar wrote: But from your side what do we have? Just direct NAKs without much explanation. The only one who gave some explanation was Greg, and he vaguely pointed to Linus's com

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Xi, On 8/25/22 09:28, Xi Ruoyao wrote: On Thu, 2022-08-25 at 09:20 +0200, Alejandro Colomar via Gcc-patches wrote: I don't know for sure, and I never pretended to say otherwise.  But what IMHO the kernel could do is to make the types compatible, by typedefing to the same fundamental

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Linus, (Oops, I mistyped you name in my previous reply; I'm on a roll for funny typos this week it seems) On 8/25/22 09:42, Linus Torvalds wrote: On Thu, Aug 25, 2022 at 12:20 AM Alejandro Colomar wrote: This patch is not about kernel, but about the section 2 and 3 manual pages,

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
On 8/25/22 09:44, Alejandro Colomar wrote: Hi Greg, On 8/25/22 07:57, Greg Kroah-Hartman wrote: On Thu, Aug 25, 2022 at 01:36:10AM +0200, Alejandro Colomar wrote: But from your side what do we have?  Just direct NAKs without much explanation.  The only one who gave some explanation was Greg

Re: [PATCH v3] bpf.2: Use standard types and attributes

2021-05-21 Thread Alejandro Colomar via Gcc-patches
Hello Daniel, On 5/17/21 8:56 PM, Daniel Borkmann wrote: On 5/16/21 11:16 AM, Alejandro Colomar (man-pages) wrote: Signed-off-by: Alejandro Colomar Discussion: <https://lore.kernel.org/linux-man/6740a229-842e-b368-86eb-defc786b3...@gmail.com/T/> Nacked-by: Alexei Starovoitov Nac

<    1   2   3   4   >