Re: [PATCH] diagnostics: libcpp: Improve locations for _Pragma lexing diagnostics [PR114423]

2024-10-18 Thread David Malcolm
On Fri, 2024-10-18 at 09:25 -0400, Lewis Hyatt wrote: > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114423 > > The diagnostics we issue while lexing tokens from a _Pragma string > have > always come out at invalid locations. I had tried a couple years ago > to > fix this in a general

Re: [RFC][PATCH] AArch64: Remove AARCH64_EXTRA_TUNE_USE_NEW_VECTOR_COSTS

2024-10-18 Thread Richard Biener
On Thu, 17 Oct 2024, Richard Sandiford wrote: > Jennifer Schmitz writes: > > [...] > > Looking at the diff of the vect dumps (below is a section of the diff for > > strided_store_2.c), it seemed odd that vec_to_scalar operations cost 0 now, > > instead of the previous cost of 2: > > > > +stride

[PATCH v2] RISC-V:Auto vect for vector-bfloat16

2024-10-18 Thread Feng Wang
This patch add auto-vect patterns for vector-bfloat16 extension. Similar to vector extensions, these patterns can use vector BF16 instructions to optimize the automatic vectorization of for loops. gcc/ChangeLog: * config/riscv/autovec-opt.md (*widen_bf16_fma): Add vfwmacc auto-vect

[PATCH] SVE intrinsics: Fold svsra with op1 all zeros to svlsr/svasr.

2024-10-18 Thread Jennifer Schmitz
A common idiom in intrinsics loops is to have accumulator intrinsics in an unrolled loop with an accumulator initialized to zero at the beginning. Propagating the initial zero accumulator into the first iteration of the loop and simplifying the first accumulate instruction is a desirable transforma

[committed] testsuite: arm: Corrected expected error message for cde-mve-error-1.c

2024-10-18 Thread Torbjörn SVENSSON
Pushed below patch as obivous to trunk. -- gcc/testsuite/ChangeLog: * gcc.target/arm/acle/cde-mve-error-1.c: Corrected quotation in expected error message. Signed-off-by: Torbjörn SVENSSON --- .../gcc.target/arm/acle/cde-mve-error-1.c | 56 +-- 1 file chang

Re: [PATCH v2 00/36] arm: [MVE intrinsics] Re-implement more intrinsics

2024-10-18 Thread Christophe Lyon
On Mon, 14 Oct 2024 at 20:30, Richard Earnshaw (lists) wrote: > > On 04/09/2024 14:26, Christophe Lyon wrote: > > Hi, > > > > This is v2 of the patch series I sent in > > https://gcc.gnu.org/pipermail/gcc-patches/2024-July/657065.html. > > > > I have taken into account the feedback I received, and

Re: [PATCH] AArch64: Remove redundant check in aarch64_simd_mov

2024-10-18 Thread Kyrylo Tkachov
> On 17 Oct 2024, at 22:32, Victor Do Nascimento > wrote: > > FWIW, I definitely agree about the spuriousness of the V2DI mode check. > While I can't approve, I can confirm it looks good. Thanks for looking at it Victor. The patch is ok. Kyrill > > Thanks, > Victor. > > On 10/17/24 16:10,

Re: [PATCH v16b 2/4] gcc/: Rename array_type_nelts => array_type_nelts_minus_one

2024-10-18 Thread Alejandro Colomar
Hi Joseph, On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote: > Hi Joseph, > > On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote: > > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > > > The old name was misleading. > > > > > > While at it, also rename some temporary v

RE: [PATCH] SVE intrinsics: Add fold_active_lanes_to method to refactor svmul and svdiv.

2024-10-18 Thread Tamar Christina
> -Original Message- > From: Richard Sandiford > Sent: Thursday, October 17, 2024 6:05 PM > To: Jennifer Schmitz > Cc: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; Tamar > Christina > Subject: Re: [PATCH] SVE intrinsics: Add fold_active_lanes_to method to > refactor > svmul and svdiv. > >

Re: [PATCH] c++: Fix crash during NRV optimization with invalid input [PR117099]

2024-10-18 Thread Sam James
Simon Martin writes: > Hi Sam, Hi Simon, > > On 16 Oct 2024, at 22:06, Sam James wrote: > >> Simon Martin writes: >> >>> We ICE upon the following invalid code because we end up calling >>> finalize_nrv_r with a RETURN_EXPR with no operand. >>> >>> === cut here === >>> struct X { >>> ~X(); >

Re: [PATCH 1/7] libstdc++: Refactor std::uninitialized_{copy, fill, fill_n} algos [PR68350]

2024-10-18 Thread Jonathan Wakely
On 16/10/24 21:39 -0400, Patrick Palka wrote: On Tue, 15 Oct 2024, Jonathan Wakely wrote: +#if __cplusplus < 201103L + + // True if we can unwrap _Iter to get a pointer by using std::__niter_base. + template +struct __unwrappable_niter +{ + template struct __is_ptr { enum { __valu

Re: [PATCH 1/7] libstdc++: Refactor std::uninitialized_{copy, fill, fill_n} algos [PR68350]

2024-10-18 Thread Jonathan Wakely
On 18/10/24 10:41 +0100, Jonathan Wakely wrote: On 16/10/24 21:39 -0400, Patrick Palka wrote: On Tue, 15 Oct 2024, Jonathan Wakely wrote: +#if __cplusplus < 201103L + + // True if we can unwrap _Iter to get a pointer by using std::__niter_base. + template +struct __unwrappable_niter +

RE: [PATCH 1/2] Reduce lane utilization in VEC_PERM_EXPRs for two_operator nodes

2024-10-18 Thread Richard Biener
On Thu, 17 Oct 2024, Tamar Christina wrote: > Hi Christoph, > > > -Original Message- > > From: Christoph Müllner > > Sent: Tuesday, October 15, 2024 3:57 PM > > To: gcc-patches@gcc.gnu.org; Philipp Tomsich ; > > Tamar > > Christina ; Richard Biener > > Cc: Jeff Law ; Robin Dapp ; > > C

Re: [PATCH v2] RISC-V:Auto vect for vector-bfloat16

2024-10-18 Thread 钟居哲
Could you add run test case (verified by QEMU or SPIKE ) ? juzhe.zh...@rivai.ai From: Feng Wang Date: 2024-10-18 15:24 To: gcc-patches CC: kito.cheng; juzhe.zhong; Feng Wang Subject: [PATCH v2] RISC-V:Auto vect for vector-bfloat16 This patch add auto-vect patterns for vector-bfloat16 extension

[PATCH]middle-end: Fix GSI for gcond root [PR117140]

2024-10-18 Thread Tamar Christina
Hi All, When finding the gsi to use for code of the root statements we should use the one of the original statement rather than the gcond which may be inside a pattern. Without this the emitted instructions may be discarded later. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.

Re: [PATCH]middle-end: Fix GSI for gcond root [PR117140]

2024-10-18 Thread Sam James
Tamar Christina writes: > Hi All, > > When finding the gsi to use for code of the root statements we should use the > one of the original statement rather than the gcond which may be inside a > pattern. > > Without this the emitted instructions may be discarded later. > > Bootstrapped Regtested o

Re: [PATCH]middle-end: Fix GSI for gcond root [PR117140]

2024-10-18 Thread Richard Biener
On Fri, 18 Oct 2024, Tamar Christina wrote: > Hi All, > > When finding the gsi to use for code of the root statements we should use the > one of the original statement rather than the gcond which may be inside a > pattern. > > Without this the emitted instructions may be discarded later. > > Bo

RE: [PATCH 2/2] Add a new permute optimization step in SLP

2024-10-18 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Friday, October 18, 2024 11:03 AM > To: Tamar Christina > Cc: Christoph Müllner ; gcc-patches@gcc.gnu.org; > Philipp Tomsich ; Jeff Law ; > Robin Dapp > Subject: RE: [PATCH 2/2] Add a new permute optimization step in SLP > > On Thu, 17

[PATCH] Adjust assert in vect_build_slp_tree_2

2024-10-18 Thread Richard Biener
The assert in SLP discovery when we handle masked operations is confusingly wide - all gather variants should be catched by the earlier STMT_VINFO_GATHER_SCATTER_P. Bootstrap and regtest running on x86_64-unknown-linux-gnu. * tree-vect-slp.cc (vect_build_slp_tree_2): Only expect I

Re: [committed] MAINTAINERS: Add myself as pair fusion and aarch64 ldp/stp maintainer

2024-10-18 Thread Alex Coplan
Of course I forgot to actually attach the patch, now attached :) On 18/10/2024 11:09, Alex Coplan wrote: > Pushed to trunk. > > ChangeLog: > > * MAINTAINERS (CPU Port Maintainers): Add myself as aarch64 ldp/stp > maintainer. > (Various Maintainers): Add myself as pair fusion ma

Re: [PATCH] testsuite: Add necessary dejagnu directives to pr115815_0.c

2024-10-18 Thread Martin Jambor
Hi, On Mon, Oct 14 2024, Martin Jambor wrote: > Hi, > > I have received an email from the Linaro infrastructure that the test > gcc.dg/lto/pr115815_0.c which I added is failing on arm-eabi and I > realized that not only it is missing dg-require-effective-target > global_constructor but actually an

[committed] MAINTAINERS: Add myself as pair fusion and aarch64 ldp/stp maintainer

2024-10-18 Thread Alex Coplan
Pushed to trunk. ChangeLog: * MAINTAINERS (CPU Port Maintainers): Add myself as aarch64 ldp/stp maintainer. (Various Maintainers): Add myself as pair fusion maintainer.

Re: [PATCH v5] Target-independent store forwarding avoidance.

2024-10-18 Thread Konstantinos Eleftheriou
Sent a new version for this in https://gcc.gnu.org/pipermail/gcc-patches/2024-October/665794.html. Thanks, Konstantinos. On Fri, Aug 30, 2024 at 4:32 PM Richard Sandiford wrote: > > Manolis Tsamis writes: > >> > I could have some help with that, because after the new changes a > >> > subreg rel

[PATCH v6] Target-independent store forwarding avoidance.

2024-10-18 Thread Konstantinos Eleftheriou
From: kelefth This pass detects cases of expensive store forwarding and tries to avoid them by reordering the stores and using suitable bit insertion sequences. For example it can transform this: strbw2, [x1, 1] ldr x0, [x1] # Expensive store forwarding to larger load. To

RE: [PATCH 2/2] Add a new permute optimization step in SLP

2024-10-18 Thread Richard Biener
On Fri, 18 Oct 2024, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Friday, October 18, 2024 11:03 AM > > To: Tamar Christina > > Cc: Christoph Müllner ; > > gcc-patches@gcc.gnu.org; > > Philipp Tomsich ; Jeff Law > > ; > > Robin Dapp > > Subject: RE:

<    1   2