Hi,
On Mon, Oct 14 2024, Martin Jambor wrote:
> Hi,
>
> I have received an email from the Linaro infrastructure that the test
> gcc.dg/lto/pr115815_0.c which I added is failing on arm-eabi and I
> realized that not only it is missing dg-require-effective-target
> global_constructor but actually any dejagnu directives at all, which
> means it is unnecessarily running both at -O0 and -O2 and there is an
> unnecesary run test too. All fixed by this patch.
>
> I have not actually verified that the failure goes away on arm-eabi
> but have very high hopes it will. I have verified that the test still
> checks for the bug and also that it passes by running:
>
> make -k check-gcc RUNTESTFLAGS="lto.exp=*pr115815*"
>
> OK for master (and than to be part of the backports which I still need
> to do)?
>
> Thanks,
>
> Martin
>
>
> gcc/testsuite/ChangeLog:
>
> 2024-10-14 Martin Jambor <mjam...@suse.cz>
>
> * gcc.dg/lto/pr115815_0.c: Add dejagu directives.
I have convinced myself the patch was obvious after all, and committed
it as such as r15-4464-g1a458bdeb223ff so that I could proceed with the
backport.
Martin
> ---
> gcc/testsuite/gcc.dg/lto/pr115815_0.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.dg/lto/pr115815_0.c
> b/gcc/testsuite/gcc.dg/lto/pr115815_0.c
> index d938ae4c802..ade91def55b 100644
> --- a/gcc/testsuite/gcc.dg/lto/pr115815_0.c
> +++ b/gcc/testsuite/gcc.dg/lto/pr115815_0.c
> @@ -1,3 +1,7 @@
> +/* { dg-lto-options {{-O2 -flto}} } */
> +/* { dg-lto-do link } */
> +/* { dg-require-effective-target global_constructor } */
> +
> int a;
> volatile int v;
> volatile int w;
> --
> 2.46.1
