Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Bill Schmidt via Gcc-patches
On 11/18/21 3:16 PM, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: >>> I don't like that at all. The user didn't write the _vsx thing, and it >>> isn't documented either (neither is the _vec one, but that is a separate >>> issue, specific to th

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Segher Boessenkool
On Thu, Nov 18, 2021 at 03:30:48PM -0600, Bill Schmidt wrote: > > On 11/18/21 3:16 PM, Segher Boessenkool wrote: > > Hi! > > > > On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: > >>> I don't like that at all. The user didn't write the _vsx thing, and it > >>> isn't documented either

[PATCH v2] Do not abort compilation when dump file is /dev/*

2021-11-18 Thread Giuliano Belinassi via Gcc-patches
The `configure` scripts generated with autoconf often tests compiler features by setting output to `/dev/null`, which then sets the dump folder as being /dev/* and the compilation halts with an error because GCC cannot create files in /dev/. This is a problem when configure is testing for compiler

[r12-5378 Regression] FAIL: gcc.target/i386/avx512fp16-vector-complex-float.c scan-assembler-times vfmaddcph[ \\t] 1 on Linux/x86_64

2021-11-18 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 4f0a2f5a3ddb1024b885c066a18caae4d733bb6c is the first bad commit commit 4f0a2f5a3ddb1024b885c066a18caae4d733bb6c Author: Tamar Christina Date: Thu Nov 18 17:10:36 2021 + middle-end: check that both sides of complex expression is a mul. caused FAIL: gcc.target/i386/av

Re: [PATCH 3/4] Darwin : Allow for configuring Darwin to use embedded runpath.

2021-11-18 Thread Joseph Myers
On Wed, 17 Nov 2021, Iain Sandoe via Gcc-patches wrote: > If we are going to try and reconcile GCC’s local libtool for more > generic Darwin use, then I fear that is going to take quite significant > work over a period of time (since it will need much more wide testing > than GCC). The goal is

Re: [Patch] libcpp: Fix _Pragma in #__VA_ARGS__ [PR103165]

2021-11-18 Thread Joseph Myers
On Thu, 18 Nov 2021, Jakub Jelinek via Gcc-patches wrote: > Are we handling the pragma at a wrong phase of preprocessing? I think that converting it to a single preprocessing token (rather than four separate preprocessing tokens), at a stage when stringizing might still occur, does indicate it'

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Bill Schmidt via Gcc-patches
Hi! On 11/18/21 3:32 PM, Segher Boessenkool wrote: > On Thu, Nov 18, 2021 at 03:30:48PM -0600, Bill Schmidt wrote: >> On 11/18/21 3:16 PM, Segher Boessenkool wrote: >>> Hi! >>> >>> On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: > I don't like that at all. The user didn't write

[PATCH][_GLIBCXX_DEBUG] Limit performance impact in __erase_nodes_if

2021-11-18 Thread François Dumont via Gcc-patches
Hi     Here is a proposal to limit performance impact of _GLIBCXX_DEBUG mode on __erase_nodes_if.     As you can see I am adding erase overloads on the Debug container to accept base iterators. So it exposes an additional non-Standard method, do you think it is any issue.     Note that I'v

Re: [PATCH v2] c++: Implement -Wuninitialized for mem-initializers (redux) [PR19808]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/8/21 18:41, Marek Polacek wrote: On Sun, Nov 07, 2021 at 12:45:24AM -0400, Jason Merrill wrote: On 11/5/21 19:22, Marek Polacek wrote: 2021 update: Last year I posted a version of this patch: but it didn't make it in.

Re: [PATCH] coroutines: Handle initial awaiters with non-void returns [PR 100127].

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/5/21 11:46, Iain Sandoe wrote: The way in which a C++20 coroutine is specified discards any value that might be returned from the initial or final await expressions. This PR ICE was caused by an initial await expression with an await_resume () returning a reference, the function rewrite co

Re: [PATCH] c++: implicit dummy object in requires clause [PR103198]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/18/21 14:49, Patrick Palka wrote: On Thu, 18 Nov 2021, Jason Merrill wrote: On 11/17/21 14:52, Patrick Palka wrote: On Wed, 17 Nov 2021, Jason Merrill wrote: On 11/11/21 20:25, Patrick Palka wrote: In the testcase below satisfaction misbehaves for f and g ultimately because find_templ

Re: [PATCH] c++: nested lambda capturing a capture proxy [PR94376]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/2/21 14:06, Patrick Palka wrote: Here when determining the type of the FIELD_DECL for the by-value capture of 'i' in the inner lambda, we incorrectly give it the type const int instead of int since the effective initializer is the proxy for the outer capture, and this proxy is const qualifi

Re: [PATCH] c++, v2: Fix up -fstrong-eval-order handling of call arguments [PR70796]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/5/21 06:07, Jakub Jelinek wrote: On Thu, Nov 04, 2021 at 03:07:57PM +0100, Jakub Jelinek via Gcc-patches wrote: For the METHOD_TYPE first argument I use a temporary always though, that should be always is_gimple_reg_type... Doing so regressed +FAIL: g++.dg/cpp1z/inh-ctor23.C -std=gnu++1

Re: [PATCH] c++: Implement C++23 P0849R8 - auto(x) [PR103049]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/4/21 16:26, Marek Polacek wrote: This patch implements P0849R8 which allows auto in a functional cast, the result of which is a prvalue. [expr.type.conv]/1 says that the type is determined by placeholder type deduction. We only accept 'auto', not 'decltype(auto)' -- that the type shall be

Re: [PATCH] c++: nested lambda capturing a capture proxy [PR94376]

2021-11-18 Thread Patrick Palka via Gcc-patches
On Thu, 18 Nov 2021, Jason Merrill wrote: > On 11/2/21 14:06, Patrick Palka wrote: > > Here when determining the type of the FIELD_DECL for the by-value > > capture of 'i' in the inner lambda, we incorrectly give it the > > type const int instead of int since the effective initializer is > > the p

Re: [PATCH] c++: Implement C++23 P0849R8 - auto(x) [PR103049]

2021-11-18 Thread Marek Polacek via Gcc-patches
On Thu, Nov 18, 2021 at 05:36:45PM -0500, Jason Merrill wrote: > On 11/4/21 16:26, Marek Polacek wrote: > > This patch implements P0849R8 which allows auto in a functional cast, > > the result of which is a prvalue. > > > > [expr.type.conv]/1 says that the type is determined by placeholder type >

Re: [PATCH 2/6] Add returns_zero_on_success/failure attributes

2021-11-18 Thread David Malcolm via Gcc-patches
On Wed, 2021-11-17 at 14:53 +0530, Prathamesh Kulkarni wrote: > On Tue, 16 Nov 2021 at 03:42, David Malcolm > wrote: > > > > On Mon, 2021-11-15 at 12:33 +0530, Prathamesh Kulkarni wrote: > > > On Sun, 14 Nov 2021 at 02:07, David Malcolm via Gcc-patches > > > wrote: > > > > > > > > This patch ad

Re: [PATCH 2/6] Add returns_zero_on_success/failure attributes

2021-11-18 Thread David Malcolm via Gcc-patches
On Wed, 2021-11-17 at 22:43 +, Joseph Myers wrote: > On Wed, 17 Nov 2021, Prathamesh Kulkarni via Gcc-patches wrote: > > > More generally, would it be a good idea to provide attributes for > > mod/ref anaylsis ? > > So sth like: > > void foo(void) __attribute__((modifies(errno))); > > which wo

Re: [PATCH] coroutines: Handle initial awaiters with non-void returns [PR 100127].

2021-11-18 Thread Iain Sandoe
> On 18 Nov 2021, at 22:13, Jason Merrill via Gcc-patches > wrote: > > On 11/5/21 11:46, Iain Sandoe wrote: >> The way in which a C++20 coroutine is specified discards any value >> that might be returned from the initial or final await expressions. >> This PR ICE was caused by an initial awai

Re: [PATCH 2/6] Add returns_zero_on_success/failure attributes

2021-11-18 Thread David Malcolm via Gcc-patches
On Thu, 2021-11-18 at 14:08 -0600, Segher Boessenkool wrote: > On Wed, Nov 17, 2021 at 10:43:58PM +, Joseph Myers wrote: > > On Wed, 17 Nov 2021, Prathamesh Kulkarni via Gcc-patches wrote: > > > More generally, would it be a good idea to provide attributes for > > > mod/ref anaylsis ? > > > So

[committed] d: Use HOST_WIDE_INT for type size temporaries.

2021-11-18 Thread Iain Buclaw via Gcc-patches
Hi, This patch fixes an issue with bootstrap on x86_64-darwin when building with --enable-werror. These couple variables are later used as the value for the format specifier `%wd`, to which the expected type may not match dinteger_t, causing unnecessary -Wformat warnings. Bootstrapped and regres

Re: [PATCH v2] c++: Implement -Wuninitialized for mem-initializers (redux) [PR19808]

2021-11-18 Thread Marek Polacek via Gcc-patches
On Thu, Nov 18, 2021 at 05:10:47PM -0500, Jason Merrill wrote: > On 11/8/21 18:41, Marek Polacek wrote: > > @@ -1311,13 +1462,25 @@ emit_mem_initializers (tree mem_inits) > > if (!COMPLETE_TYPE_P (current_class_type)) > > return; > > + /* Keep a set holding fields that are not initialize

[PATCH] Don't allow mask/sse/mmx mov in TLS code sequences.

2021-11-18 Thread liuhongt via Gcc-patches
>Why is the above declared as a special memory constraint? Also the Change to define_memory_constraint since it's ok for reload can make them match by converting the operand to the form ‘(mem (reg X))’.where X is a base register (from the register class specified by BASE_REG_CLASS >predicate comme

[PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html

2021-11-18 Thread Eric Gallager via Gcc-patches
So, on the wiki page for EasyHacks , it says: "There is also a non-wiki list of beginner projects at http://gcc.gnu.org/projects/beginner.html, however, it is very outdated and the projects are not that easy." Since I don't have an account on the wiki (since crea

[PATCH] Fix PR 103317, ICE after PHI-OPT, minmax_replacement producing invalid SSA

2021-11-18 Thread apinski--- via Gcc-patches
From: Andrew Pinski The problem is r12-5300-gf98f373dd822b35c allows phiopt to recognize more basic blocks but missed one location where the basic block does not need to be empty but still needs to have a single predecessor. This patch fixes that over sight. OK? Bootstrapped and tested on x86_

[PATCH v2] [AARCH64] Fix PR target/103100 -mstrict-align and memset on not aligned buffers

2021-11-18 Thread apinski--- via Gcc-patches
From: Andrew Pinski The problem here is that aarch64_expand_setmem does not change the alignment for strict alignment case. This is a simplified patch from what I had previously. So constraining copy_limit to the alignment of the mem in the case of strict align fixes the issue without checking

Re: [PATCH v2] c++: Implement -Wuninitialized for mem-initializers (redux) [PR19808]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/18/21 19:24, Marek Polacek wrote: On Thu, Nov 18, 2021 at 05:10:47PM -0500, Jason Merrill wrote: On 11/8/21 18:41, Marek Polacek wrote: @@ -1311,13 +1462,25 @@ emit_mem_initializers (tree mem_inits) if (!COMPLETE_TYPE_P (current_class_type)) return; + /* Keep a set holding fi

Re: [PATCH] c++: nested lambda capturing a capture proxy [PR94376]

2021-11-18 Thread Jason Merrill via Gcc-patches
On 11/18/21 17:48, Patrick Palka wrote: On Thu, 18 Nov 2021, Jason Merrill wrote: On 11/2/21 14:06, Patrick Palka wrote: Here when determining the type of the FIELD_DECL for the by-value capture of 'i' in the inner lambda, we incorrectly give it the type const int instead of int since the effe

Re: [PING^3 PATCH v4 2/3] rs6000: Support SSE4.1 "round" intrinsics

2021-11-18 Thread Paul A. Clarke via Gcc-patches
On Mon, Nov 08, 2021 at 11:40:42AM -0600, Paul A. Clarke via Gcc-patches wrote: > On Tue, Oct 26, 2021 at 03:00:11PM -0500, Paul A. Clarke via Gcc-patches > wrote: > > Patches 1/3 and 3/3 have been committed. > > This is only a ping for 2/3. > > Gentle re-ping. Gentle re-re-ping. > > On Mon, Oc

Re: [PING^2 PATCH] rs6000: Add Power10 optimization for _mm_blendv*

2021-11-18 Thread Paul A. Clarke via Gcc-patches
On Mon, Nov 08, 2021 at 11:42:27AM -0600, Paul A. Clarke via Gcc-patches wrote: > Gentle ping... Gentile re-ping. > On Wed, Oct 20, 2021 at 08:42:07PM -0500, Paul A. Clarke via Gcc-patches > wrote: > > Power10 ISA added `xxblendv*` instructions which are realized in the > > `vec_blendv` instrins

Re: [PING^2 PATCH] rs6000: Add Power10 optimization for most _mm_movemask*

2021-11-18 Thread Paul A. Clarke via Gcc-patches
On Mon, Nov 08, 2021 at 11:42:56AM -0600, Paul A. Clarke via Gcc-patches wrote: > Gentle ping... Gentle re-ping. > On Thu, Oct 21, 2021 at 12:22:12PM -0500, Paul A. Clarke via Gcc-patches > wrote: > > Power10 ISA added `vextract*` instructions which are realized in the > > `vec_extractm` instrin

Re: [PING^2 PATCH] rs6000: Add optimizations for _mm_sad_epu8

2021-11-18 Thread Paul A. Clarke via Gcc-patches
On Mon, Nov 08, 2021 at 11:43:26AM -0600, Paul A. Clarke via Gcc-patches wrote: > Gentle ping... Gentle re-ping. > On Fri, Oct 22, 2021 at 12:28:49PM -0500, Paul A. Clarke via Gcc-patches > wrote: > > Power9 ISA added `vabsdub` instruction which is realized in the > > `vec_absd` instrinsic. > >

Re: [PATCH] regrename: Skip renaming if instruction is noop move.

2021-11-18 Thread Jojo R via Gcc-patches
— Jojo 在 2021年11月19日 +0800 AM12:13,Jeff Law ,写道: > > > On 11/16/2021 7:20 PM, Jojo R via Gcc-patches wrote: > > — Jojo > > 在 2021年11月16日 +0800 PM8:12,Richard Biener ,写道: > > > On Tue, Nov 16, 2021 at 12:45 PM Jojo R via Gcc-patches > > > wrote: > > > > Skip renaming if instruction is noop move,

[PATCH] Fix tree-optimization/103314 : Limit folding of (type) X op CST where type is a nop convert to gimple

2021-11-18 Thread apinski--- via Gcc-patches
From: Andrew Pinski There is some re-association code in fold_binary which conflicts with this optimization due keeping around some "constants" which are not INTEGER_CST (1 << -1) so we end up in an infinite loop because of that. So we need to limit this case to GIMPLE level only. OK? Bootstrapp

Re: [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html

2021-11-18 Thread Gerald Pfeifer
On Thu, 18 Nov 2021, Eric Gallager wrote: > I'd find it easier to just edit the page linked to in wwwdocs instead, > so I'm going to start seeing what I can do to update it. I figured I'd > start by removing the references to Java in it, since Java has been > removed. A patch to do that is attac

Re: [PATCH] Fix PR 103317, ICE after PHI-OPT, minmax_replacement producing invalid SSA

2021-11-18 Thread Richard Biener via Gcc-patches
On Fri, Nov 19, 2021 at 2:54 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > The problem is r12-5300-gf98f373dd822b35c allows phiopt to recognize more > basic blocks > but missed one location where the basic block does not need to be empty but > still > needs to have a single p

Re: [PATCH] Don't allow mask/sse/mmx mov in TLS code sequences.

2021-11-18 Thread Uros Bizjak via Gcc-patches
On Fri, Nov 19, 2021 at 2:14 AM liuhongt wrote: > > >Why is the above declared as a special memory constraint? Also the > Change to define_memory_constraint since it's ok for > reload can make them match by converting the operand to the form > ‘(mem (reg X))’.where X is a base register (from the r

Re: [PATCH] Don't allow mask/sse/mmx mov in TLS code sequences.

2021-11-18 Thread Uros Bizjak via Gcc-patches
On Fri, Nov 19, 2021 at 8:50 AM Uros Bizjak wrote: > > On Fri, Nov 19, 2021 at 2:14 AM liuhongt wrote: > > > > >Why is the above declared as a special memory constraint? Also the > > Change to define_memory_constraint since it's ok for > > reload can make them match by converting the operand to t

[PATCH] c++/103326 - fix ICE in tsubst with VECTOR_CST

2021-11-18 Thread Richard Biener via Gcc-patches
This adds missing handling of VECTOR_CST. Bootstrap and regtest pending on x86_64-unknown-linux-gnu, OK? Thanks, Richard. 2021-11-19 Richard Biener PR c++/103326 * pt.c (tsubst_copy): Handle VECTOR_CST. * g++.dg/pr103326.C: New testcase. --- gcc/cp/pt.c

<    1   2