Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Richard Biener
On Fri, 21 May 2021, Martin Jambor wrote: > Hi, > > On Mon, May 17 2021, Eric Botcazou wrote: > >> sorry for breaking Ada over the weekend, however... > > > > No problem. > > > >> None of the non-ACATS tests fail for me without doing a bootstrap, but I > >> did manage to reproduce this one (by th

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/24/21 9:13 PM, Martin Sebor wrote: On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: +  /* Range query mechanism for functions.  The default is to pick up + global ranges.  If a pass wants on-demand ranges OTOH, it must + call enable/disable_ranger().  */ +  range_query

[patch, committed] fortran/intrinsic.texi: Fix copy'n'paste errors and typos (was: https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gfortran/)

2021-05-25 Thread Tobias Burnus
Hi Johannes, hi all, On 24.05.21 23:21, Johannes Nendwich wrote: some more suggestions for corrections in the onlinedocs: thanks for the proof reading. I have converted it into a patch and committed it as attached. Tobias - Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 2

[PATCH] DOC: update documentation of __gcov_{dump,reset}

2021-05-25 Thread Martin Liška
Hi. Based on the PR, I suggest improvement of the documentation for GCOV-related functions. I'll install the patch if there are no objections. Martin gcc/ChangeLog: PR gcov-profile/100751 * doc/gcov.texi: Document that __gcov_dump can be called just once and that __gco

[PATCH] middle-end/100727 - fix call expansion with WITH_SIZE_EXPR arg

2021-05-25 Thread Richard Biener
call expansion used the result of get_base_address to switch between ABIs - with get_base_address now never returning NULL we have to re-instantiate the check in a more explicit way. This also adjusts mark_addressable to skip WITH_SIZE_EXPRs, consistent with how build_fold_addr_expr handles it. B

Re: [PATCH][DOCS] Remove install-old.texi

2021-05-25 Thread Martin Liška
On 5/24/21 10:09 PM, Joseph Myers wrote: On Fri, 21 May 2021, Martin Liška wrote: CPUs: aarch64, alpha, alpha64, amdgcn, arc, arceb, arm, avr, bfin, bpf, cr16, cris, csky, epiphany, fido, fr30, frv, ft32, h8300, hppa, hppa2.0, hppa64, i486, i686, ia64, iq2000, lm32, m32c, m32r, m32rle, m68k, mc

[PATCH] c++tools: Include for exit [PR100731]

2021-05-25 Thread Jakub Jelinek via Gcc-patches
Hi! This TU uses exit, but doesn't include or and relies on some other header to include it indirectly, which apparently doesn't happen on reporter's host. The other headers aren't guarded either and we rely on a compiler capable of C++11, so maybe we can rely on being around unconditionally.

[PATCH] Update copyright years in c++tools

2021-05-25 Thread Jakub Jelinek via Gcc-patches
Hi! While looking at PR100731, I have noticed the copyright years are 2020-ish only. This patch adds it to update-copyright.py and updates those. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2021-05-25 Jakub Jelinek contrib/ * update-copyright.py: Add c++tool

[PATCH] Fix sphinx-build warning.

2021-05-25 Thread Martin Liška
RemovedInSphinx40Warning: app.add_lexer() API changed; Please give lexer class instead of instance Ready for master? Thanks, Martin gcc/ada/ChangeLog: * doc/share/conf.py: Fix Sphinx 4.0.x error. --- gcc/ada/doc/share/conf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH][vect] Use main loop's thresholds and vectorization factor to narrow upper_bound of epilogue

2021-05-25 Thread Kewen.Lin via Gcc-patches
on 2021/5/24 下午3:21, Kewen.Lin via Gcc-patches wrote: > Hi Andre, > > on 2021/5/24 下午2:17, Andre Vieira (lists) via Gcc-patches wrote: >> Hi, >> >> When vectorizing with --param vect-partial-vector-usage=1 the vectorizer >> uses an unpredicated (all-true predicate for SVE) main loop and a predica

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Richard Biener via Gcc-patches
On Fri, May 21, 2021 at 2:34 PM Aldy Hernandez via Gcc-patches wrote: > > This patch converts the Walloca pass to use an on-demand ranger > accesible with RANGE_QUERY instead of having to create a ranger and pass > it around. > > Tested on x86-64 Linux. > > OK? > > gcc/ChangeLog: > > * gim

[PATCH] c++: Avoid -Wunused-value false positives on nullptr passed to ellipsis [PR100666]

2021-05-25 Thread Jakub Jelinek via Gcc-patches
Hi! When passing expressions with decltype(nullptr) type with side-effects to ellipsis, we pass (void *)0 instead, but for the side-effects evaluate them on the lhs of a COMPOUND_EXPR. Unfortunately that means we warn about it if the expression is a call to nodiscard marked function, even when th

Re: [PATCH 4/5] Convert remaining passes to RANGE_QUERY.

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 10:02 PM Martin Sebor via Gcc-patches wrote: > > On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: > > This patch converts the remaining users of get_range_info and > > get_ptr_nonnull to the range_query API. > > > > No effort was made to move passes away from VR_AN

Re: [PATCH 4/5] Convert remaining passes to RANGE_QUERY.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/24/21 9:34 PM, Martin Sebor wrote: On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: This patch converts the remaining users of get_range_info and get_ptr_nonnull to the range_query API. No effort was made to move passes away from VR_ANTI_RANGE, or any other use of deprecated me

Re: [PATCH] Fix sphinx-build warning.

2021-05-25 Thread Arnaud Charlet
> RemovedInSphinx40Warning: app.add_lexer() API changed; Please give lexer > class instead of instance > > Ready for master? Yes, thanks (incidentally we just made the same change in our internal tree today). > Thanks, > Martin > > gcc/ada/ChangeLog: > > * doc/share/conf.py: Fix Sphinx

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: > > > > On 5/21/21 1:39 PM, Aldy Hernandez wrote: > > This patch provides a generic API for accessing global ranges. It is > > meant to replace get_range_info() and get_ptr_nonnull() with one > > common interface. It uses the

Re: [PATCH] C-SKY: Cases for csky fpuv3 instructions.

2021-05-25 Thread Cooper Qu via Gcc-patches
Merged. And one thing to note is that the file path should be written in relative way. For example, gcc/testsuite/gcc.target/csky/fpuv3/fpuv3.exp should be  written as gcc.target/csky/fpuv3/fpuv3.exp. On 4/30/21 9:01 PM, Geng Qi wrote: gcc/testsuite/ChangeLog: * gcc/testsuite/gcc.targ

Re: [PATCH 2/11] use xxx_no_warning APIs in Ada

2021-05-25 Thread Eric Botcazou
> [PATCH 2/11] use xxx_no_warning APIs in Ada. Looks good to me, but remove the useless pair of parentheses in the 3rd hunk. -- Eric Botcazou

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Eric Botcazou
> The problem with this patch is that it causes: > > FAIL: gnat.dg/opt94.adb scan-tree-dump-times optimized "worker" 1 > > which is exactly the testcase from the commit which caused the bug I am > trying to address. Sorry about that, a thinko in the original change, I'm testing this fixlet.

Re: [PATCH 0/11] warning control by group and location (PR 74765)

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 2:53 AM Martin Sebor via Gcc-patches wrote: > > On 5/24/21 5:08 PM, David Malcolm wrote: > > On Mon, 2021-05-24 at 16:02 -0600, Martin Sebor wrote: > >>The rare expressions that have no location > >> continue to have just one bit[1]. > > > > Where does this get stored?

Re: [PATCH] Update copyright years in c++tools

2021-05-25 Thread Richard Biener
On Tue, 25 May 2021, Jakub Jelinek wrote: > Hi! > > While looking at PR100731, I have noticed the copyright years are 2020-ish > only. This patch adds it to update-copyright.py and updates those. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. > 2021-05-25 Jakub

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Richard Biener
On Tue, 25 May 2021, Eric Botcazou wrote: > > The problem with this patch is that it causes: > > > > FAIL: gnat.dg/opt94.adb scan-tree-dump-times optimized "worker" 1 > > > > which is exactly the testcase from the commit which caused the bug I am > > trying to address. > > Sorry about that, a

[committed] openmp: Fix reduction clause handling on teams distribute simd [PR99928]

2021-05-25 Thread Jakub Jelinek via Gcc-patches
Hi! When a directive isn't combined with worksharing-loop, it takes much simpler clause splitting path for reduction, and that one was missing handling of teams when combined with simd. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2021-05-25 Jakub Jel

Re: [PATCH] c++tools: Include for exit [PR100731]

2021-05-25 Thread Jonathan Wakely via Gcc-patches
On 25/05/21 10:37 +0200, Jakub Jelinek wrote: Hi! This TU uses exit, but doesn't include or and relies on some other header to include it indirectly, which apparently doesn't happen on reporter's host. The other headers aren't guarded either and we rely on a compiler capable of C++11, so may

Re: [PATCH 4/5] Convert remaining passes to RANGE_QUERY.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/25/21 10:47 AM, Richard Biener wrote: On Mon, May 24, 2021 at 10:02 PM Martin Sebor via Gcc-patches wrote: On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: This patch converts the remaining users of get_range_info and get_ptr_nonnull to the range_query API. No effort was mad

RE: [backport gcc10, gcc9] Requet to backport PR97969

2021-05-25 Thread Przemyslaw Wirkus via Gcc-patches
> -Original Message- > From: Richard Biener > Sent: 02 February 2021 10:08 > To: Przemyslaw Wirkus > Cc: Vladimir Makarov ; gcc-patches@gcc.gnu.org; > ja...@redhat.com; ni...@redhat.com; Richard Earnshaw > ; Ramana Radhakrishnan > ; Kyrylo Tkachov > > Subject: RE: [backport gcc10, gcc9]

Re: [PATCH] c++tools: Include for exit [PR100731]

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 11:15 AM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > This TU uses exit, but doesn't include or and relies > on some other header to include it indirectly, which apparently doesn't > happen on reporter's host. > > The other headers aren't guarded either and we rely o

[PATCH] C-SKY: Amend copyrights of recently added files.

2021-05-25 Thread Xianmiao Qu
From: Cooper Qu This patch has been pushed. gcc/ChangeLog: * config/csky/csky-modes.def : Amend copyright. * config/csky/csky_insn_fpuv2.md : Likewise. * config/csky/csky_insn_fpuv3.md : Likewise. gcc/testsuite/ChangeLog: * gcc.target/csky/fpuv3/fpuv3.exp : Amend

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/25/21 10:57 AM, Richard Biener wrote: On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: On 5/21/21 1:39 PM, Aldy Hernandez wrote: This patch provides a generic API for accessing global ranges. It is meant to replace get_range_info() and get_ptr_nonnull() with on

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: > > > > On 5/25/21 10:57 AM, Richard Biener wrote: > > On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches > > wrote: > >> > >> > >> > >> On 5/21/21 1:39 PM, Aldy Hernandez wrote: > >>> This patch provides a generic API for accessi

Re: [PATCH] Add no_sanitize_coverage attribute.

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 10:27 AM Martin Liška wrote: > > On 5/21/21 2:39 PM, Marco Elver wrote: > > On Fri, May 21, 2021 at 10:50AM +0200, Martin Liška wrote: > >> On 5/20/21 12:55 PM, Marco Elver wrote: > >>> I think this came up with other no_sanitize [1] based on what I had > >>> written to you

Re: [_GLIBCXX_DEBUG] Enhance rendering of assert message

2021-05-25 Thread Jonathan Wakely via Gcc-patches
On 22/05/21 22:08 +0200, François Dumont via Libstdc++ wrote: Here is the part of the libbacktrace patch with the enhancement to the rendering of assert message. It only contains one real fix, the rendering of address. In 2 places it was done with "0x%p", so resulting in something like: 0x0x01

Re: RFA: save/restore target options in handle_optimize_attribute

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 10:56 AM Martin Liška wrote: > > On 5/20/21 9:55 AM, Richard Biener wrote: > > On Thu, May 20, 2021 at 12:29 AM Joern Wolfgang Rennecke > > wrote: > >> > >> We set default for some target options in TARGET_OPTION_OPTIMIZATION_TABLE, > >> but these can be overridden by spec

[c++tools] Fix typo and weird syntax in configure script

2021-05-25 Thread Eric Botcazou
Tested on x86-64/Linux, applied on mainline and 11 branch as obvious. 2021-05-25 Eric Botcazou c++tools/ * configure.ac (--enable-maintainer-mode): Fix typo and weird syntax. * configure: Regenerate. -- Eric Botcazoudiff --git a/c++tools/configure.ac b/c++tools/configure.ac

Re: [PATCH] Extend is_cond_scalar_reduction to handle nop_expr after/before scalar reduction.[PR98365]

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 11:52 AM Hongtao Liu wrote: > > Hi: > Details described in PR. > Bootstrapped and regtest on > x86_64-linux-gnu{-m32,}/x86_64-linux-gnu{-m32\ > -march=cascadelake,-march=cascadelake} > Ok for trunk? +static tree +strip_nop_cond_scalar_reduction (bool has_nop, tree op

Re: [PATCH 1/2] c-family: Copy DECL_USER_ALIGN even if DECL_ALIGN is similar.

2021-05-25 Thread Robin Dapp via Gcc-patches
Hi Martin and Jason, The removal of the dead code looks good to me.  The change to "re-init lastalign" doesn't seem right.  When it's zero it means the conflict is between two attributes on the same declaration, in which case the note shouldn't be printed (it would just point to the same locatio

[PATCH] C-SKY: Add insn "ldbs".

2021-05-25 Thread Geng Qi via Gcc-patches
gcc/ * config/csky/csky.md (cskyv2_sextend_ldbs): New insn. gcc/testsuite/ * gcc/testsuite/gcc.target/csky/ldbs.c: New. --- gcc/config/csky/csky.md | 10 ++ gcc/testsuite/gcc.target/csky/ldbs.c | 11 +++ 2 files changed, 21 insertions(+) create mode 1

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/25/21 11:46 AM, Richard Biener wrote: On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: On 5/25/21 10:57 AM, Richard Biener wrote: On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: On 5/21/21 1:39 PM, Aldy Hernandez wrote: This patch provides a generic AP

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 12:53 PM Aldy Hernandez wrote: > > On 5/25/21 11:46 AM, Richard Biener wrote: > > On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: > >> > >> > >> > >> On 5/25/21 10:57 AM, Richard Biener wrote: > >>> On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches > >>

Re: [wwwdocs, patch] htdocs/gitwrite.html: Clarify ChangeLog generation

2021-05-25 Thread Tobias Burnus
On 24.05.21 09:45, Gerald Pfeifer wrote: On Sun, 23 May 2021, Tobias Burnus wrote: As there was some confusion regarding when the ChangeLog is generated, I propose the attached wwwdocs patch. Comments? -Apply the patch to your local tree. ChangeLog entries will be -automatically added to the c

Re: [PATCH 4/5] Convert remaining passes to RANGE_QUERY.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Same as before, but with the minor change that the following IPA pass uses the correct struct function, as discussed. Tests on x86-64 Linux on-going. Aldy diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index a0238710e72..d8292777647 100644 --- a/gcc/tree-ssa-structalias.c

[PATCH] C-SKY: Fix copyright of csky-modes.def.

2021-05-25 Thread Xianmiao Qu
From: Cooper Qu Tested and pushed. The incorrect copyright comment format causes build error: builddir/source//gcc/gcc/config/csky/csky-modes.def: In function ‘void create_modes()’: builddir/source//gcc/gcc/config/csky/csky-modes.def:1:4: error: ‘C’ was not declared in this scope ;; C-SKY ext

Re: [PATCH] Fix selftest for targets where short and int are the same size.

2021-05-25 Thread Jeff Law via Gcc-patches
On 5/25/2021 12:44 AM, Aldy Hernandez wrote: avr-elf seems to use HImode for both integer_type_node and signed_char_type_node, which is causing the check for different sized VARYING ranges to fail. I've fixed this by using a char which I think should always be smaller than an int. Is there a

Re: [PATCH] middle-end/100727 - fix call expansion with WITH_SIZE_EXPR arg

2021-05-25 Thread Jeff Law via Gcc-patches
On 5/25/2021 2:27 AM, Richard Biener wrote: call expansion used the result of get_base_address to switch between ABIs - with get_base_address now never returning NULL we have to re-instantiate the check in a more explicit way. This also adjusts mark_addressable to skip WITH_SIZE_EXPRs, consis

[committed] RISC-V: Pass -mno-relax to assembler

2021-05-25 Thread Kito Cheng
gcc/ChangeLog: * config/riscv/riscv.h (ASM_SPEC): Pass -mno-relax. --- gcc/config/riscv/riscv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/config/riscv/riscv.h b/gcc/config/riscv/riscv.h index f3e85723c85..f47d5b40a66 100644 --- a/gcc/config/riscv/riscv.h +++ b/gcc/config/risc

Re: [PATCH] c++/88601 - [C/C++] __builtin_shufflevector support

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 2:57 AM, Richard Biener wrote: On Fri, 21 May 2021, Jason Merrill wrote: On 5/21/21 8:33 AM, Richard Biener wrote: This adds support for the clang __builtin_shufflevector extension to the C and C++ frontends. The builtin is lowered to VEC_PERM_EXPR. Because VEC_PERM_EXPR does not s

[PATCH, OpenMP 5.0] Remove array section base-pointer mapping semantics, and other front-end adjustments (mainline trunk)

2021-05-25 Thread Chung-Lin Tang
Hi Jakub, this is a version of this patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570075.html for mainline trunk. This patch largely implements three pieces of functionality: (1) Per discussion and clarification on the omp-lang mailing list, standards conforming behavior for mapping

Re: [PATCH] c++: Avoid -Wunused-value false positives on nullptr passed to ellipsis [PR100666]

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 4:44 AM, Jakub Jelinek wrote: When passing expressions with decltype(nullptr) type with side-effects to ellipsis, we pass (void *)0 instead, but for the side-effects evaluate them on the lhs of a COMPOUND_EXPR. Unfortunately that means we warn about it if the expression is a call to n

Re: [PATCH] Use match-and-simplify in phi-opt

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 4:09 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > To simplify PHI-OPT and future improvements to it in most > (but not all) cases, using match-and-simplify simplifies how > much code is needed to be added. > > This depends on the following two patches:

Re: [PATCH 8/11] use xxx_no_warning APIs in Objective-C

2021-05-25 Thread Iain Sandoe via Gcc-patches
Hi Martin Martin Sebor via Gcc-patches wrote: The attached patch replaces the uses of TREE_NO_WARNING in the Objective-C front end. I’ve been gradually trying to improve/add locations in the ObjC stuff. To that end, I wonder if it might be worth considering always supplying the intended ma

Re: [PATCH] c++tools: Include for exit [PR100731]

2021-05-25 Thread Jakub Jelinek via Gcc-patches
On Tue, May 25, 2021 at 11:18:55AM +0200, Richard Biener via Gcc-patches wrote: > On Tue, May 25, 2021 at 11:15 AM Jakub Jelinek via Gcc-patches > wrote: > > > > Hi! > > > > This TU uses exit, but doesn't include or and relies > > on some other header to include it indirectly, which apparently d

Re: [PATCHv2] Optimize x < 0 ? ~y : y to (x >> 31) ^ y in match.pd

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 3:27 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > This copies the optimization that is done in phiopt for > "x < 0 ? ~y : y to (x >> 31) ^ y" into match.pd. The code > for phiopt is kept around until phiopt uses match.pd (which > I am working towards).

Re: [PATCHv2] Add a couple of A?CST1:CST2 match and simplify optimizations

2021-05-25 Thread Richard Biener via Gcc-patches
On Sun, May 23, 2021 at 12:03 PM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > Instead of some of the more manual optimizations inside phi-opt, > it would be good idea to do a lot of the heavy lifting inside match > and simplify instead. In the process, this moves the three simple

Re: [RFC PATCH] i386: Enable auto-vectorization for 32bit modes (+ testcases)

2021-05-25 Thread Richard Biener via Gcc-patches
On Fri, May 21, 2021 at 5:00 PM Uros Bizjak via Gcc-patches wrote: > > Here it is, the patch that enables auto-vectorization for 32bit modes. > > Sent as RFC, because the patch fails some vectorizer scans, as it > obviously enables more vectorization to happen: > > Running target unix > FAIL: gcc.

Re: [PATCH] Add 3 target hooks for memset

2021-05-25 Thread Richard Biener via Gcc-patches
On Thu, May 20, 2021 at 10:50 PM H.J. Lu wrote: > > On Wed, May 19, 2021 at 5:55 AM H.J. Lu wrote: > > > > On Wed, May 19, 2021 at 2:25 AM Richard Biener > > wrote: > > > > > > On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > > > > > > > Add TARGET_READ_MEMSET_VALUE and TARGET_GEN_MEMSET_VALU

Re: [PATCH v4 04/12] Remove MAX_BITSIZE_MODE_ANY_INT

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > It is only defined for i386 and everyone uses the default: > > #define MAX_BITSIZE_MODE_ANY_INT (64*BITS_PER_UNIT) > > Whatever problems we had before, they have been fixed now. So I don't have a strong recollection here apart from memory usage

Re: RFA: fix gcc.dg/tree-ssa/popcount4l.c 16 bit failure, improve 64 bit popcount expansion for 32 bit target

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 17, 2021 at 3:18 PM Joern Wolfgang Rennecke wrote: > > Attached is the updated version of the patch. > Bootstrapped and regtested on x86_64-pc-linux-gnu. > > OK to apply? + machine_mode m = mode_for_size ((prec + 1) / 2, MODE_INT, 1).require (); + int half_prec = GET_MODE_

Re: [PATCH] c++: access for hidden friend of nested class template [PR100502]

2021-05-25 Thread Patrick Palka via Gcc-patches
On Mon, 24 May 2021, Jason Merrill wrote: > On 5/21/21 4:35 PM, Patrick Palka wrote: > > Here, during ahead of time access checking for the private member > > EnumeratorRange::end_reached_ in the hidden friend f, we're triggering > > the the assert in enforce_access that verifies we're not trying

RE: [PATCH 2/4]AArch64: Add support for sign differing dot-product usdot for NEON and SVE.

2021-05-25 Thread Tamar Christina via Gcc-patches
Hi Richard, > -Original Message- > From: Richard Sandiford > Sent: Monday, May 10, 2021 5:49 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH 2/4]AArch64: Add support for sign differing dot-produc

RE: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-05-25 Thread Tamar Christina via Gcc-patches
Hi Richi, Here's a respun version of the patch. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. Ok for master? Thanks, Tamar gcc/ChangeLog: * optabs.def (usdot_prod_optab): New. * doc/md.texi: Document it and clarify other dot prod optabs. * optabs-tree

[PATCH][AArch32]: Correct sdot RTL on aarch32

2021-05-25 Thread Tamar Christina via Gcc-patches
Hi All, The RTL Generated from dot_prod is invalid as operand3 cannot be written to, it's a normal input. For the expand it's just another operand but the caller does not expect it to be written to. Bootstrapped Regtested on arm-none-linux-gnueabihf and no issues. Ok for master? and backport to

Re: [PATCH] c++/88601 - [C/C++] __builtin_shufflevector support

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 7:32 AM, Jason Merrill via Gcc-patches wrote: On 5/25/21 2:57 AM, Richard Biener wrote: On Fri, 21 May 2021, Jason Merrill wrote: On 5/21/21 8:33 AM, Richard Biener wrote: This adds support for the clang __builtin_shufflevector extension to the C and C++ frontends.  The builtin is

[PATCH]AArch64: Correct dot-product auto-vect optab RTL

2021-05-25 Thread Tamar Christina via Gcc-patches
Hi All, The current RTL for the vectorizer patterns for dot-product are incorrect. Operand3 isn't an output parameter so we can't write to it. This fixes this issue and reduces the number of RTL. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. Ok for master? And backport to GCC

FW: [PATCH 4/4]middle-end: Add tests middle end generic tests for sign differing dotproduct.

2021-05-25 Thread Tamar Christina via Gcc-patches
Forgot the list... -Original Message- From: Tamar Christina Sent: Tuesday, May 25, 2021 3:58 PM To: Tamar Christina Cc: nd ; rguent...@suse.de Subject: RE: [PATCH 4/4]middle-end: Add tests middle end generic tests for sign differing dotproduct. Hi All, Adding a few more tests Bootst

RE: [PATCH 3/4][AArch32]: Add support for sign differing dot-product usdot for NEON.

2021-05-25 Thread Tamar Christina via Gcc-patches
Forgot to include the list > -Original Message- > From: Tamar Christina > Sent: Tuesday, May 25, 2021 3:57 PM > To: Tamar Christina > Cc: Richard Earnshaw ; nd ; > Ramana Radhakrishnan ; Kyrylo Tkachov > > Subject: RE: [PATCH 3/4][AArch32]: Add support for sign differing dot- > product u

[PATCH] c++, v2: Avoid -Wunused-value false positives on nullptr passed to ellipsis [PR100666]

2021-05-25 Thread Jakub Jelinek via Gcc-patches
On Tue, May 25, 2021 at 09:40:13AM -0400, Jason Merrill wrote: > Please also test the case of a [[nodiscard]] function returning an empty > class type. Here it is. I have also extended the decltype(nullptr) nodiscard test. Retested on x86_64-linux (nothing other than testcases changed), ok for tr

Re: [PATCH] Add 3 target hooks for memset

2021-05-25 Thread H.J. Lu via Gcc-patches
On Tue, May 25, 2021 at 7:34 AM Richard Biener wrote: > > On Thu, May 20, 2021 at 10:50 PM H.J. Lu wrote: > > > > On Wed, May 19, 2021 at 5:55 AM H.J. Lu wrote: > > > > > > On Wed, May 19, 2021 at 2:25 AM Richard Biener > > > wrote: > > > > > > > > On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote

Re: [PATCH 1/2] c-family: Copy DECL_USER_ALIGN even if DECL_ALIGN is similar.

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 4:38 AM, Robin Dapp wrote: Hi Martin and Jason, The removal of the dead code looks good to me.  The change to "re-init lastalign" doesn't seem right.  When it's zero it means the conflict is between two attributes on the same declaration, in which case the note shouldn't be printed (

Re: [PATCH] c++: access for hidden friend of nested class template [PR100502]

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 10:50 AM, Patrick Palka wrote: On Mon, 24 May 2021, Jason Merrill wrote: On 5/21/21 4:35 PM, Patrick Palka wrote: Here, during ahead of time access checking for the private member EnumeratorRange::end_reached_ in the hidden friend f, we're triggering the the assert in enforce_access

Re: [PATCH] c++, v2: Avoid -Wunused-value false positives on nullptr passed to ellipsis [PR100666]

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 11:10 AM, Jakub Jelinek wrote: On Tue, May 25, 2021 at 09:40:13AM -0400, Jason Merrill wrote: Please also test the case of a [[nodiscard]] function returning an empty class type. Here it is. I have also extended the decltype(nullptr) nodiscard test. Retested on x86_64-linux (nothin

Re: [PATCH 8/11] use xxx_no_warning APIs in Objective-C

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 8:01 AM, Iain Sandoe via Gcc-patches wrote: Hi Martin Martin Sebor via Gcc-patches wrote: The attached patch replaces the uses of TREE_NO_WARNING in the Objective-C front end. I’ve been gradually trying to improve/add locations in the ObjC stuff. To that end, I wonder if it mig

Re: [PATCH 8/11] use xxx_no_warning APIs in Objective-C

2021-05-25 Thread Iain Sandoe via Gcc-patches
Martin Sebor wrote: On 5/25/21 8:01 AM, Iain Sandoe via Gcc-patches wrote: Hi Martin Martin Sebor via Gcc-patches wrote: The attached patch replaces the uses of TREE_NO_WARNING in the Objective-C front end. I’ve been gradually trying to improve/add locations in the ObjC stuff. To that end,

Re: [PATCH 1/2] c-family: Copy DECL_USER_ALIGN even if DECL_ALIGN is similar.

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 11:15 AM, Martin Sebor wrote: On 5/25/21 4:38 AM, Robin Dapp wrote: Hi Martin and Jason, The removal of the dead code looks good to me.  The change to "re-init lastalign" doesn't seem right.  When it's zero it means the conflict is between two attributes on the same declaration, in

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
The interface is now an inline function for get_range_query() and an external function for get_global_range_query), as discussed. There are no magic cfun uses behind the scenes. The annoying downcast is gone. Passes can now decide if they want to export global ranges after they use a ranger.

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Adjustments per discussion. OK pending tests? Aldy >From 97bedf7dc0a7860802461b5fd3e72b687076ae30 Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Wed, 19 May 2021 18:27:47 +0200 Subject: [PATCH 3/5] Convert Walloca pass to get_range_query. This patch converts the Walloca pass to use an on-

Re: [PATCH 3/5] Convert evrp pass to RANGE_QUERY(cfun).

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Adjustments per discussion. OK pending tests? Aldy >From 1c275296ab64cd877bce795b9964532c8655fa3f Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Tue, 25 May 2021 17:44:51 +0200 Subject: [PATCH 2/5] Convert evrp pass to get_range_query. gcc/ChangeLog: * gimple-ssa-evrp.c (rvrp_folder::rv

Re: [PATCH 4/5] Convert remaining passes to RANGE_QUERY.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Adjustments per discussion. OK pending tests? Aldy >From d701627d2b0a3cdfea7a11b3b4cf4105db08dcf5 Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Wed, 19 May 2021 18:44:08 +0200 Subject: [PATCH 4/5] Convert remaining passes to get_range_query. This patch converts the remaining users of get

Re: [PATCH 5/5] Cleanup get_range_info

2021-05-25 Thread Aldy Hernandez via Gcc-patches
No changes needed for this patch. OK pending tests? Aldy

[PATCH] arm: Auto-vectorization for MVE: vaddv

2021-05-25 Thread Christophe Lyon via Gcc-patches
This patch adds support for the reduc_plus_scal optab with MVE, which maps to the vaddv instruction. It moves the reduc_plus_scal_ expander from neon.md to vec-common.md and adds support for MVE to it. Since vaddv uses a 32-bits accumulator, we have to truncate it's result. For instance: int32_t

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Jeff Law via Gcc-patches
On 5/25/2021 10:17 AM, Aldy Hernandez wrote: Adjustments per discussion. OK pending tests? The latest revision of #2-#5 are OK once #1 is ACK'd. Jeff

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Eric Botcazou
> LGTM. Thanks, but a bit too bold because gimplify_and_add can promote the non-static DECL to static memory and reinstate DECL_INITIAL, so first hunk adjusted. * gimplify.c (gimplify_decl_expr): Clear TREE_READONLY on the DECL when really creating an initialization statement fo

Re: [PATCH] Fix selftest for targets where short and int are the same size.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
Ok, let's use build_nonstandard_integer_type which works for everyone and gets you unblocked. Pushed. Aldy On Tue, May 25, 2021 at 3:15 PM Jeff Law wrote: > > > > On 5/25/2021 12:44 AM, Aldy Hernandez wrote: > > avr-elf seems to use HImode for both integer_type_node and > > signed_char_type_nod

Re: [PATCH] Fix selftest for targets where short and int are the same size.

2021-05-25 Thread Jeff Law via Gcc-patches
On 5/25/2021 10:36 AM, Aldy Hernandez wrote: Ok, let's use build_nonstandard_integer_type which works for everyone and gets you unblocked. Just to be clear, I'm not blocked on xstormy16.   The upstream GCC tester flagged the failure and I did enough triage to blame you :-) In my day job I'm

Re: [PATCH] c++: constexpr and copy elision within mem init [PR100368]

2021-05-25 Thread Patrick Palka via Gcc-patches
On Mon, 24 May 2021, Jason Merrill wrote: > On 5/24/21 1:48 PM, Patrick Palka wrote: > > In the testcase below, the initializer for C::b inside C's default > > constructor is encoded as a TARGET_EXPR wrapping the CALL_EXPR f() in > > C++17 mode. During massaging of this constexpr constructor, > >

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 10:17 AM, Aldy Hernandez via Gcc-patches wrote: Adjustments per discussion. OK pending tests? Aldy I have no concern with the alloca changes. The xfail removals from the two tests in this patch (a nice improvement) don't seem to be related to alloca so I'd expect them to fail unle

[PATCH] c++: Output less irrelevant info for function template decl [PR100716]

2021-05-25 Thread Matthias Kretz
From: Matthias Kretz Ensure dump_template_decl for function templates never prints template parameters after the function name (it did with -fno-pretty-templates) and skip output of irrelevant & confusing "[with T = T]" in dump_substitution. gcc/cp/ChangeLog: PR c++/100716 *

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-05-25 Thread Qing Zhao via Gcc-patches
Ping…. Qing On May 12, 2021, at 12:16 PM, Qing Zhao via Gcc-patches mailto:gcc-patches@gcc.gnu.org>> wrote: Hi, This is the 3rd version of the patch for the new security feature for GCC. Please take look and let me know your comments and suggestions. thanks. Qing **Compare with the 2nd

PING [PATCH] PR fortran/100602 - [11/12 Regression] Erroneous "pointer argument is not associated" runtime error

2021-05-25 Thread Harald Anlauf via Gcc-patches
*PING* > Gesendet: Dienstag, 18. Mai 2021 um 20:36 Uhr > Von: "Harald Anlauf" > An: "fortran" , "gcc-patches" > Betreff: [PATCH] PR fortran/100602 - [11/12 Regression] Erroneous "pointer > argument is not associated" runtime error > > The generation of the new runtime check picked up the wrong

Re: [PATCH][DOCS] Remove install-old.texi

2021-05-25 Thread Joseph Myers
On Tue, 25 May 2021, Martin Liška wrote: > +@quotation > +aix@var{version}, amdhsa, aout, cygwin, darwin@var{version} Missing comma at the end of this line. > +eabi, eabialtivec, eabisim, eabisimaltivec, elf, elf32, > +elfbare, elfoabi, freebsd@var{version}gnu, hpux, hpux@var{version}, Missing

[PATCH] Document that -fno-trampolines is for Ada only [PR100735]

2021-05-25 Thread Paul Eggert
The GCC manual's documentation of -fno-trampolines was apparently written from an Ada point of view. However, when I read it I understandably mistook it to say that -fno-trampolines also works for C, C++, etc. It doesn't: it is silently ignored for these languages, and I assume for any language oth

Re: [PATCH] c++: constexpr and copy elision within mem init [PR100368]

2021-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/21 1:12 PM, Patrick Palka wrote: On Mon, 24 May 2021, Jason Merrill wrote: On 5/24/21 1:48 PM, Patrick Palka wrote: In the testcase below, the initializer for C::b inside C's default constructor is encoded as a TARGET_EXPR wrapping the CALL_EXPR f() in C++17 mode. During massaging of

[r12-1044 Regression] FAIL: libgomp.c++/task-reduction-16.C execution test on Linux/x86_64

2021-05-25 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, fd97aeb494cdcffe0d21e7f15ab4593662e065bd is the first bad commit commit fd97aeb494cdcffe0d21e7f15ab4593662e065bd Author: Eric Botcazou Date: Tue May 25 18:30:29 2021 +0200 Remove stalled TREE_READONLY flag on automatic variable caused FAIL: libgomp.c++/taskloop-reduction

Re: [PATCH 0/11] warning control by group and location (PR 74765)

2021-05-25 Thread Martin Sebor via Gcc-patches
On 5/25/21 3:04 AM, Richard Biener wrote: On Tue, May 25, 2021 at 2:53 AM Martin Sebor via Gcc-patches wrote: On 5/24/21 5:08 PM, David Malcolm wrote: On Mon, 2021-05-24 at 16:02 -0600, Martin Sebor wrote: The rare expressions that have no location continue to have just one bit[1]. Whe

Re: [_GLIBCXX_DEBUG] Enhance rendering of assert message

2021-05-25 Thread François Dumont via Gcc-patches
On 25/05/21 11:58 am, Jonathan Wakely wrote: On 22/05/21 22:08 +0200, François Dumont via Libstdc++ wrote: Here is the part of the libbacktrace patch with the enhancement to the rendering of assert message. It only contains one real fix, the rendering of address. In 2 places it was done with

Re: [_GLIBCXX_DEBUG] Enhance rendering of assert message

2021-05-25 Thread Jonathan Wakely via Gcc-patches
On 25/05/21 23:01 +0200, François Dumont wrote: On 25/05/21 11:58 am, Jonathan Wakely wrote: On 22/05/21 22:08 +0200, François Dumont via Libstdc++ wrote: Here is the part of the libbacktrace patch with the enhancement to the rendering of assert message. It only contains one real fix, the ren

[PATCH 1/8] Change gori_compute to inherit from gori_map instead of, having a gori-map.

2021-05-25 Thread Andrew MacLeod via Gcc-patches
This is the first in a set of, well, many patches.  It ultimately changes the gori-compute model into a consumer of the range_query class, which allows for much simpler and consistent interaction with the fold_stmt class. I'm basically evolving all the code base to consistently interact with ra

[PATCH 2/8] fully populate the export list from range_cache, not, gori_compute.

2021-05-25 Thread Andrew MacLeod via Gcc-patches
Ranger wants to prepopulate all the export blocks so that it has an initial invariant set of names. GORI consumers shouldn't be penalized for ranger requirements.  This way any gori client remains lightweight. Bootstraps on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew >From cb33af1a

[PATCH 3/8] Add imports and strengthen the export definition to range_def and gori_map.

2021-05-25 Thread Andrew MacLeod via Gcc-patches
This patch introduced imports to range_def, and corrects some minor issues with export calculation. When gori-compute is evaluating sequences in a block:   - an "export" is defined as any ssa_name which may have a range calculated on an outgoing edge.  If the edge may CHANGE the value of ssa-

[PATCH 4/8] Unify temporal cache with gori dependencies.

2021-05-25 Thread Andrew MacLeod via Gcc-patches
The patch removes the custom temporal cache from GCC11 and replaces it with a simple timestamp vector and utilizes the direct dependants from gori_compute. This allows the registration of said dependencies to be handled generically by the simplified fold_stmt class thru the gori_compute class

[PATCH 5/8] Tweak location of non-null calls. revamp ranger debug, output.

2021-05-25 Thread Andrew MacLeod via Gcc-patches
Just some minor tweaking of the location of calls to non_null_deref_p, as well as debug output. Bootstraps on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew >From 35c78c6fc54721e067ed3a30ddd9184b45c5981d Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Tue, 25 May 2021 14:41:16 -

  1   2   >