[Patch, committed] libgomp: Fixes + cleanup for OpenACC's Fortran module + openacc_lib.h

Hi all, this patch does various cleanups/bug fixes and it updates acc_get_property(_string) to include a spec bug fix. Namely: (0) I added a .gitattributes file for openacc_lib.h (this is a Fortran file) as otherwise "git diff" marks the space-indentation as "wrong"/red; but ISO Fortran doesn't

Re: [PATCH] Fix -save-temp leaking files in /tmp and possible data loss in signal handler

On Tue, Feb 18, 2020 at 6:12 PM Bernd Edlinger wrote: > > Hi, > > I noticed that my /tmp directory gets clobbered with many *.ld/*.le files > whenever > the test suite runs. I tracked that down to a bug in the collect2 and > lto-wrapper > executable, which happens when -save-temps is used. As

[PATCH] testsuite: Require vect_mutiple_sizes for scan-tree-dump in vect-epilogues.c

Default testsuite flags do not enable V8QI (MMX) vector mode for 32bit x86 targets. Require vect_multiple_sizes effective target in scan-tree-dump to avoid "LOOP EPILOGUE VECTORIZED" failure. Tested on x86_64-linux-gnu {,-m32}. 2020-02-19 Uroš Bizjak * gcc.dg/vect/vect-epilogues.c (scan-tree

Re: [committed] libstdc++: P1964R2 Wording for boolean-testable

On 18/02/20 13:49 +, Jonathan Wakely wrote: On 17/02/20 22:27 +0100, Tim Song wrote: On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: This removes the complicated std::boolean concept, as agreed in Prague. * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn)

Re: [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass

On 10/12/2019 18:28, Craig Blackmore wrote: > > Hi Jim, > > Thank you for your review. I have posted an updated patch below which I think > addresses your comments. > Ping https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00712.html https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00713.html Craig

[PATCH] vect: Fix offset calculation for -ve strides [PR93767]

This PR is a regression caused by r256644, which added support for alias checks involving variable strides. One of the changes in that commit was to split the access size out of the segment length. The PR shows that I hadn't done that correctly for the handling of negative strides in vect_compile

Re: [PATCH] alias: Fix offset checks involving section anchors [PR92294]

What should we do about this? The PR is a wrong-code regression from GCC 9 and it doesn't look like we can remove the second offset_overlap_p check, given how many cases currently rely on it. Thanks, Richard Richard Sandiford writes: > Richard Biener writes: >> On Tue, Feb 4, 2020 at 6:44 PM R

[committed] libstdc++: Implement LWG issues 3398, 3379, 3304, 3321, 3280, 3335

Add ranges_size_t and rename all_view (LWG 3335) Remove converting constructors from views (LWG 3280) uninitialized_construct_using_allocator should use construct_at (LWG 3321) Add nodiscard to polymorphic_allocator members (LWG 3304) "safe" in several library names is misleading (LWG 3379) tuple_

[PATCH] lra: Stop registers being incorrectly marked live v2 [PR92989]

This PR is about a case in which the clobbers at the start of an EH receiver can lead to registers becoming unnecessarily live in predecessor blocks. My first attempt at fixing this made sure that we update the bb liveness info based on the real live set: http://gcc.gnu.org/g:e648e57efca6ce6d75

Re: [committed] libstdc++: Implement LWG issues 3398, 3379, 3304, 3321, 3280, 3335

On 19/02/20 12:47 +, Jonathan Wakely wrote: Add ranges_size_t and rename all_view (LWG 3335) Remove converting constructors from views (LWG 3280) uninitialized_construct_using_allocator should use construct_at (LWG 3321) Add nodiscard to polymorphic_allocator members (LWG 3304) "safe" in seve

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

Hi all, Second version of the patch here addressing comments. This patch enables the Armv8.1-M Mainline LOB (low overhead branch) extension low overhead loops (LOL) feature by using the 'loop-doloop' pass. Given the following function: void loop (int *a) { for (int i = 0; i < 1000; i++) a

Re: [PATCH] vect: Fix offset calculation for -ve strides [PR93767]

On Wed, Feb 19, 2020 at 1:13 PM Richard Sandiford wrote: > > This PR is a regression caused by r256644, which added support for alias > checks involving variable strides. One of the changes in that commit > was to split the access size out of the segment length. The PR shows > that I hadn't done

Re: [PATCH] avoid issuing -Wredundant-tags in shared C/C++ code in headers (PR 93804)

On 19/02/2020 01:02, Martin Sebor wrote: PR 93804 points out that issuing -Wredundant-tags for declarations in C headers included in C++ isn't helpful because the tags cannot be removed without breaking C programs that depend on the headers. Attached is a patch that avoids the warning in these c

Re: [PATCH] alias: Fix offset checks involving section anchors [PR92294]

On Wed, Feb 19, 2020 at 1:19 PM Richard Sandiford wrote: > > What should we do about this? The PR is a wrong-code regression from > GCC 9 and it doesn't look like we can remove the second offset_overlap_p > check, given how many cases currently rely on it. Did you check whether we eventually dis

Re: [PATCH] alias: Fix offset checks involving section anchors [PR92294]

On Wed, Feb 19, 2020 at 3:20 PM Richard Biener wrote: > > On Wed, Feb 19, 2020 at 1:19 PM Richard Sandiford > wrote: > > > > What should we do about this? The PR is a wrong-code regression from > > GCC 9 and it doesn't look like we can remove the second offset_overlap_p > > check, given how many

Re: [PR47785] COLLECT_AS_OPTIONS

On Wed, Feb 19, 2020 at 12:19 AM Prathamesh Kulkarni wrote: > > On Tue, 18 Feb 2020 at 19:40, Richard Biener > wrote: > > > > On Tue, Feb 18, 2020 at 1:52 PM Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 17 Feb 2020 at 19:52, Richard Biener > > > wrote: > > > > > > > > On Mon, Feb 17, 20

[PATCH] Avoid collect2 calling signal unsafe functions and/or unlink, with uninitialized memory (for gcc-8 branch)

Hi, this fixes the signal handler calling signal unsafe vfprintf and/or passing uninitialized memory to unlink in signal handler. This is the patch for the gcc-8 branch. Bootstrapped and reg-tested with x86_64-pc-linux-gnu. Is it OK for the gcc-8 branch? Thanks Bernd. From dd98fe7c45c5096dfab

Re: [PATCH] alias: Fix offset checks involving section anchors [PR92294]

Richard Biener writes: > On Wed, Feb 19, 2020 at 1:19 PM Richard Sandiford > wrote: >> >> What should we do about this? The PR is a wrong-code regression from >> GCC 9 and it doesn't look like we can remove the second offset_overlap_p >> check, given how many cases currently rely on it. > > Did

[committed] libstdc++: Implement LWG issues 3320, 3369, 3200, 3348, 3237

make polymorphic_allocator throw consistent type (LWG 3237) Add __cpp_lib_unwrap_ref feature test macro midpoint should not constrain T is complete (LWG 3200) span's deduction-guide for built-in arrays doesn't work (LWG 3369) Remove std::span::cbegin and std::span::cend (LWG 3320) Tested powerpc6

Re: [PATCH] testsuite/strlenopt-81.c: Add target limitation.

On 2/18/20 5:35 PM, Jim Wilson wrote: On Sun, Feb 16, 2020 at 9:02 PM Kito Cheng wrote: It cause the __builtin_strlen not optimized/folded in test_local_cpy_4, and the reason is blocked by __builtin_memcpy, it's same issue in strlenopt-80.c, so I there is two way to fix this issue: Another po

[PATCH] PPC64 builtin vec_rlnm() argument order is wrong

GCC maintainers: The implemented argument order for the vec_rlnm() builtin for PPC64 is wrong. The following bugzilla was created for the issue: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93819 I included a patch to fix the issue in the patch. Per the request from Martin Liska I am posting t

Re: [PATCH, GCC/ARM] Fix MVE scalar shift tests

Hi Christophe, On 01/23/2020 09:34 AM, Christophe Lyon wrote: On Mon, 20 Jan 2020 at 19:01, Mihail Ionescu wrote: Hi, This patch fixes the scalar shifts tests added in: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01195.html https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01196.html By adding

Re: [PATCH] Fix bug in recursiveness check for function to be cloned (ipa/pr93707)

Hi, On Thu, Feb 13 2020, Feng Xue OS wrote: > I've submitted a bug tracker, > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93707. > > The root cause is that for a self-recursive function, a for-all-contexts > clone could generate > an edge whose callee is not the function. Therefore, to check wh

Re: Test failure on GCC-8/9 in typebound_call_22.f03

PR91984 modified typebound_call_22.f03 as it was expected to fail. PR92113 negated the need for the xfail but unfortunately the test case was not modified. The attached patch removes the xfail. gcc/testsuite/ChangeLog     Mark Eggleston     * typebound_call_22.d03 : Remove xfail clause. Pa

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

‐‐‐ Original Message ‐‐‐ On Sunday, February 16, 2020 3:10 PM, GT wrote: > ‐‐‐ Original Message ‐‐‐ > On Friday, February 14, 2020 5:09 PM, Jakub Jelinek ja...@redhat.com wrote: > > > On Fri, Feb 14, 2020 at 10:02:39PM +, GT wrote: > > > > > > > Function rs6000_simd_clone_adju

Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

Hi, Here is the latest version of the patch. It just has some minor formatting changes that were brought up by Richard Sandiford in the AArch64 patches Thanks, Delia On 1/31/20 3:23 PM, Delia Burduv wrote: Here is the updated patch. The changes are minor, so let me know if there is anything

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

Hi, Here is the latest version of the patch. It just has some minor formatting changes that were brought up by Richard Sandiford in the AArch64 patches Thanks, Delia On 1/22/20 5:29 PM, Delia Burduv wrote: Ping. I will change the tests to use the exact input and output registers as Richar

Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32

Hi, Here is the latest version of the patch. It just has some minor formatting changes that were brought up by Richard Sandiford in the AArch64 patches Thanks, Delia On 1/22/20 5:31 PM, Delia Burduv wrote: Ping. I will change the tests to use the exact input and output registers as Richa

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

Sorry I missed this discussion until now, I have been out of the office much of the last week. On 2/16/20 2:10 PM, GT wrote: ‐‐‐ Original Message ‐‐‐ On Friday, February 14, 2020 5:09 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Feb 14, 2020 at 10:02:39PM +, GT wrote: Funct

Re: [PATCH] Fix -save-temp leaking files in /tmp and possible data loss in signal handler

On 2/19/20 6:36 PM, Bernhard Reutner-Fischer wrote: > Bernd, > > On 18 February 2020 18:12:21 CET, Bernd Edlinger > wrote: >> Hi, > > +is not allocatted with calloc. */ > > s/tt/t/ > Thanks yes, fixed as obvious: commit fd136f018e6d64bff08b7a0243ba34911792547c Author: Bernd Edlinge

Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

On Fri, Feb 14, 2020 at 09:12:58AM +0100, Jason Merrill wrote: > On 2/13/20 8:56 PM, Marek Polacek wrote: > > My P0388R4 patch changed build_array_conv to create an identity > > conversion at the start of the conversion chain. > > Hmm, an identity conversion of {} suggests that it has a type, whic

[PATCH] libstdc++: Add missing call to unused subroutine in split_view test

libstdc++-v3/ChangeLog: * testsuite/std/ranges/adaptors/split.cc (test03): Don't include the null terminator of the underlying string as part of the test_range. (main): Call test03. --- libstdc++-v3/testsuite/std/ranges/adaptors/split.cc | 3 ++- 1 file changed, 2 insertio

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

‐‐‐ Original Message ‐‐‐ On Wednesday, February 19, 2020 12:33 PM, Bill Schmidt wrote: > > > > The reason 'c' was added to the ABI is this mailing list discussion: > > https://sourceware.org/ml/libc-alpha/2019-11/msg00765.html > > As long as 'b' specifies that the VSX functionality is th

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

On 2/19/20 1:10 PM, GT wrote: ‐‐‐ Original Message ‐‐‐ On Wednesday, February 19, 2020 12:33 PM, Bill Schmidt wrote: The reason 'c' was added to the ABI is this mailing list discussion: https://sourceware.org/ml/libc-alpha/2019-11/msg00765.html As long as 'b' specifies that the VSX

[committed] testsuite: Add -msse2 to fix ia32 tests.

testsuite: Add -msse2 to fix ia32 tests. Tested on x86_64-linux-gnu {,-m32}. 2020-02-19 Uroš Bizjak * gcc.dg/gimplefe-41.c: Add -msse2 additional options for x86 targets. * gcc.dg/ipa/ipa-sra-19.c: Ditto. Uros. diff --git a/gcc/testsuite/gcc.dg/gimplefe-41.c b/gcc/testsuite/gcc.dg/g

Re: [PATCH] libstdc++: Add missing call to unused subroutine in split_view test

On 19/02/20 14:01 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: * testsuite/std/ranges/adaptors/split.cc (test03): Don't include the null terminator of the underlying string as part of the test_range. (main): Call test03. OK.

Re: [PATCH v2] c++: Fix value-init crash in template [PR93676]

On Fri, Feb 14, 2020 at 12:24:30AM +0100, Jason Merrill wrote: > On 2/11/20 8:54 PM, Marek Polacek wrote: > > Since we > > attempt to value-initialize in build_vec_init even when there's no > > initializer but the type has a constexpr defau

[committed] libstdc++: Implement LWG issues 3247, 3282

subrange converting constructor should disallow slicing (LWG 3282) ranges::iter_move should perform ADL-only lookup (LWG 3247) Tested powerpc64le-linux, committed to master. commit 77f5310f0205714538668b88fbf1de44f1f435be Author: Jonathan Wakely Date: Wed Feb 19 17:04:07 2020 + libs

[PATCH] c++: Fix wrong-code with non-constexpr constructor [PR93169]

In order to detect modifying constant objects in constexpr evaluation, which is UB, in r10-2655 I added code that sets TREE_READONLY on CONSTRUCTORs of const-qualified objects after they have been fully constructed. But I never made sure that what we're setting the flag on actually is a CONSTRUCTO

[committed] libstdc++: Implement LWG issues 3329, 3331, 3360, 3364, 3385

make common_iterator require copyable (LWG 3385) Add default-initializers to views (LWG 3364) Simplify std::three_way_comparable_with (LWG 3360) Simplify std::totally_ordered (LWG 3331) Simplify std::totally_ordered_with (LWG 3329) Tested powerpc64le-linux, committed to master. commit 1b425f3ac

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

On Wed, 19 Feb 2020, GT wrote: > 1. In the Vector Function ABI document, under section "Vector Function > Name Mangling", state that all vector variants will be created by > the compiler. And that it will be up to the caller of vectorized > functions to select the preferred version ('b' or 'c'

[PATCH v2] debug/93751 Option to generate DIEs for external variables

Hi all, Attached is a patch adjusted per discussion in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93751 - The manual is corrected to reflect that DIEs for external variables are not generated when using DWARF - A new option is introduced that implements the behavior that was described in t

Re: [PATCH] RISC-V: Adjust floating point code gen for LTGT compare

On Tue, Feb 18, 2020 at 9:29 PM Kito Cheng wrote: > * config/riscv/riscv.c (riscv_emit_float_compare): Change the code gen > for LTGT. I think you should update riscv_rtx_costs also. The comment is now wrong for LTGT, and the cost calculation is wrong too. Looks like it should b

Re: [PATCH] reject invalid flexarrays even in anonymous structs (PR 93753)

On 2/18/20 12:06 AM, Martin Sebor wrote: The improved checking of flexible array members committed in r231665 (and later) deliberately excluded anonymous structs and unions (unnamed members of types with no tags) to allow a harmless extension that was accepted by G++ prior to the change.  However

Re: [PATCH] c++: use "C++20" in std header hints

On 2/18/20 2:14 AM, David Malcolm wrote: On Sat, 2020-02-15 at 22:21 +0100, Jason Merrill wrote: It's probably past time for this, but definitely now that we're done with the final committee meeting of C++20. This patch only adds the option and adjusts the testsuite to recognize it; more extens

Re: [PATCH] only handle true class-keys in -Wredundant-tags (PR 93801)

On 2/18/20 8:52 PM, Martin Sebor wrote: The -Wredundant-tags warning, new in GCC 10, issues false positives for some declarations involving typename.  Typename isn't a C++ class-key so the warning is not intended in these cases.  Attached is a simple fix tested on x86_64-linux. OK.

Re: [PATCH] reject invalid flexarrays even in anonymous structs (PR 93753)

On 2/19/20 4:51 PM, Jason Merrill wrote: On 2/18/20 12:06 AM, Martin Sebor wrote: The improved checking of flexible array members committed in r231665 (and later) deliberately excluded anonymous structs and unions (unnamed members of types with no tags) to allow a harmless extension that was acc

Re: [PATCH] avoid issuing -Wredundant-tags in shared C/C++ code in headers (PR 93804)

On 2/19/20 1:02 AM, Martin Sebor wrote: PR 93804 points out that issuing -Wredundant-tags for declarations in C headers included in C++ isn't helpful because the tags cannot be removed without breaking C programs that depend on the headers. Attached is a patch that avoids the warning in these ca

Re: [PATCH] c++: Fix wrong-code with non-constexpr constructor [PR93169]

On 2/19/20 11:12 PM, Marek Polacek wrote: In order to detect modifying constant objects in constexpr evaluation, which is UB, in r10-2655 I added code that sets TREE_READONLY on CONSTRUCTORs of const-qualified objects after they have been fully constructed. But I never made sure that what we're

Re: [PATCH] reject invalid flexarrays even in anonymous structs (PR 93753)

On 2/20/20 1:08 AM, Martin Sebor wrote: On 2/19/20 4:51 PM, Jason Merrill wrote: On 2/18/20 12:06 AM, Martin Sebor wrote: The improved checking of flexible array members committed in r231665 (and later) deliberately excluded anonymous structs and unions (unnamed members of types with no tags) t

New German PO file for 'gcc' (version 10.1-b20200209)

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: https://translationproject.org/latest/gcc/de.po (This file, 'gcc-10.1-b20200209.de.po',

Re: [PATCH v2] c++: Fix value-init crash in template [PR93676]

On 2/19/20 10:15 PM, Marek Polacek wrote: On Fri, Feb 14, 2020 at 12:24:30AM +0100, Jason Merrill wrote: On 2/11/20 8:54 PM, Marek Polacek wrote: Since we attempt to value-initialize in build_vec_init even when there's no initializer bu

[PATCH] use pointer size rather than array size when storing the former (PR 93829)

The buffer overflow detection for multi-char stores uses the size of a source array even when what's actually being accessed (read and stored) is a pointer to the array. That leads to incorrect warnings in some cases. The attached patch corrects the function that computes the size of the access

Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

On 2/19/20 7:30 PM, Marek Polacek wrote: On Fri, Feb 14, 2020 at 09:12:58AM +0100, Jason Merrill wrote: On 2/13/20 8:56 PM, Marek Polacek wrote: My P0388R4 patch changed build_array_conv to create an identity conversion at the start of the conversion chain. Hmm, an identity conversion of {} s

[PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

PR93658 shows a problem in rs6000_legitimate_address_p() where we erroneously mark an Altivec address as being invalid, which causes LRA to go into an infinite loop spilling the same address over and over again. The problem is, when VSX is enabled, the rs6000_vector_mem[], returns VECTOR_VSX rathe

Re: [PATCH] Fix bug in recursiveness check for function to be cloned (ipa/pr93707)

This is a simpel and nice fix, but could suppress some CP opportunities for self-recursive call. Using the test case as example, the first should be a for-all-context clone, and the call "recur_fn (i, 1, depth + 1)" is replaced with a newly created recursive node. Thus, in the next round of CP it

[PATCH 2/2] libstdc++: P1739R4 Avoid template bloat for safe_ranges in combination with ...

... 'subrange-y' view adaptors This implements an interpretation of P1739R4. It's only an "interpretation" becuase AFAICT there is an issue with the paper's wording as-is. So this patch deviates from paper when it comes to the problematic wording. The issue is that the paper's wording for views

[PATCH 1/2] libstdc++: Forward second argument of views::iota using the correct type

We are forwarding the second argument of views::iota using the wrong type, causing compiling errors when calling it with a value and bound of different types, like in the test case below. libstdc++-v3/ChangeLog: * include/std/ranges (views::_Iota::operator()): Forward __f using the

Re: [PATCH] use pointer size rather than array size when storing the former (PR 93829)

On 20 February 2020 01:26:58 CET, Martin Sebor wrote: + Sets *NULTREM if the representation contains a zero byte, and sets s/NULTREM/NULTERM/ thanks,

[PATCH] c++/93730 create VLA constructor if explicitly initialized as zeroes

* cp/decl.c (reshape_init_array_1): Enforce constructor creation for VLAs when initialized with zero value. * testsuite/g++.dg/pr93730.C: New test * testsuite/g++.dg/abi/mangle72.C: Change mangling to new version Signed-off-by: Slava Barinov This fixes case when V

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

On Wed, Feb 19, 2020 at 09:17:26PM -0600, Peter Bergner wrote: > PR93658 shows a problem in rs6000_legitimate_address_p() where we erroneously > mark an Altivec address as being invalid, which causes LRA to go into an > infinite loop spilling the same address over and over again. The problem > is,