Re: [PATCH] xfail and improve some failing libgomp tests

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 08:49:47AM +0100, Harwath, Frederik wrote: > Add xfails for nvptx offloading because > "no GOMP_OFFLOAD_async_run implemented in plugin-nvptx.c" > (https://gcc.gnu.org/PR81688) and because > "omp target link not implemented for nvptx" > (https://gcc.gnu.org/PR81689). > > li

Re: [PATCH Coroutines]Pickup more CO_AWAIT_EXPR expanding cases

2020-02-10 Thread bin.cheng
Hi, We found more ICEs because of unexpanded CO_AWAIT_EXPR, it turned out we can fix these issues with more simplification in function co_await_expander. Here is the patch with a new test. Bootstrap and test on x86_64. Is it OK? Thanks, bin gcc/cp 2020-02-10 Bin Cheng * coroutine

Re: [PATCH] libstdc++: Make sure iterator_traits is populated

2020-02-10 Thread Jonathan Wakely
On 07/02/20 13:59 -0500, Patrick Palka wrote: Since basic_istream_view::iterator is neither a cpp17 iterator (because it's move-only) nor does it define all four of the types {difference_type, value_type, reference, iterator_category}, then by the rule in [iterator.traits], its iterator_traits ha

Re: [PATCH Coroutines]Insert the default return_void call at correct position

2020-02-10 Thread Bin.Cheng
Ping. Thanks, bin On Mon, Feb 3, 2020 at 1:55 PM bin.cheng wrote: > > Hi, > > Exception in coroutine is not correctly handled because the default > return_void call is now inserted before the finish suspend point, > rather than at the end of the original coroutine body. This patch > fixes the i

[COMMITTED] c++: Fix flexible array with synthesized constructor.

2020-02-10 Thread Jason Merrill
We were already rejecting initialization of a flexible array member in a constructor; we similarly shouldn't try to clean it up. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/93618 * tree.c (array_of_unknown_bound_p): New. * init.c (perform_member_init): Do nothing

Re: [PATCH coroutines] Change lowering behavior of alias variable from copy to substitute

2020-02-10 Thread JunMa
在 2020/2/6 下午7:09, JunMa 写道: 在 2020/2/6 下午5:12, Iain Sandoe 写道: Hi JunMa, JunMa wrote: 在 2020/2/4 下午8:17, JunMa 写道: Hi When testing coroutines with lambda function, I find we copy each captured variable to frame. However, according to gimplify pass, for each declaration that is an alias

Patch ping

2020-02-10 Thread Jakub Jelinek
Hi! I'd like to ping a couple of patches: PR target/91913 - arm movsi + cmpsi -> movsi_compare0 peephole2 ICE fix https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00010.html PR preprocessor/92319 - partially implement P1042R1: __VA_OPT__ wording clarifications https://gcc.gnu.org/ml/gcc-patc

Re: [ARM] Fix -mpure-code for v6m

2020-02-10 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 17:55, Richard Earnshaw (lists) wrote: > > On 07/02/2020 16:43, Christophe Lyon wrote: > > On Fri, 7 Feb 2020 at 14:49, Richard Earnshaw (lists) > > wrote: > >> > >> On 07/02/2020 13:19, Christophe Lyon wrote: > >>> When running the testsuite with -fdisable-rtl-fwprop2 and -

Re: [PATCH coroutines v1] Build co_await/yield_expr with unknown_type in processing_template_decl phase

2020-02-10 Thread JunMa
Kindly ping. Regards JunMa 在 2020/2/5 下午5:17, JunMa 写道: 在 2020/2/5 下午2:14, JunMa 写道: Hi This patch builds co_await/yield_expr with unknown_type when we can not know the promise type in processing_template_decl phase. it avoid to confuse compiler when handing type deduction and conversion. Boo

[PATCH] [MIPS] Prevent allocation of a GPR for a floating mode pseudo

2020-02-10 Thread Mihailo Stojanovic
Similar to the mirror case of allocating an FPR for an integer mode pseudo, prevent GPRs from being allocated for a floating mode pseudo. --- gcc/config/mips/mips.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c index 513fc5f..ffcb14d 1006

Re: [PATCH Coroutines]Insert the default return_void call at correct position

2020-02-10 Thread Iain Sandoe
Hi Bin, Bin.Cheng wrote: > Ping. We are seeking to clarify the standard wording around this (and the cases where unhandled_exception() returns - hopefully during the WG21 meeting this week, FWIW, I think your interpretation makes sense here. thanks Iain > > Thanks, > bin > > On Mon, Feb 3,

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Christophe Lyon
Hi, On Fri, 7 Feb 2020 at 09:19, Jakub Jelinek wrote: > > Hi! > > As the following testcase shows, unwind.h on ARM can't be (starting with GCC > 10) compiled with -std=c* modes, only -std=gnu* modes. > The problem is it uses asm keyword, which isn't a keyword in those modes > (system headers vs.

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: > > Here we were swallowing all the syntax errors by parsing tentatively, and > returning error_mark_node without ever actually giving an error. Fixed by > using save_tokens/rollback_tokens instead. > > Tested x86_64-pc-linux-gnu, applying to trun

[PATCH] c++: Fix return type deduction with an abbreviated function template

2020-02-10 Thread Patrick Palka
This patch fixes two issues with return type deduction in the presence of an abbreviated function template. The first issue (PR 69448) is that if a placeholder auto return type contains any modifiers such as & or *, then the abbreviated-function-template compensation in splice_late_return_type doe

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 02:03:47PM +0100, Christophe Lyon wrote: > > 2020-02-07 Jakub Jelinek > > > > PR target/93615 > > * config/arm/unwind-arm.h (gnu_Unwind_Find_got): Rename to ... > > (_Unwind_gnu_Find_got): ... this. Use __asm instead of asm. Remove > > tr

Re: [PATCH] [MIPS] Prevent allocation of a GPR for a floating mode pseudo

2020-02-10 Thread Mihailo Stojanović
Please disregard this. Forgot to add the ChangeLog entry. Mihailo

[PATCH v2] [MIPS] Prevent allocation of a GPR for a floating mode pseudo

2020-02-10 Thread Mihailo Stojanovic
Similar to the mirror case of allocating an FPR for an integer mode pseudo, prevent GPRs from being allocated for a floating mode pseudo. gcc/ChangeLog: * gcc/config/mips/mips.c (mips_ira_change_pseudo_allocno_class): Limit the allocation of floating mode pseudos to FP_REGS. ---

Re: [PATCH v2] [MIPS] Prevent allocation of a GPR for a floating mode pseudo

2020-02-10 Thread Andrew Pinski
On Mon, Feb 10, 2020 at 5:33 AM Mihailo Stojanovic wrote: > > Similar to the mirror case of allocating an FPR for an integer mode > pseudo, prevent GPRs from being allocated for a floating mode pseudo. Can you expand on why you want to do this? Provide benchmarking or a testcase which this improv

[Pingx3][GCC][PATCH][ARM]Add ACLE intrinsics for dot product (vusdot - vector, vdot - by element) for AArch32 AdvSIMD ARMv8.6 Extension

2020-02-10 Thread Stam Markianos-Wright
On 2/3/20 11:20 AM, Stam Markianos-Wright wrote: On 1/27/20 3:54 PM, Stam Markianos-Wright wrote: On 1/16/20 4:05 PM, Stam Markianos-Wright wrote: On 1/10/20 6:48 PM, Stam Markianos-Wright wrote: On 12/18/19 1:25 PM, Stam Markianos-Wright wrote: On 12/13/19 10:22 AM, Stam Markianos

Re: [FYI] Patches that fix testing santiziers with qemu user mode

2020-02-10 Thread Christophe Lyon
Hi Andrew, On Sat, 8 Feb 2020 at 10:16, Andrew Pinski wrote: > > Hi, > These two patches are what I use to fix testing of the santizers > with qemu. The first one disables coloring always as for some reason > when running with qemu (but not normally), coloring is detected. I > have not gone

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Jason Merrill
On Mon, Feb 10, 2020 at 2:13 PM Christophe Lyon wrote: > On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: > > > > Here we were swallowing all the syntax errors by parsing tentatively, and > > returning error_mark_node without ever actually giving an error. Fixed > by > > using save_tokens/roll

[committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Jakub Jelinek
Hi! Clearly I can't count, so we would consider as SECTION_BSS even sections like .lbssfoo or .gnu.linkonce.lbbar, even when linker only considers as special .lbss or .lbss.baz or .gnu.linkonce.lb.qux. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvi

[committed] c++: Fix strncmp last argument in dump_decl_name [PR93641]

2020-02-10 Thread Jakub Jelinek
Hi! I'm not aware of symbols starting with _ZG that don't start with _ZGR prefix, but perhaps in the future there might be some. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-02-10 Jakub Jelinek PR other/93641 * error

[PATCH] c-format: -Wformat-diag fix [PR93641]

2020-02-10 Thread Jakub Jelinek
Hi! The last argument to strncasecmp is incorrect, so it matched even when can%' wasn't followed by t. Also, the !ISALPHA (format_chars[1]) test looks pointless, format_chars[1] must be ' if strncasecmp succeeded and so will never be ISALPHA. Fixed thusly, bootstrapped/regtested on x86_64-linux

[PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Jakub Jelinek
Hi! As mentioned in the PR, for -mavx -mno-avx2 the backend does support vcondv4div4df and vcondv8siv8sf optabs (while generally 32-byte vectors aren't much supported in that case, it is performed using vandps/vandnps/vorps). The problem is that after the last generic vector lowering (where the V

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 14:26, Jakub Jelinek wrote: > > On Mon, Feb 10, 2020 at 02:03:47PM +0100, Christophe Lyon wrote: > > > 2020-02-07 Jakub Jelinek > > > > > > PR target/93615 > > > * config/arm/unwind-arm.h (gnu_Unwind_Find_got): Rename to ... > > > (_Unwind_gnu_Find

Re: [PATCH] c-format: -Wformat-diag fix [PR93641]

2020-02-10 Thread Marek Polacek
On Mon, Feb 10, 2020 at 03:25:43PM +0100, Jakub Jelinek wrote: > Hi! > > The last argument to strncasecmp is incorrect, so it matched even when > can%' wasn't followed by t. Also, the !ISALPHA (format_chars[1]) test > looks pointless, format_chars[1] must be ' if strncasecmp succeeded and > so wi

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 14:53, Jason Merrill wrote: > > On Mon, Feb 10, 2020 at 2:13 PM Christophe Lyon > wrote: >> >> On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: >> > >> > Here we were swallowing all the syntax errors by parsing tentatively, and >> > returning error_mark_node without ever

Re: [PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Richard Biener
On Mon, Feb 10, 2020 at 3:33 PM Jakub Jelinek wrote: > > Hi! > > As mentioned in the PR, for -mavx -mno-avx2 the backend does support > vcondv4div4df and vcondv8siv8sf optabs (while generally 32-byte vectors > aren't much supported in that case, it is performed using > vandps/vandnps/vorps). The

Re: [PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 03:40:18PM +0100, Richard Biener wrote: > Hmm. Maybe with FP operands we can also try to implement the mask > as != 0.0 FP condition? Not sure if -1 (or 1) is enough non-NaNish to > not cause problems of course. Well, by the time we reach expansion, we have just the VECTO

Re: [PATCH] libstdc++: Make sure iterator_traits is populated

2020-02-10 Thread Patrick Palka
On Mon, 10 Feb 2020, Jonathan Wakely wrote: > On 07/02/20 13:59 -0500, Patrick Palka wrote: > > Since basic_istream_view::iterator is neither a cpp17 iterator (because it's > > move-only) nor does it define all four of the types {difference_type, > > value_type, reference, iterator_category}, then

committed: fix typo in define_subst example, md.texi

2020-02-10 Thread Hans-Peter Nilsson
Committed as obvious. gcc: * md.texi (Define Subst): Match closing paren in example. diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index cec74ea78..66c5eea3b 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -10545,7 +10545,7 @@ generated with the following @code{define_subst}: ""

Re: [PATCH] arm: Fix ICE with movsi + cmpsi -> movsi_compare0 peephole2 [PR91913]

2020-02-10 Thread Richard Earnshaw (lists)
On 01/02/2020 08:30, Jakub Jelinek wrote: Hi! The following testcase ICEs on arm. The problem is that the following peephole tries to match adjacent *arm_movsi_insn + *arm_cmpsi_insn; the *arm_movsi_insn uses =rk, rk constraints and *arm_cmpsi_insn uses r, IL constraints for what is matched by

[PATCH] arm: correct constraints on movsi_compare0 [PR91913]

2020-02-10 Thread Richard Earnshaw
The peephole that detects a mov of one register to another followed by a comparison of the original register against zero is only used in Arm state; but the instruction that matches this is generic to all 32-bit compilation states. That instruction lacks support for SP which is permitted in Arm s

[PATCH] Fix stack pointer handling in ms_hook_prologue functions for i386 target.

2020-02-10 Thread Paul Gofman
ChangeLog: PR target/91489 * config/i386/i386.md (simple_return): Also check for ms_hook_prologue function attribute. * config/i386/i386.c (ix86_can_use_return_insn_p): Also check for ms_hook_prologue function attribute. testsuite/ChangeLog: PR target/91489 * gc

Re: [PATCH] Fix -ffast-math flags handling inconsistencies

2020-02-10 Thread Ulrich Weigand
Joseph Myers wrote: > On Fri, 7 Feb 2020, Ulrich Weigand wrote: > > > I thought that a *more specific* option like -fsignalling-nans was always > > intended to override a more generic option like -ffast-math, no matter > > whether it comes before or after it on the command line. > > Yes, that's c

Re: [PATCH] Fix -ffast-math flags handling inconsistencies

2020-02-10 Thread Ulrich Weigand
Segher Boessenkool wrote: > On Fri, Feb 07, 2020 at 05:47:32PM +0100, Ulrich Weigand wrote: > > > but what happens to -fsignalling-nans -ffast-math then? Better leave > > > those > > > in I'd say. > > > > Ah, it seems I was confused about the intended semantics here. > > > > I thought that a *m

[PATCH] c++: Improve dump_decl for standard concepts

2020-02-10 Thread Patrick Palka
This patch improves the pretty printing of standard concept definitions in error messages. In particular, standard concepts are now printed qualified whenever appropriate, and the "concept" specifier is printed only when the TFF_DECL_SPECIFIERS flag is specified. In the below test, the first erro

Re: [ARM] Fix -mpure-code for v6m

2020-02-10 Thread Richard Earnshaw (lists)
On 10/02/2020 09:27, Christophe Lyon wrote: On Fri, 7 Feb 2020 at 17:55, Richard Earnshaw (lists) wrote: On 07/02/2020 16:43, Christophe Lyon wrote: On Fri, 7 Feb 2020 at 14:49, Richard Earnshaw (lists) wrote: On 07/02/2020 13:19, Christophe Lyon wrote: When running the testsuite with -fd

[0/6 CRIS cc0-preparations]

2020-02-10 Thread Hans-Peter Nilsson
Stuff I broke out from the CRIS decc0ration work; compare-decanonicalization and tests that would be regressions in a future timeline, but fixed later on. Besides the first patch, nothing you'd normally care about, and perhaps for people doing CC0 work: the test-cases and the cc0 effective-target

[1/6 CRIS cc0-preparations] try to generate zero-based comparisons

2020-02-10 Thread Hans-Peter Nilsson
* config/cris/cris.c (cris_reduce_compare): New function. * config/cris/cris-protos.h (cris_reduce_compare): Add prototype. * config/cris/cris.md ("cbranch4", "cbranchdi4", "cstoredi4") (cstore4"): Apply cris_reduce_compare in expanders. The decc0ration work of the CRIS port made me look closer a

[2/6 CRIS cc0-preparations] gcc.target/cris/cris.exp (check_effective_target_cc0): New.

2020-02-10 Thread Hans-Peter Nilsson
To simplify separating the cc0-specific xfails, let's have an effective-target. This likely fits all targets. --- gcc/testsuite/gcc.target/cris/cris.exp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gcc/testsuite/gcc.target/cris/cris.exp b/gcc/testsuite/gcc.target/cris/cris.ex

[3/6 CRIS cc0-preparations] gcc.target/cris/pr93372-1.c: New test.

2020-02-10 Thread Hans-Peter Nilsson
This test was separated from the posted and approved patch named "dbr: Filter-out TARGET_FLAGS_REGNUM from end_of_function_needs" and applied: it doesn't fail yet. It differs from the posted version in that function "g" is commented-out; see the added comment. --- gcc/testsuite/gcc.target/cris/pr

[4/6 CRIS cc0-preparations] gcc.target/cris/pr93372-2.c, -5.c, -8.c: New tests.

2020-02-10 Thread Hans-Peter Nilsson
* gcc.target/cris/pr93372-2.c, gcc.target/cris/pr93372-5.c, gcc.target/cris/pr93372-8.c: New tests. These tests fails miserably both at being an example of cc0 eliminating compare instructions, and post-cc0-CRIS at showing a significant improvement. They're here to track suboptimal comparison cod

[5/6 CRIS cc0-preparations] gcc.target/cris/pr93372-3.c, -4.c...-35.c: New tests.

2020-02-10 Thread Hans-Peter Nilsson
PR target/93372 * gcc.target/cris/pr93372-3.c, gcc.target/cris/pr93372-4.c, gcc.target/cris/pr93372-6.c, gcc.target/cris/pr93372-7.c, gcc.target/cris/pr93372-9.c, gcc.target/cris/pr93372-10.c, gcc.target/cris/pr93372-11.c, gcc.target/cris/pr93372-12.c, gcc.target/cris/pr93372-13.c, gcc.target/cris/

[6/6 CRIS cc0-preparations] gcc.target/cris/dbr-1.c: New test.

2020-02-10 Thread Hans-Peter Nilsson
Random spotting. Exposes the missed benefit for delay-slot filling of a splitter for indexed addressing mode (the [rN+M] one). To be considered for common instructions and perhaps only for suitable M; at least +-63 is obious (when there's a register available) as both the original and the add fit

[PATCH] fix off-by-one mistakes in attribute access syntax checking (PR 93640)

2020-02-10 Thread Martin Sebor
PR 93641 points out a number of off-by-one mistakes in calls to strncmp in GCC where the bound is (unintentionally) less than the length of the string literal argument. PR 93640 is a separate report of another such mistake in the code that validates the mode argument in attribute access. As a re

Re: [PATCH] fix off-by-one mistakes in attribute access syntax checking (PR 93640)

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 10:20:50AM -0700, Martin Sebor wrote: > PR 93641 points out a number of off-by-one mistakes in calls to strncmp > in GCC where the bound is (unintentionally) less than the length of > the string literal argument. > > PR 93640 is a separate report of another such mistake in

Re: [committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Segher Boessenkool
On Mon, Feb 10, 2020 at 03:07:49PM +0100, Jakub Jelinek wrote: > + || strncmp (name, ".lbss.", sizeof (".lbss.") - 1) == 0 You can just use strlen (".lbss.") which is nicer to read and compiles to the same thing? Segher

Re: patch, fortan] PR83113 Bogus "duplicate allocatable attribute" error for submodule character function

2020-02-10 Thread Andrew Benson
This is now committed (after adding the macro as Steve suggested): https://gcc.gnu.org/g:7848054c68bad6e2aa40cb59f77cc99bd8448d52 On Sunday, February 9, 2020 4:32:26 PM PST Steve Kargl wrote: > Patch looks to me. OK to commit. > > I'm wondering if we need a macro or helper function to > simplif

Re: patch, fortan] PR83113 Bogus "duplicate allocatable attribute" error for submodule character function

2020-02-10 Thread Andrew Benson
I don't think I have the ability to mark the PR as resolved. Can someone do that? On Monday, February 10, 2020 10:02:24 AM PST Andrew Benson wrote: > This is now committed (after adding the macro as Steve suggested): > > https://gcc.gnu.org/g:7848054c68bad6e2aa40cb59f77cc99bd8448d52 > > On Sund

Re: [committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 12:00:28PM -0600, Segher Boessenkool wrote: > On Mon, Feb 10, 2020 at 03:07:49PM +0100, Jakub Jelinek wrote: > > + || strncmp (name, ".lbss.", sizeof (".lbss.") - 1) == 0 > > You can just use strlen (".lbss.") which is nicer to read and compiles > to the same thing?

Re: [PATCH] c++: Improve dump_decl for standard concepts

2020-02-10 Thread Jason Merrill
On 2/10/20 5:28 PM, Patrick Palka wrote: This patch improves the pretty printing of standard concept definitions in error messages. In particular, standard concepts are now printed qualified whenever appropriate, and the "concept" specifier is printed only when the TFF_DECL_SPECIFIERS flag is sp

Re: patch, fortan] PR83113 Bogus "duplicate allocatable attribute" error for submodule character function

2020-02-10 Thread Segher Boessenkool
On Mon, Feb 10, 2020 at 10:05:48AM -0800, Andrew Benson wrote: > I don't think I have the ability to mark the PR as resolved. Can someone do > that? You have an @gcc.gnu.org account; if you use that for your BZ account, you will magically get everything you need here. Segher

Re: [PATCH] c++: Fix return type deduction with an abbreviated function template

2020-02-10 Thread Jason Merrill
On 2/10/20 2:20 PM, Patrick Palka wrote: This patch fixes two issues with return type deduction in the presence of an abbreviated function template. The first issue (PR 69448) is that if a placeholder auto return type contains any modifiers such as & or *, then the abbreviated-function-template

[PATCH], Rename and document PowerPC -mprefixed-addr to -mprefixed

2020-02-10 Thread Michael Meissner
This patch renames the PowerPC internal switch -mprefixed-addr to be -mprefixed. Last week, Bill, Segher, and I were talking, and we came to the conclusion that we needed to make the prefixed addressing option more public. This is particularly true, when you consider that only 64-bit little endia

Re: patch, fortan] PR83113 Bogus "duplicate allocatable attribute" error for submodule character function

2020-02-10 Thread Andrew Benson
Thanks - that worked. On Monday, February 10, 2020 12:18:57 PM PST Segher Boessenkool wrote: > On Mon, Feb 10, 2020 at 10:05:48AM -0800, Andrew Benson wrote: > > I don't think I have the ability to mark the PR as resolved. Can someone > > do > > that? > > You have an @gcc.gnu.org account; if you

New template for 'cpplib' made available

2020-02-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'cpplib' has been made available to the language teams for translation. It is archived as: https://translationproject.org/POT-files/

Contents of PO file 'cpplib-10.1-b20200209.uk.po'

2020-02-10 Thread Translation Project Robot
cpplib-10.1-b20200209.uk.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

New Ukrainian PO file for 'cpplib' (version 10.1-b20200209)

2020-02-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Ukrainian team of translators. The file is available at: https://translationproject.org/latest/cpplib/uk.po (This file, 'cpplib-10.1-b2020

Re: [PATCH] c++: Fix return type deduction with an abbreviated function template

2020-02-10 Thread Patrick Palka
On Mon, 10 Feb 2020, Jason Merrill wrote: > On 2/10/20 2:20 PM, Patrick Palka wrote: > > This patch fixes two issues with return type deduction in the presence of an > > abbreviated function template. > > > > The first issue (PR 69448) is that if a placeholder auto return type > > contains > > an

[PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread H.J. Lu
Since nested function isn't only called directly, there is ENDBR32 at function entry and we need to skip it for direct jump in trampoline. Tested on Linux/x86-64 CET machine with and without -m32. gcc/ PR target/93656 * config/i386/i386.c (ix86_trampoline_init): Skip ENDBR32 at

New template for 'gcc' made available

2020-02-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'gcc' has been made available to the language teams for translation. It is archived as: https://translationproject.org/POT-files/gcc

[committed] Darwin: -Wformat-diag fix (PR93641)

2020-02-10 Thread Iain Sandoe
Hi As show in the PR, The length used for the comparison for 'CFStringRef’ was only comparing for 'CFString', potentially allowing mismatched identifiers. fixed thus, tested on x86_64-darwin16, applied to master thanks Iain Darwin: -Wformat-diag fix (PR93641) The length used for the compa

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > Since nested function isn't only called directly, there is ENDBR32 at > function entry and we need to skip it for direct jump in trampoline. Hm, I'm afraid I don't understand this comment. Can you perhaps rephrase it? Uros. > Tested on Linux/x8

Re: [PATCH] c++: Fix return type deduction with an abbreviated function template

2020-02-10 Thread Jason Merrill
On 2/10/20 8:21 PM, Patrick Palka wrote: On Mon, 10 Feb 2020, Jason Merrill wrote: On 2/10/20 2:20 PM, Patrick Palka wrote: This patch fixes two issues with return type deduction in the presence of an abbreviated function template. The first issue (PR 69448) is that if a placeholder auto retu

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread H.J. Lu
On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > Since nested function isn't only called directly, there is ENDBR32 at > > function entry and we need to skip it for direct jump in trampoline. > > Hm, I'm afraid I don't understand this

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2020 at 8:53 PM H.J. Lu wrote: > > On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > > > Since nested function isn't only called directly, there is ENDBR32 at > > > function entry and we need to skip it for direct j

Re: [PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2020 at 3:33 PM Jakub Jelinek wrote: > > Hi! > > As mentioned in the PR, for -mavx -mno-avx2 the backend does support > vcondv4div4df and vcondv8siv8sf optabs (while generally 32-byte vectors > aren't much supported in that case, it is performed using > vandps/vandnps/vorps). The

Re: [PATCH 1/2] analyzer: gfortran testsuite support

2020-02-10 Thread David Malcolm
On Sun, 2020-02-09 at 16:38 -0800, Steve Kargl wrote: > On Sun, Feb 09, 2020 at 04:19:13PM -0500, David Malcolm wrote: > > On Sun, 2020-02-09 at 12:55 -0800, Steve Kargl wrote: > > > On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote: > > > > On 2/6/20 9:01 PM, David Malcolm wrote: > > > >

Contents of PO file 'cpplib-10.1-b20200209.de.po'

2020-02-10 Thread Translation Project Robot
cpplib-10.1-b20200209.de.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

New German PO file for 'cpplib' (version 10.1-b20200209)

2020-02-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the German team of translators. The file is available at: https://translationproject.org/latest/cpplib/de.po (This file, 'cpplib-10.1-b2020020

Re: [PATCH 1/2] analyzer: gfortran testsuite support

2020-02-10 Thread Steve Kargl
On Mon, Feb 10, 2020 at 03:52:13PM -0500, David Malcolm wrote: > On Sun, 2020-02-09 at 16:38 -0800, Steve Kargl wrote: > > > > Having now looked at the patch, I think it's okay to commit. > > As you note, it is new functionality in 10 so technically > > cannot be a regression. But, it does fix a

Fix libgcc build failure on FRV

2020-02-10 Thread Jeff Law
Alan recently changed the diagnostic in binutils for changing various attributes of a section from a warning to a hard error. This caused the FRV port to fail to build frvbegin/frvend because of differences in the flags for the .ctors/.dtors sections. This patch twiddles frvbegin.c/frvend.c in l

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-10 Thread Segher Boessenkool
Hi! On Mon, Feb 10, 2020 at 02:17:04PM +0800, Kewen.Lin wrote: > on 2020/1/20 下午8:33, Segher Boessenkool wrote: > > On Thu, Jan 16, 2020 at 05:36:52PM +0800, Kewen.Lin wrote: > >> As we discussed in the thread > >> https://gcc.gnu.org/ml/gcc-patches/2020-01/msg00196.html > >> Original: https://gcc

[PATCH] Tweak testcases for pr70010

2020-02-10 Thread will schmidt
Hi, This fixes up a few tests that explicitly disable vsx, but still require altivec be enabled by adding the -maltivec option. (Noted on AIX, also seen on Linux/Power6). OK for master? Thanks, -Will [testsuite] * gcc.target/powerpc/pr70010-2.c: Add -maltivec. * gc

[PATCH] Add ppc_ieee128_ok target-supports proc

2020-02-10 Thread will schmidt
Hi, This adds a target_supports entry to check that the _ieee128 keyword is understood by the target. Also adds that require-effective-target check to the existing pr92796 testcase. Sniff tested on Linux (power6,power9) and AIX. OK for master? Thanks -Will [testsuite] *

[PATCH] issue -Wstringop-overflow for potential overflow, not -truncation (PR 93646)

2020-02-10 Thread Martin Sebor
The reporter of RHBZ #1798636 was mislead and confused by GCC issuing -Wstringop-truncation for a possible overflow in strncat. It took a few iterations to appreciate this subtlety and realize the warning was of the wrong kind. The attached patch adjusts the logic of the function responsible for

Re: [PATCH] Use a non-empty test program to test ability to link

2020-02-10 Thread Joseph Myers
On Sat, 8 Feb 2020, Sandra Loosemore wrote: > > > BTW, I did run autoconf in every subdirectory that contains a > > > configure.ac, > > > but it appears only libstc++-v3 actually uses this test; all the other > > > regenerated configure scripts were unchanged. > > > > There's some problem with th

New Brazilian Portuguese PO file for 'cpplib' (version 10.1-b20200209)

2020-02-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Brazilian Portuguese team of translators. The file is available at: https://translationproject.org/latest/cpplib/pt_BR.po (This file, 'cpp

Contents of PO file 'cpplib-10.1-b20200209.pt_BR.po'

2020-02-10 Thread Translation Project Robot
cpplib-10.1-b20200209.pt_BR.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

Re: [PATCH] Fix -ffast-math flags handling inconsistencies

2020-02-10 Thread Joseph Myers
On Mon, 10 Feb 2020, Ulrich Weigand wrote: > Given the above rule, in the last case __FINITE_MATH_ONLY__ should > also be 0, right? Yes. > I'm not sure how this can be implemented in the current option handling > framework. The -ffast-math handling case would have to check whether > or not ther

[committed] analyzer: fix ICE reporting NULL dereference (PR 93647)

2020-02-10 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6566-ge953f9588d4a7ea4183d14914f915329cc37941f. gcc/analyzer/ChangeLog: PR analyzer/93647 * diagnostic-manager.cc (diagnostic_manager::prune_for_sm_diagnostic): Bulletproof against

[committed] analyzer: handle vector types (PR 93350)

2020-02-10 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6567-ge87deb37649cfe480217fc83c8d56fe925600f93. gcc/analyzer/ChangeLog: PR analyzer/93350 * region-model.cc (region_model::get_lvalue_1): Handle BIT_FIELD_REF. (make_region_for_ty

[committed] analyzer.opt: fix typos in descriptions (PR 93659)

2020-02-10 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6568-geb031d4ba27b3fdc292f5a1092e66024f5ee239c. gcc/analyzer/ChangeLog: PR analyzer/93659 * analyzer.opt (-param=analyzer-max-recursion-depth=): Fix "tha" -> "that" typo. (Wanaly

Re: [PATCH 1/4 v2 GCC11] Add middle-end unroll factor estimation

2020-02-10 Thread Segher Boessenkool
Hi! On Mon, Feb 10, 2020 at 02:20:17PM +0800, Kewen.Lin wrote: > * tree-ssa-loop-manip.c (decide_uf_const_iter): New function. > (decide_uf_runtime_iter): Likewise. > (decide_uf_stupid): Likewise. These names still use "uf". (Those are the last I see). > * tree-ssa-loop-

Re: [PATCH 4/4 v2 GCC11] rs6000: P9 D-form test cases

2020-02-10 Thread Segher Boessenkool
On Mon, Feb 10, 2020 at 02:24:15PM +0800, Kewen.Lin wrote: > 2020-02-10 Kelvin Nilsen > Kewen Lin > > * gcc.target/powerpc/p9-dform-0.c: New test. > * gcc.target/powerpc/p9-dform-1.c: New test. > * gcc.target/powerpc/p9-dform-2.c: New test. > * gcc.target/p

Re: [patch, fortran] PR93486 - ICE on valid with nested submodules and long submodule names

2020-02-10 Thread Andrew Benson
*ping* On Tuesday, January 28, 2020 4:45:59 PM PST Andrew Benson wrote: > I opened PR93486 for this problem: > > The following causes an ICE with revision > ad690d79cfbb905c5546c9333c5fd089d906505b: > > module ivs > interface l > module procedure l_ > end interface l > contains > func

[PATCH coroutines] Do not strip cleanup_point when promote temporaries out of current stmt

2020-02-10 Thread JunMa
Hi In maybe_promote_captured_temps, the cleanup_point_stmt has been stripped when handle temporaries captured by reference. However, maybe there are non-reference temporaries in current stmt which cause ice in gimpilify pass. This patch fix this. The testcase comes from cppcoro and is reduced by

Re: [PATCH 1/4 v2 GCC11] Add middle-end unroll factor estimation

2020-02-10 Thread Jiufu Guo
"Kewen.Lin" writes: > Hi Segher, > > Thanks for your comments! Updated to v2 as below: > > 1) Removed unnecessary hook loop_unroll_adjust_tree. > 2) Updated estimated_uf to estimated_unroll and some comments. > > gcc/ChangeLog > > 2020-02-10 Kewen Lin > > * cfgloop.h (struct loop):

Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-10 Thread Jiufu Guo
Jan Hubicka writes: >> On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote: >> > On 2/3/20 2:17 AM, Jiufu Guo wrote: >> > > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 >> > > "loop2_unroll"} } */ >> > >> > Sorry I didn't catch this addition to the original testcase >> > earli

[PATCH] rs6000: Use strlen instead of sizeof - 1

2020-02-10 Thread Segher Boessenkool
It is easier to read and understand strlen ("string") than it is to read and understrand sizeof ("string") - 1 . Tested on powerpc64-linux {-m32,-m64}. Committing to trunk. Segher 2020-02-10 Segher Boessenkool * config/rs6000/rs6000.c (rs6000_debug_print_mode): Don't use sizeo

Re: [committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Segher Boessenkool
On Mon, Feb 10, 2020 at 07:07:46PM +0100, Jakub Jelinek wrote: > We use sizeof ("...") - 1 or sizeof "..." - 1 in a lot of places though. [...] > config/rs6000/rs6000.c:spaces += sizeof (" Reload=sl") - 1; > config/rs6000/rs6000.c:spaces += sizeof (" Upper=y") - 1; > config/rs6000/rs600

[PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps

2020-02-10 Thread JunMa
Hi As title. in maybe_promote_captured_temps, we promote captured temporaries and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains co_await_expr and maybe other function calls, the side effects flag should be set. This patch fix one mismatch in cppcoro, the testcase comes from cppcor

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-10 Thread Kewen.Lin
on 2020/2/11 上午5:29, Segher Boessenkool wrote: > Hi! > > On Mon, Feb 10, 2020 at 02:17:04PM +0800, Kewen.Lin wrote: >> on 2020/1/20 下午8:33, Segher Boessenkool wrote: >>> On Thu, Jan 16, 2020 at 05:36:52PM +0800, Kewen.Lin wrote: As we discussed in the thread https://gcc.gnu.org/ml/gcc-pa

Re: [PATCH 1/4 v2 GCC11] Add middle-end unroll factor estimation

2020-02-10 Thread Kewen.Lin
Hi Jeff, on 2020/2/11 上午10:14, Jiufu Guo wrote: > "Kewen.Lin" writes: > >> Hi Segher, >> >> Thanks for your comments! Updated to v2 as below: >> >> 1) Removed unnecessary hook loop_unroll_adjust_tree. >> 2) Updated estimated_uf to estimated_unroll and some comments. >> >> gcc/ChangeLog >> >

Re: [PATCH], Rename and document PowerPC -mprefixed-addr to -mprefixed

2020-02-10 Thread Segher Boessenkool
Hi! On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote: > This patch renames the PowerPC internal switch -mprefixed-addr to be > -mprefixed. > If you use -mpcrel, you must be using the 64-bit ELF v2 ABI, and the code > model > must be medium. Currently, anyway. > If you use -mpcr

Re: [PATCH] Tweak testcases for pr70010

2020-02-10 Thread Segher Boessenkool
Hi! On Mon, Feb 10, 2020 at 03:39:44PM -0600, will schmidt wrote: > This fixes up a few tests that explicitly disable vsx, > but still require altivec be enabled by adding the -maltivec > option. (Noted on AIX, also seen on Linux/Power6). > diff --git a/gcc/testsuite/gcc.target/powerpc/pr7

Re: [PATCH] Add ppc_ieee128_ok target-supports proc

2020-02-10 Thread Segher Boessenkool
Hi! On Mon, Feb 10, 2020 at 03:39:49PM -0600, will schmidt wrote: > This adds a target_supports entry to check that the > _ieee128 keyword is understood by the target. (Two underscores, "__ieee128".) > Also adds that require-effective-target check to the > existing pr92796 testcase. > +# See if

Re: [PATCH], Rename and document PowerPC -mprefixed-addr to -mprefixed

2020-02-10 Thread Bill Schmidt
On 2/10/20 9:24 PM, Segher Boessenkool wrote: Hi! On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote: This patch renames the PowerPC internal switch -mprefixed-addr to be -mprefixed. If you use -mpcrel, you must be using the 64-bit ELF v2 ABI, and the code model must be medium.

  1   2   >