Hi! On Mon, Feb 10, 2020 at 03:39:49PM -0600, will schmidt wrote: > This adds a target_supports entry to check that the > _ieee128 keyword is understood by the target.
(Two underscores, "__ieee128".) > Also adds that require-effective-target check to the > existing pr92796 testcase. > +# See if the __ieee128 keyword is understood. > +proc check_effective_target_ppc_ieee128_ok { } { > + return [check_cached_effective_target ppc_ieee128_ok { > + # disable on Darwin, AIX. > + if { [istarget powerpc-*-eabi] > + || [istarget powerpc*-*-eabispe] > + || [istarget *-*-darwin*] > + || [istarget *-*-aix*] } { > + expr 0 Do we need to exclude those two explicitly? Why? And why eabi? And you don't need eabispe either. > + } else { > + set options "-mvsx" > + check_runtime_nocache ppc_ieee128_ok { > + int main() > + { > + __ieee128 a; > + return 0; > + } > + } $options > + } Why do you use -mvsx while we actually need a superset of that? Segher