Re: [PATCH, RFC] Avoid the -D option which is not available install-sh

2019-02-18 Thread Iain Buclaw
On Sat, 16 Feb 2019 at 13:58, Bernd Edlinger wrote: > > On 2/9/19 7:21 PM, Bernd Edlinger wrote: > > On 2/9/19 7:18 PM, Jakub Jelinek wrote: > >> On Sat, Feb 09, 2019 at 06:11:00PM +, Bernd Edlinger wrote: > >>> --- libphobos/libdruntime/Makefile.am (revision 268614) > >>> +++ libphobos/

Re: [build] Fix libgphobos linking on Solaris 11

2019-02-18 Thread Iain Buclaw
On Tue, 27 Nov 2018 at 23:28, Rainer Orth wrote: > > As mentioned in passing in PR d/87864, libgphobos.so currently fails to > link before Solaris 11.4. Until then, you needed to link with -lsocket > -lnsl for the networking functions, in S11.4 they were merged into libc. > > To fix this, I've ad

Re: [libphobos, build] Enable libphobos on Solaris 11/x86

2019-02-18 Thread Iain Buclaw
On Tue, 29 Jan 2019 at 13:35, Rainer Orth wrote: > > With the set of libphobos Solaris patches just posted, it would become > possible to enable libphobos on Solaris 11/x86 by default. > > This is what this patch does. > > * It uses a LIBPHOBOS_SUPPORTED variable both in toplevel configure and >

[C++ PATCH] Ensure constexpr evaluation is done on pre-cp_fold_function bodies (PR c++/89285)

2019-02-18 Thread Jakub Jelinek
Hi! As mentioned in the PR, we've regressed on the trunk in diagnostics of some invalid constexpr evaluations. The problem is that the constexpr evaluation is effectively done on post-cp_fold_function bodies/arguments and cp_fold optimizes away some important trees for constexpr diagnostics, eith

[PR fortran/89266, patch] - ICE with TRANSFER of len=0 character array constructor

2019-02-18 Thread Harald Anlauf
The issue in the PR is caused during simplification in the frontend because it does not properly differentiate between expressions of size 0 (e.g. arrays of length 0 or character strings of len=0) and failure. The attached patch tries to solve this problem by modifying the helper functions gfc_ele

Re: [PATCH] Teach evrp that main's argc argument is always non-negative for C family (PR tree-optimization/89350)

2019-02-18 Thread Segher Boessenkool
Hi Jakub, On Sat, Feb 16, 2019 at 08:12:34AM +0100, Jakub Jelinek wrote: > Both the C and C++ standard guarantee that the argc argument to main is > non-negative, the following patch sets (or adjusts) the corresponding > SSA_NAME_RANGE_INFO. I think this should test for flag_hosted somehow? And

[C++ PATCH] Don't ICE on invalid scoped enum E::~E (PR c++/89390)

2019-02-18 Thread Jakub Jelinek
Hi! On the following testcase we ICE because name is BIT_NOT_EXPR and suggest_alternative_in_scoped_enum assumes it is called on IDENTIFIER_NODE only. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? There is another issue, starting with 7.x we don't use sensibl

Re: [PATCH] Teach evrp that main's argc argument is always non-negative for C family (PR tree-optimization/89350)

2019-02-18 Thread Jakub Jelinek
On Mon, Feb 18, 2019 at 04:47:57PM -0600, Segher Boessenkool wrote: > On Sat, Feb 16, 2019 at 08:12:34AM +0100, Jakub Jelinek wrote: > > Both the C and C++ standard guarantee that the argc argument to main is > > non-negative, the following patch sets (or adjusts) the corresponding > > SSA_NAME_RAN

[C++ PATCH] Avoid ICE on void to type&& reinterpret_cast (PR c++/89391)

2019-02-18 Thread Jakub Jelinek
Hi! The if (TYPE_REF_IS_RVALUE (type)) code has been added recently, but build_target_expr_with_type asserts that the expression doesn't have void type. Fixed by using the old handling in that case (the expression is not lvalue in that case and diagnostics is emitted if complain). Bootstrapped/r

[C++ PATCH] Fix maybe_generic_this_capture ICE on USING_DECL (PR c++/89387)

2019-02-18 Thread Jakub Jelinek
Hi! On the following testcase, id_expr is false and TREE_CODE (*iter) is USING_DECL (and the following one is FUNCTION_DECL). Since the USING_DECL changes, this ICEs because DECL_NONSTATIC_MEMBER_FUNCTION_P uses TREE_TYPE which can't be used here. Previously, I believe DECL_NONSTATIC_MEMBER_FUNCTI

Re: [PATCH] Teach evrp that main's argc argument is always non-negative for C family (PR tree-optimization/89350)

2019-02-18 Thread Segher Boessenkool
On Mon, Feb 18, 2019 at 11:55:56PM +0100, Jakub Jelinek wrote: > On Mon, Feb 18, 2019 at 04:47:57PM -0600, Segher Boessenkool wrote: > > On Sat, Feb 16, 2019 at 08:12:34AM +0100, Jakub Jelinek wrote: > > > Both the C and C++ standard guarantee that the argc argument to main is > > > non-negative, t

Re: Fix libphobos testsuite failures on Solaris

2019-02-18 Thread Iain Buclaw
On Tue, 29 Jan 2019 at 15:44, Rainer Orth wrote: > > Yet another trivial fix for a Solaris libphobos testsuite failure: > > FAIL: libphobos.shared/load.d -shared-libphobos -ldl (test for excess errors) > Excess errors: > /vol/gcc/src/hg/trunk/local/libphobos/testsuite/libphobos.shared/load.d:9: >

Re: [PATCH] Teach evrp that main's argc argument is always non-negative for C family (PR tree-optimization/89350)

2019-02-18 Thread Joseph Myers
On Sat, 16 Feb 2019, Jakub Jelinek wrote: > Hi! > > Both the C and C++ standard guarantee that the argc argument to main is > non-negative, the following patch sets (or adjusts) the corresponding > SSA_NAME_RANGE_INFO. While main is just one, with IPA VRP it can also > propagate etc. I had to c

Re: [PATCH, libphobos] Detect if qsort_r is available (PR d/88127)

2019-02-18 Thread Iain Buclaw
On Sat, 2 Feb 2019 at 11:01, Johannes Pfau wrote: > > Adds a configure test for qsort_r and use the fallback code path if > it's not available. Fixes d/88127. rt/qsort.d changes have been > pushed upstream and reviewed there: > https://github.com/dlang/druntime/pull/2480 > Bootstrapped & ran D te

Re: [C++ Patch] PR 84536 ("[7/8/9 Regression] ICE with non-type template parameter")

2019-02-18 Thread Jason Merrill
On 2/18/19 12:14 PM, Paolo Carlini wrote: Hi Jason, On 18/02/19 19:28, Jason Merrill wrote: On 2/18/19 5:31 AM, Paolo Carlini wrote: Hi Jason, On 18/02/19 10:20, Jason Merrill wrote: On 2/17/19 6:58 AM, Paolo Carlini wrote: Hi, here, when we don't see an initializer we believe we are surel

Re: [C++ PATCH] Don't ICE on invalid scoped enum E::~E (PR c++/89390)

2019-02-18 Thread Jason Merrill
On 2/18/19 12:50 PM, Jakub Jelinek wrote: Hi! On the following testcase we ICE because name is BIT_NOT_EXPR and suggest_alternative_in_scoped_enum assumes it is called on IDENTIFIER_NODE only. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. There is an

Re: [C++ PATCH] Avoid ICE on void to type&& reinterpret_cast (PR c++/89391)

2019-02-18 Thread Jason Merrill
On 2/18/19 12:58 PM, Jakub Jelinek wrote: Hi! The if (TYPE_REF_IS_RVALUE (type)) code has been added recently, but build_target_expr_with_type asserts that the expression doesn't have void type. Fixed by using the old handling in that case (the expression is not lvalue in that case and diagnost

Re: [C++ PATCH] Fix maybe_generic_this_capture ICE on USING_DECL (PR c++/89387)

2019-02-18 Thread Jason Merrill
On 2/18/19 1:02 PM, Jakub Jelinek wrote: Hi! On the following testcase, id_expr is false and TREE_CODE (*iter) is USING_DECL (and the following one is FUNCTION_DECL). Since the USING_DECL changes, this ICEs because DECL_NONSTATIC_MEMBER_FUNCTION_P uses TREE_TYPE which can't be used here. Previou

Re: [C++ PATCH] Fix cxx_eval_store_expression (PR c++/89336)

2019-02-18 Thread Jason Merrill
On 2/17/19 3:34 AM, Jakub Jelinek wrote: On Sat, Feb 16, 2019 at 08:51:33AM -1000, Jason Merrill wrote: The likely case is still that nothing has changed in between, so this patch just quickly verifies if that is the case (by comparing CONSTRUCTOR_ELT (ctor, 0) with the previously saved value of

Re: [C++ Patch] PR 84536 ("[7/8/9 Regression] ICE with non-type template parameter")

2019-02-18 Thread Paolo Carlini
Hi, On 19/02/19 00:52, Jason Merrill wrote: On 2/18/19 12:14 PM, Paolo Carlini wrote: Hi Jason, On 18/02/19 19:28, Jason Merrill wrote: On 2/18/19 5:31 AM, Paolo Carlini wrote: Hi Jason, On 18/02/19 10:20, Jason Merrill wrote: On 2/17/19 6:58 AM, Paolo Carlini wrote: Hi, here, when we do

Re: [C++ Patch] PR 84536 ("[7/8/9 Regression] ICE with non-type template parameter")

2019-02-18 Thread Jason Merrill
On 2/18/19 3:15 PM, Paolo Carlini wrote: Hi, On 19/02/19 00:52, Jason Merrill wrote: On 2/18/19 12:14 PM, Paolo Carlini wrote: Hi Jason, On 18/02/19 19:28, Jason Merrill wrote: On 2/18/19 5:31 AM, Paolo Carlini wrote: Hi Jason, On 18/02/19 10:20, Jason Merrill wrote: On 2/17/19 6:58 AM, P

Re: [C++ PATCH] Ensure constexpr evaluation is done on pre-cp_fold_function bodies (PR c++/89285)

2019-02-18 Thread Jason Merrill
On 2/18/19 12:45 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, we've regressed on the trunk in diagnostics of some invalid constexpr evaluations. The problem is that the constexpr evaluation is effectively done on post-cp_fold_function bodies/arguments and cp_fold optimizes away some imp

PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-18 Thread Martin Sebor
Please let me know what it will take to get the fix for these two issues approved. I've answered the questions so I don't know what else I'm expected to do here. https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00793.html On 2/11/19 12:20 PM, Martin Sebor wrote: This is a repost of a patch for

Re: [committed] Fix set_uids_in_ptset (PR middle-end/89303)

2019-02-18 Thread Jonathan Wakely
On 18/02/19 21:22 +0100, Jakub Jelinek wrote: On Mon, Feb 18, 2019 at 09:15:39PM +0100, Rainer Orth wrote: 2019-02-15 Rainer Orth * g++.dg/torture/pr89303.C (bad_weak_ptr): Rename to bad_weak_ptr_. Ok, thanks. If needed, guess we could rename much more (or rename the namesp

Re: [REVISED PATCH 5/9]: C++ P0482R5 char8_t: Standard library support

2019-02-18 Thread Jonathan Wakely
On 08/02/19 12:56 +, Jonathan Wakely wrote: On 07/02/19 23:35 -0500, Tom Honermann wrote: On 2/7/19 4:44 AM, Jonathan Wakely wrote: On 23/12/18 21:27 -0500, Tom Honermann wrote: Attached is a revised patch that addresses changes in P0482R6.  Changes from the prior patch include: - Updated

Re: [REVISED PATCH 7/9]: C++ P0482R5 char8_t: New standard library tests

2019-02-18 Thread Jonathan Wakely
On 07/02/19 23:39 -0500, Tom Honermann wrote: On 2/7/19 4:54 AM, Jonathan Wakely wrote: On 23/12/18 21:27 -0500, Tom Honermann wrote: Attached is a revised patch that addresses changes in P0482R6.  Changes from the prior patch include: - Updated the value of the __cpp_char8_t feature test macr

Re: [PATCH, GCC] PR target/86487: fix the way 'uses_hard_regs_p' handles paradoxical subregs

2019-02-18 Thread Vladimir Makarov
On 2019-02-15 6:35 a.m., Andre Vieira (lists) wrote: Hi Vlad, On 13/02/2019 16:46, Vladimir Makarov wrote: On 2019-02-13 5:54 a.m., Andre Vieira (lists) wrote: PING. Since Jeff is away can another maintainer have a look at this please? I see the following patch Yeah I uploaded the wro

Re: [C++ PATCH] Ensure constexpr evaluation is done on pre-cp_fold_function bodies (PR c++/89285)

2019-02-18 Thread Jakub Jelinek
On Mon, Feb 18, 2019 at 04:04:15PM -1000, Jason Merrill wrote: > > --- gcc/cp/constexpr.c.jj 2019-02-17 17:09:47.113351897 +0100 > > +++ gcc/cp/constexpr.c 2019-02-18 19:34:57.995136395 +0100 > > @@ -1269,6 +1301,49 @@ cxx_eval_builtin_function_call (const co > > return t; > >

[PATCH] luoxhu - backport from trunk r255555, r257253 and r258137

2019-02-18 Thread luoxhu
From: Xiong Hu Luo This is a backport of r25, r257253 and r258137 of trunk to gcc-7-branch. The patches were on trunk before GCC 8 forked already. Totally 5 files need mannual resolve due to code changes for r25. r257253 and r258137 are dependent testcases require vsx support need merge t

<    1   2