Re: [PATCH 11/25] Simplify vec_merge according to the mask.

2018-09-27 Thread Richard Sandiford
Andrew Stubbs writes: > On 26/09/18 17:48, Richard Sandiford wrote: >> Andrew Stubbs writes: >>> + /* Nested vec_merge. */ >>> + rtx nvm = gen_rtx_VEC_MERGE (mode, vm1, vm2, mask1); >>> + ASSERT_EQ (vm1, simplify_merge_mask (nvm, mask1, 0)); >>> + ASSERT_EQ (vm2, simplify_merge_mask (nvm, ma

Re: [PATCH] Fix PR87440, extra lexical block in inline instances

2018-09-27 Thread Richard Biener
On Wed, 26 Sep 2018, Jason Merrill wrote: > On Wed, Sep 26, 2018 at 9:35 AM, Richard Biener wrote: > > > > We do not create a DW_AT_lexical_block for the outermost block in > > functions but we do for DW_AT_inlined_subroutines. That makes > > debuginfo look like if there were two of each local,

[PATCH] GCOV: introduce --json-format.

2018-09-27 Thread Martin Liška
Hi. For some time we've been providing an intermediate format as output of GCOV tool. It's documented in our code that primary consumer of it is lcov. Apparently that's not true: https://github.com/linux-test-project/lcov/issues/38#issuecomment-371203750 So that I decided to come up with providin

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Richard Biener
On Wed, 26 Sep 2018, Qing Zhao wrote: > > > On Sep 26, 2018, at 6:07 PM, Alexander Monakov wrote: > > > > On Wed, 26 Sep 2018, Qing Zhao wrote: > >> The request is for application developers who want to use gcc's online > >> patching feature. > >> > >> Today, developers can turn off inlining

[Committed] S/390: Implement speculation barrier

2018-09-27 Thread Andreas Krebbel
gcc/ChangeLog: 2018-09-27 Andreas Krebbel * config/s390/s390.md (PPA_TX_ABORT, PPA_OOO_BARRIER): New constant definitions. ("tx_assist"): Replace magic number with PPA_TX_ABORT. ("*ppa"): Enable pattern also for -march=zEC12 -mno-htm. ("speculation_barri

Re: [PATCH, GCC/ARM] Fix PR87374: ICE with -mslow-flash-data and -mword-relocations

2018-09-27 Thread Kyrill Tkachov
Hi Thomas, On 26/09/18 18:39, Thomas Preudhomme wrote: Hi, GCC ICEs under -mslow-flash-data and -mword-relocations because there is no way to load an address, both literal pools and MOVW/MOVT being forbidden. This patch gives an error message when both options are specified by the user and adds

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Richard Sandiford
Tamar Christina writes: > Hi All, > > Currently some target supports checks such as vect_int cache their > results in a manner that would cause them not to be rechecked when > running the same tests against a different variant in a multi variant > run. This causes tests to be skipped or run when

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Richard Sandiford
Richard Sandiford writes: > If instead you want to support "return" (would be nice IMO), you could > use something like: > > set code [catch {uplevel eval $args} result options] > if {$code != 0 && $code != 2} { > return -code $code $result > } > set et_cache($prop,$target) $

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Alexander Monakov
On Wed, 26 Sep 2018, Qing Zhao wrote: > I don’t think a -Os-like option will do the job. > > As Jeff already mentioned in a very previous email: > > “Presumably one of the cases where this capability is really helpful is > things like ksplice. If you have a function with global scope that has >

[PATCH] ASAN: emit line information of stack variables.

2018-09-27 Thread Martin Liška
Hi. I've noticed ASAN can inform user about location of stack variables when a stack violation is detected. Sample example: ... This frame has 3 object(s): [32, 36) 'counter' (line 3) <== Memory access at offset 36 overflows this variable [96, 100) 'size' (line 5) [160, 164) 'leng

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Jan Hubicka
> On Wed, 26 Sep 2018, Qing Zhao wrote: > > The request is for application developers who want to use gcc's online > >patching feature. > > > > Today, developers can turn off inlining and deliver just the patched > > routine. They > >can also allow all inlining and deliver the patched ro

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Jan Hubicka
> > Okay, I see. > > > > > If you make this to be INTERPOSABLE (which means it can be replaced by > > different > > implementation by linker and that is probably what we want for live > > patching) > > then also inliner, ipa-sra and other optimization will give up on these. > > do you suggest

Re: [PATCH] PR86957

2018-09-27 Thread Richard Biener
On Mon, Sep 24, 2018 at 9:14 PM Indu Bhagat wrote: > > Done. Attached is updated patch. > > Patch is tested on x86_64 You obviously did _not_ properly test the patch since it causes a bunch of new testsuite failures: FAIL: g++.dg/pr60518.C -std=gnu++11 (test for excess errors) FAIL: g++.dg/pr60

Re: [PATCH][GCC][AArch64] Add support for SVE stack clash probing [patch (2/7)]

2018-09-27 Thread Tamar Christina
Hi All, It turns out the testsuite didn't have a case in it which would cause a significant enough spill to enter the loop. After creating one I noticed a bug in the loop and fixed it. The loops are now .cfi_startproc mov x15, sp cntbx16, all, mul #11 add

Re: [PATCH] PR86957

2018-09-27 Thread Martin Liška
On 9/27/18 11:47 AM, Richard Biener wrote: > On Mon, Sep 24, 2018 at 9:14 PM Indu Bhagat wrote: >> >> Done. Attached is updated patch. >> >> Patch is tested on x86_64 > > You obviously did _not_ properly test the patch since it causes a > bunch of new testsuite > failures: > > FAIL: g++.dg/pr605

Re: [PATCH, GCC/ARM] Fix PR87374: ICE with -mslow-flash-data and -mword-relocations

2018-09-27 Thread Ramana Radhakrishnan
On 27/09/2018 09:26, Kyrill Tkachov wrote: Hi Thomas, On 26/09/18 18:39, Thomas Preudhomme wrote: Hi, GCC ICEs under -mslow-flash-data and -mword-relocations because there is no way to load an address, both literal pools and MOVW/MOVT being forbidden. This patch gives an error message when bot

Re: [PATCH, GCC/ARM] Fix PR87374: ICE with -mslow-flash-data and -mword-relocations

2018-09-27 Thread Kyrill Tkachov
On 27/09/18 11:13, Ramana Radhakrishnan wrote: On 27/09/2018 09:26, Kyrill Tkachov wrote: Hi Thomas, On 26/09/18 18:39, Thomas Preudhomme wrote: Hi, GCC ICEs under -mslow-flash-data and -mword-relocations because there is no way to load an address, both literal pools and MOVW/MOVT being for

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Tamar Christina
Hi Richard, Thanks for the review! The 09/27/2018 09:40, Richard Sandiford wrote: > Tamar Christina writes: > > > > and no testsuite errors. Difference would depend on your site.exp. > > On arm we get about 4500 new testcases and on aarch64 the low 10s. > > On PowerPC and x86_64 no changes as ex

Re: [PR 87415] handle 1 bit bit fields in set_value_range_with_overflow()

2018-09-27 Thread Richard Biener
On Wed, Sep 26, 2018 at 7:46 PM Aldy Hernandez wrote: > > As I've said in the PR... > > For a 1-bit signed field we are trying to subtract the following ranges: > > [0, 0] - VR_VARYING > > Mathematically these are: > > [MAX, MAX] - [MIN, MAX] > [0, 0] - [MIN, MAX] > => [0, 0] - [-1, 0]

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread Richard Biener
On Wed, Sep 26, 2018 at 8:11 PM H.J. Lu wrote: > > Add -mzero-caller-saved-regs=[skip|used|all] command-line option and > zero_caller_saved_regs("skip|used|all") function attribue: > > 1. -mzero-caller-saved-regs=skip and zero_caller_saved_regs("skip") > > Don't zero caller-saved integer registers

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Richard Biener
On Thu, 27 Sep 2018, Jan Hubicka wrote: > > On Wed, 26 Sep 2018, Qing Zhao wrote: > > > The request is for application developers who want to use gcc's online > > >patching feature. > > > > > > Today, developers can turn off inlining and deliver just the patched > > > routine. They > > >

Re: [PATCH][GCC][AArch64] Add support for SVE stack clash probing [patch (2/7)]

2018-09-27 Thread Richard Sandiford
> It turns out the testsuite didn't have a case in it which would cause a > significant enough spill to enter the loop. After creating one I noticed a > bug > in the loop and fixed it. > > The loops are now > > .cfi_startproc > mov x15, sp > cntbx16, all, mul #11 >

Re: [PATCH 2/4] Remove unused functions and fields.

2018-09-27 Thread Bernhard Reutner-Fischer
On Wed, 26 Sep 2018 10:59:02 +0200 Martin Liška wrote: > On 9/25/18 3:34 PM, Jeff Law wrote: > > On 9/25/18 6:19 AM, Richard Biener wrote: > >> On Tue, Sep 25, 2018 at 9:09 AM Martin Liška > >> wrote: > >>> > >>> On 9/24/18 4:42 PM, Jeff Law wrote: > On 9/22/18 1:08 PM, marxin wrote:

Re: [Patch, Aarch64] Testsuite patch to fix one of the regressions in PR 87433, gcc.target/aarch64/ashltidisi.c

2018-09-27 Thread Kyrill Tkachov
Hi Steve, On 26/09/18 15:44, Steve Ellcey wrote: The patch for PR rtl-optimization/85160 which allowed combine to convert two instructions into two different instructions if they had a lower cost caused a couple of regressions on aarch64. This patch fixes one of them. After the above patch, t

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Richard Sandiford
Tamar Christina writes: > The 09/27/2018 09:40, Richard Sandiford wrote: >> Tamar Christina writes: >> > @@ -120,22 +121,41 @@ proc check_cached_effective_target { prop args } { >> > global et_prop_list >> > >> > set target [current_target_name] >> > -if {![info exists et_cache($pr

Re: [PATCH 07/25] [pr82089] Don't sign-extend SFV 1 in BImode

2018-09-27 Thread Andrew Stubbs
On 26/09/18 17:25, Richard Sandiford wrote: OK, thanks. Committed, thanks. Andrew

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

2018-09-27 Thread Martin Jambor
Hi, (this message is a part of the thread originating with https://gcc.gnu.org/ml/gcc-patches/2018-09/msg01018.html) On Thu, Sep 27 2018, Jan Hubicka wrote: >> > If you make this to be INTERPOSABLE (which means it can be replaced by >> > different >> > implementation by linker and that is probab

Re: OpenCoarrays integration with gfortran

2018-09-27 Thread Richard Biener
On Mon, Sep 24, 2018 at 12:58 PM Alastair McKinstry wrote: > > > On 23/09/2018 10:46, Toon Moene wrote: > > On 09/22/2018 01:23 AM, Jerry DeLisle wrote: > > > > I just installed opencoarrays on my system at home (Debian Testing): > > > > root@moene:~# apt-get install libcoarrays-openmpi-dev > > ..

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread H.J. Lu
On Thu, Sep 27, 2018 at 3:52 AM, Richard Biener wrote: > On Wed, Sep 26, 2018 at 8:11 PM H.J. Lu wrote: >> >> Add -mzero-caller-saved-regs=[skip|used|all] command-line option and >> zero_caller_saved_regs("skip|used|all") function attribue: >> >> 1. -mzero-caller-saved-regs=skip and zero_caller_s

Re: [PATCH, AArch64 00/11] LSE atomics out-of-line

2018-09-27 Thread Ramana Radhakrishnan
On 26/09/2018 06:03, rth7...@gmail.com wrote: From: Richard Henderson ARMv8.1 adds an (mandatory) Atomics extension, also known as the Large System Extension. Deploying this extension at the OS level has proved challenging. The following is the result of a conversation between myself, Alex Gr

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread Szabolcs Nagy
On 26/09/18 19:10, H.J. Lu wrote: Add -mzero-caller-saved-regs=[skip|used|all] command-line option and zero_caller_saved_regs("skip|used|all") function attribue: 1. -mzero-caller-saved-regs=skip and zero_caller_saved_regs("skip") Don't zero caller-saved integer registers upon function return.

Re: [PATCH, AArch64 10/11] aarch64: Implement TImode compare-and-swap

2018-09-27 Thread Matthew Malcomson
Hi Richard, I don't have any comment on the overall aim of the patch series, but in this particular patch implementing casp it looks like you doesn't ensure the register pairs for casp are even-odd. This is the restriction in the Arm Arm decode for casp variants as  if Rs<0> == '1' then Unall

Re: [PATCH] PR86957

2018-09-27 Thread Martin Liška
On 9/27/18 12:14 PM, Martin Liška wrote: > On 9/27/18 11:47 AM, Richard Biener wrote: >> On Mon, Sep 24, 2018 at 9:14 PM Indu Bhagat wrote: >>> >>> Done. Attached is updated patch. >>> >>> Patch is tested on x86_64 >> >> You obviously did _not_ properly test the patch since it causes a >> bunch of

Add Header to libstdc++

2018-09-27 Thread connor horman
Changelog: For C++2a Support: Add header in libstdc++ top level (From C++2a Working Draft) If __cplusplus is greater than 201703L (indicates C++2a): To namespace std, add span class. The Definition of span used is https://en.cppreference.com/w/cpp/container/span. Notes: Current Static-Extent spans

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread H.J. Lu
On Thu, Sep 27, 2018 at 6:08 AM, Szabolcs Nagy wrote: > On 26/09/18 19:10, H.J. Lu wrote: >> >> Add -mzero-caller-saved-regs=[skip|used|all] command-line option and >> zero_caller_saved_regs("skip|used|all") function attribue: >> >> 1. -mzero-caller-saved-regs=skip and zero_caller_saved_regs("skip

Re: [PATCH] Fix PR87440, extra lexical block in inline instances

2018-09-27 Thread Jason Merrill
On Thu, Sep 27, 2018 at 3:28 AM, Richard Biener wrote: > On Wed, 26 Sep 2018, Jason Merrill wrote: > >> On Wed, Sep 26, 2018 at 9:35 AM, Richard Biener wrote: >> > >> > We do not create a DW_AT_lexical_block for the outermost block in >> > functions but we do for DW_AT_inlined_subroutines. That

[PATCH][GCC][AARCH64]Introduce aarch64 atomic_{load,store}ti patterns

2018-09-27 Thread Matthew Malcomson
[PATCH][GCC][AARCH64] Introduce aarch64 atomic_{load,store}ti patterns In Armv8.4-a these patterns use the LDP/STP instructions that are guaranteed to be single-copy atomic, ensure correct memory ordering semantics by using the DMB instruction. We put the use of these inline expansions behind a c

Re: [PATCH] GCOV: introduce --json-format.

2018-09-27 Thread David Malcolm
On Thu, 2018-09-27 at 09:46 +0200, Martin Liška wrote: > Hi. > > For some time we've been providing an intermediate format as > output of GCOV tool. It's documented in our code that primary > consumer of it is lcov. Apparently that's not true: > https://github.com/linux-test-project/lcov/issues/38

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread Rich Felker
On Wed, Sep 26, 2018 at 11:10:29AM -0700, H.J. Lu wrote: > Add -mzero-caller-saved-regs=[skip|used|all] command-line option and > zero_caller_saved_regs("skip|used|all") function attribue: Minor nit, but could this be named -mzero-call-clobbered-regs? "Caller-saved" is a misnomer and inconsistent

[PATCH][GCC][AARCH64] Add even-pair register classes

2018-09-27 Thread Matthew Malcomson
Hello, LSE instructions like casp require even-odd pairs of registers. Other instructions that take a pair of registers don't have this restriction. As mentioned in the internals documentation, a limitation of forcing a register pair to start with an even register can't be enforced by defining an

Re: [PATCH 11/25] Simplify vec_merge according to the mask.

2018-09-27 Thread Andrew Stubbs
On 27/09/18 08:16, Richard Sandiford wrote: On keeping the complexity down: if (side_effects_p (x)) return NULL_RTX; makes this quadratic for chains of unary operations. Is it really needed? The code after it simply recurses on operands and doesn't discard anything itself, so it looks

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Tamar Christina
> > > > The error you would get if you do this is very confusing so I thought > > since it didn't matter much for the regexp only target triple tests > > that just accepting this would be fine. > > Seems a good thing that that's a noisy failure; the function should > make up its mind whether it wa

[PATCH] Fix PR87451

2018-09-27 Thread Richard Biener
differen comment chars. Tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-09-27 Richard Biener PR testsuite/87451 * gcc.dg/debug/dwarf2/inline5.c: Deal with different comment characters. Index: gcc/testsuite/gcc.dg/debug/dwarf2/inline5.c ==

Re: [PATCH] PR86957

2018-09-27 Thread Richard Biener
On Thu, Sep 27, 2018 at 3:10 PM Martin Liška wrote: > > On 9/27/18 12:14 PM, Martin Liška wrote: > > On 9/27/18 11:47 AM, Richard Biener wrote: > >> On Mon, Sep 24, 2018 at 9:14 PM Indu Bhagat wrote: > >>> > >>> Done. Attached is updated patch. > >>> > >>> Patch is tested on x86_64 > >> > >> You

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread Richard Biener
On Thu, Sep 27, 2018 at 3:16 PM H.J. Lu wrote: > > On Thu, Sep 27, 2018 at 6:08 AM, Szabolcs Nagy wrote: > > On 26/09/18 19:10, H.J. Lu wrote: > >> > >> Add -mzero-caller-saved-regs=[skip|used|all] command-line option and > >> zero_caller_saved_regs("skip|used|all") function attribue: > >> > >> 1

Re: [PATCH, AArch64 00/11] LSE atomics out-of-line

2018-09-27 Thread Alexander Graf
> Am 27.09.2018 um 15:07 schrieb Ramana Radhakrishnan > : > >> On 26/09/2018 06:03, rth7...@gmail.com wrote: >> From: Richard Henderson >> ARMv8.1 adds an (mandatory) Atomics extension, also known as the >> Large System Extension. Deploying this extension at the OS level >> has proved challe

Re: [PATCH][GCC][AARCH64] Add even-pair register classes

2018-09-27 Thread Matthew Malcomson
I had a superfluous #include in the testcase and some spelling mistakes in documentation -- corrected patch attached. On 27/09/18 15:02, Matthew Malcomson wrote: Hello, LSE instructions like casp require even-odd pairs of registers. Other instructions that take a pair of registers don't have

Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.

2018-09-27 Thread Richard Sandiford
Tamar Christina writes: >> > >> > The error you would get if you do this is very confusing so I thought >> > since it didn't matter much for the regexp only target triple tests >> > that just accepting this would be fine. >> >> Seems a good thing that that's a noisy failure; the function should >

Re: [PATCH 11/25] Simplify vec_merge according to the mask.

2018-09-27 Thread Richard Sandiford
Andrew Stubbs writes: > On 27/09/18 08:16, Richard Sandiford wrote: >> On keeping the complexity down: >> >>if (side_effects_p (x)) >> return NULL_RTX; >> >> makes this quadratic for chains of unary operations. Is it really >> needed? The code after it simply recurses on operands and

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Qing Zhao
> On Sep 27, 2018, at 2:45 AM, Richard Biener wrote: > > On Wed, 26 Sep 2018, Qing Zhao wrote: > >> >>> On Sep 26, 2018, at 6:07 PM, Alexander Monakov wrote: >>> >>> On Wed, 26 Sep 2018, Qing Zhao wrote: The request is for application developers who want to use gcc's online patch

Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions

2018-09-27 Thread Qing Zhao
> On Sep 27, 2018, at 3:58 AM, Jan Hubicka wrote: > >> >> Okay, I see. >> >>> >>> If you make this to be INTERPOSABLE (which means it can be replaced by >>> different >>> implementation by linker and that is probably what we want for live >>> patching) >>> then also inliner, ipa-sra and ot

Re: [PATCH, AArch64 10/11] aarch64: Implement TImode compare-and-swap

2018-09-27 Thread Richard Henderson
On 9/27/18 6:04 AM, Matthew Malcomson wrote: > Hi Richard, > > > On 26/09/18 06:03, rth7...@gmail.com wrote: >> From: Richard Henderson >> >> This pattern will only be used with the __sync functions, because >> we do not yet have a bare TImode atomic load. >> >> > I don't have any comment on the

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

2018-09-27 Thread Qing Zhao
Thanks, Martin, for all these interesting information. Looks like that a more general option to help live-patching is needed. I will do a little more study on this direction. Qing > On Sep 27, 2018, at 7:19 AM, Martin Jambor wrote: > > Hi, > > (this message is a part of the thread originatin

Re: [PATCH, AArch64 00/11] LSE atomics out-of-line

2018-09-27 Thread Richard Henderson
On 9/27/18 6:07 AM, Ramana Radhakrishnan wrote: > I do have an additional concern that I forgot to mention in Vancouver - > > Thanks Wilco for reminding me that this now replaces a bunch of inline > instructions with effectively a library call therefore clobbering a whole > bunch > of caller save

Re: [PATCH, AArch64 10/11] aarch64: Implement TImode compare-and-swap

2018-09-27 Thread Matthew Malcomson
On 27/09/18 17:32, Richard Henderson wrote: On 9/27/18 6:04 AM, Matthew Malcomson wrote: Hi Richard, On 26/09/18 06:03, rth7...@gmail.com wrote: From: Richard Henderson This pattern will only be used with the __sync functions, because we do not yet have a bare TImode atomic load. I don't

[PATCH][AArch64] Support zero-extended move to FP register

2018-09-27 Thread Wilco Dijkstra
The popcount expansion uses SIMD instructions acting on 64-bit values. As a result a popcount of a 32-bit integer requires zero-extension before moving the zero-extended value into an FP register. This patch adds support for zero-extended int->FP moves to avoid the redundant uxtw. Similarly, add

[gomp5] Initial OpenMP 5 task reduction support

2018-09-27 Thread Jakub Jelinek
Hi! I've committed following patch to add WIP task reduction support to GCC. Right now it is only supported for task_reduction clauses on taskgroup directive and matching in_reduction clauses on task directives. When registering the reductions, the runtime allocates memory holding array of blocks

Re: [PATCH] declare tree_to_shwi et al. nonnull and pure

2018-09-27 Thread Jeff Law
On 9/26/18 5:54 PM, Martin Sebor wrote: > The attached patch adds attributes nonnull and pure to > tree_to_shwi() and a small number of other heavily used functions > that will benefit from both. > > First, I noticed that there are a bunch of functions in tree.c that > deal gracefully with null po

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

2018-09-27 Thread Christophe Lyon
On Wed, 26 Sep 2018 at 17:26, Martin Jambor wrote: > > Hi, > > On Wed, Sep 26 2018, Christophe Lyon wrote: > > On Tue, 25 Sep 2018 at 17:50, Martin Jambor wrote: > >> > >> Hi, > >> > >> On Mon, Sep 24 2018, Christophe Lyon wrote: > >> > On Mon, 24 Sep 2018 at 20:46, Martin Jambor wrote: > >> >>

Re: Support excess precision for integer / floating-point comparisons (PR c/87390)

2018-09-27 Thread Christophe Lyon
Hi Joseph, On Wed, 26 Sep 2018 at 23:15, Joseph Myers wrote: > > In C11, implicit conversions from integer to floating-point types > produce results with the range and precision of the corresponding > evaluation format rather than only those of the type implicitly > converted to. This patch impl

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread Florian Weimer
* H. J. Lu: > +@item zero_caller_saved_regs("@var{choice}") > +@cindex @code{zero_caller_saved_regs} function attribute, x86 > +On x86 targets, the @code{zero_caller_saved_regs} attribute causes the > +compiler to zero caller-saved integer registers at function return with > +@var{choice}. @samp{

Re: Support excess precision for integer / floating-point comparisons (PR c/87390)

2018-09-27 Thread Joseph Myers
On Thu, 27 Sep 2018, Christophe Lyon wrote: > After this patch I've noticed regressions on > fp-int-convert-float16-timode.c > gcc.dg/torture/fp-int-convert-float16.c > on aarch64 and arm (at execution time) Does this patch help? Index: gcc/testsuite/gcc.dg/torture/fp-int-convert.h =

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread H.J. Lu
On Thu, Sep 27, 2018 at 7:57 AM, Richard Biener wrote: > On Thu, Sep 27, 2018 at 3:16 PM H.J. Lu wrote: >> >> On Thu, Sep 27, 2018 at 6:08 AM, Szabolcs Nagy wrote: >> > On 26/09/18 19:10, H.J. Lu wrote: >> >> >> >> Add -mzero-caller-saved-regs=[skip|used|all] command-line option and >> >> zero_c

Re: [gomp5] Initial OpenMP 5 task reduction support

2018-09-27 Thread Jakub Jelinek
On Thu, Sep 27, 2018 at 07:38:20PM +0200, Jakub Jelinek wrote: > task-reduction-5.C testcase still fails, need to fix up passing of the > remapped original address properly even for C/C++ array reductions. Fixed thusly, committed to gomp-5_0-branch. 2018-09-27 Jakub Jelinek * omp-low.

[PATCH] rs6000: Delete many HAVE_AS_* (PR87149)

2018-09-27 Thread Segher Boessenkool
This deletes most HAVE_AS_* that determine if the assembler supports some ISA level (and also HAVE_AS_MFPGPR and HAVE_AS_DFP). These are not useful: we will only generate an instruction that requires some newer ISA if the user specifically asked for it (with -mcpu=, say). If the assembler cannot h

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread H.J. Lu
On Thu, Sep 27, 2018 at 12:24 PM, Florian Weimer wrote: > * H. J. Lu: > >> +@item zero_caller_saved_regs("@var{choice}") >> +@cindex @code{zero_caller_saved_regs} function attribute, x86 >> +On x86 targets, the @code{zero_caller_saved_regs} attribute causes the >> +compiler to zero caller-saved in

Re: RFC: [PATCH] x86: Add -mzero-caller-saved-regs=[skip|used|all]

2018-09-27 Thread H.J. Lu
On Thu, Sep 27, 2018 at 7:01 AM, Rich Felker wrote: > On Wed, Sep 26, 2018 at 11:10:29AM -0700, H.J. Lu wrote: >> Add -mzero-caller-saved-regs=[skip|used|all] command-line option and >> zero_caller_saved_regs("skip|used|all") function attribue: > > Minor nit, but could this be named -mzero-call-cl

[PATCH, i386]: Remove fpcr register definition

2018-09-27 Thread Uros Bizjak
This is actually an unused register, there is no point to define it. 2018-09-27 Uros Bizjak * config/i386/i386.md (FPCR_REG): Remove. (x86_fnstcw_1): Use (const_int 0) instead of FPCR_REG. (x86_fldcw_1): Remove insn pattern. (fnstenv): Do not clobber FPCR_REG. (fldenv): Dit

Re: libgo patch committed: Update to 1.11 release

2018-09-27 Thread Uros Bizjak
On Wed, Sep 26, 2018 at 5:18 PM, Ian Lance Taylor wrote: > On Wed, Sep 26, 2018 at 12:57 AM, Uros Bizjak wrote: >>> I've committed a patch to update libgo to the 1.11 release. As usual >>> for these updates, the patch is too large to attach to this e-mail >>> message. I've attached some of the

Re: [Ada] Introduce -gnatd_A to set Opt.Disable_ALI_File

2018-09-27 Thread Alexandre Oliva
On Sep 26, 2018, Pierre-Marie de Rodat wrote: > This will allow us to remove the import of flag_compare_debug in > lib-writ.adb in a second stage. And here's the second stage. Tested on x86_64-linux-gnu. Ok to install? [Ada] use -gnatd_A to disable .ali on -fcompare-debug recompile From: Al

Re: [PATCH 11/25] Simplify vec_merge according to the mask.

2018-09-27 Thread Andrew Stubbs
On 27/09/18 17:19, Richard Sandiford wrote: But we wouldn't recurse for PRE_INC, MEM or ASM_OPERANDS, since they have the wrong rtx class. AFAICT no current unary, binary or ternary operator has that level of side-effect (and that's a good thing). OK, in that case I'll remove it and we can cro

Re: [PATCH 15/25] Don't double-count early-clobber matches.

2018-09-27 Thread Andrew Stubbs
On 17/09/18 10:18, Richard Sandiford wrote: The idea looks good to me FWIW, but you can't use curr_static_id for the state, since that's a static description of the .md pattern rather than data about this particular instance. I clearly misunderstood what that was for. This patch does the same

[PATCH] rs6000: Fix one more vec_splat case

2018-09-27 Thread Segher Boessenkool
This fixed the one remaining case where the stricter vec_splat checking complains in the testsuite. Committing. 2018-09-27 Segher Boessenkool gcc/testsuite/ * g++.dg/ext/altivec-6.C: Change the vec_splat second argument to a valid value, in the "vector bool int" case. --- g

Re: [PATCH] declare tree_to_shwi et al. nonnull and pure

2018-09-27 Thread Martin Sebor
On 09/27/2018 12:25 PM, Jeff Law wrote: On 9/26/18 5:54 PM, Martin Sebor wrote: The attached patch adds attributes nonnull and pure to tree_to_shwi() and a small number of other heavily used functions that will benefit from both. First, I noticed that there are a bunch of functions in tree.c th

Re: C++ PATCH to implement P1064R0, Virtual Function Calls in Constant Expressions (v4)

2018-09-27 Thread Marek Polacek
On Thu, Sep 27, 2018 at 01:15:46AM -0400, Jason Merrill wrote: > On Thu, Sep 20, 2018 at 5:20 AM, Jakub Jelinek wrote: > > On Thu, Sep 20, 2018 at 09:12:53AM +0200, Andreas Schwab wrote: > >> On Sep 19 2018, Jason Merrill wrote: > >> > >> > Andreas, do the new testcases pass? That would surprise

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-27 Thread Carl Love
Segher: I have addressed the various formatting and other minor issues.   I checked to see if the builtins worked with -msoft-float, which they didn't. I added checks for the -msoft-float into the functions: rs6000_expand_set_fpscr_rn_builtin(),  rs6000_expand_set_fpscr_drn_builtin(), rs6000_ex

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-27 Thread Segher Boessenkool
Hi! On Thu, Sep 27, 2018 at 04:17:57PM -0700, Carl Love wrote: > + if (icode == CODE_FOR_rs6000_mffsl > + && rs6000_isa_flags_explicit & OPTION_MASK_SOFT_FLOAT) > +fatal_error (input_location, > + "__builtin_mffsl() not supported with -msoft-float"); Please use plain "error

Re: C++ PATCH to implement P1064R0, Virtual Function Calls in Constant Expressions (v4)

2018-09-27 Thread Jason Merrill
On Thu, Sep 27, 2018, 7:08 PM Marek Polacek wrote: > On Thu, Sep 27, 2018 at 01:15:46AM -0400, Jason Merrill wrote: > > On Thu, Sep 20, 2018 at 5:20 AM, Jakub Jelinek wrote: > > > On Thu, Sep 20, 2018 at 09:12:53AM +0200, Andreas Schwab wrote: > > >> On Sep 19 2018, Jason Merrill wrote: > > >>

Re: C++ PATCH to implement P1064R0, Virtual Function Calls in Constant Expressions (v4)

2018-09-27 Thread Jakub Jelinek
On Thu, Sep 27, 2018 at 07:08:41PM -0400, Marek Polacek wrote: > > This patch is OK. And your suggestion for cxx_eval_call_expression > > sounds right, too. Marek, will you follow up on that? > > Ok, I will (provided I can get a box that has TARGET_VTABLE_USES_DESCRIPTORS, > I > think ppc64 BE

Re: [Ada] Introduce -gnatd_A to set Opt.Disable_ALI_File

2018-09-27 Thread Arnaud Charlet
>> This will allow us to remove the import of flag_compare_debug in >> lib-writ.adb in a second stage. > > And here's the second stage. Tested on x86_64-linux-gnu. Ok to install? This is OK, thanks. > [Ada] use -gnatd_A to disable .ali on -fcompare-debug recompile > > From: Alexandre Oliva