Re: ubsan PATCH to fix compile-time hog with operator overloading (PR sanitizer/78208)

2016-11-17 Thread Jakub Jelinek
On Wed, Nov 16, 2016 at 04:29:05PM -0800, Marek Polacek wrote: > Sorry. So consider the following: > > class S > { > virtual void foo () = 0; > }; > > struct T { > T &operator << (const char *s); > }; > > T t; > > void > S::foo () > { > t << "a" << "b" << "c"; > } > > Before > 1498

Re: [PATCH][2/2] GIMPLE Frontend, middle-end changes

2016-11-17 Thread Richard Biener
On Wed, 16 Nov 2016, Jeff Law wrote: > On 10/28/2016 05:51 AM, Richard Biener wrote: > > > > These are the middle-end changes and additions to the testsuite. > > > > They are pretty self-contained, I've organized the changelog > > entries below in areas of changes: > > > > 1) dump changes - we

Re: [PATCH Obvious]Adjust test string wrto update dump info for gcc.target/arm/ivopts-orig_biv-inc.c

2016-11-17 Thread Richard Biener
On Wed, Nov 16, 2016 at 6:18 PM, Bin Cheng wrote: > Hi, > Dump information of IVOPT has been updated while test string > gcc.target/arm/ivopts-orig_biv-inc.c is not. This patch does this. Test > result checked on arm-none-eabi. Commit as obvious? Yes. RIchard. > Thanks, > bin > > gcc/tests

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-17 Thread Richard Biener
On Wed, Nov 16, 2016 at 6:20 PM, Bin Cheng wrote: > Hi, > Currently test gfortran.dg/vect/fast-math-mgrid-resid.f checks all predictive > commoning opportunities for all possible loops. This makes it fragile > because vectorizer may peel the loop differently, as well as may choose > different

Re: Fix PR78154

2016-11-17 Thread Richard Biener
On Wed, 16 Nov 2016, Jeff Law wrote: > On 11/16/2016 05:17 PM, Martin Sebor wrote: > > > > > > > (I've heard some noise in C++-land about making memcpy(0,0,0) valid, but > > > that may have just been noise) > > > > We may have read the same discussion. It would make some things > > a little ea

Re: [PATCH] Fix PR78333

2016-11-17 Thread Christophe Lyon
On 16 November 2016 at 10:35, Richard Biener wrote: > > Since GCC 4.6 we aggressively prune bodies of GNU extern inline functions > which means that instrumenting them via -finstrument-functions doesn't > work because that takes the address of the function. Fixed by not > instrumenting those func

Re: Fix PR78154

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > Hi Richard, > Following your suggestion in PR78154, the patch checks if stmt > contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p > and returns true in that case. > > Bootstrapped+tested on x86_64-unknown-linux-gnu. > Cross-test

Re: PR78319

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > On 17 November 2016 at 03:20, Jeff Law wrote: > > On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: > >> > >> Hi, > >> As discussed in PR, this patch marks the test-case to xfail on > >> arm-none-eabi. > >> OK to commit ? > > > > You might check

Re: [PATCH, GCC/ARM] Fix PR77904: callee-saved register trashed when clobbering sp

2016-11-17 Thread Thomas Preudhomme
On 16/11/16 10:30, Kyrill Tkachov wrote: Hi Thomas, On 03/11/16 16:52, Thomas Preudhomme wrote: Hi, When using a callee-saved register to save the frame pointer the Thumb-1 prologue fails to save the callee-saved register before that. For ARM and Thumb-2 targets the frame pointer is handled as

Re: [PATCH] Fix PR78333

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Christophe Lyon wrote: > On 16 November 2016 at 10:35, Richard Biener wrote: > > > > Since GCC 4.6 we aggressively prune bodies of GNU extern inline functions > > which means that instrumenting them via -finstrument-functions doesn't > > work because that takes the address of

Re: [PATCH] Fix PR78333

2016-11-17 Thread Rainer Orth
Hi Christophe, > The new testcase fails to link on bare-metal targets (arm/aarch64): > /cc4ckSGA.o: In function `main': > pr78333.c:(.text+0x1c): undefined reference to `__cyg_profile_func_enter' > pr78333.c:(.text+0x34): undefined reference to `__cyg_profile_func_exit' > collect2: error: ld retur

Re: [PATCH] Fix PR78333

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Rainer Orth wrote: > Hi Christophe, > > > The new testcase fails to link on bare-metal targets (arm/aarch64): > > /cc4ckSGA.o: In function `main': > > pr78333.c:(.text+0x1c): undefined reference to `__cyg_profile_func_enter' > > pr78333.c:(.text+0x34): undefined reference to

Re: [PATCH] Fix up ICEs with TREE_CONSTANT references (PR c++/78373)

2016-11-17 Thread Richard Biener
On Wed, 16 Nov 2016, Jason Merrill wrote: > On Wed, Nov 16, 2016 at 4:00 PM, Jakub Jelinek wrote: > > Jason's recent patch to turn reference vars initialized with invariant > > addresses broke the first testcase below, because &self->singleton > > is considered TREE_CONSTANT (because self is TREE

Re: [PATCH, GCC/ARM] Make arm_feature_set agree with type of FL_* macros

2016-11-17 Thread Kyrill Tkachov
On 16/11/16 18:09, Thomas Preudhomme wrote: Hi, I've rebased the patch to make arm_feature_set agree with type of FL_* macros on top of trunk rather than on top of the optional -mthumb patch. That involved doing the changes to gcc/config/arm/arm-protos.h rather than gcc/config/arm/arm-flags.h.

Re: [PATCH, GCC/ARM] Fix PR77904: callee-saved register trashed when clobbering sp

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 08:56, Thomas Preudhomme wrote: On 16/11/16 10:30, Kyrill Tkachov wrote: Hi Thomas, On 03/11/16 16:52, Thomas Preudhomme wrote: Hi, When using a callee-saved register to save the frame pointer the Thumb-1 prologue fails to save the callee-saved register before that. For ARM and T

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

2016-11-17 Thread Kyrill Tkachov
On 09/11/16 12:58, Bernd Edlinger wrote: Hi! This patch enables the ldrd/strd peephole rules unconditionally. It is meant to fix cases, where the patch to reduce the sha512 stack usage splits ldrd/strd instructions into separate ldr/str insns, but is technically independent from the other pat

[PATCH][AArch64] Fix gcc.dg/torture/float32-builtin.c with RTL checking

2016-11-17 Thread Kyrill Tkachov
Hi all, Testing with RTL checking enabled showed another failure in gcc.dg/torture/float32-builtin.c. aarch64_float_const_zero_rtx_p was passed down a complex subreg expression during combine/recog. The pattern was supposed to reject that expression but it made its way to aarch64_float_const_z

Re: [Patch 1/5] OpenACC tile clause support, OMP_CLAUSE_TILE adjustments

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 5:38 PM, Jakub Jelinek wrote: > Hi! > > On Thu, Nov 10, 2016 at 06:44:52PM +0800, Chung-Lin Tang wrote: > > Above this it is fine. > >> @@ -9388,10 +9373,23 @@ gimplify_omp_for (tree *expr_p, gimple_seq *pre_p) >> (OMP_FOR_INIT (for_stm

Re: [PATCH][AArch64] Fix gcc.dg/torture/float32-builtin.c with RTL checking

2016-11-17 Thread James Greenhalgh
On Thu, Nov 17, 2016 at 09:26:35AM +, Kyrill Tkachov wrote: > Hi all, > > Testing with RTL checking enabled showed another failure in > gcc.dg/torture/float32-builtin.c. > aarch64_float_const_zero_rtx_p was passed down a complex subreg expression > during combine/recog. > The pattern was sup

Re: [PATCH] Fix PR78333

2016-11-17 Thread Rainer Orth
Hi Richard, >> Probably providing dummy implemenations as in the original testcase in >> the PR is enough? > > Maybe { dg-require weak } plus weak definitions of the cyg_profile funcs? > Or simply restrict the test to { target *-*-linux* }? the only existing dg-do run testcase (gcc.dg/20001117-1.

Re: [Patch 2/5] OpenACC tile clause support, omp-low parts

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 6:00 PM, Jakub Jelinek wrote: > On Thu, Nov 10, 2016 at 06:45:10PM +0800, Chung-Lin Tang wrote: >> 2016-XX-XX Nathan Sidwell >> >> * internal-fn.def (GOACC_DIM_POS): Comment may be overly >> conservative. >> (GOACC_TILE): New. >> * internal-fn.c (expand_GOA

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 6:30 PM, Jakub Jelinek wrote: > On Thu, Nov 10, 2016 at 06:46:16PM +0800, Chung-Lin Tang wrote: >> 2016-XX-XX Nathan Sidwell >> >> c/ >> * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. >> (c_parser_oacc_clause_tile): Disallow collapse. Fix parsin

Re: Fix PR78154

2016-11-17 Thread Prathamesh Kulkarni
On 17 November 2016 at 14:21, Richard Biener wrote: > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > >> Hi Richard, >> Following your suggestion in PR78154, the patch checks if stmt >> contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p >> and returns true in that case. >> >>

Re: [PATCH] Fix PR77848

2016-11-17 Thread Richard Biener
On Thu, Nov 17, 2016 at 4:14 AM, Bill Schmidt wrote: > On 11/16/16 9:08 AM, Richard Biener wrote: > >> On Tue, Nov 15, 2016 at 9:03 PM, Bill Schmidt >> wrote: >>> - if ((any_pred_load_store || any_complicated_phi) >>> - && !version_loop_for_if_conversion (loop)) >>> + /* Since we have no c

Re: [PATCH] Fix PR78333

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Rainer Orth wrote: > Hi Richard, > > >> Probably providing dummy implemenations as in the original testcase in > >> the PR is enough? > > > > Maybe { dg-require weak } plus weak definitions of the cyg_profile funcs? > > Or simply restrict the test to { target *-*-linux* }? >

Re: Fix PR78154

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > On 17 November 2016 at 14:21, Richard Biener wrote: > > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > > > >> Hi Richard, > >> Following your suggestion in PR78154, the patch checks if stmt > >> contains call to memmove (and friends) in gimple_

Re: [PATCH, ARM] PR71607: New approach to arm_disable_literal_pool

2016-11-17 Thread Ramana Radhakrishnan
On Thu, Oct 6, 2016 at 2:57 PM, Andre Vieira (lists) wrote: > Hello, > > This patch tackles the issue reported in PR71607. This patch takes a > different approach for disabling the creation of literal pools. Instead > of disabling the patterns that would normally transform the rtl into > actual li

Re: [PATCH, GCC/ARM] Fix PR77933: stack corruption on ARM when using high registers and lr

2016-11-17 Thread Kyrill Tkachov
On 09/11/16 16:41, Thomas Preudhomme wrote: I've reworked the patch following comments from Wilco [1] (sorry could not find it in my MUA for some reason). [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00317.html == Context == When saving registers, function thumb1_expand_prologue () aim

Re: [PATCH 0/6][ARM] Implement support for ACLE Coprocessor Intrinsics

2016-11-17 Thread Kyrill Tkachov
Hi Andre, On 09/11/16 10:00, Andre Vieira (lists) wrote: Hello, This patch series aims to implement support for the ACLE coprocessor intrinsics. To do so I first refactor the NEON builtin framework to accommodate the usage of this framework to implement other builtins. I then port the existing

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-17 Thread Bin.Cheng
On Thu, Nov 17, 2016 at 8:32 AM, Richard Biener wrote: > On Wed, Nov 16, 2016 at 6:20 PM, Bin Cheng wrote: >> Hi, >> Currently test gfortran.dg/vect/fast-math-mgrid-resid.f checks all >> predictive commoning opportunities for all possible loops. This makes it >> fragile because vectorizer may

Re: [PATCH] Fix PR78333

2016-11-17 Thread Christophe Lyon
On 17 November 2016 at 10:53, Richard Biener wrote: > On Thu, 17 Nov 2016, Rainer Orth wrote: > >> Hi Richard, >> >> >> Probably providing dummy implemenations as in the original testcase in >> >> the PR is enough? >> > >> > Maybe { dg-require weak } plus weak definitions of the cyg_profile funcs?

Re: [PATCH 0/6][ARM] Implement support for ACLE Coprocessor Intrinsics

2016-11-17 Thread Andre Vieira (lists)
Hi Kyrill, On 17/11/16 10:11, Kyrill Tkachov wrote: > Hi Andre, > > On 09/11/16 10:00, Andre Vieira (lists) wrote: >> >> Tested the series by bootstrapping arm-none-linux-gnuabihf and found no >> regressions, also did a normal build for arm-none-eabi and ran the >> acle.exp tests for a Cortex-M3

Re: [PATCH 1/6][ARM] Refactor NEON builtin framework to work for other builtins

2016-11-17 Thread Kyrill Tkachov
Hi Andre, On 09/11/16 10:11, Andre Vieira (lists) wrote: Hi, Refactor NEON builtin framework such that it can be used to implement other builtins. Is this OK for trunk? Regards, Andre gcc/ChangeLog 2016-11-09 Andre Vieira * config/arm/arm-builtins.c (neon_builtin_datum): Rename to .

Re: [PATCH 0/6][ARM] Implement support for ACLE Coprocessor Intrinsics

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 10:31, Andre Vieira (lists) wrote: Hi Kyrill, On 17/11/16 10:11, Kyrill Tkachov wrote: Hi Andre, On 09/11/16 10:00, Andre Vieira (lists) wrote: Tested the series by bootstrapping arm-none-linux-gnuabihf and found no regressions, also did a normal build for arm-none-eabi and ran t

Re: [PATCH] [ARC] Add support for QuarkSE processor.

2016-11-17 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-16 11:30:35 +0100]: > Updated QuarkSE patch. > > Ok to apply? Looks fine. Thanks, Andrew > Claudiu > > gcc/ > 2016-05-25 Claudiu Zissulescu > > * config/arc/arc-arches.def: Add FPX quarkse instruction as valid > for arcem. > * config/arc

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-17 Thread Richard Biener
On Thu, Nov 17, 2016 at 11:26 AM, Bin.Cheng wrote: > On Thu, Nov 17, 2016 at 8:32 AM, Richard Biener > wrote: >> On Wed, Nov 16, 2016 at 6:20 PM, Bin Cheng wrote: >>> Hi, >>> Currently test gfortran.dg/vect/fast-math-mgrid-resid.f checks all >>> predictive commoning opportunities for all possib

Re: [PATCH v2 2/2, expand] make expand_builtin_strncmp more general

2016-11-17 Thread Richard Biener
On Wed, Nov 16, 2016 at 8:22 PM, Aaron Sawdey wrote: > This patch makes expand_builtin_strncmp attempt to expand via cmpstrnsi > even if neither of the string arguments are string constants. Ok. Thanks, Richard. > 2016-11-16 Aaron Sawdey > > * builtins.c (expand_builtin_strncmp): Att

Re: [PATCH][AArch64] Expand DImode constant stores to two SImode stores when profitable

2016-11-17 Thread Kyrill Tkachov
Ping. Thanks, Kyrill On 10/11/16 09:08, Andrew Pinski wrote: On Thu, Nov 10, 2016 at 1:04 AM, Kyrill Tkachov wrote: Ping. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00040.html Andrew, do you have any objections to this version? Not really. Thanks, Andrew Thanks, Kyrill On 01/11/16 15

Re: [PATCH 4/4] [ARC] Fix compilation issue in pr71872.

2016-11-17 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-16 11:18:01 +0100]: > gcc/ > 2016-07-21 Claudiu Zissulescu > > * config/arc/arc.c (arc_ccfsm_post_advance): Handle return > instruction type. Looks fine. Thanks, Andrew > --- > gcc/config/arc/arc.c | 5 ++--- > 1 file changed, 2 insertions(+),

Re: [PATCH v2 1/2, i386] cmpstrnsi needs string length

2016-11-17 Thread Bernd Schmidt
On 11/16/2016 08:22 PM, Aaron Sawdey wrote: I've also changed the pattern to indicate that operand 3 may be clobbered (if it happens to be in cx already). That part looks like a meaningless change since the pattern in that define_expand is never used (there's a DONE at the end). I don't thin

Re: [PATCH v2 1/2, i386] cmpstrnsi needs string length

2016-11-17 Thread Uros Bizjak
On Wed, Nov 16, 2016 at 8:22 PM, Aaron Sawdey wrote: > This patch adds a test to the cmpstrnsi pattern in i386.md so that it > will bail out (FAIL) if neither of the strings is a constant string. It > can only work as a proper strncmp if the length is not longer than both > of the strings. This ch

RE: [PATCH,gcc/MIPS] Make loongson3a use fused madd.d

2016-11-17 Thread Matthew Fortune
Hi Jeff, Am I OK to accept this change without copyright assignment from Paul? The change is small and there is no other way it could be implemented anyway if I had someone write it from scratch. Thanks, Matthew > -Original Message- > From: Paul Hua [mailto:paul.hua...@gmail.com] > Sent

[PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Andrew Burgess
In the case where we access a single bit from a value and use this in a EQ/NE comparison, GCC will convert this into a sign-extend and GE/LT comparison. Normally this would be fine, however, if the value is in CMEM memory, then we don't have a sign-extending load available (using the special short

[C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Paolo Carlini
Hi, this rather old issue points out that, for the snippet below in the legacy -std=c++98 and -pedantic, we issue an hard error instead of a pedwarn - what we normally do, as clarified by Manuel. I guess we could imagine further clean-ups in this area but something as simple as the below seem

[PATCH] Fix PR78383 middle-end ICE

2016-11-17 Thread Richard Biener
The following fixes the ICE part of PR78383. We ICE when trying to turn a computed goto to a CFG edge when we know the label but that label is in another function (IPA propagation exposed this knowledge). The transform shows that we miss a DECL_NONLOCAL on the label because we happily miscompile

Re: [PATCH][AArch64] Expand DImode constant stores to two SImode stores when profitable

2016-11-17 Thread James Greenhalgh
On Tue, Nov 01, 2016 at 03:21:29PM +, Kyrill Tkachov wrote: > Here it is. > I've confirmed that it emits to STRs for 4 byte aligned stores when > -mtune=thunderx > and still generates STP for the other tunings, though now sched-fusion is > responsible for > merging them, which is ok by me. >

[PATCH] Remove -ftree-loop-if-convert-stores

2016-11-17 Thread Richard Biener
This removes a no longer used option, whether we if-convert stores now depends on --param allow-store-data-races and/or the availability of masked stores. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-11-17 Richard Biener * common.opt (ftree-loop-if-co

RE: [PATCH 1/4] [ARC] Various fixes.

2016-11-17 Thread Claudiu Zissulescu
Hi Andrew, Please ignore this patch for the time being. I would like to double check the add_n/sub_n patterns. Sorry for this detour, Claudiu > -Original Message- > From: Claudiu Zissulescu > Sent: Wednesday, November 16, 2016 11:18 AM > To: gcc-patches@gcc.gnu.org > Cc: Claudiu Zissule

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2016-11-17 Thread Toma Tabacu
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Andrew Bennett > Sent: 03 November 2016 11:33 > To: Matthew Fortune; 'Moore, Catherine'; 'gcc-patches@gcc.gnu.org' > Subject: RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard > library su

RE: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Claudiu Zissulescu
Hi Andrew, Approved, please apply, but ... > +(define_peephole2 > + [(set (match_operand:SI 0 "register_operand" "") > +(sign_extend:SI > + (match_operand:QI 1 "any_mem_operand" ""))) > + (set (reg:CC_ZN CC_REG) > + (compare:CC_ZN (match_dup 0) > + (c

Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Rainer Orth
I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems to be covered by the free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even though https://g

Re: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-17 13:02:02 +]: > Hi Andrew, > > Approved, please apply, but ... > > > +(define_peephole2 > > + [(set (match_operand:SI 0 "register_operand" "") > > +(sign_extend:SI > > + (match_operand:QI 1 "any_mem_operand" ""))) > > + (set (reg:CC_ZN CC

RE: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Claudiu Zissulescu
> > Note on tests: It will be nice to add a test where the added > > peephole kicks in. If you consider to add this test to the current > > patch, please resubmit it. > > There were cmem-bit-{1,2,3,4}.c added in that patch. All of which > fail for me without the peephole, and work with the peeph

Re: [PATCH, GCC/ARM] Fix ICE when compiling empty FIQ interrupt handler in ARM mode

2016-11-17 Thread Christophe Lyon
On 16 November 2016 at 10:39, Kyrill Tkachov wrote: > > On 09/11/16 16:19, Thomas Preudhomme wrote: >> >> Hi, >> >> This patch fixes the following ICE when building when compiling an empty >> FIQ interrupt handler in ARM mode: >> >> empty_fiq_handler.c:5:1: error: insn does not satisfy its constra

RE: [PATCH 4/4] [ARC] Fix compilation issue in pr71872.

2016-11-17 Thread Claudiu Zissulescu
> Looks fine. > > Thanks, > Andrew > Committed, thank you for your review, Claudiu

RE: [PATCH] [ARC] Add support for QuarkSE processor.

2016-11-17 Thread Claudiu Zissulescu
> > Looks fine. > Committed, thank you for your review, Claudiu

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2016-11-17 Thread Matthew Fortune
Toma Tabacu writes: > Hi, > > The patch below is a rebased version of Andrew's patch plus a few more changes > to test options. > > I have tested Andrew's patch by passing -msoft-float to the testsuite without > having a soft-float library available, and saw that the > inline-memcpy-{1,2,3,4,5}

RE: [PATCH 2/2] [ARC] Update target specific tests.

2016-11-17 Thread Claudiu Zissulescu
> These entries should be going into the gcc/testsuite/ChangeLog file, > and so don't need the "testsuite/" prefix. > Ups :) Fix it. > Otherwise I'm happy for this to be merged. I've only skimmed the > change, but assuming you've run the tests this all seems good. Results of running arc.exp on

[patch,avr,committed] More use of CONST_INT_P, SUBREG_P.

2016-11-17 Thread Georg-Johann Lay
This is a no-op code clean-up that makes more use of SUBREG_P and CONST_INT_P if possible. Applied as obvious. Johann * config/avr/avr.c (avr_print_operand_address): Use CONST_INT_P if appropriate. (ashlqi3_out, ashlsi3_out, ashrqi3_out, ashrhi3_out): Same. (ash

Re: [patch,testsuite] Support dg-require-effective-target label_offsets.

2016-11-17 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > On 04.11.2016 06:18, Senthil Kumar Selvaraj wrote: >> >> Georg-Johann Lay writes: >>> State of matters is that Binutils support is missing, and if I understand >>> you >>> correctly, dg-require is not appropriate to factor out availability of such >>> features? >> >> I

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-17 Thread Bin.Cheng
On Thu, Nov 17, 2016 at 10:53 AM, Richard Biener wrote: > On Thu, Nov 17, 2016 at 11:26 AM, Bin.Cheng wrote: >> On Thu, Nov 17, 2016 at 8:32 AM, Richard Biener >> wrote: >>> On Wed, Nov 16, 2016 at 6:20 PM, Bin Cheng wrote: Hi, Currently test gfortran.dg/vect/fast-math-mgrid-resid.f c

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 14/11/16 14:25, Kyrill Tkachov wrote: On 11/11/16 15:31, Kyrill Tkachov wrote: On 11/11/16 10:17, Kyrill Tkachov wrote: On 10/11/16 23:39, Segher Boessenkool wrote: On Thu, Nov 10, 2016 at 02:42:24PM -0800, Andrew Pinski wrote: On Thu, Nov 10, 2016 at 6:25 AM, Kyrill Tkachov I ran SPE

Re: [PATCH] Fix PR77848

2016-11-17 Thread Bill Schmidt
> On Nov 17, 2016, at 3:42 AM, Richard Biener > wrote: > > On Thu, Nov 17, 2016 at 4:14 AM, Bill Schmidt > wrote: >> >> Yes, the new predicate works fine. New patch below, bootstrapped and tested >> on powerpc64le-unknown-linux-gnu, with only the bb-slp-cond-1.c regressions >> previously dis

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: > >>I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there > >>were > >>some interesting swings. > >>458.sjeng +1.45% > >>471.omnetpp +2.19% > >>445.gobmk -2.01% > >> >

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-17 Thread Thomas Koenig
Well, here is a newer version of the patch. I wrote a few configure tests to check for AVX. This version hast the advantage that, if anybody uses 32-bit programs with AVX, they would also benefit. Jakub, would you be OK with that patch? I do not yet want to commit this because it needs more tes

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 14:44, Segher Boessenkool wrote: Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there were some interesting swings. 458.sjeng +1.45% 471.omnetpp +2.19% 445.gobmk -2.01% On SPECFP:

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
On Thu, Nov 17, 2016 at 02:55:20PM +, Kyrill Tkachov wrote: > >>Overall, there's a slight improvement in SPECINT, even with the gobmk > >>regression and a slightly larger improvement > >>on SPECFP due to povray. > >And that is for only the "normal" GPRs, not LR or FP yet, right? > > This patch

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 15:01, Segher Boessenkool wrote: On Thu, Nov 17, 2016 at 02:55:20PM +, Kyrill Tkachov wrote: Overall, there's a slight improvement in SPECINT, even with the gobmk regression and a slightly larger improvement on SPECFP due to povray. And that is for only the "normal" GPRs, not L

Re: PR78319

2016-11-17 Thread Jeff Law
On 11/17/2016 01:52 AM, Richard Biener wrote: On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: On 17 November 2016 at 03:20, Jeff Law wrote: On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: Hi, As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi. OK to commit ? Y

Re: Fix PR78154

2016-11-17 Thread Jeff Law
On 11/17/2016 01:48 AM, Richard Biener wrote: On Wed, 16 Nov 2016, Jeff Law wrote: On 11/16/2016 05:17 PM, Martin Sebor wrote: (I've heard some noise in C++-land about making memcpy(0,0,0) valid, but that may have just been noise) We may have read the same discussion. It would make some t

Re: [PATCH][2/2] GIMPLE Frontend, middle-end changes

2016-11-17 Thread Jeff Law
On 11/17/2016 01:20 AM, Richard Biener wrote: On Wed, 16 Nov 2016, Jeff Law wrote: On 10/28/2016 05:51 AM, Richard Biener wrote: These are the middle-end changes and additions to the testsuite. They are pretty self-contained, I've organized the changelog entries below in areas of changes:

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Paolo Carlini
... oops, forgot about parser->non_integral_constant_expression_p. The version below, which I'm currently regtesting again, seems more correct. Thanks, Paolo. /// Index: cp/parser.c === --- cp/parser.c (revision 242

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Rainer Orth
Rainer Orth writes: > I happened to notice that my libcilkrts SPARC port has been applied > upstream. So to reach closure on this issue for the GCC 7 release, I'd > like to import upstream into mainline which seems to be covered by the > free-for-all clause in https://gcc.gnu.org/svnwrite.html#p

[PATCH 0/2] PR77822

2016-11-17 Thread Dominik Vogt
The following two patches fix PR 77822 on s390x for gcc-7. As the macro doing the argument range checks can be used on other targets as well, I've put it in system.h (couldn't think of a better place; maybe rtl.h?). Bootstrapped on s390x biarch, regression tested on s390x biarch and s390, all on

Re: [PATCH 2/2] PR77822

2016-11-17 Thread Dominik Vogt
On Thu, Nov 17, 2016 at 04:53:03PM +0100, Dominik Vogt wrote: > The following two patches fix PR 77822 on s390x for gcc-7. As the > macro doing the argument range checks can be used on other targets > as well, I've put it in system.h (couldn't think of a better > place; maybe rtl.h?). > > Bootstr

[committed] Fix locations within raw strings

2016-11-17 Thread David Malcolm
Whilst investigating PR preprocessor/78324 I noticed that the substring location code currently doesn't handle raw strings correctly, by not skipping the 'R', opening quote, delimiter and opening parenthesis. For example, an attempt to underline chars 4-7 with caret at 6 of this raw string yields

Re: [PATCH 1/2] PR77822

2016-11-17 Thread Dominik Vogt
On Thu, Nov 17, 2016 at 04:53:03PM +0100, Dominik Vogt wrote: > The following two patches fix PR 77822 on s390x for gcc-7. As the > macro doing the argument range checks can be used on other targets > as well, I've put it in system.h (couldn't think of a better > place; maybe rtl.h?). > > Bootstr

Fix PR rtl-optimization/78355

2016-11-17 Thread Eric Botcazou
As diagnosed by the submitter, LRA can generate unaligned accesses when SLOW_UNALIGNED_ACCESS is 1, for example when STRICT_ALIGNMENT is 1, because simplify_operand_subreg can wrongly reject aligned accesses when reloading SUBREGs of MEMs in favor of unaligned ones. The fix is to add the missin

Re: [PATCH] Fix PR78333

2016-11-17 Thread Christophe Lyon
On 17 November 2016 at 11:27, Christophe Lyon wrote: > On 17 November 2016 at 10:53, Richard Biener wrote: >> On Thu, 17 Nov 2016, Rainer Orth wrote: >> >>> Hi Richard, >>> >>> >> Probably providing dummy implemenations as in the original testcase in >>> >> the PR is enough? >>> > >>> > Maybe { d

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 08:41:48AM +0100, Thomas Koenig wrote: > Am 17.11.2016 um 00:20 schrieb Jakub Jelinek: > >On Thu, Nov 17, 2016 at 12:03:18AM +0100, Thomas Koenig wrote: > >>>Don't you need to test in configure if the assembler supports AVX? > >>>Otherwise if somebody is bootstrapping gcc wi

Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-17 Thread James Greenhalgh
On Thu, Oct 27, 2016 at 08:44:02PM +, Michael Collison wrote: > This patch is designed to improve code generation for "and" instructions with > certain immediate operands. > > For the following test case: > > int f2(int x) > { >x &= 0x0ff8; > >x &= 0xff001fff; > >return x; >

Patch ping: [PATCH] Fix ICE in default_use_anchors_for_symbol_p (PR middle-end/78201)

2016-11-17 Thread Jakub Jelinek
Hi! On Thu, Nov 10, 2016 at 06:00:29PM +0100, Jakub Jelinek wrote: > On arm/aarch64 we ICE because some decls that make it here has non-NULL > DECL_SIZE, which is a VAR_DECL rather than CONST_INT (or DECL_SIZE that > doesn't fit into shwi would ICE similarly). While it is arguably a FE bug > that

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 14:55, Kyrill Tkachov wrote: On 17/11/16 14:44, Segher Boessenkool wrote: Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there were some interesting swings. 458.sjeng +1.45% 471.omnetp

Re: [PR target/78213] Do not ICE on non-empty -fself-test

2016-11-17 Thread Aldy Hernandez
On 11/14/2016 08:18 AM, Bernd Schmidt wrote: On 11/11/2016 06:10 PM, Aldy Hernandez wrote: The problem in this PR is that -fself-test is being run on a non empty source file. This causes init_emit() to run, which sets: REG_POINTER (virtual_incoming_args_rtx) = 1; Setting REG_POINTER on th

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-17 Thread Jonathan Wakely
On 03/11/16 15:11 +0100, Rainer Orth wrote: Fortunately, this is all easily fixed by wrapping the affected templates in a new macro. That's what this patch does. The new libstdc++ acinclude.m4 test may well need wording changes in comments etc. and can perhaps be shortened a bit, bit it worked

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Ilya Verbin
2016-11-17 18:50 GMT+03:00 Rainer Orth : > Rainer Orth writes: > >> I happened to notice that my libcilkrts SPARC port has been applied >> upstream. So to reach closure on this issue for the GCC 7 release, I'd >> like to import upstream into mainline which seems to be covered by the >> free-for-a

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Jeff Law
On 11/17/2016 09:56 AM, Ilya Verbin wrote: 2016-11-17 18:50 GMT+03:00 Rainer Orth : Rainer Orth writes: I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems

Re: [PATCH] Fix ICE in default_use_anchors_for_symbol_p (PR middle-end/78201)

2016-11-17 Thread Jeff Law
On 11/10/2016 10:00 AM, Jakub Jelinek wrote: Hi! On arm/aarch64 we ICE because some decls that make it here has non-NULL DECL_SIZE, which is a VAR_DECL rather than CONST_INT (or DECL_SIZE that doesn't fit into shwi would ICE similarly). While it is arguably a FE bug that it creates for VLA init

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Jason Merrill
How about changing cp_parser_non_integral_constant_expression to issue a pedwarn instead of error for NIC_FLOAT? Jason

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
On Thu, Nov 17, 2016 at 04:50:46PM +, Kyrill Tkachov wrote: > >>Is loading/storing a pair as cheap as loading/storing a single register? > >>In that case you could shrink-wrap per pair of registers instead. > > > >I suppose it can vary by microarchitecture. For the purposes of codegen > >I'd s

Re: Default associative containers constructors/destructor/assignment

2016-11-17 Thread Jonathan Wakely
On 28/10/16 21:42 +0200, François Dumont wrote: /** * @brief %Map move constructor. - * @param __x A %map of identical element and allocator types. * - * The newly-created %map contains the exact contents of @a __x. - * The contents of @a __x are a va

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-17 Thread Jeff Law
On 11/16/2016 03:12 PM, Andrew Burgess wrote: * Mike Stump [2016-11-16 12:59:53 -0800]: On Nov 16, 2016, at 12:09 PM, Andrew Burgess wrote: My only remaining concern is the new tests, I've tried to restrict them to targets that I suspect they'll pass on with: /* { dg-final-use { scan-as

[PATCH] avoid calling alloca(0)

2016-11-17 Thread Martin Sebor
Testing my patch to warn on overflow in calls to allocation functions (bugs 77531 and 78284): https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01672.html exposed a number of instances of alloca(0) calls in GCC sources. Besides this patch which enables the new warnings with -Wextra (the patch is s

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: > --- a/gcc/fortran/interface.c > +++ b/gcc/fortran/interface.c > @@ -2821,7 +2821,8 @@ compare_actual_formal (gfc_actual_arglist **ap, > gfc_formal_arglist *formal, >for (f = formal; f; f = f->next) > n++; > > - new_arg = X

[PATCH] PR target/78101, Fix PowerPC power9-fusion support

2016-11-17 Thread Michael Meissner
This patch fixes the problem reported in PR 78101 where the power9-fusion support generates an insn that isn't matched: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78101 It also fixes the bug that Andrew Stubbs reported. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01367.html There were two bug

[committed] strncmp builtin expansion improvement

2016-11-17 Thread Aaron Sawdey
Committed to trunk as 242556 after removing the use->clobber change from cmpstrnsi and bootstrap/regtest. gcc/ChangeLog 2016-11-17  Aaron Sawdey   * config/i386/i386.md (cmpstrnsi): New test to bail out if neither string input is a string constant. 2016-11-17  Aaron Sawdey  

Re: [PATCH] PR target/78101, Fix PowerPC power9-fusion support

2016-11-17 Thread Segher Boessenkool
Hi! On Thu, Nov 17, 2016 at 01:55:25PM -0500, Michael Meissner wrote: > Are these patches ok to change into the trunk? Since the bug shows up in GCC > 6.x, can I apply and submit these patches to the GCC 6.x branch? This is okay for trunk. Please watch that for regressions for a week or so befo

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Jason Merrill
On 11/17/2016 04:34 AM, Chung-Lin Tang wrote: + /* These clauses really need a positive integral constant expression, +but we don't have a predicate for that (yet). */ What do you mean? Don't you check this in finish_omp_clauses after the tsubst? Jason

Re: [PATCH, GCC/ARM] Fix ICE when compiling empty FIQ interrupt handler in ARM mode

2016-11-17 Thread Thomas Preudhomme
Hi Christophe, On 17/11/16 13:36, Christophe Lyon wrote: On 16 November 2016 at 10:39, Kyrill Tkachov wrote: On 09/11/16 16:19, Thomas Preudhomme wrote: Hi, This patch fixes the following ICE when building when compiling an empty FIQ interrupt handler in ARM mode: empty_fiq_handler.c:5:1:

Re: [PATCH, GCC/ARM] Fix PR77933: stack corruption on ARM when using high registers and lr

2016-11-17 Thread Thomas Preudhomme
Hi Kyrill, I've committed the following updated patch where the test is restricted to Thumb execution mode and skipping it if not possible since -mtpcs-leaf-frame is only available in Thumb mode. I've considered the change obvious. *** gcc/ChangeLog *** 2016-11-08 Thomas Preud'homme

  1   2   >