> > Note on tests: It will be nice to add a test where the added
> > peephole kicks in. If you consider to add this test to the current
> > patch, please resubmit it.
> 
> There were cmem-bit-{1,2,3,4}.c added in that patch.  All of which
> fail for me without the peephole, and work with the peephole.
> 
> The code generated for L/E ARC is slightly different than the code
> generated for B/E ARC due to how the structures are laid out in
> memory, so, for now I've made parts of the test B/E only.
> 
> In order to get code that is as efficient for L/E as B/E I'd end up
> adding a whole new peeophole, I'd rather not do that - it would be
> extra code to maintain for a combination CMEM+L/E that is not used.  I
> figure we can come back to that if/when that combination ever becomes
> interesting.  I'm hoping you'll be fine with that.
> 

Sure, please go ahead and apply your patch after having the spaces converted ;) 
Claudiu

Reply via email to