Re: [Patch] Fix PR 60040

2016-04-28 Thread Joern Wolfgang Rennecke
On 28/04/16 07:57, Senthil Kumar Selvaraj wrote: diff --git libcilkrts/ChangeLog libcilkrts/ChangeLog index 8fada8a..ed26a3a 100644 --- libcilkrts/ChangeLog +++ libcilkrts/ChangeLog @@ -1,9 +1,3 @@ -2016-04-26 Rainer Orth - - PR target/60290 - * Makefile.am (GENERAL_FLAGS): Add -

Re: [RFC] Update gmp/mpfr/mpc minimum versions

2016-04-28 Thread Richard Biener
On Wed, 27 Apr 2016, Bernd Edlinger wrote: > On 26.04.2016 22:14, Joseph Myers wrote: > > On Tue, 26 Apr 2016, Bernd Edlinger wrote: > > > >> Hi, > >> > >> as we all know, it's high time now to adjust the minimum supported > >> gmp/mpfr/mpc versions for gcc-7. > > > > I think updating the minimum

New Vietnamese PO file for 'gcc' (version 6.1.0)

2016-04-28 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Vietnamese team of translators. The file is available at: http://translationproject.org/latest/gcc/vi.po (This file, 'gcc-6.1.0.vi.po', has j

[PATCH] Fix PR70777

2016-04-28 Thread Richard Biener
The following removes a premature optimization/canonicalization from fold-const.c which is now done by reassoc. This avoids doing this when sincos is not run (at -Og). The reassoc pass now does this transform (and in a more generic way by using powi). I suspect there are a few missed simplifica

[patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Matthias Klose
Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor version is still encoded in the gcj abi, not seen during development of the 6 series until it was bumped for the final release. The gcc-5-branch needs a slightly different approach, because we froze the abi version only

Re: [patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Andrew Haley
On 28/04/16 08:55, Matthias Klose wrote: > Ok for the 6 branch and the trunk? OK, Andrew.

Re: [Patch] Fix PR 60040

2016-04-28 Thread Senthil Kumar Selvaraj
Joern Wolfgang Rennecke writes: > On 28/04/16 07:57, Senthil Kumar Selvaraj wrote: >> diff --git libcilkrts/ChangeLog libcilkrts/ChangeLog >> index 8fada8a..ed26a3a 100644 >> --- libcilkrts/ChangeLog >> +++ libcilkrts/ChangeLog >> @@ -1,9 +1,3 @@ >> -2016-04-26 Rainer Orth >> - >> -PR targ

Re: [PATCH 1/2] [ARC/LIBGCC] Add TLS support.

2016-04-28 Thread Joern Wolfgang Rennecke
On 15/04/16 10:58, Claudiu Zissulescu wrote: TLS mods for libgcc. OK to apply? Claudiu libgcc/ 2016-04-15 Claudiu Zissulescu Joern Rennecke * config/arc/crttls.S: New file. * config/arc/t-arc: New rule. * config.host (arc*-*-elf*, arc*-*-linux*): Add

Re: [patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Rainer Orth
Matthias Klose writes: > Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor > version is still encoded in the gcj abi, not seen during development of the > 6 series until it was bumped for the final release. This is PR java/70839. Rainer -- -

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Maxim Kuvyrkov
> On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: > > Hi Maxim, > > thanks for starting the work on this; I have added the missing > command line option. It builds now and the resulting compiler generates > a linux kernel with the desired properties, so work can continue there. Thanks for work

Re: [PATCH 2/2] [ARC] Add TLS support.

2016-04-28 Thread Joern Wolfgang Rennecke
On 15/04/16 10:58, Claudiu Zissulescu wrote: TLS mods for ARC backend. OK to apply? Claudiu This is using an inefficient TLS global dynamic implementation that would not be expected in a new and/or well-tuned port. However, if you have to work with a legacy runtime, that can't be helped.

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Maxim Kuvyrkov
> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: > > On 27/04/16 16:22, Torsten Duwe wrote: >> Hi Maxim, >> >> thanks for starting the work on this; I have added the missing >> command line option. It builds now and the resulting compiler generates >> a linux kernel with the desired propertie

[PATCH] Re-use cc1-checksum.c for stage-final

2016-04-28 Thread Richard Biener
The following prototype patch re-uses cc1-checksum.c from the previous stage when compiling stage-final. This eventually allows to compare cc1 from the last two stages to fix the lack of a true comparison when doing LTO bootstrap (it compiles LTO bytecode from the compile-stage there, not the fin

Re: [patch] cleanup *finish_omp_clauses

2016-04-28 Thread Jakub Jelinek
On Wed, Apr 27, 2016 at 07:37:17PM -0700, Cesar Philippidis wrote: > This patch replaces all of the bool argument to c_finish_omp_clauses and > finish_omp_clauses in the c and c++ front ends, respectively. Right now > there are three bool arguments, one for is_omp/allow_fields, > declare_simd and i

Re: [PATCH][AArch64][wwwdocs] Summarise some more AArch64 changes for GCC6

2016-04-28 Thread Kyrill Tkachov
On 27/04/16 18:14, Jim Wilson wrote: On Wed, Apr 27, 2016 at 3:33 AM, Kyrill Tkachov wrote: Thanks, I've incorporated your and James' feedback. Since James ok'd the content of the patch from an AArch64 perspective I'll commit this later today if I receive no further feedback. There is no para

Re: [PATCH] operand_equal_p checking (PR sanitizer/70683)

2016-04-28 Thread Christophe Lyon
Hi, This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70843 On 27 April 2016 at 14:41, Richard Biener wrote: > On Wed, 27 Apr 2016, Jakub Jelinek wrote: > >> On Tue, Apr 26, 2016 at 03:02:38PM +0200, Jakub Jelinek wrote: >> > The debugging hack is too ugly and slows down the compiler (by

Re: [ubsan PATCH] Fix compile-time hog with &TARGET_EXPRs (PR sanitizer/70342)

2016-04-28 Thread Jakub Jelinek
On Wed, Apr 27, 2016 at 07:03:25PM +0200, Marek Polacek wrote: > This test took forever to compile with -fsanitize=null, because the > instrumentation was creating incredible amount of duplicated expressions, in a > quadratic fashion. I think the problem is that we instrument &TARGET_EXPR <> > exp

Re: [PATCH GCC]Do more tree if-conversions by handlding PHIs with more than two arguments.

2016-04-28 Thread Richard Biener
On Wed, Apr 27, 2016 at 5:49 PM, Bin Cheng wrote: > Hi, > Currently tree if-conversion only supports PHIs with no more than two > arguments unless the loop is marked with "simd pragma". This patch makes > such PHIs supported unconditionally if they have no more than MAX_PHI_ARG_NUM > arguments

[ARM] Enable __fp16 as a function parameter and return type.

2016-04-28 Thread Matthew Wahab
Hello, The ARM target supports the half-precision floating point type __fp16 but does not allow its use as a function return or parameter type. This patch removes that restriction and defines the ACLE macro __ARM_FP16_ARGS to indicate this. The code generated for passing __fp16 values into and ou

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Matthias Klose
On 27.04.2016 17:56, Dhole wrote: Thanks again for the review Bernd, On 16-04-27 01:33:47, Bernd Schmidt wrote: + epoch = strtoll (source_date_epoch, &endptr, 10); + if ((errno == ERANGE && (epoch == LLONG_MAX || epoch == LLONG_MIN)) + || (errno != 0 && epoch == 0)) +fatal_error (UNK

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Bernd Schmidt
On 04/28/2016 11:20 AM, Matthias Klose wrote: On 27.04.2016 17:56, Dhole wrote: I'm attaching the updated patch with the two minor issues fixed. committed. Something else that occurred to me - could you please also work on a testcase? Bernd

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-04-28 Thread Kyrill Tkachov
On 21/03/16 10:41, Ramana Radhakrishnan wrote: On Fri, Mar 11, 2016 at 3:32 PM, Kyrill Tkachov wrote: Hi all, As reported in the PR we can end up calling fclose twice on a file, causing an error. This patch fixes that by reorganising the logic a bit to ensure we return after closing the file

New German PO file for 'cpplib' (version 6.1.0)

2016-04-28 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/cpplib/de.po (This file, 'cpplib-6.1.0.de.po',

Contents of PO file 'cpplib-6.1.0.de.po'

2016-04-28 Thread Translation Project Robot
cpplib-6.1.0.de.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-04-28 Thread Ramana Radhakrishnan
On Thu, Apr 28, 2016 at 10:24 AM, Kyrill Tkachov wrote: > > On 21/03/16 10:41, Ramana Radhakrishnan wrote: >> >> On Fri, Mar 11, 2016 at 3:32 PM, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> As reported in the PR we can end up calling fclose twice on a file, >>> causing >>> an error. >>> This

RE: [PATCH] [ARC] Add SIMD extensions for ARC HS

2016-04-28 Thread Claudiu Zissulescu
Committed r235551. Thanks, Claudiu > > On 08/04/16 09:30, Claudiu Zissulescu wrote: > > This patch adds support for the new SIMD operations added to ARC HS > > cpu class. The proposed patch doesn't chase for performance but offers > > support for those newly added operations, and autovectorizat

Re: [PATCH 1/6] [ARC] Don't use drsub* instructions when selecting fpuda.

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 15:33, Claudiu Zissulescu wrote: The double precision floating point assist instructions are not implementing the reverse double subtract instruction (drsub) found in the FPX extension, hence, this patch. OK to apply? Claudiu gcc/ 2016-04-18 Claudiu Zissulescu * config

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 11:20:28AM +0200, Matthias Klose wrote: > On 27.04.2016 17:56, Dhole wrote: > >Thanks again for the review Bernd, > > > >On 16-04-27 01:33:47, Bernd Schmidt wrote: > >>>+ epoch = strtoll (source_date_epoch, &endptr, 10); > >>>+ if ((errno == ERANGE && (epoch == LLONG_MAX |

Re: New hashtable power 2 rehash policy

2016-04-28 Thread Jonathan Wakely
On 23/04/16 10:27 +0200, François Dumont wrote: Hi Here is a patch to introduce a new power of 2 based rehash policy. It enhances performance as it avoids modulo float operations. I have updated performance benches and here is the result: 54075.cctr1 benches 455r

Re: [PATCH] Fix type field walking in gimplifier unsharing

2016-04-28 Thread Eric Botcazou
> Aww, I was hoping for sth that would not require me to fix all > frontends ... I don't really see how this can work without DECL_EXPR though. You need to define when the variable-sized expressions are evaluated to lay out the type, otherwise it will be laid out on the first use, which may see

Avoid NULL cfun ICE in gcc/config/nvptx/nvptx.c:nvptx_libcall_value (was: [PATCH] Fix PR70760)

2016-04-28 Thread Thomas Schwinge
Hi! Richard's r235511 changes (quoted below) cause certain nvptx offloading test cases to run into SIGSEGVs: [...] #4 0x00d14193 in nvptx_libcall_value (mode=mode@entry=SImode) at [...]/source-gcc/gcc/config/nvptx/nvptx.c:489 #5 0x00d17a20 in nvptx_function_v

Re: [PATCH 2/6] [ARC] Fix FPX/FPUDA code gen when compiling for big-endian.

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 15:33, Claudiu Zissulescu wrote: OK to apply? Claudiu gcc/ 2016-04-18 Claudiu Zissulescu * config/arc/arc.c (arc_process_double_reg_moves): Fix for big-endian compilation. * config/arc/arc.md (addf3): Likewise. (subdf3): Likewise. (muldf3

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Bernd Schmidt
On 04/28/2016 12:08 PM, Jakub Jelinek wrote: BTW, I think fatal_error doesn't make sense, it isn't something that is not recoverable, normal error or just a warning would be IMHO more than sufficient. The fallback would be just using current time, i.e. ignoring the env var. I thought about thi

Re: [PATCH 3/6] [ARC] Pass mfpuda to assembler.

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 15:33, Claudiu Zissulescu wrote: OK to apply? Claudiu gcc/ 2016-04-18 Claudiu Zissulescu * config/arc/arc.h (ASM_SPEC): Pass mfpuda to assembler. OK.

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 12:31:40PM +0200, Bernd Schmidt wrote: > On 04/28/2016 12:08 PM, Jakub Jelinek wrote: > >BTW, I think fatal_error doesn't make sense, it isn't something that is not > >recoverable, normal error or just a warning would be IMHO more than > >sufficient. The fallback would be j

Re: [RFC patch, i386]: Use STV pass to load/store any TImode constant using SSE insns

2016-04-28 Thread Ilya Enkovich
2016-04-27 22:58 GMT+03:00 Uros Bizjak : > Hello! > > This RFC patch illustrates the idea of using STV pass to load/store > any TImode constant using SSE insns. The testcase: > > --cut here-- > __int128 x; > > __int128 test_1 (void) > { > x = (__int128) 0x00112233; > } > > __int128 test_2 (void)

Re: [RFC patch, i386]: Use STV pass to load/store any TImode constant using SSE insns

2016-04-28 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 01:36:30PM +0300, Ilya Enkovich wrote: > @@ -3145,11 +3168,25 @@ scalar_chain::compute_convert_gain () >|| GET_CODE (src) == IOR >|| GET_CODE (src) == XOR >|| GET_CODE (src) == AND) > - gain += ix86_cost->add; > + {

Re: Avoid NULL cfun ICE in gcc/config/nvptx/nvptx.c:nvptx_libcall_value (was: [PATCH] Fix PR70760)

2016-04-28 Thread Richard Biener
On Thu, 28 Apr 2016, Thomas Schwinge wrote: > Hi! > > Richard's r235511 changes (quoted below) cause certain nvptx offloading > test cases to run into SIGSEGVs: > > [...] > #4 0x00d14193 in nvptx_libcall_value (mode=mode@entry=SImode) > at [...]/source-gcc/gcc/config/nvp

Re: [RFC patch, i386]: Use STV pass to load/store any TImode constant using SSE insns

2016-04-28 Thread Uros Bizjak
On Thu, Apr 28, 2016 at 12:36 PM, Ilya Enkovich wrote: > 2016-04-27 22:58 GMT+03:00 Uros Bizjak : >> Hello! >> >> This RFC patch illustrates the idea of using STV pass to load/store >> any TImode constant using SSE insns. The testcase: >> >> --cut here-- >> __int128 x; >> >> __int128 test_1 (void)

Re: check-target-libgomp wall time, without vs. with offloading

2016-04-28 Thread Thomas Schwinge
Hi! On Thu, 24 Mar 2016 22:42:10 +0100, I wrote: > On Wed, 23 Mar 2016 20:02:01 +0100, Jakub Jelinek wrote: > > On Tue, Mar 22, 2016 at 11:23:43AM +0100, Thomas Schwinge wrote: > > > As discussed in > > > > > >

Re: [RFC patch, i386]: Use STV pass to load/store any TImode constant using SSE insns

2016-04-28 Thread Ilya Enkovich
2016-04-28 13:41 GMT+03:00 Jakub Jelinek : > On Thu, Apr 28, 2016 at 01:36:30PM +0300, Ilya Enkovich wrote: >> @@ -3145,11 +3168,25 @@ scalar_chain::compute_convert_gain () >>|| GET_CODE (src) == IOR >>|| GET_CODE (src) == XOR >>|| GET_CODE (src) == A

Re: Fix PR ada/70759

2016-04-28 Thread Eric Botcazou
> As discussed on gcc@, this removes the internal_reference_types machinery, > which is used only by the Ada compiler for a reason probably long obsolete. > > Tested on x86_64-suse-linux, applied on the mainline. Andreas S. reported the PR against 6.0 so I have backported the patch onto the 6 br

Re: [RFC patch, i386]: Use STV pass to load/store any TImode constant using SSE insns

2016-04-28 Thread Ilya Enkovich
2016-04-28 13:43 GMT+03:00 Uros Bizjak : > On Thu, Apr 28, 2016 at 12:36 PM, Ilya Enkovich > wrote: >> 2016-04-27 22:58 GMT+03:00 Uros Bizjak : >>> Hello! >>> >>> This RFC patch illustrates the idea of using STV pass to load/store >>> any TImode constant using SSE insns. The testcase: >>> >>> --c

Re: [patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Rainer Orth
Rainer Orth writes: > Matthias Klose writes: > >> Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor >> version is still encoded in the gcj abi, not seen during development of the >> 6 series until it was bumped for the final release. > > This is PR java/70839. I just not

Re: [PATCH] Fix type field walking in gimplifier unsharing

2016-04-28 Thread Richard Biener
On Thu, 28 Apr 2016, Eric Botcazou wrote: > > Aww, I was hoping for sth that would not require me to fix all > > frontends ... > > I don't really see how this can work without DECL_EXPR though. You need to > define when the variable-sized expressions are evaluated to lay out the type, > otherw

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Szabolcs Nagy
On 28/04/16 09:47, Maxim Kuvyrkov wrote: >> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: >> >> with -mfentry, by default the user only has to >> implement the fentry call (linux wants nops there, but >> e.g. glibc could use -pg -mfentry for profiling on >> aarch64 and the target specific deta

[Ada] Fix PR ada/70786

2016-04-28 Thread Eric Botcazou
It's a small pasto in one of the variants of Get_Immediate. Tested on x86_64-suse-linux, applied on all active branches. 2016-04-28 Eric Botcazou PR ada/70786 * a-textio.adb (Get_Immediate): Add missing 'not' in expression. -- Eric Botcazou Index: a-textio.adb

Re: Avoid NULL cfun ICE in gcc/config/nvptx/nvptx.c:nvptx_libcall_value (was: [PATCH] Fix PR70760)

2016-04-28 Thread Alexander Monakov
On Thu, 28 Apr 2016, Richard Biener wrote: > Doing anything based on 'cfun' here is fishy at least for the > call context of aggregate_value_p as that is also used when > looking at the caller side of a call for example when expanding calls > where cfun is then the callers cfun and not the callees.

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Torsten Duwe
On Thu, Apr 28, 2016 at 11:39:48AM +0300, Maxim Kuvyrkov wrote: > > On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: > > Your current patch is great for experiments for the kernel engineers to check > if suggested approaches to code patching will work. Still, I prefer to > implement LTO-friend

Re: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 15:33, Claudiu Zissulescu wrote: OK to apply? No. You are clobbering DBL0H. Besides, why would you change any of the code, apart from the argument to #ifdef and the comments?

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Torsten Duwe
On Thu, Apr 28, 2016 at 11:58:25AM +0100, Szabolcs Nagy wrote: > On 28/04/16 09:47, Maxim Kuvyrkov wrote: > >> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: > >> > >> with -mfentry, by default the user only has to > >> implement the fentry call (linux wants nops there, but > >> e.g. glibc coul

RE: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Claudiu Zissulescu
> Besides, why would you change any of the code, apart from the argument > to #ifdef and the comments? It is not working/giving wrong results. I think, the test shows you this if you run it without all the libgcc mods.

Re: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Joern Wolfgang Rennecke
On 28/04/16 12:35, Claudiu Zissulescu wrote: Besides, why would you change any of the code, apart from the argument to #ifdef and the comments? It is not working/giving wrong results. I think, the test shows you this if you run it without all the libgcc mods. I can't. Where exactly does the

Re: Avoid NULL cfun ICE in gcc/config/nvptx/nvptx.c:nvptx_libcall_value

2016-04-28 Thread Bernd Schmidt
On 04/28/2016 01:15 PM, Alexander Monakov wrote: So if my understanding is correct, additional !cfun check can be acceptable as a fix along the existing hack. Perhaps with a note about the nature of the hack. Yes, I think Thomas' patch is ok. Bernd

RE: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Claudiu Zissulescu
> > Where exactly does the test go wrong? I will try to trace it back when I develop it. It passed too long since then. Probably something related with big-endian.

Re: [patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Matthias Klose
On 28.04.2016 12:52, Rainer Orth wrote: Rainer Orth writes: Matthias Klose writes: Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor version is still encoded in the gcj abi, not seen during development of the 6 series until it was bumped for the final release. This

Re: [PATCH 5/6] [ARC] Fix unwanted match for sign extend 16-bit constant.

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 15:33, Claudiu Zissulescu wrote: The combine pass may conclude umulhisi3_imm pattern can accept also sign extended 16-bit constants. This patch prohibits the combine in considering this pattern as suitable. OK to apply? Claudiu gcc/ 2016-04-18 Claudiu Zissulescu * conf

Re: [patch] Don't encode the minor version in the gcj abi version

2016-04-28 Thread Andrew Haley
On 04/28/2016 12:45 PM, Matthias Klose wrote: > yes, that looks good. Can't approve it myself. OK. Andrew.

RE: [PATCH 1/2] [ARC/LIBGCC] Add TLS support.

2016-04-28 Thread Claudiu Zissulescu
Committed r235558. Thanks, Claudiu > > libgcc/ > > 2016-04-15 Claudiu Zissulescu > > Joern Rennecke > > > > * config/arc/crttls.S: New file. > > * config/arc/t-arc: New rule. > > * config.host (arc*-*-elf*, arc*-*-linux*): Add crttls.o. > > - > The libgcc part is OK.

RE: [PATCH 2/2] [ARC] Add TLS support.

2016-04-28 Thread Claudiu Zissulescu
Fixing the loose ends. Committed r235559 Thanks, Claudiu > > > +(define_insn "tls_gd_load" > .. > > + ; if the linker has to patch this into IE, we need a long insns > > Typo: a long insn. > > arc_emit_call_tls_get_addr is missing a start-of-function comment. > > Otherwise this is OK.

[C PATCH PING] PR43651: add warning for duplicate qualifier

2016-04-28 Thread Mikhail Maltsev
On 04/10/2016 11:12 PM, Martin Sebor wrote: > On 04/09/2016 06:28 AM, Mikhail Maltsev wrote: >> On 04/08/2016 08:54 PM, Martin Sebor wrote: The name for new option "-Wduplicate-decl-specifier" and wording was chosen to match the same option in Clang. >>> >>> My version of Clang also warns

[PATCH, i386]: Improve fop and corresponding peephole2 patterns

2016-04-28 Thread Uros Bizjak
Hello! mult_operator will never match in patterns, protected with !COMMUTATIVE_ARITH. The patch also adds "reg = op (mem, reg)" peephole2 to break additional cases of dependency of two loads from x87 stack. 2016-04-28 Uros Bizjak * config/i386/i386.md (*fop__1_mixed): Do not check for

Re: [PATCH] Fix type field walking in gimplifier unsharing

2016-04-28 Thread Richard Biener
On Thu, 28 Apr 2016, Richard Biener wrote: > On Thu, 28 Apr 2016, Eric Botcazou wrote: > > > > Aww, I was hoping for sth that would not require me to fix all > > > frontends ... > > > > I don't really see how this can work without DECL_EXPR though. You need to > > define when the variable-size

RE: [PATCH 1/6] [ARC] Don't use drsub* instructions when selecting fpuda.

2016-04-28 Thread Claudiu Zissulescu
Committed r235562. Thanks, Claudiu > > > > gcc/ > > 2016-04-18 Claudiu Zissulescu > > > > * config/arc/arc.md (cpu_facility): Add fpx variant. > > (subdf3): Prohibit use reverse sub when assist operations option > > is enabled. > > * config/arc/fpx.md (subdf3_insn, *dsubh_peep2

[PATCH] Add some more powi patterns to match.pd

2016-04-28 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu. Richard. 2016-04-28 Richard Biener PR tree-optimization/70840 * match.pd: powi(-x, y) and powi(|x|,y) -> powi(x,y) if y is even; Fix pow(copysign(x, y), z) -> pow(x, z) and add powi variant; Mark x * pow(x,c

Re: New hashtable power 2 rehash policy

2016-04-28 Thread Jonathan Wakely
I'm making this small change to some comments in hashtable_policy.h Tested x86_64-linux, committing to trunk. commit c387345f7c68df8812c7909f9187445a79bd5dcb Author: Jonathan Wakely Date: Thu Apr 28 11:25:29 2016 +0100 * include/bits/hashtable_policy.h (__detail::_Insert_base, __d

Re: [PATCH 6/6] [ARC] Various instruction pattern fixes

2016-04-28 Thread Joern Wolfgang Rennecke
On 18/04/16 19:25, Claudiu Zissulescu wrote: Forgot to add the reload cases. Here it is the updated patch. //Claudiu gcc/ 2016-04-18 Claudiu Zissulescu * config/arc/arc.md (mulsidi3): Change operand 0 predicate to register_operand. (umulsidi3): Likewise. (

gcc-patches@gcc.gnu.org

2016-04-28 Thread Jonathan Wakely
A few more places where we should be using std::addressof. Tested x86_64-linux, committed to trunk. commit 6d5bde9f90e7f1470d3f8d53b3288e6832f536df Author: Jonathan Wakely Date: Thu Apr 28 11:45:22 2016 +0100 libstdc++/70766 use std::addressof instead of operator& PR libstdc++/

Re: [PATCH] Update gmp/mpfr/mpc in-tree versions

2016-04-28 Thread Richard Biener
On Thu, 28 Apr 2016, Bernd Edlinger wrote: > Hi, > > here is the first part of the patch that addresses only the in-tree > builds. I tried different combinations of the documented supported > in-tree versions, and all combinations seem to work. > Then I changed the download_prerequisites batch t

[patch] generate_libstdcxx_web_docs: Use realpath to get absolute path

2016-04-28 Thread Jonathan Wakely
When I ran maintainer-scripts/generate_libstdcxx_web_docs to make the onlinedocs/libstdc++ for 6.1 the other day it failed because I use a relative path for the output dir argument. This would make it work, but is relying on GNU realpath OK? I think in practice nobody is going to generate those d

RE: [PATCH 2/6] [ARC] Fix FPX/FPUDA code gen when compiling for big-endian.

2016-04-28 Thread Claudiu Zissulescu
Fixed naming in arc_rtx_costs, committed r235567. Thanks, Claudiu >> gcc/ > > 2016-04-18 Claudiu Zissulescu > > > > * config/arc/arc.c (arc_process_double_reg_moves): Fix for > > big-endian compilation. > > * config/arc/arc.md (addf3): Likewise. > > (subdf3): Likewise. > >

[PATCH GCC]Proving no-trappness for array ref in tree if-conv using loop niter information.

2016-04-28 Thread Bin Cheng
Hi, Tree if-conversion sometimes cannot convert conditional array reference into unconditional one. Root cause is GCC conservatively assumes newly introduced array reference could be out of array bound and thus trapping. This patch improves the situation by proving the converted unconditional

RE: [PATCH 3/6] [ARC] Pass mfpuda to assembler.

2016-04-28 Thread Claudiu Zissulescu
Committed r235568. Thanks, Claudiu > > gcc/ > > 2016-04-18 Claudiu Zissulescu > > > > * config/arc/arc.h (ASM_SPEC): Pass mfpuda to assembler. > > > OK.

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Bernd Schmidt
On 04/28/2016 12:35 PM, Jakub Jelinek wrote: On Thu, Apr 28, 2016 at 12:31:40PM +0200, Bernd Schmidt wrote: I really don't see anything in that function that looks like a huge time sink, so I'm not that worried about it. I think it's likely to be buried way down in the noise. True, but the noi

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-04-28 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 03:10:26PM +0200, Bernd Schmidt wrote: > On 04/28/2016 12:35 PM, Jakub Jelinek wrote: > >On Thu, Apr 28, 2016 at 12:31:40PM +0200, Bernd Schmidt wrote: > >>I really don't see anything in that function that looks like a huge time > >>sink, so I'm not that worried about it. I

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-04-28 Thread Nathan Sidwell
On 04/27/16 16:59, Aaron Conole wrote: Apologies for the top post. Pinging on this again. It still applies cleanly, so no need to resubmit, I think. Is there anything else missing or required before this can go in? I'm not convinced this is a desirable feature. IIRC your rationale for it was

RE: [PATCH][SMS] SMS use loop induction variable analysis instead of depending on doloop optimization

2016-04-28 Thread Shiva Chen
Hi, I fixed some bug to pass testing on x86-64 and update the patch as 0001-SMS-use-loop-induction-variable-analysis-v1.patch. Thanks, Shiva -Original Message- From: Shiva Chen Sent: Thursday, April 28, 2016 2:07 PM To: GCC Patches ; Shiva Chen Subject: [PATCH][SMS] SMS use loop induc

Re: [PATCH] Fixup nb_iterations_upper_bound adjustment for vectorized loops

2016-04-28 Thread Ilya Enkovich
On 27 Apr 16:05, Richard Biener wrote: > >> > >> I'd like to see testcases covering the corner-cases - have them have > >> upper bound estimates by adjusting known array sizes and also cover > >> the case of peeling for gaps. > > > > OK, I'll make more tests. > > Thanks, > > Ilya > > > >> > >> Rich

[PATCH][internal-fn.c][committed] Convert conditional compilation on WORD_REGISTER_OPERATIONS

2016-04-28 Thread Kyrill Tkachov
Hi all, This is another instance of conditional compilation on WORD_REGISTER_OPERATIONS that's trivial to remove. Bootstrapped and tested on arm, aarch64, x86_64. Committing to trunk as obvious. Thanks, Kyrill 2016-04-28 Kyrylo Tkachov * internal-fn.c (expand_arith_overflow): Convert

[PATCH] Mark predicates generated by genmatch as static

2016-04-28 Thread Patrick Palka
The predicate functions emitted by genmatch are expected to only be used locally within {gimple,generic}-match.c, so this patch marks them as static. Does this look OK to commit after bootstrap and regtest? gcc/ChangeLog: * genmatch.c (write_predicate): Mark the emitted function as

[PATCH] Do not build a pointer-to-element type for arrays in layout_type

2016-04-28 Thread Richard Biener
I stumbled over this odd call, present since CVS repo import (r348). Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-04-28 Richard Biener * stor-layout.c (layout_type): Do not build a pointer-to-element type for arrays. Index: gcc/stor-layout.c

Re: [PATCH] Fixup nb_iterations_upper_bound adjustment for vectorized loops

2016-04-28 Thread Richard Biener
On Thu, Apr 28, 2016 at 3:26 PM, Ilya Enkovich wrote: > On 27 Apr 16:05, Richard Biener wrote: >> >> >> >> I'd like to see testcases covering the corner-cases - have them have >> >> upper bound estimates by adjusting known array sizes and also cover >> >> the case of peeling for gaps. >> > >> > OK

Re: [PATCH] Mark predicates generated by genmatch as static

2016-04-28 Thread Richard Biener
On Thu, Apr 28, 2016 at 3:50 PM, Patrick Palka wrote: > The predicate functions emitted by genmatch are expected to only be used > locally within {gimple,generic}-match.c, so this patch marks them as > static. Does this look OK to commit after bootstrap and regtest? Actually the idea was to for

[PATCH 3/4] PR c++/62314: C++: add fixit hint to misspelled member names

2016-04-28 Thread David Malcolm
When we emit a hint about a misspelled member name, it will slightly aid readability if we use a fixit-hint to show the proposed name in context within the source code (and in the future this might support some kind of auto-apply in an IDE). This patch adds such a hint to the C++ frontend, taking

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-28 Thread Patrick Palka
On Wed, Apr 27, 2016 at 5:36 PM, Jeff Law wrote: > On 03/10/2016 04:38 PM, Patrick Palka wrote: >> >> I ran the command >> >> git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep >> -lw main >> >> to find tests marked as compile-time tests that likely ought to instead >> be m

[PATCH 1/4] PR c++/62314: add fixit hint for missing "template <> " in explicit specialization

2016-04-28 Thread David Malcolm
This is a resend of a patch kit I sent in stage 3; the original post was here: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01933.html I've rebased the patches against yesterday's trunk and retested them. They add various fix-it hints to existing diagnostics (PR 62314 is a catch-all for adding

[PATCH 2/4] PR c++/62314: add fixit hint for "expected ';' after class definition"

2016-04-28 Thread David Malcolm
Looking over the discussion of missing semicolons in "Quality of Implementation and Attention to Detail" within http://clang.llvm.org/diagnostics.html and comparing with https://gcc.gnu.org/wiki/ClangDiagnosticsComparison I noticed that of the cases we do handle [1], there's room for improvem

[PATCH 4/4] C: add fixit hint to misspelled field names

2016-04-28 Thread David Malcolm
Similar to the C++ case, but more involved as the location of the pertinent token isn't readily available. The patch adds it as a param to build_component_ref. All callers are updated to provide the info, apart from objc_build_component_ref; fixing the latter would lead to a cascade of other chan

Re: [ubsan PATCH] Fix compile-time hog with &TARGET_EXPRs (PR sanitizer/70342)

2016-04-28 Thread Marek Polacek
On Thu, Apr 28, 2016 at 11:07:30AM +0200, Jakub Jelinek wrote: > On Wed, Apr 27, 2016 at 07:03:25PM +0200, Marek Polacek wrote: > > This test took forever to compile with -fsanitize=null, because the > > instrumentation was creating incredible amount of duplicated expressions, > > in a > > quadrat

[AArch64] Remove an unused reload hook.

2016-04-28 Thread Matthew Wahab
Hello, Yvan Roux pointed out that the patch at https://gcc.gnu.org/ml/gcc-patches/2016-02/msg01713.html was never committed. From the original submission: The LEGITIMIZE_RELOAD_ADDRESS macro is only needed for reload. Since the Aarch64 backend no longer supports reload, this macro is not

RE: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Claudiu Zissulescu
Hi, > Where exactly does the test go wrong? The test which fails is this one: TEST_EQ (double, __DBL_MAX__, __DBL_MAX__, 1); From the test file included in the patch. > Can you show a trace of __eqdf2 with register values? Sure thing, running for ARC700, using original implementation a

Re: [PATCH] Mark predicates generated by genmatch as static

2016-04-28 Thread Patrick Palka
On Thu, Apr 28, 2016 at 10:02 AM, Richard Biener wrote: > On Thu, Apr 28, 2016 at 3:50 PM, Patrick Palka wrote: >> The predicate functions emitted by genmatch are expected to only be used >> locally within {gimple,generic}-match.c, so this patch marks them as >> static. Does this look OK to comm

Re: [ubsan PATCH] Fix compile-time hog with &TARGET_EXPRs (PR sanitizer/70342)

2016-04-28 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 04:10:01PM +0200, Marek Polacek wrote: > That works too, though it of course affects all users, not just ubsan. Here's Of course, but I think that is a good thing ;) > the patch with your suggested change. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 20

Re: [PATCH] Update gmp/mpfr/mpc in-tree versions

2016-04-28 Thread Bernd Edlinger
On 28.04.2016 14:35, Richard Biener wrote: > On Thu, 28 Apr 2016, Bernd Edlinger wrote: > >> Hi, >> >> here is the first part of the patch that addresses only the in-tree >> builds. I tried different combinations of the documented supported >> in-tree versions, and all combinations seem to work. >

Re: [PATCH] Improve AVX512F sse4_1_round* patterns

2016-04-28 Thread Kirill Yukhin
Hi Jakub, On 27 Apr 23:34, Jakub Jelinek wrote: > Hi! > > While AVX512F doesn't contain EVEX encoded vround{ss,sd,ps,pd} instructions, > it contains vrndscale* which performs the same thing if bits [4:7] of the > immediate are zero. > > For _mm*_round_{ps,pd} we actually already emit vrndscale* f

Re: [PATCH 1/4] PR c++/62314: add fixit hint for missing "template <> " in explicit specialization

2016-04-28 Thread Trevor Saunders
On Thu, Apr 28, 2016 at 10:28:15AM -0400, David Malcolm wrote: > This is a resend of a patch kit I sent in stage 3; the original post > was here: > https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01933.html > > I've rebased the patches against yesterday's trunk and retested them. > > They add var

Re: [PATCH] Update gmp/mpfr/mpc in-tree versions

2016-04-28 Thread Richard Biener
On Thu, 28 Apr 2016, Bernd Edlinger wrote: > On 28.04.2016 14:35, Richard Biener wrote: > > On Thu, 28 Apr 2016, Bernd Edlinger wrote: > > > >> Hi, > >> > >> here is the first part of the patch that addresses only the in-tree > >> builds. I tried different combinations of the documented supported

Re: [PATCH] Turn some compile-time tests into run-time tests

2016-04-28 Thread Jeff Law
On 04/28/2016 08:03 AM, Patrick Palka wrote: The rest seem OK to me. Note that I'm not convinced all these tests were designed to be execution tests, even though they use __builtin_abort and friends. Though it's a good marker of something that can/should be looked at. True.. What made me l

Re: [PATCH 4/6] [ARC] Handle FPX NaN within optimized floating point library.

2016-04-28 Thread Joern Wolfgang Rennecke
On 28/04/16 15:11, Claudiu Zissulescu wrote: Sure thing, running for ARC700, using original implementation and enabled guarded code for FPX handling: [0x02a2] 0xc000 K Zld_s r0,[sp,0x0] : lw [0x5000c0c0] => 0x : (w1) r0 <= 0x * [0x02a4] 0

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Jeff Law
On 04/28/2016 05:18 AM, Torsten Duwe wrote: On Thu, Apr 28, 2016 at 11:39:48AM +0300, Maxim Kuvyrkov wrote: On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: Your current patch is great for experiments for the kernel engineers to check if suggested approaches to code patching will work. Stil

  1   2   >