On Thu, 28 Apr 2016, Bernd Edlinger wrote: > On 28.04.2016 14:35, Richard Biener wrote: > > On Thu, 28 Apr 2016, Bernd Edlinger wrote: > > > >> Hi, > >> > >> here is the first part of the patch that addresses only the in-tree > >> builds. I tried different combinations of the documented supported > >> in-tree versions, and all combinations seem to work. > >> Then I changed the download_prerequisites batch to pick each pre- > >> requisite's minimum version (that part is not tested, because I have > >> no way to update the gcc.gnu.org ftp server). > >> > >> Various boot-straps for x86_64-linux-gnu and armv7-linux-gnueabihf > >> were successful. > >> > >> Is it OK for trunk? > > > > Please do not document that in-tree versions greater than XXX are > > supported, instead just point at download_prerequesites. > > > > OK, done. > > > Why do you not update to latest mpc (there is 1.0.3) and mpfr but leave > > bugfixes for mpfr on the plate (there is 3.1.4). > > > > There's not really a good reason for that choice. > > I just started with the latest version, and later moved to older > versions, because I did not want to restrict the supported versions > more than absolutely necessary, not even in-tree. > > Are there any bug-fixes that we could depend upon? > > > Does it make sense to wait for a new GMP release that allows to get > > rid of -DNO_ASM? > > > > I was _very_ surprised that gmp-6.0.0 did at first work in-tree but > enabled invalid assembly code, in gmp-6.0.0/mpn/generic/div_qr_1n_pi1.c > when __arm__ or __sparc__ or __s390x__ is defined together with NO_ASM. > > All in all GMP contains really much assembler code that we don't need > at all, my impression is that it is nearly impossible to test GMP > on every possible target, although it is all about mathematics. > So at least some choice would be good for us. > > In that sense, I would not like to restrict the supported GMP versions > to just one version, that is not even released at this time.
Another option would be to try if mini-gmp is enough for our (in-tree) use and what the performance impact would be if we'd use that (in-tree). > > I will upload mpfr 3.1.4 and mpc 1.0.3. > > > > Good. I updated the download_prerequsites to mpfr-3.1.4 and mpc-1.0.3 > again, but left gmp-6.1.0 at the moment. Thanks, Richard.
