Re: testsuite patches (7/14): gcc.dg/pr46647.c: xfail for avr*-*-*

2013-07-22 Thread Georg-Johann Lay
Joern Rennecke wrote: > xfail for avr*-*-* Hi, the target machine is avr-*-* because, say, avr32 (a 32-bit MCU not officially supported) is a quite different architecture than avr. Similar for your other testsuite patches with avr*-*-* Johann

Re: [ubsan] Add libcall arguments

2013-07-22 Thread Marek Polacek
On Sun, Jul 21, 2013 at 10:41:15PM -0400, Jason Merrill wrote: > On 07/21/2013 02:26 PM, Marek Polacek wrote: > > (pointer_sized_type_node): Define. > > Let's call it pointer_sized_int_node. Sure. Here it is. 2013-07-21 Marek Polacek * tree.h (enum tree_index): Add TI_POINTER_SI

Re: RFC: Gimple combine/folding interface

2013-07-22 Thread Richard Biener
Andrew Pinski wrote: >On Fri, Jul 19, 2013 at 5:09 PM, Andrew Pinski >wrote: >> I was creating a new gimple/folding interface and wanted some >opinions >> on the interface. >> >> typedef double_int (*nonzerobits_t)(tree var); >> typedef tree (*valueizer_t)(tree var); >> >> class gimple_combine >

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-22 Thread Iain Sandoe
Hi Uros, On 21 Jul 2013, at 09:15, Uros Bizjak wrote: > On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe wrote: > >>> >> >> Sure, I can test that - do you want me to apply it assuming it reg-tests OK >> on darwin & linux? >> (also I can amend the back ports - since I didn't have time to get to t

Re: [ARM][Insn classification refactoring 6/N] Delete "insn" attribute and update MOV classification

2013-07-22 Thread Ramana Radhakrishnan
On 07/19/13 15:10, Sofiane Naci wrote: Hi, This patch is part of the ongoing work of ARM instruction classification cleanup. This patch deletes the "insn" attribute and moves the MOV/MVN instruction classification to the "type" attribute, where it is split into several types for a finer-grained

RFA: Use -gdwarf in gcc.dg/debug/dwarf (Was: Re: testsuite patches (1/14): Request dwarf-2 output where needed)

2013-07-22 Thread Joern Rennecke
Quoting Jakub Jelinek : On Mon, Jul 22, 2013 at 10:31:03AM +0530, Senthil Kumar Selvaraj wrote: .. I ran into this problem a while ago, and after discussion on the mailing list, added a -gdwarf option to emit DWARF with the default version (http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00592.ht

Re: [PATCH] Fix pr57637

2013-07-22 Thread Eric Botcazou
> The patch is updated based the comments: it will check GEN set of LIVE > if df_live exists. Otherwise, just give up. The patch is missing a ChangeLog. Otherwise it looks good, modulo: + /* DF_LR_BB_INFO (bb)->def does not kill the DF_REF_PARTIAL and +DF_REF_CONDITIONAL defs

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-07-22 Thread Phil Muldoon
On 03/07/13 08:33, Phil Muldoon wrote: > This new patch replaces and obsoletes the previous. On further > inspection of some other pretty printer related bugs, it seems that > all of the printers need to fetch the referenced value where the value > type is a reference. This patch applies that ch

Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-07-22 Thread Bernd Edlinger
Hello Zoran, I may be wrong, but what you are trying to do is very similar to what's in fold-const.c optimize_bit_field_compare(). There was a discussion in April 2012 on this thread: "Continue strict-volatile-bitfields fixes" http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01094.html The result

Re: [PATCH][ARM][10/n] Partial IT block deprecation in ARMv8 AArch32 - thumb2.md changes

2013-07-22 Thread Richard Earnshaw
On 11/07/13 13:31, Kyrylo Tkachov wrote: Hi Richard, (define_insn_and_split "*thumb2_smaxsi3" - [(set (match_operand:SI 0 "s_register_operand" "=r,r,r") - (smax:SI (match_operand:SI 1 "s_register_operand" "0,r,?r") -(match_operand:SI 2 "arm_rhs_operand""r

RE: [PATCH][ARM][10/n] Partial IT block deprecation in ARMv8 AArch32 - thumb2.md changes

2013-07-22 Thread Kyrylo Tkachov
Ping? Thanks, Kyrill > > Hi Richard, > > > (define_insn_and_split "*thumb2_smaxsi3" > > - [(set (match_operand:SI 0 "s_register_operand" "=r,r,r") > > - (smax:SI (match_operand:SI 1 "s_register_operand" "0,r,?r") > > -(match_operand:SI 2 "arm_rhs_operand""rI,0,rI"

Re: [Patch] regex_iterator and regex_token_iterator implementation

2013-07-22 Thread Jonathan Wakely
On 22 July 2013 06:13, Tim Shen wrote: > > Actually, in code before this patch, private members in class > regex_iterator are indeed start without double or single underscore. > It's because the standard (28.12, n3376) specifies them, though they > are private. IMHO, they are part of standard, so I

RE: [PATCH][ARM][10/n] Partial IT block deprecation in ARMv8 AArch32 - thumb2.md changes

2013-07-22 Thread Kyrylo Tkachov
> Ping? Ah, just received your ok not even a second after I clicked send on the ping :) Thanks, Kyrill

[avr,committed] Make 1-byte loads from MEMX one byte shorted.

2013-07-22 Thread Georg-Johann Lay
http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201121 Applied this obvious improvement of the sequence to load one byte from address space memx (provided no ELPM is need). The old sequence was SBRC msb LD reg, Z ; read from RAM SBRS msp LPM reg, Z ; read from flash and the new one i

Re: [PATCH] Fix pr57637

2013-07-22 Thread Zhenqiang Chen
On 22 July 2013 17:56, Eric Botcazou wrote: >> The patch is updated based the comments: it will check GEN set of LIVE >> if df_live exists. Otherwise, just give up. > > The patch is missing a ChangeLog. Otherwise it looks good, modulo: > > + /* DF_LR_BB_INFO (bb)->def does not kill the DF

Re: testsuite patches (7/14): gcc.dg/pr46647.c: xfail for avr*-*-*

2013-07-22 Thread Joern Rennecke
Quoting Georg-Johann Lay : Joern Rennecke wrote: xfail for avr*-*-* Hi, the target machine is avr-*-* because, say, avr32 (a 32-bit MCU not officially supported) is a quite different architecture than avr. Similar for your other testsuite patches with avr*-*-* I have attached amended

[testsuite,committed] ad PR52641 skip more tests on int16

2013-07-22 Thread Georg-Johann Lay
http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201123 Applied this skip for int16 platforms that will obviously fail there. Johann PR testsuite/52641 * gcc.c-torture/execute/pr57124.x: Skip int16 platforms. * gcc.c-torture/execute/pr53366-1.x: New: Skip int16 platf

[ubsan] Add more testing

2013-07-22 Thread Marek Polacek
This adds more testing to the ubsan testsuite. It still doesn't test everything, but it's better than nothing and I've already found one bug (already fixed). Tested with RUNTESTFLAGS='--target_board=unix\{-m32,-m64\}. Commited to ubsan branch. 2013-07-22 Marek Polacek * c-c++-common/

Re: [ARM][Insn classification refactoring 6/N] Delete "insn" attribute and update MOV classification

2013-07-22 Thread Ramana Radhakrishnan
On 07/22/13 10:52, Sofiane Naci wrote: Oops sorry. Patch attached now. Ok Thanks, Ramana -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Ramana Radhakrishnan Sent: 22 July 2013 10:26 To: gcc-patches@gcc.gnu.org Subject: R

[v3] libstdc++/57920

2013-07-22 Thread Paolo Carlini
Hi, see audit trail for details. I tested on x86_64-linux (with/without _GLIBCXX_X86_RDRAND artificially undefined) the below straightforward patch and checked by hand the strace. I'm going to apply it soon. Thanks, Paolo. /// 2013-07-22 Paolo Carlini PR c++/57920

[Patch, Fortran, committed] Plug two memory leaks

2013-07-22 Thread Tobias Burnus
Found by Coverity. In the first case, "error" gets overridden if status is not NULL_TREE. The second case is rather obvious. Committed as Rev. 201125 after built on x86-64-gnu-linux. Tobias Index: gcc/fortran/ChangeLog === --- gcc/

Re: RFC: Gimple combine/folding interface

2013-07-22 Thread Florian Weimer
On 07/20/2013 02:09 AM, Andrew Pinski wrote: gimple_combine(bool reas) : nonzerobitsf(NULL), valueizerv(NULL), allow_full_reassiocation(reas) {} I think this constructor should be marked "explicit". -- Florian Weimer / Red Hat Product Security Team

Re: [PATCH] Fix pr57637

2013-07-22 Thread Eric Botcazou
> And if df_live is non-zero, do we need update df_lr's IN and OUT? I think > we need another patch to make all these consistency. Possibly, but this would belong to another patch. I nevertheless think that we should set the bit in the GEN set because we'll be testing the GEN set now. The patch

[google] Fix target specifier for testsuite/g++.dg/pr57878.C

2013-07-22 Thread Diego Novillo
This test was failing with -m64 because it was forcing -m32 instead of asking for ilp32. Committed to google/gcc-4_8 and trunk. Diego. Index: gcc/testsuite/g++.dg/pr57878.C === --- gcc/testsuite/g++.dg/pr57878.C (revision 2011

libbacktrace: walk the elf_syminfo_data chain in elf_syminfo

2013-07-22 Thread Alexander Monakov
Hello, this fixes a bug (found by inspection) that would prevent elf_syminfo from looking up symbols defined in modules other than the executable. Bootstrapped and regtested together with the next patch on x86_64-linux (excluding Java, including Go), OK for trunk? libbacktrace/Changelog: 2013-07

[PATCH] Don't include gimple.h twice

2013-07-22 Thread Marek Polacek
I don't think there's a reason to include gimple.h twice... Regtested/bootstrapped on x86_64-linux, will commit as obvious soon. 2013-07-22 Marek Polacek * gimplify.c: Don't include gimple.h twice. --- gcc/gimplify.c.mp 2013-07-22 15:29:17.202468003 +0200 +++ gcc/gimplify.c 201

Re: [Patch, Fortran, committed] Plug two memory leaks

2013-07-22 Thread Tobias Burnus
Tobias Burnus wrote: Found by Coverity. In the first case, "error" gets overridden if status is not NULL_TREE. The second case is rather obvious. I managed to commit an early draft of the patch - I meant to apply the one attached (relative diff) instead. Committed follow-up fix as Rev. 20112

libbacktrace: allow using DWARF if the main executable lacks it

2013-07-22 Thread Alexander Monakov
This fixes a bug that would prevent using DWARF debug info available in dynamically linked libraries when the main executable did not have DWARF debug info. pd.fileline_fn is not examined after dl_iterate_phdr in backtrace_initialize, so updating *fileline_fn in dl_iterate_phdr is useless as later

Re: Go patch committed: Update libgo to 1.1.1

2013-07-22 Thread Uros Bizjak
Hello! > I have committed a large patch to update libgo to the library that was > part of the Go 1.1.1 release. As usual, I'm not including the entire > patch in this e-mail message, because it is too large. I'm only > including the changes to the files that are partially gccgo-s

Re: [Patch, PR 57790] Waste work in can_move_insns_across()

2013-07-22 Thread Jeff Law
On 07/21/2013 07:45 PM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57790 I bootstrapped and ran the regression tests for this patch

Re: [ubsan] Add libcall arguments

2013-07-22 Thread Jason Merrill
On 07/19/2013 02:45 PM, Marek Polacek wrote: /* This type represents an entry in the hash table. */ struct ubsan_typedesc { + /* This represents the type of a variable. */ tree type; + + /* This is the VAR_DECL of the type. */ tree decl; }; What I was looking for was something al

Re: [PATCH] Don't include gimple.h twice

2013-07-22 Thread Jeff Law
On 07/22/2013 07:31 AM, Marek Polacek wrote: I don't think there's a reason to include gimple.h twice... Regtested/bootstrapped on x86_64-linux, will commit as obvious soon. 2013-07-22 Marek Polacek * gimplify.c: Don't include gimple.h twice. OK. jeff

Re: libbacktrace: walk the elf_syminfo_data chain in elf_syminfo

2013-07-22 Thread Ian Lance Taylor
On Mon, Jul 22, 2013 at 6:26 AM, Alexander Monakov wrote: > > this fixes a bug (found by inspection) that would prevent elf_syminfo from > looking up symbols defined in modules other than the executable. > > Bootstrapped and regtested together with the next patch on x86_64-linux > (excluding Java,

Re: libbacktrace: allow using DWARF if the main executable lacks it

2013-07-22 Thread Ian Lance Taylor
On Mon, Jul 22, 2013 at 6:34 AM, Alexander Monakov wrote: > > 2013-07-22 Alexander Monakov > > * elf.c (backtrace_initialize): Pass elf_fileline_fn to > dl_iterate_phdr callbacks. This is OK. Thanks. Ian

Re: [Patch, PR57803] Wasted work in gfc_build_dummy_array_decl()

2013-07-22 Thread Jeff Law
On 07/19/2013 04:59 PM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57803 I bootstrapped and ran the regression tests for this patch

[PATCH][committed] Fix FAIL: gcc.dg/pr53265.c (test for warnings, line 88)

2013-07-22 Thread Kyrylo Tkachov
Hi all, r201119 adds an extra line to the testcase that confuses the dg-message which explicitly hardocdes a line number. This patch updates the testcase. Committed as obvious as r201135. Thanks, Kyrill 2013-07-22 Kyrylo Tkachov * gcc.dg/pr53265.c: Correct line number in dg-message

[C++ testcase, committed] PR 52816

2013-07-22 Thread Paolo Carlini
Hi, testcase committed to mainline. Thanks, Paolo. /// 2013-07-22 Paolo Carlini PR c++/52816 * g++.dg/cpp0x/decltype56.C: New. Index: g++.dg/cpp0x/decltype56.C === --- g++.dg/cpp0x/decltype56

[Patch, PR 57811] Wasted work in find_reloads()

2013-07-22 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached one-line patches that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57811 Bootstrap and regression-tested on x86_64-linux. In method "find_reloads()" in gcc/reload.c, the loop on line

[Patch, PR 57812] Wasted work in computed_jump_p()

2013-07-22 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57812. Bootstrap and regression-tested on x86_64-linux. In method "computed_jump_p()" in gcc/rtlanal.c, the loop on line 2801 should break immediately after "has

Re: [Patch, PR 57811] Wasted work in find_reloads()

2013-07-22 Thread Marek Polacek
On Mon, Jul 22, 2013 at 11:39:38AM -0500, pcha...@cs.wisc.edu wrote: > Hi, > > The problem appears in revision 201034 in version 4.9. I attached > one-line patches that fixes it. I also reported this problem > at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57811 > > Bootstrap and regression-tes

[Patch, Fortran, committed] PR57762 - Fix memleak in gfortran.dg/class_array_7.f03

2013-07-22 Thread Tobias Burnus
That's a patch of the category: Make the testers happy (here: Dominque). gfortran (in GCC 4.9) no longer frees allocatable at the end of the main program as they get implicitly the SAVE attribute (cf. Fortran 2008) - and that's now detectable due to finalizers. Result: gfortran.dg/class_array

[PATCH][4.8 backport] Fix PR57735

2013-07-22 Thread Kyrylo Tkachov
Hi all, The fix for PR57735 is in current trunk (for a different issue I think), just needs a backport to 4.8. It is r198462 by Richard Sandiford: 2013-04-30 Richard Sandiford * explow.c (plus_constant): Pass "mode" to immed_double_int_const. Use gen_int_mode rather than

Re: [ubsan] Add libcall arguments

2013-07-22 Thread Marek Polacek
On Mon, Jul 22, 2013 at 10:09:00AM -0400, Jason Merrill wrote: > On 07/19/2013 02:45 PM, Marek Polacek wrote: > > /* This type represents an entry in the hash table. */ > > struct ubsan_typedesc > > { > >+ /* This represents the type of a variable. */ > > tree type; > >+ > >+ /* This is the V

[PATCH, PowerPC] rs6000_expand_vector_init selects wrong field for splat in LE mode

2013-07-22 Thread Bill Schmidt
In little-endian mode, the field selected for use in a vector splat is numbered differently than in big-endian mode. This patch corrects the code generated for little-endian. This addresses 45 test failures when running the test-suite in little-endian mode. Bootstrapped and tested on powerpc64-u

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:21 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: >> >>> - /* Now we have to go throught the whole table >>> + /* Now we have to go thought the whole table >>> >>> Again, throught -> through. >> >> Fixed. >

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:18 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: > >>> diff --git a/gcc/testsuite/c-c++-common/pr41779.c >>> b/gcc/testsuite/c-c++-common/pr41779.c >>> index 80c8e6b..f80412c 100644 >>> --- a/gcc/testsuite/c-c++-common/pr41779.c >>> +++ b/gcc/testsuite

Re: [Patch, Fortran] PR57906 - fix issue with coarray component assignment

2013-07-22 Thread Steve Kargl
On Mon, Jul 22, 2013 at 07:17:50PM +0200, Tobias Burnus wrote: > For coarrays, an assignment does not affect the allocation status. That > also implies that the type parameters, shape and effective types between > the LHS and RHS have to match. > > For coarrays components, that's handled (since

[Patch, Fortran] PR57906 - fix issue with coarray component assignment

2013-07-22 Thread Tobias Burnus
For coarrays, an assignment does not affect the allocation status. That also implies that the type parameters, shape and effective types between the LHS and RHS have to match. For coarrays components, that's handled (since Rev. 200955) by re-assigning the saved data after the assignment: tm

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:09 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: > >> I've reviewed and applied the gcc/doc changes that were trivial. The >> only patches not applied were the ok->OK patches. > > *For formal documentation* such as gcc/doc, I think changing ok->OK is

[C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-22 Thread Paolo Carlini
Hi all, Jason, while looking a bit into c++/57942, I noticed (again) that in the definition of the predicate DERIVED_FROM_P we use tf_warning_or_error, not tf_none, which seems weird for a predicate, being in general able to produce hard errors (*). I tested the below with no regressions. Th

[Patch, PR 57787] Wasted work in ix86_pad_returns()

2013-07-22 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57787. Bootstrap and regression-tested on x86_64-linux. In method "ix86_pad_returns()" in i386.c, the loop on line 35723 should break immediately after "replace"

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Oleg Endo
On Sun, 2013-07-21 at 09:35 -0700, Mike Stump wrote: > On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > > This is series of typo fixing patches. They are generated with stylepp > > https://github.com/neleai/stylepp > > which makes patch generation very effective. > > I've checked in most change

Re: libbacktrace: walk the elf_syminfo_data chain in elf_syminfo

2013-07-22 Thread Alexander Monakov
On Mon, 22 Jul 2013, Ian Lance Taylor wrote: > Thanks for noticing the problem. This patch isn't enough by itself. > The code has to protect itself against the list changing in > mid-stream. See dwarf_fileline in dwarf.c. Thank you. Here's the updated patch, however I have to admit it's not ent

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-22 Thread Martin Jambor
Hi, On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > gcc/ > > Explicitly number the instances of passes within passes.def. > > This is needed by a subsequent patch so that we can create > fields within the pipeline class for each pass instance (to help > l

Re: [PATCH][4.8 backport] Fix PR57735

2013-07-22 Thread Richard Sandiford
"Kyrylo Tkachov" writes: > Hi all, > > The fix for PR57735 is in current trunk (for a different issue I think), just > needs a backport to 4.8. > It is r198462 by Richard Sandiford: > > 2013-04-30 Richard Sandiford > > * explow.c (plus_constant): Pass "mode" to immed_double_int_const

Re: [PATCH][4.8 backport] Fix PR57735

2013-07-22 Thread Richard Sandiford
Richard Sandiford writes: > "Kyrylo Tkachov" writes: >> Hi all, >> >> The fix for PR57735 is in current trunk (for a different issue I think), just >> needs a backport to 4.8. >> It is r198462 by Richard Sandiford: >> >> 2013-04-30 Richard Sandiford >> >> * explow.c (plus_constant): P

Re: [PATCH] FPU IEEE 754 for MIPS r5900

2013-07-22 Thread Richard Sandiford
Hi Jürgen, Thanks for the update, looks good. "Jürgen Urban" writes: > Index: gcc/config.gcc > === > --- gcc/config.gcc(Revision 200583) > +++ gcc/config.gcc(Arbeitskopie) > @@ -3080,7 +3080,7 @@ >esac > fi > > -# Inf

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 22, 2013, at 11:20 AM, Oleg Endo wrote: > On Sun, 2013-07-21 at 09:35 -0700, Mike Stump wrote: >> On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: >>> This is series of typo fixing patches. They are generated with stylepp >>> https://github.com/neleai/stylepp >>> which makes patch generati

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-22 Thread Jason Merrill
OK. (*) Note that, depending on how it's called, the predicate can currently produce errors anyway, for example because it calls complete_type. This may or may not be all there is to c++/57942. It looks like lookup_base seems to deliberately avoid trying to complete the base, so the call to

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-22 Thread David Malcolm
On Mon, 2013-07-22 at 20:25 +0200, Martin Jambor wrote: > Hi, > > On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > > gcc/ > > > > Explicitly number the instances of passes within passes.def. > > > > This is needed by a subsequent patch so that we can create > > fields

Re: RFC: Gimple combine/folding interface

2013-07-22 Thread Jeff Law
On 07/21/2013 08:14 PM, Andrew Pinski wrote: On Fri, Jul 19, 2013 at 5:09 PM, Andrew Pinski wrote: I was creating a new gimple/folding interface and wanted some opinions on the interface. typedef double_int (*nonzerobits_t)(tree var); typedef tree (*valueizer_t)(tree var); class gimple_combin

Re: RFC: Gimple combine/folding interface

2013-07-22 Thread Jakub Jelinek
On Mon, Jul 22, 2013 at 01:36:17PM -0600, Jeff Law wrote: > Before designing an interface which inherently includes that > information we should think hard about if it's valuable and if a > tree combiner is the right place. > > I have high hopes that we can get the zero/sign extension > eliminatio

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-22 Thread Paolo Carlini
On 07/22/2013 09:22 PM, Jason Merrill wrote: OK. Thanks, applied. (*) Note that, depending on how it's called, the predicate can currently produce errors anyway, for example because it calls complete_type. This may or may not be all there is to c++/57942. It looks like lookup_base seems to del

[PATCH] Use CHECKSUM_ macros and ULEB128 checksum for DIE tag

2013-07-22 Thread Eric Christopher
Hi Cary, This patch changes the ODR checker to use the CHECKSUM_ macros and instead of depending on size of int to use the ULEB128 of the tag (similar to the deep hash) to compute the values. Thoughts? -eric 2013-07-22 Eric Christopher * dwarf2out.c (die_odr_checksum): New function

Re: [PATCH] Use CHECKSUM_ macros and ULEB128 checksum for DIE tag

2013-07-22 Thread Jakub Jelinek
On Mon, Jul 22, 2013 at 01:15:15PM -0700, Eric Christopher wrote: > --- gcc/dwarf2out.c (revision 198904) > +++ gcc/dwarf2out.c (working copy) > @@ -6097,6 +6097,13 @@ >CHECKSUM_ULEB128 (0); > } > I guess you should add a function comment, plus spaces before ( everywhere (and while you'

Re: libbacktrace: walk the elf_syminfo_data chain in elf_syminfo

2013-07-22 Thread Ian Lance Taylor
On Mon, Jul 22, 2013 at 11:20 AM, Alexander Monakov wrote: > On Mon, 22 Jul 2013, Ian Lance Taylor wrote: >> Thanks for noticing the problem. This patch isn't enough by itself. >> The code has to protect itself against the list changing in >> mid-stream. See dwarf_fileline in dwarf.c. > > Thank

Re: [PATCH] Use CHECKSUM_ macros and ULEB128 checksum for DIE tag

2013-07-22 Thread Cary Coutant
- md5_process_bytes (&die->die_tag, sizeof (die->die_tag), &ctx); - md5_process_bytes (name, strlen (name) + 1, &ctx); + /* Checksum the current DIE. */ + die_odr_checksum(die, &ctx); Since we've already gone to the trouble of getting the name of this DIE, it seems wasteful to

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-22 Thread Jason Merrill
I guess ptr_reasonably_similar should return false if one of the target types is incomplete. Jason

[SPARC] Work around data cache nullify issues on LEON3

2013-07-22 Thread Eric Botcazou
This enhances -mfix-ut699 to work around the data cache nullify issues recently uncovered on the LEON3 processor, as documented in the relevant errata sheet. Tested on SPARC/Solaris, applied on the mainline. 2013-07-22 Eric Botcazou * config.gcc (sparc*-*-*): Accept leon3 processor.

Re: [SPARC] Work around data cache nullify issues on LEON3

2013-07-22 Thread David Miller
From: Eric Botcazou Date: Mon, 22 Jul 2013 23:34:29 +0200 > This enhances -mfix-ut699 to work around the data cache nullify issues > recently > uncovered on the LEON3 processor, as documented in the relevant errata sheet. > > Tested on SPARC/Solaris, applied on the mainline. Looks good, nice

Re: [PATCH] Use CHECKSUM_ macros and ULEB128 checksum for DIE tag

2013-07-22 Thread Eric Christopher
On Mon, Jul 22, 2013 at 1:30 PM, Cary Coutant wrote: > - md5_process_bytes (&die->die_tag, sizeof (die->die_tag), &ctx); > - md5_process_bytes (name, strlen (name) + 1, &ctx); > + /* Checksum the current DIE. */ > + die_odr_checksum(die, &ctx); > > Since we've already gone to t

[Patch, PR 57782] Wasted work in remove_path()

2013-07-22 Thread pchang9
Hi, The problem appears in revision 200945 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57782 In method "remove_path()" in cfgloopmanip.c, the loop on line 343 should break immediately after "irred_invalid

Re: [PATCH, PowerPC] rs6000_expand_vector_init selects wrong field for splat in LE mode

2013-07-22 Thread David Edelsohn
On Mon, Jul 22, 2013 at 1:12 PM, Bill Schmidt wrote: > In little-endian mode, the field selected for use in a vector splat is > numbered differently than in big-endian mode. This patch corrects the > code generated for little-endian. This addresses 45 test failures when > running the test-suite

[PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-22 Thread Bill Schmidt
This patch is another fix for vector handling in little endian mode. The first two operands for a pack pattern are two vector registers that form a contiguous array of inputs. In LE mode the order of the operands must be reversed so that the array remains contiguous in the reverse order. This fix

RE: [ping] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-07-22 Thread Bernd Edlinger
Hello Hans-Peter, > On Sat, 13 Jul 2013, Bernd Edlinger wrote: >> Hi Sandra, >> >> On Fri, 5 Jul 2013, Hans-Peter Nilsson wrote >>> Or - maybe more acceptable - an optional warning, say >>> -Wportable-volatility, to warn about code for which separate >>> incompatbile definitions on different platf

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-22 Thread David Edelsohn
On Mon, Jul 22, 2013 at 7:05 PM, Bill Schmidt wrote: > This patch is another fix for vector handling in little endian mode. > The first two operands for a pack pattern are two vector registers that > form a contiguous array of inputs. In LE mode the order of the operands > must be reversed so tha

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-22 Thread Bill Schmidt
On Mon, 2013-07-22 at 19:49 -0400, David Edelsohn wrote: > On Mon, Jul 22, 2013 at 7:05 PM, Bill Schmidt > wrote: > > This patch is another fix for vector handling in little endian mode. > > The first two operands for a pack pattern are two vector registers that > > form a contiguous array of in

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-22 Thread Bill Schmidt
On Mon, 2013-07-22 at 19:56 -0500, Bill Schmidt wrote: > > On Mon, 2013-07-22 at 19:49 -0400, David Edelsohn wrote: > > On Mon, Jul 22, 2013 at 7:05 PM, Bill Schmidt > > wrote: > > > This patch is another fix for vector handling in little endian mode. > > > The first two operands for a pack patte

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-22 Thread Bill Schmidt
On Mon, 2013-07-22 at 19:49 -0400, David Edelsohn wrote: > On Mon, Jul 22, 2013 at 7:05 PM, Bill Schmidt > wrote: > > This patch is another fix for vector handling in little endian mode. > > The first two operands for a pack pattern are two vector registers that > > form a contiguous array of in

[Patch, PR 57780] Waste work in subst_dup()

2013-07-22 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57780 Bootstrap and regression-tested on x86_64-linux. In method "subst_dup()" in gensupport.c, the loop on line 218

Re: RFA: implement C11 _Generic

2013-07-22 Thread Joseph S. Myers
I have now revised this patch from a year ago in line with my understanding of how _Generic ought to handle the various special cases (selector undergoes lvalue-to-rvalue conversion, and decay of functions and arrays to pointers, because nothing says it doesn't - "The controlling expression of a ge

Re: RFA: implement C11 _Generic

2013-07-22 Thread Joseph S. Myers
On Tue, 23 Jul 2013, Joseph S. Myers wrote: > The committee discussion includes a further point to ensure rvalues > can have qualified type: treating qualified function return types the (to ensure they *can't* have qualified type, that is) -- Joseph S. Myers jos...@codesourcery.com

libgo patch committed: Ignore SIGPROF on non-Go thread

2013-07-22 Thread Ian Lance Taylor
This patch to libgo ignores a SIGPROF signal if it is received on a non-Go thread. This permits the Go library profiling support to work in a program that calls C/C++ code that starts threads. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. I

Re: [Patch, PR 57812] Wasted work in computed_jump_p()

2013-07-22 Thread Chung-Ju Wu
2013/7/23 : > > 2013-07-22 Chang > > * rtlanal.c (computed_jump_p): Exit loop once we find label > reference is used. > The second line is supposed to be aligned with '*' character at first line. Like this: * rtlanal.c (computed_jump_p): Exit loop once we find label

Add more info to google/gcc-4_8 powerpc64 xfails file.

2013-07-22 Thread Brooks Moses
Diego - The attached patch adds a little more analysis info to the powerpc64 xfails file. Ok to commit? Thanks, - Brooks 2013-07-22_xfail-more-info.diff Description: Binary data

Re: [Patch, microblaze]: Add -fstack-usage support

2013-07-22 Thread David Holsgrove
Hi Eric / Chung-Ju, On 21 July 2013 01:33, Chung-Ju Wu wrote: > On 7/20/13 4:14 PM, Eric Botcazou wrote: 2013-03-18 David Holsgrove * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue): Add check for flag_stack_usage to handle -fstack-usage support >>