- md5_process_bytes (&die->die_tag, sizeof (die->die_tag), &ctx); - md5_process_bytes (name, strlen (name) + 1, &ctx); + /* Checksum the current DIE. */ + die_odr_checksum(die, &ctx);
Since we've already gone to the trouble of getting the name of this DIE, it seems wasteful to have die_odr_checksum call get_AT_string again. Why not just pass name as a parameter? > I guess you should add a function comment, plus spaces before ( everywhere > (and while you're at it, you can change also the is_cxx() ). Will leave the > rest to Cary. Agree with the function comment and the spaces. > 2013-07-22 Eric Christopher <echri...@gmail.com> > > * dwarf2out.c (die_odr_checksum): New function to use > CHECKSUM_ macros and ULEB128 for DIE tag. > (generate_type_signature): Use. This is OK with those changes. Thanks! -cary
