Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Jan Kratochvil
Hello Ian, On Tue, 23 Oct 2012 06:55:01 +0200, Ian Lance Taylor wrote: > PR 54918 points out that libgo is not using version numbers as it > should. At present none of libgo in 4.6, 4.7 and mainline are > compatible with each other. This patch to the 4.7 branch sets the > version number for libg

Re: [PATCH] Fix PR55011

2012-10-23 Thread Richard Biener
On Mon, 22 Oct 2012, Michael Matz wrote: > Hi, > > On Mon, 22 Oct 2012, Richard Biener wrote: > > > On Mon, 22 Oct 2012, Michael Matz wrote: > > > > > Hi, > > > > > > On Mon, 22 Oct 2012, Richard Biener wrote: > > > > > > > > > > > This fixes PR55011, it seems nothing checks for invalid latt

Re: Fix array bound niter estimate (PR middle-end/54937)

2012-10-23 Thread Richard Biener
On Mon, 22 Oct 2012, Jan Hubicka wrote: > Hi, > here is updated patch with the comments. The fortran failures turned out to > be > funny interaction in between this patch and my other change that hoped that > loop closed SSA is closed on VOPs, but it is not. > > Regtested x86_64-linux, bootstra

Re: Minor record_upper_bound tweek

2012-10-23 Thread Richard Biener
On Mon, 22 Oct 2012, Jan Hubicka wrote: > Hi, > with profile feedback we may misupdate the profile and start to believe that > loops > iterate more times than they do. This patch makes at least > nb_iterations_estimate > no greater than nb_iterations_upper_bound. This makes the > unrolling/pe

Re: Loop closed SSA loop update

2012-10-23 Thread Richard Biener
On Mon, 22 Oct 2012, Jan Hubicka wrote: > Hi, > this patch updates tree_unroll_loops_completely to update loop closed SSA. > WHen unlooping the loop some basic blocks may move out of the other loops > and that makes the need to check their use and add PHIs. > Fortunately update_loop_close_ssa alre

[PATCH] [0/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
Folks, We would like to request the merge of aarch64-branch into trunk. This series of patches represents the delta from gcc trunk @r192445 to aarch64-branch @r192535. The patch set is broken down as follows: [1/10] gcc configury This patch contains the adjustments to top level gcc configur

[PATCH] [1/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch contains the adjustments to top level gcc configury required to enable the AArch64 port. Proposed ChangeLog: * config.gcc: Add AArch64. * configure.ac: Add AArch64 TLS support detection. * configure: Regenerate. diff --git a/gcc/config.gcc b/gcc/config.gc

[PATCH] [2/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch contains the additions to the gcc/doc files to document the AArch64 port. Proposed ChangeLog: * doc/invoke.texi (AArch64 Options): New. * doc/md.texi (Machine Constraints): Add AArch64. diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index a9a79343985bdc6bcd0

[PATCH] [6/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch adjusts the libatomic configury for AArch64. Proposed ChangeLog: * configure.tgt: Mark libatomic unsupported.diff --git a/libatomic/configure.tgt b/libatomic/configure.tgt index 847ac41ebed81efff601fcb966d76f35d228dda2..0caa0f42ff99766d1020acd8d966509d0f3447ce 100644 --- a/

[PATCH] [4/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch contains the adjustments to the existing test suite to support AArch64. Proposed ChangeLog: * lib/target-supports.exp (check_profiling_available): Add AArch64. (check_effective_target_vect_int): Likewise. (check_effective_target_vect_shift): Likewis

[PATCH] [7/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch adjusts the libcpp configury for AArch64. Proposed ChangeLog: * configure.ac: Enable AArch64. * configure: Regenerate.diff --git a/libcpp/configure.ac b/libcpp/configure.ac index 29bd8c5e6f1a7bddb628f415f3138dfeaa69a483..e62da06ce278f832084ff2080d694c99e24f8532 10064

[PATCH] [9/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch adjusts the libgomp configury for AArch64. Proposed ChangeLog: * configure.tgt: Add AArch64.diff --git a/libgomp/configure.tgt b/libgomp/configure.tgt index d5a1480e4812634ae280238684cb2187b2c618f8..2eecc93a349f3afe9e0afbbc2e98194065873498 100644 --- a/libgomp/configure.tgt

[PATCH] [10/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch provides the AArch64 libstdc++-v3 port, it contains both the required configury adjustment to config.host and the new file introduced by the AArch64 port. Proposed ChangeLog: * config/cpu/aarch64/cxxabi_tweaks.h: New file. * configure.host: Enable aarch64.diff --git

[PATCH] [8/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
This patch provides the AArch64 libgcc port, it contains both the required configury adjustment to config.host and the new files introduced by the AArch64 port. Proposed ChangeLog: * config.host (aarch64*-*-elf, aarch64*-*-linux*): New. * config/aarch64/crti.S: New file.

Re: [PATCH] [9/10] AArch64 Port

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 10:42:57AM +0100, Marcus Shawcroft wrote: > This patch adjusts the libgomp configury for AArch64. > > Proposed ChangeLog: > > * configure.tgt: Add AArch64. This is ok. > diff --git a/libgomp/configure.tgt b/libgomp/configure.tgt > index > d5a1480e4812634ae280238

Re: [wwwdocs,Java] Replace sources.redhat.com by sourceware.org

2012-10-23 Thread Andrew Hughes
- Original Message - > ...and some other simplifications and improvements I noticed on > the way. > > This was triggered by a note that the sources.redhat.com DNS entry > is going to go away at some point in the future that I got yesterday. > > Applied. > > Gerald > > > 2012-10-21 G

Re: Minimize downward code motion during reassociation

2012-10-23 Thread Richard Biener
On Mon, Oct 22, 2012 at 8:31 PM, Easwaran Raman wrote: > On Mon, Oct 22, 2012 at 12:59 AM, Richard Biener > wrote: >> On Fri, Oct 19, 2012 at 12:36 AM, Easwaran Raman wrote: >>> Hi, >>> >>> During expression reassociation, statements are conservatively moved >>> downwards to ensure that dependen

Re: [wwwdocs,Java] Replace sources.redhat.com by sourceware.org

2012-10-23 Thread Andrew Haley
On 10/23/2012 10:47 AM, Andrew Hughes wrote: > It's never been obvious to me how the web material gets updated. GCJ > regularly misses out on being mentioned in changes too, despite fixes going > in. Web material gets updated with patches through the same process as the software. Andrew.

Re: Constant-fold vector comparisons

2012-10-23 Thread Richard Biener
On Mon, Oct 22, 2012 at 10:31 PM, Marc Glisse wrote: > On Mon, 15 Oct 2012, Richard Biener wrote: > >> On Fri, Oct 12, 2012 at 4:07 PM, Marc Glisse wrote: >>> >>> On Sat, 29 Sep 2012, Marc Glisse wrote: >>> 1) it handles constant folding of vector comparisons, 2) it fixes another p

Re: Fix bugs introduced by switch-case profile propagation

2012-10-23 Thread Jan Hubicka
> Ping. > > > On Wed, Oct 17, 2012 at 1:48 PM, Easwaran Raman wrote: > > Hi, > > This patch fixes bugs introduced by my previous patch to propagate > > profiles during switch expansion. Bootstrap and profiledbootstrap > > successful on x86_64. Confirmed that it fixes the crashes reported in > >

Re: Remove def operands cache, try 2

2012-10-23 Thread Richard Biener
On Mon, Oct 22, 2012 at 4:12 PM, Michael Matz wrote: > Hi, > > On Tue, 11 Sep 2012, Michael Matz wrote: > >> the operands cache is ugly. This patch removes it at least for the def >> operands, saving three pointers for roughly each normal statement (the >> pointer in gsbase, and two pointers from

Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2012-10-23 Thread Uros Bizjak
On Tue, Oct 23, 2012 at 12:14 PM, Alexander Ivchenko wrote: > Please take a look at the attached patch. > > I changed the asm-pattern implementation according to your recomendation. > Changed the name of feature option from -mfxsave to -mfxsr, as it is in > Intel SDM. Corrected the arguments name

Re: [wwwdocs,Java] Replace sources.redhat.com by sourceware.org

2012-10-23 Thread Mark Wielaard
On Tue, Oct 23, 2012 at 10:52:41AM +0100, Andrew Haley wrote: > On 10/23/2012 10:47 AM, Andrew Hughes wrote: > > It's never been obvious to me how the web material gets updated. GCJ > > regularly misses out on being mentioned in changes too, despite fixes going > > in. > > Web material gets upda

Additional fix for pre-reload schedule on x86 targets.

2012-10-23 Thread Yuri Rumyantsev
Hi All, This fix is aimed to remove stability issues with using pre-reload scheduler for x86 targets caused by cross-block motion of function arguments passed in likely-spilled HW registers. We found one more issue in a process of more detail testing pre-reload scheduler for all x86 platforms. Th

Re: Additional fix for pre-reload schedule on x86 targets.

2012-10-23 Thread Uros Bizjak
On Tue, Oct 23, 2012 at 1:38 PM, Yuri Rumyantsev wrote: > This fix is aimed to remove stability issues with using pre-reload > scheduler for x86 targets caused by cross-block motion of function > arguments passed in likely-spilled HW registers. We found one more > issue in a process of more detai

[PATCH 0/3][asan] Instrument memory access builtins calls

2012-10-23 Thread Dodji Seketeli
Hello, The three patches following up this message implement instrumenting memory access builtins calls in AddressSanitizer, like what the llvm implementation does. The first two patches do some factorizing that is used by the third one. I have split them up like this to ease the review and to e

[PATCH 1/3] [asan] Make build_check_stmt accept an SSA_NAME for its base

2012-10-23 Thread Dodji Seketeli
This patch makes build_check_stmt accept its memory access parameter to be an SSA name. This is useful for a subsequent patch that will re-use. Tested by running cc1 -fasan on the program below with and without the patch and inspecting the gimple output to see that there is no change. void foo (

[PATCH 2/3] [asan] Factorize condition insertion code out of build_check_stmt

2012-10-23 Thread Dodji Seketeli
This patch splits a new create_cond_insert_point_before_iter function out of build_check_stmt, to be used by a later patch. Tested by running cc1 -fasan on the test program below with and without the patch and by inspecting the gimple output to see that there is no change. void foo () { char fo

Re: [PATCH 1/3] [asan] Make build_check_stmt accept an SSA_NAME for its base

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 03:07:14PM +0200, Dodji Seketeli wrote: > * asan.c (build_check_stmt): Accept the memory access to be > represented by an SSA_NAME. This is ok for asan, thanks. Jakub

[PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Dodji Seketeli
This patch instruments many memory access patterns through builtins. Basically, for a call like: __builtin_memset (from, 0, n_bytes); the patch would only instrument the accesses at the beginning and at the end of the memory region [from, from + n_bytes]. This is the strategy used by the l

Re: [PATCH 2/3] [asan] Factorize condition insertion code out of build_check_stmt

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 03:08:07PM +0200, Dodji Seketeli wrote: > +static gimple_stmt_iterator > +create_cond_insert_point_before_iter (gimple_stmt_iterator *iter, > + bool then_more_likely_p, > + basic_block *then_block, > +

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 12:37 AM, Jan Kratochvil wrote: > > On Tue, 23 Oct 2012 06:55:01 +0200, Ian Lance Taylor wrote: >> PR 54918 points out that libgo is not using version numbers as it >> should. At present none of libgo in 4.6, 4.7 and mainline are >> compatible with each other. This patch

Re: [PATCH] Fix PR55011

2012-10-23 Thread Michael Matz
Hi, On Tue, 23 Oct 2012, Richard Biener wrote: > > > > ... for this. We should never "produce" UNDEFINED when the input > > > > wasn't > > > > UNDEFINED already. > > > > > > Why? > > > > Because doing so _always_ means an invalid lattice transition. UNDEFINED > > is TOP, anything not UNDEF

[Patch] Fix the test libgomp.graphite/force-parallel-6.c

2012-10-23 Thread Dominique Dhumieres
The test libgomp.graphite/force-parallel-6.c is not valid as it tries to write Y[2*N] for Y defined as int X[2*N], Y[2*N], B[2*N]; This patch fixes the bounds of the loops in order to make the test valid Since I don't have write access, could someone commit the patch if it is approved? Dominiqu

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote: > * asan.c (insert_if_then_before_iter) > (instrument_mem_region_access) > (maybe_instrument_builtin_call, maybe_instrument_call): New static Why not just write it: * asan.c (insert_if_then_before_iter, instr

[Patch] Fix the tests gcc.dg/vect/vect-8[23]_64.c

2012-10-23 Thread Dominique Dhumieres
Following the changes in [PATCH] Add option for dumping to stderr (issue6190057) the tests gcc.dg/vect/vect-8[23]_64.c fails on powerpc*-*-*. This patch adjust the dump files and has been tested on powerpc-apple-darwin9. If approved could someone commit it for me (no write access). Note that thes

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Richard Biener
On Tue, Oct 9, 2012 at 5:09 PM, Kenneth Zadeck wrote: > This patch implements the wide-int class.this is a more general version > of the double-int class and is meant to be the eventual replacement for that > class.The use of this class removes all dependencies of the host from > the targe

Re: [MIPS] Implement static stack checking

2012-10-23 Thread Maciej W. Rozycki
On Mon, 22 Oct 2012, Richard Sandiford wrote: > > The loop probes at FIRST + N * PROBE_INTERVAL for values of N from 1 until > > it > > is equal to ROUNDED_SIZE, inclusive, so FIRST + SIZE is always probed. > > Doh! But in that case, rather than: > > 1: > beq r1,r2,2f > addiu

Re: [PATCH] Fix PR55011

2012-10-23 Thread Richard Biener
On Tue, 23 Oct 2012, Michael Matz wrote: > Hi, > > On Tue, 23 Oct 2012, Richard Biener wrote: > > > > > > ... for this. We should never "produce" UNDEFINED when the input > > > > > wasn't > > > > > UNDEFINED already. > > > > > > > > Why? > > > > > > Because doing so _always_ means an invali

Ping^3 Re: Defining C99 predefined macros for whole translation unit

2012-10-23 Thread Joseph S. Myers
Ping^3. This patch (non-C parts) is still pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] [2/10] AArch64 Port

2012-10-23 Thread Joseph S. Myers
On Tue, 23 Oct 2012, Marcus Shawcroft wrote: > +@item -mcmodel=tiny > +@opindex mcmodel=tiny > +Generate code for the tiny code model. The program and its statically > defined > +symbols must be within 1GB of each other. Pointers are 64 bits. Programs > can > +be statically or dynamically lin

Re: Ping^3 Re: Defining C99 predefined macros for whole translation unit

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 02:35:53PM +, Joseph S. Myers wrote: > Ping^3. This patch > (non-C parts) is > still pending review. Looks ok to me. Jakub

Re: Tidy extract_bit_field_1 & co.

2012-10-23 Thread Eric Botcazou
> Here's a version with the corresponding fixes from Eric's review > of the store_bit_field_1 patch. Tested as before. > > gcc/ > * expmed.c (store_split_bit_field): Update the calls to > extract_fixed_bit_field. In the big-endian case, always > use the mode of OP0 to count the

Re: [PATCH] [4/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch contains the adjustments to the existing test suite to support AArch64. Proposed ChangeLog: * lib/target-supports.exp (check_profiling_available): Add AArch64. (check_effective_target_vect_int): Likewise.

Re: [PATCH] [7/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch adjusts the libcpp configury for AArch64. Proposed ChangeLog: * configure.ac: Enable AArch64. * configure: Regenerate. This is fine. Please install. Jeff

Re: [PATCH] [6/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch adjusts the libatomic configury for AArch64. Proposed ChangeLog: * configure.tgt: Mark libatomic unsupported. This is good. Please install. Presumably at some point in the not too distant future, aarch support will be added

loop-unroll.c TLC 3/4 simple peeling heuristic fix

2012-10-23 Thread Jan Hubicka
Hi, simple peeling heuristic thinks it makes no sense to peel loops with known iteration count (because they will be runtime unrolled instead). This is not true because the known iteration count is only upper bound. Fixed this. To make testcase possible I had to reduce overactive heuristic on numb

Re: [PATCH] [5/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch contains all of the new files added to the test suite for AArch64, the patch does not modify any existing file. Proposed ChangeLog: * gcc.target/aarch64/aapcs/aapcs64.exp: New file. * gcc.target/aarch64/aapcs/abitest-2

Re: [PATCH] [8/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch provides the AArch64 libgcc port, it contains both the required configury adjustment to config.host and the new files introduced by the AArch64 port. Proposed ChangeLog: * config.host (aarch64*-*-elf, aarch64*-*-linux*): New.

Re: [PATCH] [2/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch contains the additions to the gcc/doc files to document the AArch64 port. Proposed ChangeLog: * doc/invoke.texi (AArch64 Options): New. * doc/md.texi (Machine Constraints): Add AArch64. This is fine. Please install

Re: [PATCH] Fix PR55011

2012-10-23 Thread Michael Matz
Hi, On Tue, 23 Oct 2012, Richard Biener wrote: > > So, one question, are you claiming that a VRP worker like this: > > > >VR derive_new_range_from_operation (VR a, VR b) > > > > is _ever_ allowed to return UNDEFINED when a or b is something else than > > UNDEFINED? You seem to claim so AF

Re: [PATCH] [3/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch contains all of the new files for the target port itself, the patch does not modify any existing file. Proposed ChangeLog: * common/config/aarch64/aarch64-common.c: New file. * config/aarch64/aarch64-arches.def: New

[PATCH] Invalidate in cselib sp after processing frame_pointer_needed fp setter (PR rtl-optimization/54921)

2012-10-23 Thread Jakub Jelinek
Hi! This is an attempt to hopefully end the endless stream of aliasing miscompilations where alias.c assumes that hfp based accesses can't alias sp based accesses, but both sp and fp can appear in VALUEs pretty much randomly. As detailed in the PR, we have the r variable at rbp - 48 and rsp is al

Re: [PATCH] [1/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch contains the adjustments to top level gcc configury required to enable the AArch64 port. Proposed ChangeLog: * config.gcc: Add AArch64. * configure.ac: Add AArch64 TLS support detection. * configure: Regen

Re: [PATCH] [10/10] AArch64 Port

2012-10-23 Thread Jeff Law
On 10/23/2012 03:43 AM, Marcus Shawcroft wrote: This patch provides the AArch64 libstdc++-v3 port, it contains both the required configury adjustment to config.host and the new file introduced by the AArch64 port. Proposed ChangeLog: * config/cpu/aarch64/cxxabi_tweaks.h: New file.

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Xinliang David Li
On Tue, Oct 23, 2012 at 6:11 AM, Dodji Seketeli wrote: > This patch instruments many memory access patterns through builtins. > > Basically, for a call like: > > __builtin_memset (from, 0, n_bytes); > > the patch would only instrument the accesses at the beginning and at > the end of the memo

[Patch] libitm: Ask dispatch whether it requires serial mode.

2012-10-23 Thread Torvald Riegel
This patch cleans up an implicit assumption about which TM methods actually need to be run in serial mode. Instead, the transaction begin code now asks a TM method's dispatch what it needs. OK for trunk? Torvald commit 12170ba5013e855bf4ea784823961f63e3e2de4c Author: Torvald Riegel Date: Tue

[patch] libitm: Clarify ABI requirements for data-logging functions.

2012-10-23 Thread Torvald Riegel
This patch clarifies the ABI requirements for data-logging functions in libitm's documentation. Thanks to Luke Dalessandro for pointing this out. OK for trunk? Torvald commit b9cbb260f958f53afbea69675458f3f15a04b812 Author: Torvald Riegel Date: Tue Oct 23 14:56:32 2012 +0200 Clarify ABI

[PATCH, ARM] Fix offset_ok_for_ldrd_strd in Thumb1

2012-10-23 Thread Greta Yorsh
The function offset_ok_for_ldrd_strd should return false for Thumb1, because TARGET_LDRD and Thumb1 can be both enabled (for example, the default for cortex-m0). This patch fixes ICE that is caused by gcc r192678 and occurs when building gcc with newlib for arm-none-eabi cortex-m0. Ok for trunk?

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 08:47:48AM -0700, Xinliang David Li wrote: > > + /* The builtin below cannot be safely instrumented as their > > + length parameter is just a mere limit. > > + > > Why can't the following be instrumented? The length is min (n, strlen (str)). Because that would

Re: [PATCH] [3/10] AArch64 Port

2012-10-23 Thread Ramana Radhakrishnan
On 10/23/12 16:38, Jeff Law wrote: > On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: > > The one question in the back of my mind is whether or not this uses the > new iterator support we discussed a few months ago? I can't recall if > that was integrated into the trunk or not. Generic support fo

Re: [PATCH, ARM] Fix offset_ok_for_ldrd_strd in Thumb1

2012-10-23 Thread Ramana Radhakrishnan
Ok for trunk? Ok. ramana

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote: > + /* (src, n) style memops. */ > +case BUILT_IN_STRNDUP: > + source0 = gimple_call_arg (call, 0); > + len = gimple_call_arg (call, 1); > + break; I think you can't instrument strndup either, the length is ju

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-23 Thread Xinliang David Li
On Tue, Oct 23, 2012 at 8:58 AM, Jakub Jelinek wrote: > On Tue, Oct 23, 2012 at 08:47:48AM -0700, Xinliang David Li wrote: >> > + /* The builtin below cannot be safely instrumented as their >> > + length parameter is just a mere limit. >> > + >> >> Why can't the following be instrumen

Re: [PATCH, ARM] Fix offset_ok_for_ldrd_strd in Thumb1

2012-10-23 Thread Richard Earnshaw
On 23/10/12 16:54, Greta Yorsh wrote: The function offset_ok_for_ldrd_strd should return false for Thumb1, because TARGET_LDRD and Thumb1 can be both enabled (for example, the default for cortex-m0). This patch fixes ICE that is caused by gcc r192678 and occurs when building gcc with newlib for

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Kenneth Zadeck
On 10/23/2012 10:12 AM, Richard Biener wrote: On Tue, Oct 9, 2012 at 5:09 PM, Kenneth Zadeck wrote: This patch implements the wide-int class.this is a more general version of the double-int class and is meant to be the eventual replacement for that class.The use of this class removes a

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Matthias Klose
On 23.10.2012 06:55, Ian Lance Taylor wrote: > PR 54918 points out that libgo is not using version numbers as it > should. At present none of libgo in 4.6, 4.7 and mainline are > compatible with each other. This patch to the 4.7 branch sets the > version number for libgo there. Bootstrapped and

[Patch] Potential fix for PR55033

2012-10-23 Thread Sebastian Huber
-- Sebastian Huber, embedded brains GmbH Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany Phone : +49 89 18 90 80 79-6 Fax : +49 89 18 90 80 79-9 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilu

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 06:16:25PM +0200, Matthias Klose wrote: > On 23.10.2012 06:55, Ian Lance Taylor wrote: > > PR 54918 points out that libgo is not using version numbers as it > > should. At present none of libgo in 4.6, 4.7 and mainline are > > compatible with each other. This patch to the

Re: [C++ PATCH] Fix cplus_decl_attributes (PR c++/54988)

2012-10-23 Thread Jason Merrill
OK. Jason

Re: [PATCH] [3/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
On 23/10/12 16:38, Jeff Law wrote: Given that you and Richard Earnshaw are the approved maintainers for the AAarch64 port, I'm going to give this an OK without diving into it. I'm going to assume you and Richard will iterate with anyone who does dive deeply into the port and has comments/sugges

[PATCH] variably_modified_type_p tweak for cdtor cloning (PR debug/54828)

2012-10-23 Thread Jakub Jelinek
Hi! The following testcase ICEs, because the VLA ARRAY_TYPE in the ctor isn't considered variably_modified_type_p during cloning of the ctor when the types weren't gimplified yet. The size is a non-constant expression that has SAVE_EXPR of a global VAR_DECL in it, so when variably_modified_type_p

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 9:27 AM, Jakub Jelinek wrote: > On Tue, Oct 23, 2012 at 06:16:25PM +0200, Matthias Klose wrote: >> On 23.10.2012 06:55, Ian Lance Taylor wrote: >> > PR 54918 points out that libgo is not using version numbers as it >> > should. At present none of libgo in 4.6, 4.7 and main

Re: [PATCH] [6/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
On 23/10/12 16:14, Jeff Law wrote: On 10/23/2012 03:42 AM, Marcus Shawcroft wrote: This patch adjusts the libatomic configury for AArch64. Proposed ChangeLog: * configure.tgt: Mark libatomic unsupported. This is good. Please install. Presumably at some point in the not too distan

Re: libgo patch committed: Update to current Go library

2012-10-23 Thread Uros Bizjak
Hello! > I have committed a patch to update the mainline version of libgo to the > current master Go library sources. At this point I will only be > updating the gcc 4.7 branch for bug fixes. > > This is a substantial patch that brings in several months of work. As > usual I am not posting the c

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-23 Thread Paul_Koning
On Oct 5, 2012, at 6:05 PM, Cary Coutant wrote: >> There certainly is a fair amount of code in dwarf2read.c in gdb to handle >> DW_AT_declaration and do things differently for declarations. >> >> Should I rework this patch to use that mechanism instead? If so, how? If >> the class is marked

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2012 at 09:57:21AM -0700, Ian Lance Taylor wrote: > The problem is that I forgot to do that when the 4.7 branch was > created. So the 4.7 branch and the 4.6 branch were using the same > SONAME although they had completely different ABIs. > > That is, there is no ABI change on the

Re: [C++ Patch] PR 54922

2012-10-23 Thread Jason Merrill
OK. Jason

Re: [PATCH] Fix sizeof related pt.c ICE (PR c++/54844)

2012-10-23 Thread Jason Merrill
OK. Jason

Re: LRA has been merged into trunk.

2012-10-23 Thread Uros Bizjak
Hello! > Hi, I was going to merge LRA into trunk last Sunday. It did not happen. LRA > was actively changed last 4 weeks by implementing reviewer's proposals which > resulted in a lot of new LRA regressions on GCC testsuite in comparison with > reload. Finally, they were fixed and everything lo

Re: [PATCH] [2/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
On 23/10/12 15:39, Joseph S. Myers wrote: On Tue, 23 Oct 2012, Marcus Shawcroft wrote: +@item -mcmodel=tiny +@opindex mcmodel=tiny +Generate code for the tiny code model. The program and its statically defined +symbols must be within 1GB of each other. Pointers are 64 bits. Programs can +be

Re: Fix bugs introduced by switch-case profile propagation

2012-10-23 Thread Easwaran Raman
On Tue, Oct 23, 2012 at 3:03 AM, Jan Hubicka wrote: >> Ping. >> >> >> On Wed, Oct 17, 2012 at 1:48 PM, Easwaran Raman wrote: >> > Hi, >> > This patch fixes bugs introduced by my previous patch to propagate >> > profiles during switch expansion. Bootstrap and profiledbootstrap >> > successful on

Re: [PATCH] [0/10] AArch64 Port

2012-10-23 Thread Marcus Shawcroft
On 23/10/12 10:42, Marcus Shawcroft wrote: Folks, We would like to request the merge of aarch64-branch into trunk. All of the patches approved by Jeff and Jakub are now committed, with the documentation correction requested by Joseph. /Marcus

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-23 Thread Jason Merrill
OK. Jason

Re: libgo patch committed: Update to current Go library

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 10:47 AM, Uros Bizjak wrote: > > On my x86_64-linux-gnu (Fedora 18) libgo testsuite fails following test: > > --- FAIL: TestCgoCrashHandler (0.01 seconds) > testing.go:377: program exited with error: exec: "go": > executable file not found in $PATH > --- FAIL: TestC

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Lawrence Crowl
On 10/23/12, Richard Biener wrote: > I wonder if for the various ways to specify precision/len there > is a nice C++ way of moving this detail out of wide-int. I can > think only of one: > > struct WIntSpec { > WIntSpec (unsigned int len, unsigned int precision); > WIntSpec (const_tree); >

[m68k] Fix option handling for -m68020-40 and -m68020-60

2012-10-23 Thread Gunther Nikl
Hello, While working with GCC 4.7, I noticed that the -m68020-40 and -m68020-60 options are broken. This bug was introduced in May 2011 with the patch at . The code in m68k_option_override to set cpu and tune doesn't trigger when using -m680

Re: libgo patch committed: Update to current Go library

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 10:47 AM, Uros Bizjak wrote: > > Additional test fails on alphaev68-linux-gnu: > > --- FAIL: TestPassFD (0.15 seconds) > passfd_test.go:62: FileConn: dup: Bad file descriptor > FAIL > FAIL: syscall As far as I can see this error message occurs when calling dup on the

Re: Tidy store_bit_field_1 & co.

2012-10-23 Thread Richard Sandiford
Eric Botcazou writes: >> + enum machine_mode op_mode = mode_for_extraction (EP_insv, 3); >>if (HAVE_insv >>&& GET_MODE (value) != BLKmode >>&& bitsize > 0 >> @@ -690,25 +670,34 @@ store_bit_field_1 (rtx str_rtx, unsigned >> -fstrict-volatile-bitfields is in effect.

Re: gcc 4.7 libgo patch committed: Set libgo version number

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 9:59 AM, Jakub Jelinek wrote: > On Tue, Oct 23, 2012 at 09:57:21AM -0700, Ian Lance Taylor wrote: >> The problem is that I forgot to do that when the 4.7 branch was >> created. So the 4.7 branch and the 4.6 branch were using the same >> SONAME although they had completely

Re: [Patch] Fix the tests gcc.dg/vect/vect-8[23]_64.c

2012-10-23 Thread Sharad Singhai
+cc richard.guent...@gmail.com If it is approved, I will be happy to commit it for you. Thanks, Sharad Sharad On Tue, Oct 23, 2012 at 6:52 AM, Dominique Dhumieres wrote: > Following the changes in [PATCH] Add option for dumping to stderr > (issue6190057) > the tests gcc.dg/vect/vect-8[23]_64.

Re: LRA has been merged into trunk.

2012-10-23 Thread Vladimir Makarov
On 10/23/2012 01:57 PM, Uros Bizjak wrote: Hello! Hi, I was going to merge LRA into trunk last Sunday. It did not happen. LRA was actively changed last 4 weeks by implementing reviewer's proposals which resulted in a lot of new LRA regressions on GCC testsuite in comparison with reload. Fina

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Lawrence Crowl
On 10/23/12, Kenneth Zadeck wrote: > On 10/23/2012 10:12 AM, Richard Biener wrote: > > + inline bool minus_one_p () const; > > + inline bool zero_p () const; > > + inline bool one_p () const; > > + inline bool neg_p () const; > > > > what's wrong with w == -1, w == 0, w == 1, etc.? > > I would

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-23 Thread Paul_Koning
On Oct 23, 2012, at 2:02 PM, Jason Merrill wrote: > OK. > > Jason Thanks. Committed. paul

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Kenneth Zadeck
On 10/23/2012 02:38 PM, Lawrence Crowl wrote: On 10/23/12, Kenneth Zadeck wrote: On 10/23/2012 10:12 AM, Richard Biener wrote: + inline bool minus_one_p () const; + inline bool zero_p () const; + inline bool one_p () const; + inline bool neg_p () const; what's wrong with w == -1, w == 0,

Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-10-23 Thread Manuel López-Ibáñez
On 19 October 2012 18:17, Joseph S. Myers wrote: > On Wed, 17 Oct 2012, Manuel López-Ibáñez wrote: > >> documentation but I can also implement -Wformat=0 being an alias for >> -Wno-format and -Wformat=1 an alias for -Wformat and simply reject >> -Wno-format=. > > I think that's what's wanted; -Wno

Re: [PATCH] [7/10] AArch64 Port

2012-10-23 Thread Tom Tromey
> "Marcus" == Marcus Shawcroft writes: Marcus> This patch adjusts the libcpp configury for AArch64. Marcus> Proposed ChangeLog: Marcus> * configure.ac: Enable AArch64. Marcus> * configure: Regenerate. This is ok. Thanks. Tom

Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-23 Thread Tom Tromey
Steven> Probably you mean the revised patch here: Steven> http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html Steven> The patch look OK to me but I can't approve it. I'm sorry about the delay on this. The libcpp bits are ok. I can't approve the other parts. I think new configure options sho

Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 12:38 PM, Tom Tromey wrote: > Steven> Probably you mean the revised patch here: > Steven> http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html > > Steven> The patch look OK to me but I can't approve it. > > I'm sorry about the delay on this. > > The libcpp bits are ok. >

Re: [m68k] Fix option handling for -m68020-40 and -m68020-60

2012-10-23 Thread Andreas Schwab
Gunther Nikl writes: > While working with GCC 4.7, I noticed that the -m68020-40 and -m68020-60 > options are broken. Broken in which way? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something complete

  1   2   >