Re: [Patch contrib] check_GNU_style: remove tmp file

2012-10-01 Thread Christophe Lyon
Ping? May I commit this small patch? http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00580.html Thanks, Christophe. On 10 September 2012 14:23, Christophe Lyon wrote: > On 9 September 2012 12:46, Gerald Pfeifer wrote: >> On Mon, 3 Sep 2012, Christophe Lyon wrote: >>> check_GNU_style.sh currently

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Jakub Jelinek
On Mon, Oct 01, 2012 at 08:47:13AM +0200, Steven Bosscher wrote: > The test case compiles just fine at -O2, only VRP has trouble with it. > Let's try to stick with facts, not speculation. I was talking about the other PR, PR26854, which from what I remember when trying it myself and even the lates

Re: [rtl] combine a vec_concat of 2 vec_selects from the same vector

2012-10-01 Thread Eric Botcazou
> 2012-09-09 Marc Glisse > > gcc/ > * simplify-rtx.c (simplify_binary_operation_1) : > Detect the identity. > : Handle VEC_SELECTs from the same vector. > > gcc/testsuite/ > * gcc.target/i386/vect-rebuild.c: New testcase. OK if you adjust the above date and add the mis

[Ada] Ada 2012 Legality check on requeue statements

2012-10-01 Thread Arnaud Charlet
The target of a requeue statement on a protected entry must be a variable. This is part of AI05-0225, a binding interpretation that applies to all versions of the language. See ACATS test b954005.adb. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-01 Ed Schonberg * sem_ch9

[Ada] Validity checks on subprogram parameters and results

2012-10-01 Thread Arnaud Charlet
This patch introduces two new validity checks to the GNAT compiler: 1) -gnatVl Check non-overlapping parameters When this check is enabled, each subprogram call is preceded by a sequence of checks that ensure no overlap between actual parameters. 2) -gnatVv Check proper initialization of scal

[i386] Fix unwind/debug info for nested functions on 64-bit Windows

2012-10-01 Thread Eric Botcazou
Hi, in the section of ix86_expand_prologue establishing the frame for Windows targets, there is: /* Note that SEH directives need to continue tracking the stack pointer even after the frame pointer has been set up. */ if (m->fs.cfa_reg == stack_pointer_rtx || TARGET_SEH)

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
[ Sorry for re-send, it seems that mobile gmail sends text/html and the sourceware mailer daemon rejects that. ] On Monday, October 1, 2012, Jakub Jelinek wrote: > On Sun, Sep 30, 2012 at 06:50:50PM -0400, Vladimir Makarov wrote: > > I think this testcase shouldn't be a show stopper for LRA inclu

[Ada] Handling of -vPx with incorrect x

2012-10-01 Thread Arnaud Charlet
Command line switch -vPx (set verbosity level for project file facility) in gnatmake and gnatcmd is is valid only for x=0, 1, or 2. This change ensures that any attempt to pass an invalid value generates a proper error message. The following commands must generate the indicated errors: $ gnat lis

[Ada] Detect more cases of possible infinite loops

2012-10-01 Thread Arnaud Charlet
In cases where GNAT did not detect the possibility of an infinite loop, it now issues a warning. For example, on the following code: $ gcc -c bad.adb bad.adb:9:13: warning: variable "Cur" is not modified in loop body bad.adb:9:13: warning: possible infinite loop 1. package body Bad is 2

[Ada] Ada 2012 legality checks on uses of names of protected procedures

2012-10-01 Thread Arnaud Charlet
Ada 2012 AI05-0225 clarifies that most uses of the names of protected procedures and entries require that the target object (explicit or implicit) be a variable. This applies to calls, generic actuals, and prefixes of 'Access. It applies in particular to such uses within the body a protected funct

[Ada] Tagged "/=" operator in GNAT tree doesn't get fully resolved with -gnatc

2012-10-01 Thread Arnaud Charlet
When an inequality operator is used for a tagged type, the tree node for the inequality prior to expansion (such as with -gnatc) reflects "/=" operator in Standard rather than being resolved to be a logical negation of the tagged type's equality function. This is a problem for ASIS in Corresponding

Re: [rtl] combine a vec_concat of 2 vec_selects from the same vector

2012-10-01 Thread Marc Glisse
On Mon, 1 Oct 2012, Eric Botcazou wrote: 2012-09-09 Marc Glisse gcc/ * simplify-rtx.c (simplify_binary_operation_1) : Detect the identity. : Handle VEC_SELECTs from the same vector. gcc/testsuite/ * gcc.target/i386/vect-rebuild.c: New testcase. OK if you ad

[Ada] Next step in implementing extended overflow checking

2012-10-01 Thread Arnaud Charlet
This patch defines the four modes of overflow handling (SUPPRESSED, CHECKED, MINIMIZED, ELIMINATED), and adds the Overflow_Checks pragma and extedned -gnato switch to et them. But for now Checked, Minimized, and Eliminated are all treated as Checked, so the behavior is unchanged. The following pro

Re: [rtl] combine a vec_concat of 2 vec_selects from the same vector

2012-10-01 Thread Eric Botcazou
> > /* Try to merge 2 VEC_SELECTs from the same vector into a single one. */ > > I was trying to avoid splitting in 2 lines, but ok I'll split. Indeed. Then you can remove the '2' above, it doesn't add much. -- Eric Botcazou

[Ada] Set the flag In_Assertion_Expr during analysis of assertion expressions

2012-10-01 Thread Arnaud Charlet
In_Assertion_Expr should be non-zero during analysis of assertion expressions, even for preanalysis of these expressions. So wrap the call to Preanalyze_Spec_Expression to provide proper increment/decrement of the flag for assertion expressions. Tested on x86_64-pc-linux-gnu, committed on trunk 2

[Ada] Checks on aliasing and initialization of scalars for parameters

2012-10-01 Thread Arnaud Charlet
This patch reimplements the checks related to aliasing and initialization of scalars for subprogram parameters and ties them to compilation flags -gnateA and -gnateV respectively. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-01 Hristian Kirtchev * checks.adb (Apply_Parame

[Ada] Invariant checks and multiple inheritance

2012-10-01 Thread Arnaud Charlet
This patch fixes some problems involving the use of Type_Invariant'Class on the ancestor of a derived type that also implements an interface. The following command: gnatmake -q -gnat12 -gnata test_invariant test_invariant must yield: raised SYSTEM.ASSERTIONS.ASSERT_FAILURE : fa

[Ada] Ada 2012 invariant checks on subcomponents

2012-10-01 Thread Arnaud Charlet
If a record has a subvomponent whose type has a defined invariant, then there must be a invariant check on that component whenever a value of the record type is created or modified by a visible primitive operation of the type. The command: gnatmake -q -gnat12 -gnata main main must yield:

[Ada] Additional invariant checks on composite types

2012-10-01 Thread Arnaud Charlet
If a composite type has a declared invariant, and some of its compoents are of types that have their own invariants, the invariant checks on those compoents must be added to the invariant checks for the enclosing type. The command; gnatmake -q -gnat12 -gnata test_bars test_bars must yield:

[Ada] Front-end support for per-instance coverage analysis

2012-10-01 Thread Arnaud Charlet
This changes adds circuitry to the front-end that allows the code generated for different instances of the same generic to be identified in debugging information. This will subsequently be used to allow per-instance coverage analysis. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-01

Re: vec_cond_expr adjustments

2012-10-01 Thread Richard Guenther
On Fri, Sep 28, 2012 at 6:55 PM, Marc Glisse wrote: > On Fri, 28 Sep 2012, Richard Guenther wrote: > >> On Fri, Sep 28, 2012 at 12:42 AM, Marc Glisse >> wrote: >>> >>> Hello, >>> >>> I have been experimenting with generating VEC_COND_EXPR from the >>> front-end, >>> and these are just a couple th

Profile housekeeping 5/n (make RTL loop optimizers to use loop bounds better)

2012-10-01 Thread Jan Hubicka
Hi, this patch commonizes the maximal iteration estimate logic in between SCEV and loop-iv. Both are now using loop->nb_iterations_upper_bound. I decided to keep same API for SCEV code as for RTL code, so I made estimated_loop_iterations and max_loop_iterations to not try to recompute bounds and

Re: [patch] Minor TARGET_MEM_REF cleanup

2012-10-01 Thread Richard Guenther
On Sat, Sep 29, 2012 at 1:17 PM, Eric Botcazou wrote: > Hi, > > for simple loops like: > > extern int a[]; > extern int b[]; > > void foo (int l) > { > int i; > > for (i = 0; i < l; i++) > a[i] = b [i]; > } > > you get in the .lim3 dump: > > Unanalyzed memory reference 0: _5 = MEM[symbol:

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-01 Thread Steven Bosscher
On Sat, Sep 29, 2012 at 8:37 AM, Bin Cheng wrote: > This is the updated patch according to your comments. Please review. > I also re-collected code size data and found it is improved by about 0.24% > for mips, which is better than previous data. I believe this should be > caused by recent changes

Re: [PATCH] Fix PR middle-end/54759

2012-10-01 Thread Richard Guenther
On Sun, Sep 30, 2012 at 9:03 PM, Dehao Chen wrote: > Hi, > > This patch fixes the bug when comparing location to UNKNOWN_LOC. > > Bootstrapped and passed gcc regression test. > > Okay for trunk? Ok. Thanks, Richard. > Thanks, > Dehao > > 2012-09-30 Dehao Chen > > PR middle-end/54759 > * gcc/

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Richard Guenther
On Mon, Oct 1, 2012 at 7:48 AM, Jakub Jelinek wrote: > On Sun, Sep 30, 2012 at 06:50:50PM -0400, Vladimir Makarov wrote: >> But I think that LRA cpu time problem for this test can be fixed. >> But I don't think I can fix it for 2 weeks. So if people believe >> that current LRA behaviour on this

Re: [Patch,avr]: Ad PR rtl-optimization/52543: Undo the MEM->UNSPEC hack

2012-10-01 Thread Denis Chertykov
2012/9/30 Georg-Johann Lay : >> Denis Chertykov wrote: >> I have tried to use secondary a few years ago (may be 5 or 7). >> I have definitely remember only one thing: secondary reload should be >> avoided as long as possible. > > > Currently each mov has to be decorated with moving the segment to R

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 9:16 AM, Jakub Jelinek wrote: > On Mon, Oct 01, 2012 at 08:47:13AM +0200, Steven Bosscher wrote: >> The test case compiles just fine at -O2, only VRP has trouble with it. >> Let's try to stick with facts, not speculation. > > I was talking about the other PR, PR26854, which

Re: Profile housekeeping 5/n (make RTL loop optimizers to use loop bounds better)

2012-10-01 Thread Richard Guenther
On Mon, Oct 1, 2012 at 11:37 AM, Jan Hubicka wrote: > Hi, > this patch commonizes the maximal iteration estimate logic in between SCEV and > loop-iv. Both are now using loop->nb_iterations_upper_bound. I decided to > keep same API for SCEV code as for RTL code, so I made > estimated_loop_iterati

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 11:52 AM, Richard Guenther wrote: >> I think this testcase shouldn't be a show stopper for LRA inclusion into >> 4.8, but something to look at for stage3. > > I agree here. I would also agree if it were not for the fact that IRA is already a scalability bottle-neck and that

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Sun, Sep 30, 2012 at 7:03 PM, Richard Guenther wrote: > On Sun, Sep 30, 2012 at 6:52 PM, Steven Bosscher > wrote: >> Hi, >> >> >> To look at it in yet another way: >> >>> integrated RA : 189.34 (16%) usr >>> LRA non-specific: 59.82 ( 5%) usr >>> LRA virtuals eliminatenon

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Jakub Jelinek
On Mon, Oct 01, 2012 at 12:01:36PM +0200, Steven Bosscher wrote: > I would also agree if it were not for the fact that IRA is already a > scalability bottle-neck and that has been known for a long time, too. > I have no confidence at all that if LRA goes in now, these scalability > problems will be

[Ada] Implement extended overflow handling for comparison ops

2012-10-01 Thread Arnaud Charlet
This patch enables extended overflow handling for comparison ops so that the comparison can be done in an expanded type, or even in bignum mode if operating in ELIMINATED overflow check mode. The following test program: 1. with Text_IO; use Text_IO; 2. procedure Overflowm2 is 3.

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 12:14 PM, Jakub Jelinek wrote: > On Mon, Oct 01, 2012 at 12:01:36PM +0200, Steven Bosscher wrote: >> I would also agree if it were not for the fact that IRA is already a >> scalability bottle-neck and that has been known for a long time, too. >> I have no confidence at all t

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Bernd Schmidt
On 10/01/2012 12:14 PM, Jakub Jelinek wrote: > On Mon, Oct 01, 2012 at 12:01:36PM +0200, Steven Bosscher wrote: >> I would also agree if it were not for the fact that IRA is already a >> scalability bottle-neck and that has been known for a long time, too. >> I have no confidence at all that if LRA

[Patch, Committed] Fix declared inline after being called warning

2012-10-01 Thread Tom de Vries
Hi, I've committed to branch 4.7 as obvious attached patch that fixes a compiler warning 'declared inline after being called'. I ran into this warning when building the 4.7 branch with a gcc 4.3 compiler: ... var-tracking.c:558: warning: 'set_dv_changed' declared inline after being called var-tra

[patch][lra] Use XNEWVEC and friends instead of xmalloc/xrealloc, and add some timevars

2012-10-01 Thread Steven Bosscher
Hello, This patch uses the libiberty new-like operators instead of using xmalloc/xrealloc. It also adds timevars for the main LRA phases, and it fixes a warning suggesting a space before a ';' in an only-looping for loop. Bootstrapped (lra-branch, of course) on x86_64-unknown-linux-gnu. OK? Ciao

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 12:10 PM, Steven Bosscher wrote: > The " LRA create live range" time is mostly spent in merge_live_ranges > walking lists. Hmm no, that's just gcc17's ancient debugger telling me lies. lra_live_range_in_p is not even used. /me upgrades to something newer than gdb 6.8... C

Re: Constant-fold vector comparisons

2012-10-01 Thread Richard Guenther
On Sat, Sep 29, 2012 at 3:25 PM, Marc Glisse wrote: > Hello, > > this patch does 2 things (I should have split it in 2, but the questions go > together): > > 1) it handles constant folding of vector comparisons, > > 2) it fixes another place where vectors are not expected (I'll probably wait > to

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread H.J. Lu
On Sun, Sep 30, 2012 at 11:36 PM, Sharad Singhai wrote: > Resend to gcc-patches > > I have addressed the comments by fixing all the minor issues, > bootstrapped and tested on x86_64. I did the recommended reshuffling > by moving non-tree code from tree-dump.c into a new file dumpfile.c. > > I comm

[patch] experimenting with renumbering of pseudos after expand

2012-10-01 Thread Steven Bosscher
Hello, For most code, expand creates a lot of pseudos that are cleaned up in subsequent passes, if they even live long enough to make it there. On average, for cc1 preprocessed source, the number of "holes" in regno_reg_rtx is about half the size of that array, or in other words: regno_reg_rtx is

[PATCH] Fix PR47799 - debug info for early-inlining with LTO

2012-10-01 Thread Richard Guenther
This tries to emit proper debug information for early-inlined functions from LTO LTRANS phase (thus, emit DW_TAG_inlined_subroutine and allow gdb to set breakpoints). We need to avoid confusing LTO and dwarf2out with the full abstract block tree, so this patch "flattens" the abstract block tree b

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-01 Thread Richard Guenther
On Sun, 30 Sep 2012, Jan Hubicka wrote: > Hi, > the point of the following patch is to make vectorizer to not vectorize the > following testcase with profile feedback: > > int a[1]; > int i=5; > int k=2; > int val; > __attribute__ ((noinline,noclone)) > test() > { > int j; > for(j

Re: [PATCH] Do not mark pseudo-copies decomposable during first lower-subreg pass

2012-10-01 Thread Ulrich Weigand
> * gcc.dg/lower-subreg-1.c: Disable on arm-*-* targets. I just noticed that the triple is incomplete; we're supposed to use arm*-*-* instead of just arm-*-*. Checked in the the following fix as obvious. Bye, Ulrich 2012-10-01 Ulrich Weigand * gcc.dg/lower-subreg-1.c: Disabl

Re: [patch] experimenting with renumbering of pseudos after expand

2012-10-01 Thread Richard Guenther
On Mon, Oct 1, 2012 at 2:06 PM, Steven Bosscher wrote: > Hello, > > For most code, expand creates a lot of pseudos that are cleaned up in > subsequent passes, if they even live long enough to make it there. On > average, for cc1 preprocessed source, the number of "holes" in > regno_reg_rtx is abou

Re: [PATCH] Fix instability of -fschedule-insn for x86

2012-10-01 Thread Igor Zamyatin
We also plan to test these changes along with LRA On Sun, Sep 30, 2012 at 4:33 PM, Uros Bizjak wrote: > On Tue, Sep 18, 2012 at 1:31 PM, Uros Bizjak wrote: > >>> This patch aims to fix all stability issues related to using the first >>> scheduler in gcc >>> for x86 target (there several reported

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Sat, Sep 29, 2012 at 10:26 PM, Steven Bosscher wrote: > LRA create live ranges : 175.30 (15%) usr 2.14 (13%) sys 177.44 > (15%) wall2761 kB ( 0%) ggc I've tried to split this up a bit more: process_bb_lives ~50% create_start_finish_chains ~25% remove_some_program_points_and_update_liv

[Ada] Membership tests work with extended overflow checks

2012-10-01 Thread Arnaud Charlet
This patch implements membership tests in which the operands can be out of range in extended overflow checkig modes. The following is a test program: 1. pragma Ada_2012; 2. with Text_IO; use Text_IO; 3. procedure Overflowm3 is 4.subtype Int10 is Integer range 1 .. 5;

[Ada] Exponentiation works with extended overflow checks

2012-10-01 Thread Arnaud Charlet
This patch implements extended overflow checking modes with the exonentiation operator. The following is a test program: 1. with Text_IO; use Text_IO; 2. procedure Overflowm4 is 3.function r1 (a, b : Integer) return Boolean is 4.begin 5. return a ** 2 - b **

[Ada] Division/Rem/Mod work with extended overflow checks

2012-10-01 Thread Arnaud Charlet
This patch implements extended overflow checking modes with the division, rem, and mod operators. This completes the work on extended overflow checking. The following is a test program: 1. with Text_IO; use Text_IO; 2. procedure Overflowm5 is 3.function r1 (a, b, c : Integer)

[Ada] Static predicate checks on type conversions

2012-10-01 Thread Arnaud Charlet
In Ada 2012, if a subtype has predicates, a predicate check must be applied to the expression in a type conversion to the subtype. Furthermore, if the expression is a scalar static constant, the predicate must be evluated at compile-time, and the program must be rejected if the predicate is false.

[Ada] Complain when actual Symbol is present in any dimension output call

2012-10-01 Thread Arnaud Charlet
This patch prevents the user to provide parameter Symbol (reserved for compiler use only) in any dimension output call. -- Source -- with System.Dim.Mks;use System.Dim.Mks; with System.Dim.Mks_IO; use System.Dim.Mks_IO; procedure Main is begin Put (8.0**(1 / 3) *

[PATCH] Fix -frounding-math builtins

2012-10-01 Thread Richard Guenther
I noticed that we attach the no-vops attribute to -frounding-math math functions. That's bogus as can be seen from the testcase int fesetround(int); double asinh(double x); double foo (double x, int b) { double y = 0.0, z; if (b) y = asinh (x); fesetround (0x400 /*FE_DOWNWARD*/); z

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Sharad Singhai
I am sorry, I didn't enable all the languages. Will fix the fortran test breakage shortly. Thanks, Sharad Sharad On Mon, Oct 1, 2012 at 4:50 AM, H.J. Lu wrote: > On Sun, Sep 30, 2012 at 11:36 PM, Sharad Singhai wrote: >> Resend to gcc-patches >> >> I have addressed the comments by fixing all t

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread H.J. Lu
On Mon, Oct 1, 2012 at 6:49 AM, Sharad Singhai wrote: > I am sorry, I didn't enable all the languages. Will fix the fortran > test breakage shortly. It is not just Fortran. There are some failures in C testcases. > Thanks, > Sharad > Sharad > > > On Mon, Oct 1, 2012 at 4:50 AM, H.J. Lu wrote:

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Sharad Singhai
On Mon, Oct 1, 2012 at 6:52 AM, H.J. Lu wrote: > On Mon, Oct 1, 2012 at 6:49 AM, Sharad Singhai wrote: >> I am sorry, I didn't enable all the languages. Will fix the fortran >> test breakage shortly. > > It is not just Fortran. There are some failures in C testcases. I checked and those files l

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Richard Guenther
On Mon, Oct 1, 2012 at 3:55 PM, Sharad Singhai wrote: > On Mon, Oct 1, 2012 at 6:52 AM, H.J. Lu wrote: >> On Mon, Oct 1, 2012 at 6:49 AM, Sharad Singhai wrote: >>> I am sorry, I didn't enable all the languages. Will fix the fortran >>> test breakage shortly. >> >> It is not just Fortran. There

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Sharad Singhai
Okay, I am retesting without any special configs and with multilibs as you suggested. Thanks, Sharad On Mon, Oct 1, 2012 at 7:00 AM, Richard Guenther wrote: > On Mon, Oct 1, 2012 at 3:55 PM, Sharad Singhai wrote: >> On Mon, Oct 1, 2012 at 6:52 AM, H.J. Lu wrote: >>> On Mon, Oct 1, 2012 at 6:49

Second ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-01 Thread Simon Baldwin
Ping, again. On 21 September 2012 12:45, Simon Baldwin wrote: > > Ping. > > http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html > > Full text of previous message and context at URL above. No comments > or code changes since. Patch description left below for convenience. > > > > > Add flags

[Patch] Fix PR53397

2012-10-01 Thread venkataramanan.kumar
Hi, The below patch fixes the FFT/Scimark regression caused by useless prefetch generation. This fix tries to make prefetch less aggressive by prefetching arrays in the inner loop, when the step is invariant in the entire loop nest. GCC currently tries to prefetch invariant steps when they are

Re: [PATCH, i386]: Implement atomic_fetch_sub

2012-10-01 Thread Andrew MacLeod
On 08/30/2012 05:33 PM, Richard Henderson wrote: On 08/23/2012 08:59 AM, Andrew MacLeod wrote: 2012-08-23 Andrew MacLeod gcc PR target/54087 * optabs.c (expand_atomic_fetch_op_no_fallback): New. Factored code from expand_atomic_fetch_op. (expand_atomic_fetch_

Re: vec_cond_expr adjustments

2012-10-01 Thread Marc Glisse
[merging both threads, thanks for the answers] On Mon, 1 Oct 2012, Richard Guenther wrote: optabs should be fixed instead, an is_gimple_val condition is implicitely val != 0. For vectors, I think it should be val < 0 (with an appropriate cast of val to a signed integer vector type if necessar

Re: [patch, mips] Patch for new mips triplet - mips-mti-elf

2012-10-01 Thread Steve Ellcey
On Sun, 2012-09-30 at 19:53 +0100, Richard Sandiford wrote: > Sorry for only noticing now, but this produced: > > ERROR: gcc.target/mips/pr37362.c -O0 : syntax error in target selector > "target ! mips*-sde-elf mips*-mti-elf" for " dg-do 2 compile { target { ! > mips*-sde-elf mips*-mti-elf } }

Re: Tweak IRA checks for singleton register classes

2012-10-01 Thread Vladimir Makarov
On 12-09-30 2:21 PM, Richard Sandiford wrote: IRA has code to check whether there is only a single acceptable register for a given operand. This code uses conditions like: ira_class_hard_regs_num[cl] != 0 && (ira_class_hard_regs_num[cl] <= ira_reg_class_max_nregs[cl][mode]) i.e. the numb

Re: [PATCH, i386]: Implement atomic_fetch_sub

2012-10-01 Thread Paolo Bonzini
Il 03/08/2012 17:08, Richard Henderson ha scritto: > On 2012-08-03 08:01, Uros Bizjak wrote: >> On Fri, Aug 3, 2012 at 4:40 PM, Richard Henderson wrote: >>> On 2012-08-03 01:51, Uros Bizjak wrote: The same reasoning goes for dynamic negation: for neg %eax,%eax value 0x8000 stays the

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Vladimir Makarov
On 12-10-01 6:30 AM, Bernd Schmidt wrote: On 10/01/2012 12:14 PM, Jakub Jelinek wrote: On Mon, Oct 01, 2012 at 12:01:36PM +0200, Steven Bosscher wrote: I would also agree if it were not for the fact that IRA is already a scalability bottle-neck and that has been known for a long time, too. I ha

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-01 Thread Jan Hubicka
> > > > So the unvectorized cost is > > SIC * niters > > > > The vectorized path is > > SOC + VIC * ((niters-PL_ITERS-EP_ITERS)/VF) + VOC > > The scalar path of vectorizer loop is > > SIC * niters + SOC > > Note that 'th' is used for the runtime profitability check

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Michael Meissner
Your change on September 30th, breaks the powerpc port because the REPORT_DETAILS value in the enumeration is no longer there, and the rs6000_density_test function was using that. Please in the future, when you are making global changes, grep for uses of enum values in all of the machine dependent

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Michael Meissner
On Mon, Oct 01, 2012 at 02:02:26PM -0400, Michael Meissner wrote: > Your change on September 30th, breaks the powerpc port because the > REPORT_DETAILS value in the enumeration is no longer there, and the > rs6000_density_test function was using that. Please in the future, when you > are making gl

Re: [patch, libfortran] Fix PR 54736, memory corruption with GFORTRAN_CONVERT_UNIT

2012-10-01 Thread Thomas Koenig
Hello world, the previous version of the patch has an issue that Shane pointed out in the PR. This version should work; at least it survived all the test cases I could come up with. Regression-tested (again). OK for trunk? Also for 4.6 and 4.7? Thomas 2012-10-01 Thomas König

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Gabriel Dos Reis
On Mon, Oct 1, 2012 at 1:27 PM, Michael Meissner wrote: > On Mon, Oct 01, 2012 at 02:02:26PM -0400, Michael Meissner wrote: >> Your change on September 30th, breaks the powerpc port because the >> REPORT_DETAILS value in the enumeration is no longer there, and the >> rs6000_density_test function w

Re: RFC: LRA for x86/x86-64 [4/9]

2012-10-01 Thread Richard Sandiford
Thanks a lot for doing this. When you finally get to the stage of "rm reload.c reload1.c", please do it in a screen session and save the log for posterity. Vladimir Makarov writes: > +/* Return register bank of given hard regno for the current target. */ > +DEFHOOK > +(register_bank, > + "A tar

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Ian Lance Taylor
On Mon, Oct 1, 2012 at 10:51 AM, Vladimir Makarov wrote: > > When I proposed merge LRA to gcc4.8, I had in mind that: > o moving most changes from LRA branch will help LRA maintenance on the > branch and I'll have more time to work on other targets and problems. > o the earlier we start the tr

Re: RFC: LRA for x86/x86-64 [4/9]

2012-10-01 Thread Paul_Koning
On Oct 1, 2012, at 2:51 PM, Richard Sandiford wrote: > ... > E.g. for MIPS, SImode loads and stores have a displacement range of > [-32768, 32764], but DImode loads and stores only accept [-32768, 32760]. > So the maximal displacement depends on mode, even though the instruction set > is pretty r

Re: [Patch contrib] check_GNU_style: remove tmp file

2012-10-01 Thread Ian Lance Taylor
On Mon, Sep 10, 2012 at 5:23 AM, Christophe Lyon wrote: > > Good point. Here is a new version, catching the same signals as warn_summary. This is OK. Thanks. (Minor note: it's easier if you the ChangeLog entry in the body of the message rather than the patch.) Ian

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread David Miller
From: Ian Lance Taylor Date: Mon, 1 Oct 2012 11:55:56 -0700 > Steven is correct in saying that there is a tendency to move on and > never address GCC bugs. However, there is also a counter-vailing > tendency to fix GCC bugs. Anyhow I'm certainly not saying that in all > cases it's OK to accept

Re: PR 53889: Add __gthread_recursive_mutex_destroy

2012-10-01 Thread Ian Lance Taylor
On Sun, Sep 30, 2012 at 11:41 AM, Jonathan Wakely wrote: > There is no __gthread_recursive_mutex_destroy function in the gthreads API. > > Trying to use __gthread_mutex_destroy fails to compile on platforms > where the mutex > types are different. To avoid resource leaks libstdc++ needs to hack >

[SH] PR 51244 - Handle T bit -> 0x7FFFFFFF / 0x80000000

2012-10-01 Thread Oleg Endo
Hello, This handles the case where the T bit is stored to a reg as the value 0x7FFF or 0x8000. Tested on rev 191894 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new failures. OK? Cheers, Oleg gcc/ChangeLog:

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Vladimir Makarov
On 10/01/2012 03:19 PM, David Miller wrote: From: Ian Lance Taylor Date: Mon, 1 Oct 2012 11:55:56 -0700 Steven is correct in saying that there is a tendency to move on and never address GCC bugs. However, there is also a counter-vailing tendency to fix GCC bugs. Anyhow I'm certainly not sayi

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 9:19 PM, David Miller wrote: > From: Ian Lance Taylor > Date: Mon, 1 Oct 2012 11:55:56 -0700 > >> Steven is correct in saying that there is a tendency to move on and >> never address GCC bugs. However, there is also a counter-vailing >> tendency to fix GCC bugs. Anyhow I'

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-01 Thread Steven Bosscher
On Mon, Oct 1, 2012 at 9:51 PM, Vladimir Makarov wrote: >> I think it's more important in this case to recognize Steven's real >> point, which is that for an identical situation (IRA), and with an >> identical patch author, we had similar bugs. They were promised to be >> worked on, and yet some

Re: RFC: LRA for x86/x86-64 [4/9]

2012-10-01 Thread Jeff Law
On 09/27/2012 07:44 PM, Vladimir Makarov wrote: On 09/27/2012 08:07 PM, Joseph S. Myers wrote: On Thu, 27 Sep 2012, Vladimir Makarov wrote: Hook spill_class returns a value of enum reg_class which is defined in target-depend include file. That's what reg_class_t is for: avoiding enum reg_clas

[PATCH, libbacktrace]: Compile with -fasynchronous-unwind-tables

2012-10-01 Thread Uros Bizjak
Hello! Without -fasynchronous-unwind-tables, FDE is not generated for backtrace_full and backtrace_simple wrappers. Without FDE, unwinding terminates at these functions. Attached patch fixes this problem by adding -fasynchronous-unwind-tables, and this way forcing FDEs for all functions. With thi

Re: [patch][lra] Use XNEWVEC and friends instead of xmalloc/xrealloc, and add some timevars

2012-10-01 Thread Mike Stump
On Oct 1, 2012, at 4:05 AM, Steven Bosscher wrote: > This patch uses the libiberty new-like operators instead of using > xmalloc/xrealloc. So, in headers that can be used by C compiles, we should use the abstraction… Should we prefer it for translation units that are C++ only?

[PATCH] Fix powerpc breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Michael Meissner
I tracked down some of the other code that previously used REPORT_DETAILS, and MSG_NOTE is the new way to do the same thing. This bootstraps and no unexpected errors occur during make check. Is it ok to install? 2012-10-01 Michael Meissner * config/rs6000/rs6000.c (toplevel): Include

Re: [PATCH] Fix powerpc breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Gabriel Dos Reis
On Mon, Oct 1, 2012 at 4:37 PM, Michael Meissner wrote: > I tracked down some of the other code that previously used REPORT_DETAILS, and > MSG_NOTE is the new way to do the same thing. This bootstraps and no > unexpected errors occur during make check. Is it ok to install? yes -- qualifies as "

Convert more non-GTY htab_t to hash_table.

2012-10-01 Thread Lawrence Crowl
Change more non-GTY hash tables to use the new type-safe template hash table. Constify member function parameters that can be const. Correct a couple of expressions in formerly uninstantiated templates. The new code is 0.362% faster in bootstrap, with a 99.5% confidence of being faster. Tested on

[patch][lra] a few bitmap obstacks for lra-assigns

2012-10-01 Thread Steven Bosscher
Hello, This eliminates a few large loops in lra-assigns.c. They're not the most costly loops but the life times of the bitmaps is well-defined and destroying a bitmap obstack is much cheaper than looping over all bitmaps calling bitmap_clear. The saving is small but you have to start somewhere...

[PATCH rs6000 testsuite] Fix a couple tests for VSX scalar instructions

2012-10-01 Thread Pat Haugen
This patch fixes a couple failures that occur if the testsuite is run with -mvsx and the VSX scalar sqrt instructions are generated. Ok for trunk? -Pat testsuite/ChangeLog: 2012-10-01 Pat Haugen * gcc.target/powerpc/pr46728-1.c: Accept xssqrtdp. * gcc.target/powerpc/pr46728-

[patch][lra] Comment typo fix

2012-10-01 Thread Steven Bosscher
I suppose no-one would object if I commit this as obvious at some point? Index: lra-constraints.c === --- lra-constraints.c (revision 191858) +++ lra-constraints.c (working copy) @@ -4293,7 +4293,7 @@ update_ebb_live_info (rtx hea

Re: [patch][lra] Comment typo fix

2012-10-01 Thread Robert Dewar
On 10/1/2012 6:09 PM, Steven Bosscher wrote: I suppose no-one would object if I commit this as obvious at some point? Index: lra-constraints.c === --- lra-constraints.c (revision 191858) +++ lra-constraints.c (working copy) @@ -

MAINTAINERS: add myself as dwarf debugging code maintainer

2012-10-01 Thread Cary Coutant
2012-10-01 Cary Coutant * MAINTAINERS: Add myself as dwarf debugging code maintainer. Index: MAINTAINERS === --- MAINTAINERS (revision 191942) +++ MAINTAINERS (working copy) @@ -185,6 +185,7 @@ caller-save.c

Re: [PATCH] Fix powerpc breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Xinliang David Li
On Mon, Oct 1, 2012 at 2:37 PM, Michael Meissner wrote: > I tracked down some of the other code that previously used REPORT_DETAILS, and > MSG_NOTE is the new way to do the same thing. This bootstraps and no > unexpected errors occur during make check. Is it ok to install? > > 2012-10-01 Michae

Re: [PATCH, libbacktrace]: Compile with -fasynchronous-unwind-tables

2012-10-01 Thread Ian Lance Taylor
On Mon, Oct 1, 2012 at 2:12 PM, Uros Bizjak wrote: > > Without -fasynchronous-unwind-tables, FDE is not generated for > backtrace_full and backtrace_simple wrappers. Without FDE, unwinding > terminates at these functions. I'm not opposed to -fasynchronous-unwind-tables, but now that you bring it

Re: [PATCH] Fix powerpc breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Sharad Singhai
Thanks for tracking down and fixing the powerpc port. The "dump_kind_p ()" check is redundant but canonical form here. I think blocks of dump code guarded by "if dump_kind_p (...)" might be easier to read/maintain. Sharad Sharad On Mon, Oct 1, 2012 at 3:45 PM, Xinliang David Li wrote: > On Mon

Re: [PATCH] Fix powerpc breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Xinliang David Li
On Mon, Oct 1, 2012 at 4:05 PM, Sharad Singhai wrote: > Thanks for tracking down and fixing the powerpc port. > > The "dump_kind_p ()" check is redundant but canonical form here. I > think blocks of dump code guarded by "if dump_kind_p (...)" might be > easier to read/maintain. > I find it confus

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2d

2012-10-01 Thread Michael Meissner
2012-10-01 Michael Meissner * config/rs6000/rs6000.c (rs6000_option_override_internal): If -mcpu= is not specified and the compiler is not configured using --with-cpu=, use the bits from the TARGET_DEFAULT to set the initial options. I reworked the patch to allo

[v3] libstdc++/54757

2012-10-01 Thread Paolo Carlini
Hi, sanity checked x86_64-linux (both cases), committed to mainline. Thanks, Paolo. / 2012-10-01 Paolo Carlini PR libstdc++/54757 * include/ext/random (rice_distribution<>::operator()): Use std::hypot only if _GLIBCXX_USE_C99_MATH_TR1.

Re: [PATCH rs6000 testsuite] Fix a couple tests for VSX scalar instructions

2012-10-01 Thread David Edelsohn
On Mon, Oct 1, 2012 at 6:03 PM, Pat Haugen wrote: > This patch fixes a couple failures that occur if the testsuite is run with > -mvsx and the VSX scalar sqrt instructions are generated. Ok for trunk? > > -Pat > > > testsuite/ChangeLog: > 2012-10-01 Pat Haugen > > * gcc.target/powerpc/pr

Re: [PATCH] Fix test breakage, was: Add option for dumping to stderr (issue6190057)

2012-10-01 Thread Sharad Singhai
Here is a patch to fix test breakage caused by r191883. Bootstrapped on x86_64 and tested with make -k check RUNTESTFLAGS="--target_board=unix/\{,-m32\}". Okay for trunk? Thanks, Sharad 2012-10-01 Sharad Singhai * tree-vect-stmts.c (vectorizable_operation): Add missing return. tests

  1   2   >