On Mon, Oct 1, 2012 at 1:27 PM, Michael Meissner <meiss...@linux.vnet.ibm.com> wrote: > On Mon, Oct 01, 2012 at 02:02:26PM -0400, Michael Meissner wrote: >> Your change on September 30th, breaks the powerpc port because the >> REPORT_DETAILS value in the enumeration is no longer there, and the >> rs6000_density_test function was using that. Please in the future, when you >> are making global changes, grep for uses of enum values in all of the machine >> dependent directories so we can avoid breakage like this. > > Also, in looking at the changes, given we are already up to 28 TDF_ flags, I > would recommend immediately adding a new type that is the TDF flagword type. > Thus it will be a lot simpler when we add 4 more TDF flags and have to change > the type from int to HOST_WIDE_INT.
Agreed that we need an abstraction here. -- Gaby
