Re: [RFC] Slightly fix up vgather* patterns

2011-10-10 Thread Jakub Jelinek
On Sun, Oct 09, 2011 at 12:55:40PM +0200, Uros Bizjak wrote: > About memory - can't we use (mem:BLK (match_operand:P > "register_operand" "r")) here? I don't think it is sufficient. Consider e.g. _mm_i32gather_pd (NULL, index, 1); where index is initialized from loading consecutive (32-bit) double

Re: [Patch, Fortran] Fix PR 50564

2011-10-10 Thread Tobias Burnus
Hi Thomas, > the attached patch fixes the PR by removing common function elimination > in FORALL statements. I think that part is OK. However, you do more - you also avoid the handling for DO CONCURRENT. However, I do not see why it could fail for DO CONCURRENT or rather: I do not see a case whe

Re: [wwwdocs] add libstdc++/1773 change to gcc-4.7/changes.html

2011-10-10 Thread Jonathan Wakely
On 10 October 2011 02:10, Gerald Pfeifer wrote: > On Tue, 4 Oct 2011, Jonathan Wakely wrote: >> I've committed this, which documents the fix for >> http://gcc.gnu.org/PR1773 in gcc-4.7/changes.html, and also replaces >> some > characters with the > entity. > > Interesting that the latter was not ca

[Backport 4.6,AVR,Comitted] Fix PR50652

2011-10-10 Thread Georg-Johann Lay
Backported to 4.6 branch: http://gcc.gnu.org/viewcvs?view=revision&revision=179738 Johann PR target/50652 Backport from Mainline r179737. * config/avr/avr-devices.c (avr_mcu_types): Set .data_section_start of atmega164a to 0x100.

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Richard Guenther
On Sun, 9 Oct 2011, Jan Hubicka wrote: > Hi, > whopr currently produce local_static.1234.43124 type symbols. This is because > everything gets mangled at WPA time and then again at ltrans time. This > simply > avoids the second mangling. This save some space & makes WHOPR/non_WHOPR > symbol > t

[PATCH] Mark static const strings as read-only.

2011-10-10 Thread Tom de Vries
Eric, without this patch, the mips code for the memcpy test-case in the patch looks like this. The loadbytes (lbu) and the storebytes (sb) are considered to alias, so the scheduler cannot rearrange them in a more optimal order. ... lui $2,%hi($LC0) lbu $3,%lo($LC0)($2)

[Patch,AVR]: Save instruction when squaring HI

2011-10-10 Thread Georg-Johann Lay
This is an obvious mini-optimization if the input operands of mulhi are the same, one multiply operation can be saved. Ok for trunk? Johann * config/avr/avr.md (*mulhi3_enh): Treat squaring smarter. Index: config/avr/avr.md

Re: [committed] More e-mail address fixes in ChangeLogs: dead e-mail address

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 8:07 PM, Mikael Morin wrote: > On Sunday 09 October 2011 19:30:20 Richard Guenther wrote: >> We usually don't retroactively change ChangeLogs this way. > On the other hand, ChangeLogs usually don't need to be changed. > >> Please refrain from making further changes like this

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > From: Andi Kleen > > Benchmarks show slightly faster build times on a kernel > build, near the measurement error unfortunately. > > This will only work with a recent glibc that defines MADV_HUGEPAGE. Will partial unmaps fail or split the page?

Re: [PATCH 2/5] Increase the GGC quite size to 2MB

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > From: Andi Kleen > > Using 2MB allows modern kernels to use 2MB huge pages on x86. Ok. Thanks, Richard. > gcc/: > > 2011-10-08   Andi Kleen > >        * ggc-page.c (GGC_QUIRE_SIZE): Increase to 512 > --- >  gcc/ggc-page.c |    2 +- >  1 file

Re: [PATCH 5/5] Add error checking to lto_section_read

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > From: Andi Kleen > > Various callers of lto_section_read segfault on a NULL return > when the mmap fails. Add some internal_errors to give a better > message to the user. Hm, shouldn't these be fatal_error () then? Ok with that change. Thanks

Re: [PATCH 4/5] Add a freeing threshold for the garbage collector.

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > From: Andi Kleen > > Add a threshold to avoid freeing pages back too early to the OS. > This avoid virtual memory map fragmentation. > > Based on a idea from Honza Less than 20% looks high. Shouldn't ggc-free-min be enough to avoid fragmentati

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Richard Guenther
On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > From: Andi Kleen > > Use the Linux MADV_DONTNEED call to unmap free pages in the garbage > collector.Then keep the unmapped pages in the free list. This avoid > excessive memory fragmentation on large LTO bulds, which can lead > to gcc bumping i

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Jakub Jelinek
On Mon, Oct 10, 2011 at 12:15:14PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Benchmarks show slightly faster build times on a kernel > > build, near the measurement error unfortunately. > > > > This will only work with a recent

Re: [patch] C6X unwinding/exception handling

2011-10-10 Thread Andrew Haley
On 10/09/2011 12:09 PM, Matthias Klose wrote: > This did break libobjc and libjava on arm-linux-gnueabi. > > libobjc now has an undefined reference to _Unwind_decode_target2, which can be > avoided with > > --- libobjc/exception.c.orig2011-07-21 15:33:57.0 + > +++ libobjc/exception.

[Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Georg-Johann Lay
The auto-detect machinery fails to correctly detect that TLS is not supported on AVR. This leads to gross noise of several hundreds of FAILs in testsuite. This patch explicitly tells that AVR doesn't support TLS. Lightly tested with testsuite run on avr-unknown-none where tests like gcc.dg/debug

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/7 Kai Tietz : > Hello, > > this is the updated version with the suggestion > > 2011/10/7 Richard Guenther : >> On Thu, Oct 6, 2011 at 4:25 PM, Kai Tietz wrote: >>> +      && ((TREE_CODE_CLASS (TREE_CODE (arg1)) != tcc_comparison >>> +           && TREE_CODE (arg1) != TRUTH_NOT_EXPR >>> +  

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Rainer Orth
Georg-Johann Lay writes: > The auto-detect machinery fails to correctly detect that TLS is not supported > on AVR. This leads to gross noise of several hundreds of FAILs in testsuite. > > This patch explicitly tells that AVR doesn't support TLS. > > Lightly tested with testsuite run on avr-unkno

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 12:35 PM, Kai Tietz wrote: > 2011/10/7 Kai Tietz : >> Hello, >> >> this is the updated version with the suggestion >> >> 2011/10/7 Richard Guenther : >>> On Thu, Oct 6, 2011 at 4:25 PM, Kai Tietz wrote: +      && ((TREE_CODE_CLASS (TREE_CODE (arg1)) != tcc_comparison

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Georg-Johann Lay
ould investigate what's > happening on AVR instead of papering over the problem. > > Rainer For example, after updating trunk to 179738, (gdb) set args -fpreprocessed tls-1.i -quiet -dumpbase tls-1.c -mmcu=atmega128 -auxbase tls-1 -gdwarf-2 -O3 -O2 -version -o tls-1.s (g

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Jakub Jelinek
On Mon, Oct 10, 2011 at 12:25:15PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Use the Linux MADV_DONTNEED call to unmap free pages in the garbage > > collector.Then keep the unmapped pages in the free list. This avoid > > excess

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 12:35 PM, Kai Tietz wrote: >> 2011/10/7 Kai Tietz : >>> Hello, >>> >>> this is the updated version with the suggestion >>> >>> 2011/10/7 Richard Guenther : On Thu, Oct 6, 2011 at 4:25 PM, Kai Tietz wrote: > +      && ((TREE_CODE_CLA

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Rainer Orth
Georg-Johann Lay writes: > For example, after updating trunk to 179738, > > > > > (gdb) set args -fpreprocessed tls-1.i -quiet -dumpbase tls-1.c > -mmcu=atmega128 > -auxbase tls-1 -gdwarf-2 -O3 -O2 -version -o tls-1.s > (gdb) cd ~/test > (gdb) r > G

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
Sample had a typo. Correct sample has of course to return r. int foo () {  int c, r = 0;  if ((c = foo ()) != 0 && c < 20)    r = 1;  return r; }

Re: New warning for expanded vector operations

2011-10-10 Thread Richard Guenther
On Fri, Oct 7, 2011 at 9:44 AM, Artem Shinkarov wrote: > On Fri, Oct 7, 2011 at 6:22 AM, Artem Shinkarov > wrote: >> On Wed, Oct 5, 2011 at 12:35 PM, Richard Guenther >> wrote: >>> On Wed, Oct 5, 2011 at 1:28 PM, Artem Shinkarov >>> wrote: On Wed, Oct 5, 2011 at 9:40 AM, Richard Guenther >

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 12:45 PM, Jakub Jelinek wrote: > On Mon, Oct 10, 2011 at 12:25:15PM +0200, Richard Guenther wrote: >> On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: >> > From: Andi Kleen >> > >> > Use the Linux MADV_DONTNEED call to unmap free pages in the garbage >> > collector.Then

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 12:47 PM, Kai Tietz wrote: > 2011/10/10 Richard Guenther : >> On Mon, Oct 10, 2011 at 12:35 PM, Kai Tietz wrote: >>> 2011/10/7 Kai Tietz : Hello, this is the updated version with the suggestion 2011/10/7 Richard Guenther : > On Thu, Oct 6, 2011

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Fri, Oct 7, 2011 at 11:36 PM, Kai Tietz wrote: > Hello, > > this is the updated version with the suggestion > > 2011/10/7 Richard Guenther : >> On Thu, Oct 6, 2011 at 4:25 PM, Kai Tietz wrote: >>> +      && ((TREE_CODE_CLASS (TREE_CODE (arg1)) != tcc_comparison >>> +           && TREE_CODE (ar

[patch] remove empty directory common/config/m32c

2011-10-10 Thread Matthias Klose
2011-10-10 Matthias Klose * common/config/m32c: Remove empty directory. committed as obvious. the last file in this directory was removed in r175969.

Re: [patch] C6X unwinding/exception handling

2011-10-10 Thread Matthias Klose
On 10/10/2011 12:32 PM, Andrew Haley wrote: > On 10/09/2011 12:09 PM, Matthias Klose wrote: >> This did break libobjc and libjava on arm-linux-gnueabi. >> >> libobjc now has an undefined reference to _Unwind_decode_target2, which can >> be >> avoided with with this patch, the libobjc testsuite re

[patch, libgo] remove empty directories

2011-10-10 Thread Matthias Klose
libgo currently has some empty directories. ok to remove? D go/encoding/line D go/exp/ogle D go/exp/eval D go/exp/draw D go/exp/draw/x11

Re: [PATCH] Fix PR48193 and dups

2011-10-10 Thread Richard Guenther
On Wed, Mar 23, 2011 at 4:14 PM, Richard Guenther wrote: > > This fixes VOP renaming in IPA split (well, or rather adds to its > crudeness).  We really need to rename the reaching VDEF of the > exit of the SESE region we kill, as that VDEF will be released > when removing the definitions basic-blo

[C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
Hi, reporter complains that, for: struct T {} t; bool b = 1.1 < t; we output (on x86_64-linux): 33067.C:2:18: error: no match for ‘operator<’ in ‘1.100088817841970012523233890533447265625e+0 < t’ which is clearly pretty dumb. In my opinion, a definite improvement would be follo

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Jakub Jelinek
On Mon, Oct 10, 2011 at 01:11:13PM +0200, Richard Guenther wrote: > > I don't see why.  MADV_DONTNEED isn't perfect, what it does (on Linux) > > is that it zaps the whole page range, which essentially brings it into > > the exact same state as immediately after mmap.  Any touch of the > > pages wil

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Fri, Oct 7, 2011 at 11:36 PM, Kai Tietz wrote: >> Hello, >> >> this is the updated version with the suggestion >> >> 2011/10/7 Richard Guenther : >>> On Thu, Oct 6, 2011 at 4:25 PM, Kai Tietz wrote: +      && ((TREE_CODE_CLASS (TREE_CODE (arg1)) != tcc_comp

Re: [4/4] Make SMS schedule register moves

2011-10-10 Thread Richard Sandiford
Ayal Zaks writes: >> I agree it's natural to schedule moves for intra-iteration dependencies >> in the normal get_sched_window way.  But suppose we have a dependency: >> >>   A --(T,N,1)--> B >> >> that requires two moves M1 and M2.  If we think in terms of cycles >> (in the SCHED_TIME sense), the

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
. looks like we want to do something else, not printing the number at all. See audit trail. Paolo.

Re: [PATCH] Remove "bogus" g++.dg/init/copy7.C testcase

2011-10-10 Thread Richard Guenther
On Mon, Aug 15, 2011 at 2:42 PM, Richard Guenther wrote: > > The g++.dg/init/copy7.C testcase checks whether the C++ frontend > guards memcpy it emits via a conditional verifying that src != dst > because calling memcpy with overlapping source / destination is > not supported. > > The testcase is

Re: [patch] C6X unwinding/exception handling

2011-10-10 Thread Paul Brook
> Index: libjava/exception.cc > === > --- libjava/exception.cc (revision 179739) > +++ libjava/exception.cc (working copy) > @@ -135,6 +135,7 @@ > { >_Unwind_Ptr Start; >_Unwind_Ptr LPStart; > + _Unwind_Ptr ttype_ba

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF. It has to be checked that the LHS code is same as outer CODE, as otherwise we wouldn't apply different TRUTH-IF only on inner RHS of LHS, which is of course wrong. Index: gcc/gcc/fold-const.c ===

Ping^3: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-10-10 Thread Richard Sandiford
Ping for: http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00558.html which fixes an expand-time bug in thunks that return BLKmode structures in registers. Tested on x86_64-linux-gnu and arm-linux-gnueabi. Thanks, Richard

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 02:13 PM, Paolo Carlini wrote: . looks like we want to do something else, not printing the number at all. See audit trail. An option, for 4.7 at least, would be, instead of just closing 33067 as a duplicate of the much more general 49152, doing something like: Index: c-family/c-p

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: > Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It > has to be checked that the LHS code is same as outer CODE, as > otherwise we wouldn't apply different TRUTH-IF only on inner RHS of > LHS, which is of course wrong. > > Index

Re: Ping^3: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 2:35 PM, Richard Sandiford wrote: > Ping for: > >    http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00558.html > > which fixes an expand-time bug in thunks that return BLKmode structures > in registers.  Tested on x86_64-linux-gnu and arm-linux-gnueabi. Ok with the changes s

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> On Sun, 9 Oct 2011, Jan Hubicka wrote: > > > Hi, > > whopr currently produce local_static.1234.43124 type symbols. This is > > because > > everything gets mangled at WPA time and then again at ltrans time. This > > simply > > avoids the second mangling. This save some space & makes WHOPR/non_

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Richard Guenther
On Mon, 10 Oct 2011, Jan Hubicka wrote: > > On Sun, 9 Oct 2011, Jan Hubicka wrote: > > > > > Hi, > > > whopr currently produce local_static.1234.43124 type symbols. This is > > > because > > > everything gets mangled at WPA time and then again at ltrans time. This > > > simply > > > avoids the

Re: New warning for expanded vector operations

2011-10-10 Thread Artem Shinkarov
On Mon, Oct 10, 2011 at 12:02 PM, Richard Guenther wrote: > On Fri, Oct 7, 2011 at 9:44 AM, Artem Shinkarov > wrote: >> On Fri, Oct 7, 2011 at 6:22 AM, Artem Shinkarov >> wrote: >>> On Wed, Oct 5, 2011 at 12:35 PM, Richard Guenther >>> wrote: On Wed, Oct 5, 2011 at 1:28 PM, Artem Shinkarov

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> > Actually it seems to me that mangling at WPA makes more sense - you don't > > get > > symbol name sensitive on partitioning decisions so things go a bit more > > consistently. Partitioning depends on global properties of program so any > > code > > that depends on particular partitioning deci

[Patch,AVR]: Reuse __tablejump2__

2011-10-10 Thread Georg-Johann Lay
This patch does better re-usage of __tablejump2__ from libgcc so that switch/case statements with jump tables become smaller because the sequence needs 6 to 9 words compared to 2 when JMPing to __tablejump2__. Moreover, __tablejump2__ does no more rely in the content of EIND (by using EIJMP) and u

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Richard Guenther
On Mon, 10 Oct 2011, Jan Hubicka wrote: > > > Actually it seems to me that mangling at WPA makes more sense - you don't > > > get > > > symbol name sensitive on partitioning decisions so things go a bit more > > > consistently. Partitioning depends on global properties of program so any > > > co

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> Can you try the "obvious" and simply mangle all local statics at > partitioning time? (leaving the non-conflict case for a further > improvement) Hmm, it needs to be done with non-WHOPR too, but sure I can give it a try. I should however finally push out the weakref bits. (here one can produce

Re: patch ping: thread testing infrastructure

2011-10-10 Thread Aldy Hernandez
On 10/07/11 17:50, Mike Stump wrote: On Oct 7, 2011, at 2:52 PM, Aldy Hernandez wrote: First, thanks so much for tackling this review. I don't think anyone's overly enthusiastic about reviewing dejagnu crap^H^H^H^Hcode. I'll review it. :-) The last version looks fine to me, watch out for f

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Eric Botcazou
> The patch makes sure that the src_mem computed here in > expand_builtin_memcpy is marked as MEM_READONLY_P: > ... > src_mem = get_memory_rtx (src, len); > ... > > build and reg-tested on i686, arm, and mips. > > OK for trunk? Do you get the same result by calling gen_const_mem from build_c

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:15:14PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Benchmarks show slightly faster build times on a kernel > > build, near the measurement error unfortunately. > > > > This will only work with a recent

Re: [PATCH 2/5] Increase the GGC quite size to 2MB

2011-10-10 Thread Jan Hubicka
> From: Andi Kleen > > Using 2MB allows modern kernels to use 2MB huge pages on x86. > > gcc/: > > 2011-10-08 Andi Kleen > > * ggc-page.c (GGC_QUIRE_SIZE): Increase to 512 > --- > gcc/ggc-page.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gcc/ggc-p

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:29:03PM +0200, Jakub Jelinek wrote: > On Mon, Oct 10, 2011 at 12:15:14PM +0200, Richard Guenther wrote: > > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > Benchmarks show slightly faster build times on a kernel > > > build, near the

Re: [PATCH 4/5] Add a freeing threshold for the garbage collector.

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:20:53PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Add a threshold to avoid freeing pages back too early to the OS. > > This avoid virtual memory map fragmentation. > > > > Based on a idea from Honza >

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Andi Kleen
> Shouldn't we prefer still "mapped" pages when allocating? Thus, keep > the freepages list "sorted"? Possibly. I can look at it in a followup if you want. I would prefer to not complicate this patch too much. > > With the new params to call release_pages less, how does this > interact with us

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: >> Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It >> has to be checked that the LHS code is same as outer CODE, as >> otherwise we wouldn't apply different TRUTH-IF only on inner RHS of >> LHS,

[PATCH] Fix PR50195

2011-10-10 Thread Richard Guenther
Canonicalize x*x to pow(x,2) only when optimizing which is when we do optimized expansion. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-10-10 Richard Guenther PR middle-end/50195 * fold-const.c (fold_binary_loc): Canonicalize x*x to pow (x, 2)

Re: [PATCH 4/5] Add a freeing threshold for the garbage collector.

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 3:58 PM, Andi Kleen wrote: > On Mon, Oct 10, 2011 at 12:20:53PM +0200, Richard Guenther wrote: >> On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: >> > From: Andi Kleen >> > >> > Add a threshold to avoid freeing pages back too early to the OS. >> > This avoid virtual mem

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 4:04 PM, Andi Kleen wrote: >> Shouldn't we prefer still "mapped" pages when allocating?  Thus, keep >> the freepages list "sorted"? > > Possibly. I can look at it in a followup if you want. > I would prefer to not complicate this patch too much. > >> >> With the new params

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: > 2011/10/10 Richard Guenther : >> On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: >>> Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It >>> has to be checked that the LHS code is same as outer CODE, as >>> otherwise we would

Re: [PATCH] Don't assume that constants can clobber vtbl

2011-10-10 Thread Martin Jambor
Hi, sorry that taking care of the devirtualization patches takes me longer than expected for various reasons. But I have not forgotten about this. On Sat, Oct 01, 2011 at 01:58:57PM +1300, Maxim Kuvyrkov wrote: > This patch makes detect_type_change analysis assume that only ADDR_EXPRs can > be

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: >> 2011/10/10 Richard Guenther : >>> On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It has to be checked that the LHS code is same as o

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Georg-Johann Lay
d ~/test >> (gdb) r >> GNU C (GCC) version 4.7.0 20111010 (experimental) (avr) >> compiled by GNU C version 4.3.2 [gcc-4_3-branch revision 141291], GMP >> version 5.0.1, MPFR version 3.0.0-p8, MPC version 0.8.2 >> GGC heuristics: --param ggc-min-expan

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Tom de Vries
On 10/10/2011 03:44 PM, Eric Botcazou wrote: >> The patch makes sure that the src_mem computed here in >> expand_builtin_memcpy is marked as MEM_READONLY_P: >> ... >> src_mem = get_memory_rtx (src, len); >> ... >> >> build and reg-tested on i686, arm, and mips. >> >> OK for trunk? > > Do you

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Rainer Orth
Georg-Johann Lay writes: >> This has nothing to do with AVR, but is PR middle-end/50638. It breaks >> TLS on all emutls targets. A patch has been posted and approved, but >> apparently not yet installed. > > Thanks for the notice. > The GCC documentation says that TLS need support of a dynamic

Re: [PATCH] sel-sched: fix merging of LHS reg availability (PR 50340)

2011-10-10 Thread Alexander Monakov
Ping. This is now a P1 bug, as it breaks spec2k gcc on ia64. On Tue, 13 Sep 2011, Alexander Monakov wrote: > Hello, > > This patches fixes an ICE on an assert that performs a sanity check on > target_available field of expr_t, which is tri-state: LHS register is > available (1), not available (

[PATCH] Verify stuff after IPA split

2011-10-10 Thread Richard Guenther
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2011-10-10 Richard Guenther * ipa-split.c (pass_split_functions): Add verification TODOs. (pass_feedback_split_functions): Likewise. Index: gcc/ipa-split.c ===

Re: [PATCH] Don't assume that constants can clobber vtbl

2011-10-10 Thread Martin Jambor
On Mon, Oct 10, 2011 at 05:05:14PM +0200, Martin Jambor wrote: > Hi, > > sorry that taking care of the devirtualization patches takes me longer > than expected for various reasons. But I have not forgotten about > this. Ah, please ignore the attachment, I was trying to persuade mutt to add it to

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Michael Matz
Hi, On Mon, 10 Oct 2011, Kai Tietz wrote: > extern int foo (void); /* foo modifies gbl1 */ > int gbl1 = 0; > > int foo (int ns1) > { > if (ns1 && foo () && gbl1) > return 1; > return 0; > } > > so chain of trees has to look like this: > (ANDIF (ns1 (ANDIF foo () gbl1)) Okay, indeed. I

Re: [PATCH] sel-sched: forbid differing modes in substitution (PR 50205)

2011-10-10 Thread Alexander Monakov
Ping? On Wed, 7 Sep 2011, Alexander Monakov wrote: > Hello, > > The patch repairs a problem when we attempt to substitute an insn like > (... (cmp (mem (reg:DI ax)) (reg:SI ax))) (note different modes) through > (set (reg:DI ax) (reg:DI dx)), which leaves the (reg:SI ax) part of the > comparison

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 5:07 PM, Kai Tietz wrote: > 2011/10/10 Richard Guenther : >> On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: >>> 2011/10/10 Richard Guenther : On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: > Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.

Re: [4/4] Make SMS schedule register moves

2011-10-10 Thread Ayal Zaks
On Mon, Oct 10, 2011 at 1:57 PM, Richard Sandiford wrote: > Ayal Zaks writes: >>> I agree it's natural to schedule moves for intra-iteration dependencies >>> in the normal get_sched_window way.  But suppose we have a dependency: >>> >>>   A --(T,N,1)--> B >>> >>> that requires two moves M1 and M2

[PATCH] Fix PR50389

2011-10-10 Thread Richard Guenther
This fixes missed placements of VUSEs during gimplify_and_update_call_from_tree. The gimplifier doesn't fill out virtual operands (it doesn't call update_stmt) - for a reason, we'd mark it for renaming else. So we have to stick a VUSE on every stmt that can possibly have one. update_stmt will

Re: [Patch,AVR]: Reuse __tablejump2__

2011-10-10 Thread Denis Chertykov
2011/10/10 Georg-Johann Lay : > This patch does better re-usage of __tablejump2__ from libgcc so that > switch/case statements with jump tables become smaller because the sequence > needs 6 to 9 words compared to 2 when JMPing to __tablejump2__. > > Moreover, __tablejump2__ does no more rely in the

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Eric Botcazou
> So, the patch for build_constant_desc does not have the desired effect. OK, too bad that we need to play this back-and-forth game with MEMs. So the original patch is OK (with TREE_READONLY (base) on the next line to mimic what is done just above and without the gcc/ prefix in the ChangeLog).

simulate-thread changes to avoid infinite loops

2011-10-10 Thread Aldy Hernandez
Hi folks. This was a change Andrew had made to the simulate-thread framework to avoid infinite loops in hostile threads. I forgot to merge this in my original submission, and am doing so now. The original patch is here: http://permalink.gmane.org/gmane.comp.gcc.patches/247678 My patch is a

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 5:07 PM, Kai Tietz wrote: >> 2011/10/10 Richard Guenther : >>> On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: 2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz > wrote: >> Recent patch had a thi

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread H.J. Lu
On Sun, Oct 9, 2011 at 12:49 PM, Kirill Yukhin wrote: > Hi guys, > This is a Ping. Could anyboady with appropriate rights commit that? > > I checked it in for you. Please provide ChangeLog entries together with the new patch next time. -- H.J.

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread Kirill Yukhin
Thank you K On Mon, Oct 10, 2011 at 8:08 PM, H.J. Lu wrote: > On Sun, Oct 9, 2011 at 12:49 PM, Kirill Yukhin > wrote: >> Hi guys, >> This is a Ping. Could anyboady with appropriate rights commit that? >> >> > > I checked it in for you. Please provide ChangeLog entries together > with the new p

Re: simulate-thread changes to avoid infinite loops

2011-10-10 Thread Jeff Law
On 10/10/11 09:54, Aldy Hernandez wrote: Hi folks. This was a change Andrew had made to the simulate-thread framework to avoid infinite loops in hostile threads. I forgot to merge this in my original submission, and am doing so now. The original patch is here: http://permalink.gmane.org/gmane.

Re: Rename vshuffle/vec_shuffle to vec_perm

2011-10-10 Thread Richard Henderson
On 10/09/2011 06:09 AM, Joseph S. Myers wrote: > That looks like it broke "make pdf" (something did at about that time and > this patch is the most likely candidate). > >> +@cindex @code{vec_perm_const@var{m}) instruction pattern > > has opening '{' matched with closing ')'. > Fixed, thanks.

[Patch,AVR]: Avoid unwind warning from toplev.c

2011-10-10 Thread Georg-Johann Lay
toplev.c complains about "unwind tables currently require a frame pointer for correctness". This patchlet supplies a fix to avoid build warnings/test fails in that it sets flag_omit_frame_pointer to 0 if unwind needs FP. toplev.c:process_options sets flag_unwind_tables depending on flag_non_call_

Re: [patch, libgo] remove empty directories

2011-10-10 Thread Ian Lance Taylor
Matthias Klose writes: > libgo currently has some empty directories. ok to remove? > > D go/encoding/line > D go/exp/ogle > D go/exp/eval > D go/exp/draw > D go/exp/draw/x11 Yes, thanks. Ian

int_cst_hash_table mapping persistence and the garbage collector

2011-10-10 Thread Gary Funck
Recently, a few UPC test programs failed to compile due to mis-matches of parameters in a prototype and its corresponding function definition. The mis-match was based upon the apparent inequality of UPC layout qualifiers (blocking factors). UPC blocking factors are integer constants. They are re

[PATCH]: Fix PR bootstrap/50665

2011-10-10 Thread Uros Bizjak
Hello! Attached patch moves DOI_vec_perm index to the right place. 2011-10-10 Uros Bizjak PR bootstrap/50665 * optabs.h (DOI_vec_perm): Rename from OTI_vec_perm. Move from enum optab_index to enum direct_optab_index. (vec_perm_optab): Update. Tested by bootst

Re: [Patch,AVR]: Avoid unwind warning from toplev.c

2011-10-10 Thread Denis Chertykov
2011/10/10 Georg-Johann Lay : > toplev.c complains about "unwind tables currently require a frame pointer for > correctness". > > This patchlet supplies a fix to avoid build warnings/test fails in that it > sets > flag_omit_frame_pointer to 0 if unwind needs FP. > > toplev.c:process_options sets f

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 7:47 AM, Paolo Carlini wrote: > On 10/10/2011 02:13 PM, Paolo Carlini wrote: >> >> . looks like we want to do something else, not printing the number at all. >> See audit trail. > > An option, for 4.7 at least, would be, instead of just closing 33067 as a > duplicate of the

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:13 PM, Gabriel Dos Reis wrote: on this particular input, '6' looks OK. However, the question is why '6'? Why can't we retain the original number spelling from the source code and use that instead? Yes, that would be 49152, no? It's quite a bit of work, I don't think somebody w

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 12:16 PM, Paolo Carlini wrote: > On 10/10/2011 07:13 PM, Gabriel Dos Reis wrote: >> >> on this particular input, '6' looks OK. However, the question is why '6'? >> Why can't we retain the original number spelling from the source code and >> use that instead? > > Yes, that w

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:28 PM, Gabriel Dos Reis wrote: A GCC user not interested in numerics probably won't care. However, I do not think that extends to people who do care about numerics and have literals in their program. If GCC displays an error message with literals truncated, it is not at clear t

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Andi Kleen
> So can we move the param patch back as a possible followup? I can drop it, however it will still mean fragmentation on any non Linux (or rather non MADV_DONTNEED) hosts. -Andi

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 12:30 PM, Paolo Carlini wrote: > On 10/10/2011 07:28 PM, Gabriel Dos Reis wrote: >> >> A GCC user not interested in numerics probably won't care. However, I do >> not think that extends to people who do care about numerics and have >> literals in their program. If GCC displ

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: Yes, I suspect the max_digits10 patch would be definitely an improvement. Good. It's at the beginning of this thread, passes testing. Please have a closer look. If you like it, we can have it for 4.7.0 and otherwise also mark this specific PR as

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 1:07 PM, Paolo Carlini wrote: > On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: >> >> Yes, I suspect the max_digits10 patch would be definitely an improvement. > > Good. It's at the beginning of this thread, passes testing. Please have a > closer look. I did, but you seeme

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
Hi, On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: Yes, I suspect the max_digits10 patch would be definitely an improvement. Good. It's at the beginning of this thread, passes testing. Please have a closer look. I did, but you seemed to show a preference for '6' digits which prompted my comme

Re: [PATCH, testsuite]: Remove *.gdb files from testsuite dir

2011-10-10 Thread Uros Bizjak
On Sun, Oct 9, 2011 at 9:38 PM, Uros Bizjak wrote: > Attached patch removes *.gdb temporary files from testsuite directory. > > 2011-10-09  Uros Bizjak   > >        * lib/gcc-gdb-test.exp (gdb-test): Delete $cmd_file before return. > > Tested on x86_64-pc-linux-gnu {,-m32}. OK for mainline and br

Re: [Patch, Fortran] Fix PR 50564

2011-10-10 Thread Thomas Koenig
Hi Tobias, In conclusion: I am fine with the FORALL part, but not with the DO CONCURRENT part. Yep, you're right. I have modified the patch accordingly. Here is what I committed. Best regards Thomas Index: fortran/ChangeLog ==

  1   2   >