Re: libgo patch committed: Fix 386 MakeFunc when returning struct

2013-11-30 Thread Ian Lance Taylor
On Sat, Nov 30, 2013 at 9:54 AM, Andreas Schwab wrote: > Ian Lance Taylor writes: > >> diff -r fa6c22b293e8 libgo/go/reflect/makefunc_386.S >> --- a/libgo/go/reflect/makefunc_386.S Tue Nov 26 16:49:31 2013 -0800 >> +++ b/libgo/go/reflect/makefunc_386.S Sat Nov 30 09:05:42 2013 -0800 >> @@ -26,8 +

Re: libgo patch committed: Fix 386 MakeFunc when returning struct

2013-11-30 Thread Andreas Schwab
Ian Lance Taylor writes: > diff -r fa6c22b293e8 libgo/go/reflect/makefunc_386.S > --- a/libgo/go/reflect/makefunc_386.S Tue Nov 26 16:49:31 2013 -0800 > +++ b/libgo/go/reflect/makefunc_386.S Sat Nov 30 09:05:42 2013 -0800 > @@ -26,8 +26,11 @@ >esp uint32 // 0x0 >ea

libgo patch committed: Fix 386 MakeFunc when returning struct

2013-11-30 Thread Ian Lance Taylor
On 386 when a function returns a struct the pointer to the return value is passed as a hidden first parameter, and the function is supposed to "ret 4" to pop the hidden parameter when returning to the caller. The implementation of reflect.MakeFunc in libgo was not doing that. This patch fixes the