On Sat, Nov 30, 2013 at 9:54 AM, Andreas Schwab <sch...@linux-m68k.org> wrote: > Ian Lance Taylor <i...@google.com> writes: > >> diff -r fa6c22b293e8 libgo/go/reflect/makefunc_386.S >> --- a/libgo/go/reflect/makefunc_386.S Tue Nov 26 16:49:31 2013 -0800 >> +++ b/libgo/go/reflect/makefunc_386.S Sat Nov 30 09:05:42 2013 -0800 >> @@ -26,8 +26,11 @@ >> esp uint32 // 0x0 >> eax uint32 // 0x4 >> st0 uint64 // 0x8 >> + rs int32 // 0x10 > > rs ... > >> diff -r fa6c22b293e8 libgo/go/reflect/makefuncgo_386.go >> --- a/libgo/go/reflect/makefuncgo_386.go Tue Nov 26 16:49:31 2013 -0800 >> +++ b/libgo/go/reflect/makefuncgo_386.go Sat Nov 30 09:05:42 2013 -0800 >> @@ -16,6 +16,7 @@ >> esp uint32 >> eax uint32 // Value to return in %eax. >> st0 uint64 // Value to return in %st(0). >> + sr int32 // Set to non-zero if hidden struct pointer. > > ... vs. sr.
Thanks. Fixed. Ian
diff -r b9fc602e9b17 libgo/go/reflect/makefunc_386.S --- a/libgo/go/reflect/makefunc_386.S Sat Nov 30 09:13:14 2013 -0800 +++ b/libgo/go/reflect/makefunc_386.S Sat Nov 30 10:07:25 2013 -0800 @@ -26,9 +26,9 @@ esp uint32 // 0x0 eax uint32 // 0x4 st0 uint64 // 0x8 - rs int32 // 0x10 + sr int32 // 0x10 } - The rs field is set by the function to a non-zero value if + The sr field is set by the function to a non-zero value if the function takes a struct hidden pointer that must be popped off the stack. */
