Re: options generation and language count

2011-08-30 Thread Joseph S. Myers
On Tue, 30 Aug 2011, Gary Funck wrote: > On 08/30/11 15:52:12, Joseph S. Myers wrote: > > Please send a patch. [... on points 1, 2, and 3]0 > > OK, will do. > > > GF: Also, the use of fixed masks is problematic. Perhaps the AWK script > > GF: could be changed to also generate values for CL_PARA

Re: options generation and language count

2011-08-30 Thread Gary Funck
On 08/30/11 15:52:12, Joseph S. Myers wrote: > Please send a patch. [... on points 1, 2, and 3]0 OK, will do. > GF: Also, the use of fixed masks is problematic. Perhaps the AWK script > GF: could be changed to also generate values for CL_PARAMS, etc., ensuring > GF: that will not conflict with t

Re: options generation and language count

2011-08-30 Thread Joseph S. Myers
On Mon, 29 Aug 2011, Gary Funck wrote: > 1) The sanity check should probably read: >gcc_assert ((1U << cl_lang_count) <= CL_MIN_OPTION_CLASS); > In other words, it is off-by-one. Please send a patch. > 2) The fixed shift counts starting at CL_PARAMS probably need to be > adjusted upwards to