On Sun, May 15, 2022 at 04:18:12PM +0200, Mohamed Atef wrote:
> Ping
>
> في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
> كتب:
>
> > Hello Jakub,
> >I am sorry, but should #ifdef __ELF__ put and separate file and also
> > the actual functions (e.g. extern ompd_dll_location_valid (void))
> > I
في الأحد، ١٥ مايو، ٢٠٢٢ ٤:١٨ م Mohamed Atef كتب:
> Ping
>
> في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
> كتب:
>
>> Hello Jakub,
>>I am sorry, but should #ifdef __ELF__ put and separate file and also
>> the actual functions (e.g. extern ompd_dll_location_valid (void))
>> I mean both in the
Ping
في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
كتب:
> Hello Jakub,
>I am sorry, but should #ifdef __ELF__ put and separate file and also
> the actual functions (e.g. extern ompd_dll_location_valid (void))
> I mean both in the same files or the functions should be in the
> omp-tools.h but
Hello Jakub,
I am sorry, but should #ifdef __ELF__ put and separate file and also the
actual functions (e.g. extern ompd_dll_location_valid (void))
I mean both in the same files or the functions should be in the omp-tools.h
but with #ifndef __ELF__
Mohamed
On Fri, May 13, 2022 at 8:27 PM Jaku
On Fri, May 13, 2022 at 08:22:41PM +0200, Mohamed Atef wrote:
> > As I've tried to explain, this #ifdef __ELF__ doesn't belong
> > to the public header, which should contain just
> > extern void ompd_dll_locations_valid (void) __GOMPD_NOTHROW;
> > The #define should be in some internal header that
في الجمعة، ١٣ مايو، ٢٠٢٢ ٣:١٤ م Jakub Jelinek كتب:
> On Tue, May 10, 2022 at 07:40:41AM +0200, Mohamed Atef wrote:
> > --- a/libgomp/env.c
> > +++ b/libgomp/env.c
> > @@ -33,6 +33,7 @@
> > #ifndef LIBGOMP_OFFLOADED_ONLY
> > #include "libgomp_f.h"
> > #include "oacc-int.h"
> > +#include "ompd-s
On Tue, May 10, 2022 at 07:40:41AM +0200, Mohamed Atef wrote:
> --- a/libgomp/env.c
> +++ b/libgomp/env.c
> @@ -33,6 +33,7 @@
> #ifndef LIBGOMP_OFFLOADED_ONLY
> #include "libgomp_f.h"
> #include "oacc-int.h"
> +#include "ompd-support.h"
> #include
> #include
> #include
> @@ -89,6 +90,7 @@
Here is the final change.
On Tue, May 10, 2022 at 7:21 AM Mohamed Atef
wrote:
> Resubmission.
>
> libgomp/ChangeLog
>
> 2022-05-10 Mohamed Atef
>
> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> *config/posix/plugin-su
Resubmission.
libgomp/ChangeLog
2022-05-10 Mohamed Atef
*config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*configure: Regenerate.
* Makefile.am (toolexeclib_LTLIBRARI
