في الأحد، ١٥ مايو، ٢٠٢٢ ٤:١٨ م Mohamed Atef <mohamedatef1...@gmail.com> كتب:
> Ping > > في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef <mohamedatef1...@gmail.com> > كتب: > >> Hello Jakub, >> I am sorry, but should #ifdef __ELF__ put and separate file and also >> the actual functions (e.g. extern ompd_dll_location_valid (void)) >> I mean both in the same files or the functions should be in the >> omp-tools.h but with #ifndef __ELF__ >> >> >> Mohamed >> > I am pinging this not the patch. Thanks. > >> On Fri, May 13, 2022 at 8:27 PM Jakub Jelinek <ja...@redhat.com> wrote: >> >>> On Fri, May 13, 2022 at 08:22:41PM +0200, Mohamed Atef wrote: >>> > > As I've tried to explain, this #ifdef __ELF__ doesn't belong >>> > > to the public header, which should contain just >>> > > extern void ompd_dll_locations_valid (void) __GOMPD_NOTHROW; >>> > > The #define should be in some internal header that is included >>> > > after the public one. >>> > > >>> > I will put the #define in ompd-support.h is that okay? >>> > And i will put ompd_bp_* labels there too. >>> >>> Ok. >>> >>> Jakub >>> >>>
