Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
On Mon, Dec 3, 2018 at 12:12 PM Jakub Jelinek wrote: > > On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote: > > > but I just committed r266745 adjusted for -fdec-include. > > > > Thanks, though it seems what you've committed in options.c is incomplete. > > In the patch you've posted ea

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote: > > but I just committed r266745 adjusted for -fdec-include. > > Thanks, though it seems what you've committed in options.c is incomplete. > In the patch you've posted earlier, you've changed also > gfc_init_options and gfc_handle_opti

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 10:52:18AM -0500, Fritz Reese wrote: > > I think more than enough time passed, do you plan to commit to trunk now? > > Note, small adjustment will be needed for the addition of flag_dec_include > > in set_dec_flags. > > Jakub- Sorry, yes. I've had other priorities the past

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
> I think more than enough time passed, do you plan to commit to trunk now? > Note, small adjustment will be needed for the addition of flag_dec_include > in set_dec_flags. Jakub- Sorry, yes. I've had other priorities the past few weeks here, but I just committed r266745 adjusted for -fdec-include

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Mark Eggleston
On 12/11/2018 20:28, Fritz Reese wrote: Attached is the latest version, which builds and regtests cleanly on x86_64-redhat-linux. OK for trunk, 7-branch, and 8-branch? I'm currently using this patch (pending it being committed) and have some pending patches that use it. I can use the old met

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-22 Thread Jakub Jelinek
On Mon, Nov 12, 2018 at 03:52:42PM -0500, Fritz Reese wrote: > On Mon, Nov 12, 2018 at 3:42 PM Jakub Jelinek wrote: > > Ok, so I'll ack it for trunk now, but please give the other Fortran > > maintainers one day to disagree before committing. > > For the release branches, I'd wait two weeks or so

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-12 Thread Fritz Reese
On Mon, Nov 12, 2018 at 3:42 PM Jakub Jelinek wrote: > Ok, so I'll ack it for trunk now, but please give the other Fortran > maintainers one day to disagree before committing. > For the release branches, I'd wait two weeks or so before backporting it. > Roger that. I'll happily give it some time.

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2018 at 03:28:47PM -0500, Fritz Reese wrote: > Actually, the gcc frontend appears to move -std= before the > language-specific options before f951 is even executed regardless of > its location compared to the -fdec flags. I don't know if this is a That is because: #define F951_OPTI

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-12 Thread Fritz Reese
On Thu, Nov 8, 2018 at 12:54 PM Jakub Jelinek wrote: > > On Thu, Nov 08, 2018 at 12:09:33PM -0500, Fritz Reese wrote: > > > What about the > > > /* Allow legacy code without warnings. */ > > > gfc_option.allow_std |= GFC_STD_F95_OBS | GFC_STD_F95_DEL > > > | GFC_STD_GNU | GFC_

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-08 Thread Jakub Jelinek
On Thu, Nov 08, 2018 at 12:09:33PM -0500, Fritz Reese wrote: > I find "expand" a more helpful name than "set_bitflag_1" since it > describes what the macro does. However, I don't think it makes too > much of a difference so I'll follow your preference (but I'll use > SET_BITFLAG2 since then the def

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-08 Thread Fritz Reese
On Wed, Nov 7, 2018 at 5:32 PM Jakub Jelinek wrote: > > On Wed, Nov 07, 2018 at 05:05:13PM -0500, Fritz Reese wrote: > > --- a/gcc/fortran/options.c > +++ b/gcc/fortran/options.c > @@ -32,6 +32,20 @@ along with GCC; see the file COPYING3. If not see > > gfc_option_t gfc_option; > > +#define _exp

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 05:05:13PM -0500, Fritz Reese wrote: --- a/gcc/fortran/options.c +++ b/gcc/fortran/options.c @@ -32,6 +32,20 @@ along with GCC; see the file COPYING3. If not see gfc_option_t gfc_option; +#define _expand(m) m I think it would be better to avoid names like _expand, to

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Fritz Reese
On 11/7/18, Jakub Jelinek wrote: > On Wed, Nov 07, 2018 at 03:07:04PM +, Mark Eggleston wrote: > >> PR fortran/87919 >> * options.c (gfc_handle_option): Removed case OPT_fdec_structure >> as it breaks the handling of -fno-dec-structure. > > No entries for the tests, i.e. >

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 03:07:04PM +, Mark Eggleston wrote: > PR fortran/87919 > * options.c (gfc_handle_option): Removed case OPT_fdec_structure > as it breaks the handling of -fno-dec-structure. No entries for the tests, i.e. * gfortran.dg/pr87919-dec-structure-1.f