Hello!
> diff --git a/libmudflap/testsuite/libmudflap.c/pass47-frag.c
> b/libmudflap/testsuite/libmudflap.c/pass47-frag.c
> --- a/libmudflap/testsuite/libmudflap.c/pass47-frag.c
> +++ b/libmudflap/testsuite/libmudflap.c/pass47-frag.c
> @@ -8,3 +8,5 @@ int main ()
> tolower (buf[4]
Hi Frank,
>> I could either commit the current version with the MFWRAP_SPEC addition
>> and work from there, or wait until those failures are understood and
>> fixed, too.
>
> Committing now would be fine, assuming no regressions on a primary
> platform.
below is the patch I've actually comitted,
Hi Frank,
>> > Why would solaris have to duplicate MFWRAP_SPEC if mmap64 is added to
>> > the default gcc.c one?
>>
>> I assumed that you wanted to keep the default generic, and meant to
>> separate target specific additions from the generic part.
>
> I don't have a strong opinion on this, but if
Hi, Rainer -
> >> > If so, I'd rather do it by adding some MFWRAP_OS_SPEC to avoid
> >> > having to duplicate the whole spec in the Solaris config
> >> > headers.
> >
> > Why would solaris have to duplicate MFWRAP_SPEC if mmap64 is added to
> > the default gcc.c one?
>
> I assumed that you
Hi Frank,
>> > * Some tests were failing while calling unregister in munmap. It turned
>> > out that there had been no corresponding mmap registration before.
>> > This occurs because Solaris has mmap64 for largefile-aware programs
>> > instead. Fixed by wrapping mmap64, too. What I don't
Hi, Rainer -
> > It addresses a couple of testsuite failures:
> > [...]
> > where the registration of __iob has been done automatically by the
> > compiler. I avoid this problem by not registering stdin, stdout, and
> > stderr separately on Solaris.
OK.
> > * Some tests were failing whi
Frank,
this patch has remained unreviewed for a week. Could you please have a
look?
Thanks.
Rainer
Rainer Orth writes:
> This is the first of two patches to get mudflap fully working on
> Solaris 11, both with Sun ld and GNU ld.
>
> It addresses a couple of testsuite failures:
>
> *