Re: Convert inliner to new param infrastructure

2019-11-25 Thread Martin Liška
On 11/25/19 10:27 AM, Jan Hubicka wrote: On 11/23/19 2:12 PM, Jan Hubicka wrote: I always use the outer function params since that is how local parameters behave. I hope it is kind of what is also expected in most case: it is better to inline agressively into -O3 compiled code rather than inlin

Re: Convert inliner to new param infrastructure

2019-11-25 Thread Jan Hubicka
> On 11/23/19 2:12 PM, Jan Hubicka wrote: > > I always use the outer function params since that is how local parameters > > behave. I hope it is kind of what is also expected in most case: it is > > better > > to inline agressively into -O3 compiled code rather than inline agressively > > -O3 >

Re: Convert inliner to new param infrastructure

2019-11-25 Thread Martin Liška
On 11/23/19 2:12 PM, Jan Hubicka wrote: I always use the outer function params since that is how local parameters behave. I hope it is kind of what is also expected in most case: it is better to inline agressively into -O3 compiled code rather than inline agressively -O3 functions into their cal

Re: Convert inliner to new param infrastructure

2019-11-24 Thread Rainer Orth
Hi Jan, > This patch adds opt_for_fn for all cross module params used by inliner > so they can be modified at function granuality. With inlining almost always > there are three functions to consider (callee and caller of the inlined edge > and the outer function caller is inlined to). > > I alway