On 11/25/19 10:27 AM, Jan Hubicka wrote:
On 11/23/19 2:12 PM, Jan Hubicka wrote:
I always use the outer function params since that is how local parameters
behave. I hope it is kind of what is also expected in most case: it is better
to inline agressively into -O3 compiled code rather than inline agressively -O3
functions into their callers.
Hello.
Great that you converted the inliner parameters so quickly!
It is easy to do - i did the same with all command line options some
time ago. I will look into the other options that are set by maybe_*
infrastrcture.
New params infrastructure is nice. One drawback is that is very hard to
search for individual param uses since they all occupy global namespace.
With C++ world we had chance to do something like params.param_flag_name
or params::param_flag_name instead...
Makes sense to me, feel free to send a patch for that. Note that one would
expect the same of options as well.
Martin
Why is it difficult to search for all usages? Now, we don't use any PARAM_XYZ
macros
and one can easily find all usages with something like:
$ git grep param_stack_frame_growth
It is not that hard, but I was in task of replacing all param_xyz by
opt_for_fn (some meaningful decl, param_xyz). Problem is taht
param_<something> is common in ipa-prop code so I could not simply
search for that.
Just it seemed to me that c++ way would be to give those a namespace.
Honza
Martin
