Re: Avoid _Rb_tree_rotate_[left,right] symbols export

2017-06-15 Thread Jonathan Wakely
On 13/06/17 21:51 +0200, François Dumont wrote: On 12/05/2017 13:03, Jonathan Wakely wrote: A much simpler (but equivalent) change would be: --- a/libstdc++-v3/src/c++98/tree.cc +++ b/libstdc++-v3/src/c++98/tree.cc @@ -153,6 +153,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION /* Static keyword was miss

Re: Avoid _Rb_tree_rotate_[left,right] symbols export

2017-06-13 Thread François Dumont
On 12/05/2017 13:03, Jonathan Wakely wrote: A much simpler (but equivalent) change would be: --- a/libstdc++-v3/src/c++98/tree.cc +++ b/libstdc++-v3/src/c++98/tree.cc @@ -153,6 +153,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION /* Static keyword was missing on _Rb_tree_rotate_left. Export the sym

Re: Avoid _Rb_tree_rotate_[left,right] symbols export

2017-05-14 Thread François Dumont
On 12/05/2017 13:03, Jonathan Wakely wrote: On 11/05/17 22:06 +0200, François Dumont wrote: Hi When versioned namespace is active we can avoid export of _Rb_tree_rotate_[left,right] symbols. I also took the opportunity to put static functions in the anonymous namespace rather than using s

Re: Avoid _Rb_tree_rotate_[left,right] symbols export

2017-05-12 Thread Jonathan Wakely
On 11/05/17 22:06 +0200, François Dumont wrote: Hi When versioned namespace is active we can avoid export of _Rb_tree_rotate_[left,right] symbols. I also took the opportunity to put static functions in the anonymous namespace rather than using static. Is this usage of static still planned