On 13/06/17 21:51 +0200, François Dumont wrote:
On 12/05/2017 13:03, Jonathan Wakely wrote:
A much simpler (but equivalent) change would be:
--- a/libstdc++-v3/src/c++98/tree.cc
+++ b/libstdc++-v3/src/c++98/tree.cc
@@ -153,6 +153,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
/* Static keyword was missing on _Rb_tree_rotate_left.
Export the symbol for backward compatibility until
next ABI change. */
+#if _GLIBCXX_INLINE_VERSION
+ static
+#endif
Ok, so it looks like you are not a great fan of the anonymous
namespace in this context.
Here is a new proposal. We don't need to add static keyword, this
function is only here to be exported for backward compatibility.
Tested under Linux x86_64 with versioned namespace.
What about the normal configuration? It's much more important that the
default configuration works. The versioned namespace that nobody uses
doesn't matter.
Tested under Linux x86_64 normal mode.
Ok to commit ?
OK, thanks.
