Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Jonathan Wakely
On 25/05/17 14:35 +0200, Richard Biener wrote: On May 25, 2017 1:38:36 PM GMT+02:00, Nathan Sidwell wrote: On 05/25/2017 07:21 AM, Jonathan Wakely wrote: I don't mind removing the warning again if preferred. I thought it was useful (as we already warn for ignored const in return types). O

Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Richard Biener
On May 25, 2017 1:38:36 PM GMT+02:00, Nathan Sidwell wrote: >On 05/25/2017 07:21 AM, Jonathan Wakely wrote: > >> I don't mind removing the warning again if preferred. I thought it >was >> useful (as we already warn for ignored const in return types). > >Oh yeah, I recall noticing we did that (and

Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Nathan Sidwell
On 05/25/2017 07:21 AM, Jonathan Wakely wrote: I don't mind removing the warning again if preferred. I thought it was useful (as we already warn for ignored const in return types). Oh yeah, I recall noticing we did that (and noting we didn't warn elsewhere). This new warning seems consistent

Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Jonathan Wakely
On 25/05/17 12:19 +0100, Jonathan Wakely wrote: On 25/05/17 06:54 -0400, Nathan Sidwell wrote: On 05/25/2017 01:29 AM, Richard Biener wrote: On May 25, 2017 3:22:18 AM GMT+02:00, Nathan Sidwell wrote: On 05/24/2017 09:13 PM, Nathan Sidwell wrote: On 05/24/2017 08:56 PM, Nathan Sidwell wrote:

Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Jonathan Wakely
On 25/05/17 06:54 -0400, Nathan Sidwell wrote: On 05/25/2017 01:29 AM, Richard Biener wrote: On May 25, 2017 3:22:18 AM GMT+02:00, Nathan Sidwell wrote: On 05/24/2017 09:13 PM, Nathan Sidwell wrote: On 05/24/2017 08:56 PM, Nathan Sidwell wrote: On 05/24/2017 08:34 PM, Nathan Sidwell wrote:

Re: [libibery PATCH] Fix bootstrap

2017-05-25 Thread Nathan Sidwell
On 05/25/2017 01:29 AM, Richard Biener wrote: On May 25, 2017 3:22:18 AM GMT+02:00, Nathan Sidwell wrote: On 05/24/2017 09:13 PM, Nathan Sidwell wrote: On 05/24/2017 08:56 PM, Nathan Sidwell wrote: On 05/24/2017 08:34 PM, Nathan Sidwell wrote: We now warn on casts to T const. Applied as obv

Re: [libibery PATCH] Fix bootstrap

2017-05-24 Thread Richard Biener
On May 25, 2017 3:22:18 AM GMT+02:00, Nathan Sidwell wrote: >On 05/24/2017 09:13 PM, Nathan Sidwell wrote: >> On 05/24/2017 08:56 PM, Nathan Sidwell wrote: >>> On 05/24/2017 08:34 PM, Nathan Sidwell wrote: We now warn on casts to T const. Applied as obvious to fix >bootstrap. >>> >>> And thi

Re: [libibery PATCH] Fix bootstrap

2017-05-24 Thread Nathan Sidwell
On 05/24/2017 09:13 PM, Nathan Sidwell wrote: On 05/24/2017 08:56 PM, Nathan Sidwell wrote: On 05/24/2017 08:34 PM, Nathan Sidwell wrote: We now warn on casts to T const. Applied as obvious to fix bootstrap. And this fixes c-common.c And fix auto-profile.c and lto-streamer-out.c, sigh -

Re: [libibery PATCH] Fix bootstrap

2017-05-24 Thread Nathan Sidwell
On 05/24/2017 08:56 PM, Nathan Sidwell wrote: On 05/24/2017 08:34 PM, Nathan Sidwell wrote: We now warn on casts to T const. Applied as obvious to fix bootstrap. And this fixes c-common.c And fix auto-profile.c nathan -- Nathan Sidwell 2017-05-24 Nathan Sidwell * auto-profile.c (afdo

Re: [libibery PATCH] Fix bootstrap

2017-05-24 Thread Nathan Sidwell
On 05/24/2017 08:34 PM, Nathan Sidwell wrote: We now warn on casts to T const. Applied as obvious to fix bootstrap. And this fixes c-common.c nathan -- Nathan Sidwell 2017-05-24 Nathan Sidwell * c=common.c (field_decl_cmp, resort_field_decl_cmp): Adjust T const casts to avoid warning.