Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Martin Liška
On 6/11/20 11:47 AM, Jonathan Wakely wrote: Is the attached patch what you're asking for? Yes ;) Martin

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Jonathan Wakely via Gcc-patches
On 11/06/20 10:54 +0200, Martin Liška wrote: On 6/11/20 10:48 AM, Jonathan Wakely wrote: On 11/06/20 09:54 +0200, Martin Liška wrote: On 6/10/20 2:20 PM, Jonathan Wakely wrote: Oops, this line was left in while I was testing it by amending existing commits! Here's an updated patch without tha

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Martin Liška
On 6/11/20 10:48 AM, Jonathan Wakely wrote: On 11/06/20 09:54 +0200, Martin Liška wrote: On 6/10/20 2:20 PM, Jonathan Wakely wrote: Oops, this line was left in while I was testing it by amending existing commits! Here's an updated patch without that line. I generally like the suggested idea

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Jonathan Wakely via Gcc-patches
On 11/06/20 09:54 +0200, Martin Liška wrote: On 6/10/20 2:20 PM, Jonathan Wakely wrote: Oops, this line was left in while I was testing it by amending existing commits! Here's an updated patch without that line. I generally like the suggested idea and I have suggestion to usage of the GCC_FO

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Martin Liška
On 6/11/20 9:45 AM, Martin Liška wrote: On 6/10/20 2:15 PM, Jonathan Wakely wrote: And this is another little patch that just avoids running 'git diff' twice, by using tee(1) to write to $GCC_GIT_DIFF_FILE as a side effect of generating the diff to pipe to mklog.py. Thanks, please install the

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Martin Liška
On 6/10/20 2:20 PM, Jonathan Wakely wrote: Oops, this line was left in while I was testing it by amending existing commits! Here's an updated patch without that line. I generally like the suggested idea and I have suggestion to usage of the GCC_FORCE_MKLOG. Right now, we use the env variable

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-11 Thread Martin Liška
On 6/10/20 2:15 PM, Jonathan Wakely wrote: And this is another little patch that just avoids running 'git diff' twice, by using tee(1) to write to $GCC_GIT_DIFF_FILE as a side effect of generating the diff to pipe to mklog.py. Thanks, please install the improvement. Martin

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-10 Thread Jonathan Wakely via Gcc-patches
On 10/06/20 13:13 +0100, Jonathan Wakely wrote: On 10/06/20 09:43 +0200, Martin Liška wrote: On 6/9/20 9:46 PM, Jonathan Wakely wrote: Is this worth adding to contrib/prepare-commit-msg? I like the idea and I would make it conditional based on an environment variable? Similarly to GCC_GIT_DIF

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-10 Thread Jonathan Wakely via Gcc-patches
On 10/06/20 13:13 +0100, Jonathan Wakely wrote: On 10/06/20 09:43 +0200, Martin Liška wrote: On 6/9/20 9:46 PM, Jonathan Wakely wrote: Is this worth adding to contrib/prepare-commit-msg? I like the idea and I would make it conditional based on an environment variable? Similarly to GCC_GIT_DIF

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-10 Thread Jonathan Wakely via Gcc-patches
On 10/06/20 09:43 +0200, Martin Liška wrote: On 6/9/20 9:46 PM, Jonathan Wakely wrote: Is this worth adding to contrib/prepare-commit-msg? I like the idea and I would make it conditional based on an environment variable? Similarly to GCC_GIT_DIFF_FILE? With this patch you can use the gcc-con

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-10 Thread Martin Liška
On 6/9/20 9:46 PM, Jonathan Wakely wrote: Is this worth adding to contrib/prepare-commit-msg? I like the idea and I would make it conditional based on an environment variable? Similarly to GCC_GIT_DIFF_FILE? Thanks, Martin

Re: [committed] gcc-changelog: Use non-zero exit status on error

2020-06-09 Thread Jonathan Wakely via Gcc-patches
On 09/06/20 20:42 +0100, Jonathan Wakely wrote: Also add comment explaining what the script does. contrib/ChangeLog: * gcc-changelog/git_email.py: Set exit status on error. Committed as obvious. With that change to git_email.py I can use the following change to the contrib/prepare-c