On 6/10/20 2:20 PM, Jonathan Wakely wrote:
Oops, this line was left in while I was testing it by amending
existing commits!

Here's an updated patch without that line.

I generally like the suggested idea and I have suggestion to usage of the 
GCC_FORCE_MKLOG.
Right now, we use the env variable only in 'git config alias.gcc-commit-mklog' 
alias.
Wouldn't it be better to only add

git config gcc-config.mklog-hook-type [always|smart-amend]

and do not support GCC_FORCE_MKLOG=no or GCC_FORCE_MKLOG=smart-amend?
Or do you have always GCC_FORCE_MKLOG=1 on (I mean for git commit)?

Thanks,
Martin

Reply via email to