Re: [PATCH] rs6000: Parameterize some const values for density test

on 2021/9/21 下午8:03, Segher Boessenkool wrote: > Hi! > > On Tue, Sep 21, 2021 at 01:47:19PM +0800, Kewen.Lin wrote: >> on 2021/9/18 上午6:26, Segher Boessenkool wrote: + if (data->nloads > (unsigned int) rs6000_density_load_num_threshold +&& load_pct > (unsigned int) rs6000_densit

Re: [PATCH] rs6000: Parameterize some const values for density test

Hi! On Tue, Sep 21, 2021 at 01:47:19PM +0800, Kewen.Lin wrote: > on 2021/9/18 上午6:26, Segher Boessenkool wrote: > >> + if (data->nloads > (unsigned int) rs6000_density_load_num_threshold > >> +&& load_pct > (unsigned int) rs6000_density_load_pct_threshold) > > > > Those variables are uns

Re: [PATCH] rs6000: Parameterize some const values for density test

on 2021/9/18 上午6:26, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 15, 2021 at 04:52:49PM +0800, Kewen.Lin wrote: >> This patch follows the discussion here[1], where Segher suggested >> parameterizing those exact magic constants for density heuristics, >> to make it easier to tweak if need. >> >

Re: [PATCH] rs6000: Parameterize some const values for density test

Hi Bill, Thanks for the review! on 2021/9/18 上午12:27, Bill Schmidt wrote: > Hi Kewen, > > On 9/15/21 3:52 AM, Kewen.Lin wrote: >> Hi, >> >> This patch follows the discussion here[1], where Segher suggested >> parameterizing those exact magic constants for density heuristics, >> to make it easier

Re: [PATCH] rs6000: Parameterize some const values for density test

Hi! On Wed, Sep 15, 2021 at 04:52:49PM +0800, Kewen.Lin wrote: > This patch follows the discussion here[1], where Segher suggested > parameterizing those exact magic constants for density heuristics, > to make it easier to tweak if need. > > Since these heuristics are quite internal, I make these

Re: [PATCH] rs6000: Parameterize some const values for density test

Hi! On Fri, Sep 17, 2021 at 11:27:09AM -0500, Bill Schmidt wrote: > On 9/15/21 3:52 AM, Kewen.Lin wrote: > >+-param=rs6000-density-pct-threshold= > >+Target Undocumented Joined UInteger Var(rs6000_density_pct_threshold) > >Init(85) IntegerRange(0, 99) Param > >+When costing for loop vectorization

Re: [PATCH] rs6000: Parameterize some const values for density test

Hi Kewen, On 9/15/21 3:52 AM, Kewen.Lin wrote: Hi, This patch follows the discussion here[1], where Segher suggested parameterizing those exact magic constants for density heuristics, to make it easier to tweak if need. Since these heuristics are quite internal, I make these parameters as undo