Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-03 Thread Jakub Jelinek
On Thu, Oct 03, 2019 at 05:22:49PM -0500, Aaron Sawdey wrote: > --- gcc/expr.c(revision 276516) > +++ gcc/expr.c(working copy) > @@ -1624,9 +1624,8 @@ >set_mem_size (y, const_size); > } > > - bool pieces_ok = false; > - if (CONST_INT_P (size)) > -pieces_ok = can_

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-03 Thread Aaron Sawdey
On 10/2/19 5:44 PM, Aaron Sawdey wrote: > On 10/2/19 5:35 PM, Jakub Jelinek wrote: >> On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: > 2019-09-27 Aaron Sawdey > > * builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. > (expand_builtin_memcpy):

Re: Enabling rtl checking by default (was Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove())

2019-10-03 Thread Richard Sandiford
Jakub Jelinek writes: > On Thu, Oct 03, 2019 at 11:14:25AM +0100, Richard Sandiford wrote: >> Confusingly, it needs to be --enable-checking=yes,extra,rtl for rtl >> to be a pure addition to the default. >> >> I guess it's time for a new entry in the semi-regular series >> "should rtl checking be

Re: Enabling rtl checking by default (was Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove())

2019-10-03 Thread Jakub Jelinek
On Thu, Oct 03, 2019 at 11:14:25AM +0100, Richard Sandiford wrote: > Confusingly, it needs to be --enable-checking=yes,extra,rtl for rtl > to be a pure addition to the default. > > I guess it's time for a new entry in the semi-regular series > "should rtl checking be enabled by default for develop

Enabling rtl checking by default (was Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove())

2019-10-03 Thread Richard Sandiford
Aaron Sawdey writes: > On 10/2/19 5:35 PM, Jakub Jelinek wrote: >> On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: > 2019-09-27 Aaron Sawdey > > * builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. > (expand_builtin_memcpy): Use might_overlap

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Aaron Sawdey
On 10/2/19 5:35 PM, Jakub Jelinek wrote: > On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: 2019-09-27 Aaron Sawdey * builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. (expand_builtin_memcpy): Use might_overlap parm. (expand_built

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Jakub Jelinek
On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: > >> 2019-09-27 Aaron Sawdey > >> > >>* builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. > >>(expand_builtin_memcpy): Use might_overlap parm. > >>(expand_builtin_mempcpy_args): Use might_overlap parm. >

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Aaron Sawdey
On 10/1/19 4:45 PM, Jeff Law wrote: > On 9/27/19 12:23 PM, Aaron Sawdey wrote: >> This is the third piece of my effort to improve inline expansion of memmove. >> The >> first two parts I posted back in June fixed the names of the optab entries >> involved so that optab cpymem is used for memcpy()

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-01 Thread Jeff Law
On 9/27/19 12:23 PM, Aaron Sawdey wrote: > This is the third piece of my effort to improve inline expansion of memmove. > The > first two parts I posted back in June fixed the names of the optab entries > involved so that optab cpymem is used for memcpy() and optab movmem is used > for > memmove(