Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

[Jakub Jelinek]

On Thu, Oct 03, 2019 at 05:22:49PM -0500, Aaron Sawdey wrote:
> --- gcc/expr.c        (revision 276516)
> +++ gcc/expr.c        (working copy)
> @@ -1624,9 +1624,8 @@
>        set_mem_size (y, const_size);
>      }
> 
> -  bool pieces_ok = false;
> -  if (CONST_INT_P (size))
> -    pieces_ok = can_move_by_pieces (INTVAL (size), align);
> +  bool pieces_ok = CONST_INT_P (size)
> +    && can_move_by_pieces (INTVAL (size), align);
>    bool pattern_ok = false;
> 
>    if (!pieces_ok || might_overlap)
> 
> Bootstrap/regtest (with --enable-checking=yes,rtl,tree) ok on ppc64le 
> (power9),
> committed as obvious.

The formatting is wrong.  Either it needs to be:
  bool pieces_ok
    = CONST_INT_P (size) && can_move_by_pieces (INTVAL (size), align);
or
  bool pieces_ok = (CONST_INT_P (size)
                    && can_move_by_pieces (INTVAL (size), align));

        Jakub