Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Richard Biener
On Mon, Oct 14, 2013 at 2:20 PM, Andreas Krebbel wrote: > On 14/10/13 13:30, Jakub Jelinek wrote: >> On Mon, Oct 14, 2013 at 01:26:25PM +0200, Richard Biener wrote: I somehow couldn't get it working with the add_builtin_function parameter. Perhaps because these attrs are supposed t

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Andreas Krebbel
On 14/10/13 13:30, Jakub Jelinek wrote: > On Mon, Oct 14, 2013 at 01:26:25PM +0200, Richard Biener wrote: >>> I somehow couldn't get it working with the add_builtin_function parameter. >>> Perhaps because these >>> attrs are supposed to be translated into the respective tree flags >>> (DECL_IS_RE

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Jakub Jelinek
On Mon, Oct 14, 2013 at 01:26:25PM +0200, Richard Biener wrote: > > I somehow couldn't get it working with the add_builtin_function parameter. > > Perhaps because these > > attrs are supposed to be translated into the respective tree flags > > (DECL_IS_RETURNS_TWICE) at that > > point already?! >

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Richard Biener
On Mon, Oct 14, 2013 at 1:21 PM, Andreas Krebbel wrote: > On 14/10/13 12:14, Jakub Jelinek wrote: >> On Mon, Oct 14, 2013 at 12:07:00PM +0200, Richard Biener wrote: htm-nofloat-2.c fails with that patch. The returns-twice flag on tbegin prevents several optimizations on the cfg and basi

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Andreas Krebbel
On 14/10/13 12:14, Jakub Jelinek wrote: > On Mon, Oct 14, 2013 at 12:07:00PM +0200, Richard Biener wrote: >>> htm-nofloat-2.c fails with that patch. The returns-twice flag on >>> tbegin prevents several optimizations on the cfg and basically >>> disables the TX optimization in s390_optimize_nonesc

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Jakub Jelinek
On Mon, Oct 14, 2013 at 12:07:00PM +0200, Richard Biener wrote: > > htm-nofloat-2.c fails with that patch. The returns-twice flag on > > tbegin prevents several optimizations on the cfg and basically > > disables the TX optimization in s390_optimize_nonescaping_tx that way. > > I'll try to address

Re: [PATCH] Transaction fix: New target hook special_function_flags

2013-10-14 Thread Richard Biener
On Fri, Oct 11, 2013 at 7:02 PM, Andreas Krebbel wrote: > Hi, > > the attached patch introduces a new target hook > (targetm.calls.special_function_flags) which can be used by a backend > to add specific call properties to builtins. > > On S/390 this is used for the *tbegin* and *tabort builtins w