On Mon, Oct 14, 2013 at 12:07:00PM +0200, Richard Biener wrote:
> > htm-nofloat-2.c fails with that patch. The returns-twice flag on
> > tbegin prevents several optimizations on the cfg and basically
> > disables the TX optimization in s390_optimize_nonescaping_tx that way.
> > I'll try to address this with a follow-on patch.
> >
> > Ok for mainline and 4.8?
>
> I don't see what's special about s390 so that the attributes are only
> required there. In fact they look valid generally, so no need for the
> new target hook.
Well, the builtins are machine specific. But, why don't you just
add the attributes to the builtins when you register them in the backend?
You are calling add_builtin_function with NULL_TREE attrs, just pass
the right attribute list and there won't be a need for an extra target hook.
Jakub
