Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Alexander Monakov
On Mon, 29 Oct 2018, Jason Merrill wrote: > On Mon, Oct 29, 2018 at 7:07 AM Alexander Monakov wrote: > > On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > > > check_function_arguments. > > > > David, I think your patch als

Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Jason Merrill
On Mon, Oct 29, 2018 at 7:07 AM Alexander Monakov wrote: > On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > > check_function_arguments. > > David, I think your patch also fixes PR 86567. > > David, Jason, could you comment on

Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Alexander Monakov
On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > check_function_arguments. David, I think your patch also fixes PR 86567. David, Jason, could you comment on doing something similar (using fold_for_warn instead of maybe_constant_

Re: [PATCH] Folding and check_function_arguments

2018-10-25 Thread Jason Merrill
On 10/8/18 6:24 PM, David Malcolm wrote: On Mon, 2018-10-08 at 10:37 -0400, Jason Merrill wrote: On Thu, Oct 4, 2018 at 10:12 AM David Malcolm wrote: -Wformat in the C++ FE doesn't work as well as it could: (a) it doesn't report precise locations within the string literal, and (b) it doesn't