On Mon, Oct 29, 2018 at 7:07 AM Alexander Monakov <amona...@ispras.ru> wrote: > On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > > check_function_arguments. > > David, I think your patch also fixes PR 86567. > > David, Jason, could you comment on doing something similar (using > fold_for_warn > instead of maybe_constant_value) to solve other issues where generation of new > tree uids under maybe_constant_value called in warning context changes code > generation, in particular PR 86586?
I don't see how it would help; this change does the same folding, just a bit later. Jason Jason