Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-20 Thread Marcus Shawcroft
On 18 February 2015 at 11:35, Kyrill Tkachov wrote: > Ok for trunk and 4.9? > > Thanks, > Kyrill > > 2015-02-17 Kyrylo Tkachov > > * config/aarch64/aarch64.md (*aarch64_lshr_sisd_or_int_3): > Mark operand 0 as earlyclobber in 2nd alternative. > (1st define_split below *aarch64_lshr

Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-18 Thread Kyrill Tkachov
On 18/02/15 13:46, Maxim Kuvyrkov wrote: On Feb 18, 2015, at 4:42 PM, Kyrill Tkachov wrote: On 18/02/15 12:32, Maxim Kuvyrkov wrote: On Feb 18, 2015, at 2:35 PM, Kyrill Tkachov wrote: Hi all, This patch fixes a wrong-code bug with the *aarch64_lshr_sisd_or_int_3 pattern and its associate

Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-18 Thread Maxim Kuvyrkov
On Feb 18, 2015, at 4:42 PM, Kyrill Tkachov wrote: > > On 18/02/15 12:32, Maxim Kuvyrkov wrote: >> On Feb 18, 2015, at 2:35 PM, Kyrill Tkachov wrote: >> >>> Hi all, >>> >>> This patch fixes a wrong-code bug with the *aarch64_lshr_sisd_or_int_3 >>> pattern and its associated splitters. The pro

Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-18 Thread Kyrill Tkachov
On 18/02/15 12:32, Maxim Kuvyrkov wrote: On Feb 18, 2015, at 2:35 PM, Kyrill Tkachov wrote: Hi all, This patch fixes a wrong-code bug with the *aarch64_lshr_sisd_or_int_3 pattern and its associated splitters. The problem is that for the 2nd alternative it will split a right-shift into a SISD

Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-18 Thread Maxim Kuvyrkov
On Feb 18, 2015, at 3:32 PM, Maxim Kuvyrkov wrote: > First of all, applauses! I realize how difficult it was to reduce this > problem. > > Your patch looks OK to me, but I can't shake off feeling that it will > pessimize cases when d8 is not used afterwards. In particular, your patch > make

Re: [PATCH][AArch64] Fix wrong-code bug in right-shift SISD patterns

2015-02-18 Thread Maxim Kuvyrkov
On Feb 18, 2015, at 2:35 PM, Kyrill Tkachov wrote: > Hi all, > > This patch fixes a wrong-code bug with the *aarch64_lshr_sisd_or_int_3 > pattern and its associated splitters. The problem is that for the 2nd > alternative it will split a right-shift into a SISD left-shift by the negated > amount