Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 02:28:09PM -0400, Jason Merrill wrote: > On Wed, Apr 11, 2018 at 2:07 PM, Jakub Jelinek wrote: > > On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: > >> And this one puts the check in asan_init rather than its users. OK? > > > > tsan tests have the same probl

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: > And this one puts the check in asan_init rather than its users. OK? tsan tests have the same problem. Wouldn't it be better to have a helper procedure for this and use it next to if [check_effective_target_fsanitize_address] { or f

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jason Merrill
On Wed, Apr 11, 2018 at 2:07 PM, Jakub Jelinek wrote: > On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: >> And this one puts the check in asan_init rather than its users. OK? > > tsan tests have the same problem. Hmm, tsan tests work fine for me under ulimit -v. > Wouldn't it be

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jason Merrill
On Tue, Apr 3, 2018 at 1:23 PM, Jason Merrill wrote: > On Tue, Apr 3, 2018 at 12:56 PM, Jason Merrill wrote: >> On Mon, Mar 26, 2018 at 4:01 PM, Jason Merrill wrote: >>> >>> On Mon, Mar 26, 2018 at 2:55 PM, Andreas Schwab >>> wrote: >>> > On Mär 26 2018, Jakub Jelinek wrote: >>> >> On Mon, Mar

Re: RFC: Disable asan tests under ulimit -v

2018-04-03 Thread Jason Merrill
On Tue, Apr 3, 2018 at 12:56 PM, Jason Merrill wrote: > On Mon, Mar 26, 2018 at 4:01 PM, Jason Merrill wrote: >> >> On Mon, Mar 26, 2018 at 2:55 PM, Andreas Schwab >> wrote: >> > On Mär 26 2018, Jakub Jelinek wrote: >> >> On Mon, Mar 26, 2018 at 08:33:41PM +0200, Andreas Schwab wrote: >> >>> On

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Jakub Jelinek
On Mon, Mar 26, 2018 at 08:33:41PM +0200, Andreas Schwab wrote: > On Mär 26 2018, Jason Merrill wrote: > > > if [catch {exec sh ulimit -v} ulimit_v] { > > expect1.1> exec sh ulimit -v > sh: ulimit: No such file or directory > while executing > "exec sh ulimit -v" Perhaps if [catch

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Jason Merrill
On Mon, Mar 26, 2018 at 2:55 PM, Andreas Schwab wrote: > On Mär 26 2018, Jakub Jelinek wrote: >> On Mon, Mar 26, 2018 at 08:33:41PM +0200, Andreas Schwab wrote: >>> On Mär 26 2018, Jason Merrill wrote: >>> >>> > if [catch {exec sh ulimit -v} ulimit_v] { >>> >>> expect1.1> exec sh ulimit -v >

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Andreas Schwab
On Mär 26 2018, Jakub Jelinek wrote: > On Mon, Mar 26, 2018 at 08:33:41PM +0200, Andreas Schwab wrote: >> On Mär 26 2018, Jason Merrill wrote: >> >> > if [catch {exec sh ulimit -v} ulimit_v] { >> >> expect1.1> exec sh ulimit -v >> sh: ulimit: No such file or directory >> while executin

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Andreas Schwab
On Mär 26 2018, Jason Merrill wrote: > if [catch {exec sh ulimit -v} ulimit_v] { expect1.1> exec sh ulimit -v sh: ulimit: No such file or directory while executing "exec sh ulimit -v" Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Jason Merrill
On Mon, Mar 26, 2018 at 1:31 PM, Andreas Schwab wrote: > On Mär 26 2018, Jason Merrill wrote: > >> On Sat, Mar 24, 2018 at 4:51 AM, Andreas Schwab >> wrote: >>> On Mär 23 2018, Jason Merrill wrote: >>> diff --git a/gcc/testsuite/g++.dg/asan/asan.exp b/gcc/testsuite/g++.dg/asan/asan.

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Andreas Schwab
On Mär 26 2018, Jason Merrill wrote: > On Sat, Mar 24, 2018 at 4:51 AM, Andreas Schwab wrote: >> On Mär 23 2018, Jason Merrill wrote: >> >>> diff --git a/gcc/testsuite/g++.dg/asan/asan.exp >>> b/gcc/testsuite/g++.dg/asan/asan.exp >>> index 4ee8dd98697..a22d2ac5e20 100644 >>> --- a/gcc/testsuit

Re: RFC: Disable asan tests under ulimit -v

2018-03-26 Thread Jason Merrill
On Sat, Mar 24, 2018 at 4:51 AM, Andreas Schwab wrote: > On Mär 23 2018, Jason Merrill wrote: > >> diff --git a/gcc/testsuite/g++.dg/asan/asan.exp >> b/gcc/testsuite/g++.dg/asan/asan.exp >> index 4ee8dd98697..a22d2ac5e20 100644 >> --- a/gcc/testsuite/g++.dg/asan/asan.exp >> +++ b/gcc/testsuite/g

Re: RFC: Disable asan tests under ulimit -v

2018-03-24 Thread Andreas Schwab
On Mär 23 2018, Jason Merrill wrote: > diff --git a/gcc/testsuite/g++.dg/asan/asan.exp > b/gcc/testsuite/g++.dg/asan/asan.exp > index 4ee8dd98697..a22d2ac5e20 100644 > --- a/gcc/testsuite/g++.dg/asan/asan.exp > +++ b/gcc/testsuite/g++.dg/asan/asan.exp > @@ -24,6 +24,13 @@ load_lib asan-dg.exp >

Re: RFC: Disable asan tests under ulimit -v

2018-03-23 Thread Mike Stump
On Mar 23, 2018, at 11:52 AM, Jason Merrill wrote: > > asan doesn't work under ulimit -v, which I want to use on shared hosts > to avoid causing trouble with runaway processes. There doesn't seem > to be a way within expect to access getrlimit/setrlimit, so in this > patch I call out to the shel

RFC: Disable asan tests under ulimit -v

2018-03-23 Thread Jason Merrill
asan doesn't work under ulimit -v, which I want to use on shared hosts to avoid causing trouble with runaway processes. There doesn't seem to be a way within expect to access getrlimit/setrlimit, so in this patch I call out to the shell to test the current limit, and give up if I get back a number