Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
Andrea Corallo writes: > Hi Kyrill, > > thanks for catching that. > > The attached is committed into master as d2b86e14c14. > > Andrea And backported in releases/gcc-10 as e5907f3b631. Andrea

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
Kyrylo Tkachov writes: > I just remembered a recurring bit of review feedback from Ramana on my > patches... > New effective target checks need to be documented in doc/sourcebuild.texi. > > Ok with the documentation. > Thanks, > Kyrill Hi Kyrill, thanks for catching that. The attached is comm

RE: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Kyrylo Tkachov
Hi Andrea, > -Original Message- > From: Andrea Corallo > Sent: 04 August 2020 09:28 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Richard Sandiford > > Subject: Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs > > Hi all, &g

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
Hi all, looking into the regression I realized I've got the condition into the effective target test wrong (== vs !=). Apologies for the noise. Bootstrapped on aarch64-none-linux-gnu and regresssioned on aarch64-none-elf. Still okay for trunk and to backport on gcc-10? Thanks Andrea gcc/Ch

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-07-31 Thread Richard Sandiford
Andrea Corallo writes: > Hi all, > > I'd like to submit the following patch that adds a missing CC reg > clobber for the FJCVTZS instruction [1]. > > The patch adds an executing testcase that fails without the clobber. > > Bootstrapped on aarch64-linux-gnu, regression ongoing. > > Okay for trunk w