RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

[Public] Hello, > OK, > thanks! > Honza Thanks! We have pushed the patch. Regards, Tejas

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

> > On Tue, 3 Jan 2023, Jan Hubicka wrote: > > > > * gcc/common/config/i386/i386-common.cc (processor_alias_table): > > > Use CPU_ZNVER4 for znver4. > > > * config/i386/i386.md: Add znver4.md. > > > * config/i386/znver4.md: New. > > OK, > > thanks! > > Honza, I'm curious what are your fu

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Tue, 3 Jan 2023, Jan Hubicka wrote: > > * gcc/common/config/i386/i386-common.cc (processor_alias_table): > > Use CPU_ZNVER4 for znver4. > > * config/i386/i386.md: Add znver4.md. > > * config/i386/znver4.md: New. > OK, > thanks! Honza, I'm curious what are your further plans f

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

> [Public] > > Hello, > > I have addressed all your comments in this revision of the patch, please find > attached and inlined. > > * I have updated all the latencies with Agner's measurements. > * Incorrect pipelines, loads/stores are addressed. > * The double pumped avx512 insns take one cycl

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

[Public] Hello, I have addressed all your comments in this revision of the patch, please find attached and inlined. * I have updated all the latencies with Agner's measurements. * Incorrect pipelines, loads/stores are addressed. * The double pumped avx512 insns take one cycle for 256 half and t

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

> I have addressed all your comments in this revised patch, PFA and inlined > below. > > Is it ok for trunk? > > Thanks and Regards, > Tejas > > gcc/ChangeLog: > > * gcc/common/config/i386/i386-common.cc (processor_alias_table): > Use CPU_ZNVER4 for znver4. > * config/i386/i

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Thu, 1 Dec 2022, Joshi, Tejas Sanjay wrote: > I have addressed all your comments in this revised patch, PFA and inlined > below. Thank you. Honza, please let me know if any further input is needed from my side. For reference, here's how insn-automata.o table sizes look with this patch (top

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Mon, 21 Nov 2022, Joshi, Tejas Sanjay wrote: > I have addressed all your comments in the patch attached here. I have also > used znver4-direct for avx512 insns. Thanks. > * This patch increased the insn-automata.cc size from 201502 to 214902. Assuming it's the number of lines of code, I ha

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

[Public] Hi, > I think instead of (znver4-fpu)*2 there should be > > znver4-fpu0*2|znver4-fpu1*2|znver4-fpu2*2|znver4-fpu3*2 > > assuming the instruction occupies the same pipe on both cycles (your variant > models as if it can move from one pipe to another). > Also I think it's better to us

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Tue, 15 Nov 2022, Joshi, Tejas Sanjay wrote: > > > +;; AVX instructions > > > +(define_insn_reservation "znver4_sse_log" 1 > > > + (and (eq_attr "cpu" "znver4") > > > + (and (eq_attr "type" "sselog,sselog1") > > > +

RE: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

[Public] Hi, Thank you for reviewing the patch. > Hi. I'm still waiting for feedback on fixes for existing models: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finbox. > sourceware.org%2Fgcc-patches%2F5ae6fc21-edc6-133-aee2- > a41e16eb5b7%40ispras.ru%2FT%2F%23t&data=05%7C01

Re: [PATCH][X86_64] Separate znver4 insn reservations from older znvers

On Mon, 14 Nov 2022, Joshi, Tejas Sanjay wrote: > [Public] > > Hi, Hi. I'm still waiting for feedback on fixes for existing models: https://inbox.sourceware.org/gcc-patches/5ae6fc21-edc6-133-aee2-a41e16eb...@ispras.ru/T/#t did you have a chance to look at those? > PFA the patch which adds znv