Re: [PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-17 Thread David Edelsohn
On Wed, May 17, 2017 at 9:11 AM, REIX, Tony wrote: > Patch has been submitted to libffi github : > https://github.com/libffi/libffi/pull/308 . Good. There still was no ChangeLog included with the patch. Also, the new functions in the patch are not consistent with the insertion of the word "go"

RE:[PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-17 Thread REIX, Tony
.net De : REIX, Tony Envoyé : mercredi 17 mai 2017 14:53 À : David Edelsohn Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : RE:[PATCH,AIX] Enable FFI Go Closure on AIX Hi, We have built and installed the libffi master of yesterday on a AIX 6.1 machine and we have rebuilt and tested Pyt

RE:[PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-17 Thread REIX, Tony
s; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX On Tue, May 16, 2017 at 10:44 AM, REIX, Tony wrote: > Hi David, > > We'll submit the patch to the libffi project asap. > > We have tested this patch on AIX 6.1 with libffi (master from github) in &g

Re: [PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-16 Thread David Edelsohn
On Tue, May 16, 2017 at 10:44 AM, REIX, Tony wrote: > Hi David, > > We'll submit the patch to the libffi project asap. > > We have tested this patch on AIX 6.1 with libffi (master from github) in > 32bit and 64bit with same results (same exact failures) when testing with and > without our patch,

RE:[PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-16 Thread REIX, Tony
32 Échirolles - France www.atos.net De : David Edelsohn [dje@gmail.com] Envoyé : lundi 15 mai 2017 22:36 À : REIX, Tony Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX This patch needs to be submitted to the

Re: [PATCH,AIX] Enable FFI Go Closure on AIX

2017-05-15 Thread David Edelsohn
This patch needs to be submitted to the libffi project. Also, the ChangeLog needs to specify exactly what is being changed not "Implement Go Closures". The patch clearly touches existing parts of the files that affect more than simply Go closures. How was this tested? libffi is used in many mor