Hi David,
We'll submit the patch to the libffi project asap.
We have tested this patch on AIX 6.1 with libffi (master from github) in 32bit
and 64bit with same results (same exact failures) when testing with and without
our patch, using libffi testsuite.
Without patch:
=== libffi Summary === 64bit & 32bit
# of expected passes 1870
# of unexpected failures 38
# of unresolved testcases 2
# of unsupported tests 30
With patch:
=== libffi Summary === 64bit & 32bit
# of expected passes 1890
# of unexpected failures 38
# of unresolved testcases 2
# of unsupported tests 28
We'll test with Python asap, probably this week.
Cordialement,
Tony Reix
Bull - ATOS
IBM Coop Architect & Technical Leader
Office : +33 (0) 4 76 29 72 67
1 rue de Provence - 38432 Échirolles - France
www.atos.net
________________________________________
De : David Edelsohn [dje....@gmail.com]
Envoyé : lundi 15 mai 2017 22:36
À : REIX, Tony
Cc : GCC Patches; SARTER, MATTHIEU (ext)
Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX
This patch needs to be submitted to the libffi project.
Also, the ChangeLog needs to specify exactly what is being changed not
"Implement Go Closures". The patch clearly touches existing parts of
the files that affect more than simply Go closures.
How was this tested? libffi is used in many more places than Go, so
any changes need to be tested very carefully and thoroughly. What are
the results for the libffi testsuite? Have you tried building Python
with a version of libffi built with this patch?
Thanks, David
